| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
scripts from 1 to 4.
Also adds a command line flag to override the default: --num-pac-threads=X
BUG=11079
Review URL: http://codereview.chromium.org/2893005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
called with zero downloads.
CID=9160
TEST=trybots
BUG=none
Review URL: http://codereview.chromium.org/2934002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used to implement 3605. I created separate notification as we're planning to port to other platfrom.
BUG=chromium-os:3605
TEST=added browser test
Review URL: http://codereview.chromium.org/2913001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
never get read from again.
r=jar
Review URL: http://codereview.chromium.org/2925006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=48690
Review URL: http://codereview.chromium.org/2896007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add automation hooks to:
- install a given theme
- fetch info about the current theme
- reset to default theme
Add a test exercising the above.
BUG=36215
TEST=python chrome/test/functional/themes.py
Review URL: http://codereview.chromium.org/2827048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=34647
TEST=manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51494
Review URL: http://codereview.chromium.org/2822044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34647
TEST=built on all platforms
Review URL: http://codereview.chromium.org/2970001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change detects if there is a chance that a proxy MIGHT
be used to perform a connection, and if so, it avoids doing
any speculative preconnections, or speculative DNS
pre-resolution.
For testing purposes, a flag is provided to avoid this
probe for proxy status. If you enable --preconnect-despite-proxy
then preconnection will take place (as appropriate) even
if there is a chance that a proxy might be used
for connections to some hosts.
BUG=47906
r=eroman
Review URL: http://codereview.chromium.org/2871038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation to add an AudioInputController for audio recording in subsequent changes.
BUG=none
TEST=no functional change
Review URL: http://codereview.chromium.org/2964005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2812043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is just the HTML and CSS and the skeleton of some of the JavaScript. Only the checkbox for the Home button currently works. Remaining functionality will be added over time.
BUG=48713
TEST=Basics page in options should show options; "Show Home button" should work.
Review URL: http://codereview.chromium.org/2972001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
run after it.
BUG=48717
TEST=none
TBR=dmazzoni
Review URL: http://codereview.chromium.org/2923004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
previously disabled in ChromeOS.
BUG=chrome-os:4073
TEST=open about:system, right mouse click and pick Save As menu item
Review URL: http://codereview.chromium.org/2880009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Forward declare printing::PrintViewManager in TabContents
- tab_contents.h shouldn't depend on autocomplete_edit.h
- Pull logging out of Browser through PageTransitionTypes
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2934004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4659
TEST=none
Review URL: http://codereview.chromium.org/2957005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46528
TEST=mini_installer.exe --installerdata=<file_path>
Review URL: http://codereview.chromium.org/2962004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the root view Layout code which does not give
the child views a chance to process the layout if a layout manager existed for the root view. The default layout manager for
the root view is the FillView.
Fix is to handle layout correctly in the ExternalTabContainer in the InfoBarSizeChanged notification by maintaining the current
grid view in a member and invoking layout on it.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=48569
Bug=48569
Review URL: http://codereview.chromium.org/2963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2836046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=evan,estade
BUG=51974
TEST=went green locally.
Review URL: http://codereview.chromium.org/2900004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
away from the default theme. This is to avoid the server-wins logic from
overwriting custom themes for new sync clients. With this patch, the first
non-default theme that gets synced will be propagated to all clients.
BUG=48155
TEST=manually tested
Review URL: http://codereview.chromium.org/2946001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm having a hard time reproing this hang locally -- I ran the test for several days on windows with no hangs. So this change should prevent any individual test in this test from hanging and hopefully help provide some helpful info when it hangs again.
And since the tests won't hang anymore, I believe we can make them FLAKY.
BUG=39070
Review URL: http://codereview.chromium.org/2864043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The heuristic should catch these. Keeping the list just makes it harder to find problems
with the heuristic.
BUG=none
TEST=Still no infobars for single-word queries on any networks.
Review URL: http://codereview.chromium.org/2917007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
being used until the maximum size is reached.
BUG=48494
TEST=create notifications of various sizes, watch for jitter
Review URL: http://codereview.chromium.org/2941003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and scripts to run on the Chrome Extensions Gallery site. There are
security concerns in enabling this and so it remains off by default,
but this is needed for automation testing of the gallery.
Cleanup: Have UserScriptSlave::InjectScripts() return void instead of a bogus bool.
TEST=Visit http://chrome.google.com/extensions, check that content scripts work when the command-line switch is given, and are not injected when the switch is not given.
BUG=none
Review URL: http://codereview.chromium.org/2912002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ThemeChangeProcessor, since the error will clear the profile_ without returning, and the profile is accessed later. Since the code discusses how to process deletes, I think this is the correct fix.
BUG=none
TEST=sync themes and then delete it
Review URL: http://codereview.chromium.org/2913006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The favicon used to be loaded from a png file in
the resources directory. Since the file is gone,
this no longer works. Instead, check for the bookmark
manager extension earlier and load the image from the
pak file.
BUG=48218
Review URL: http://codereview.chromium.org/2960002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This completes the linux implementation of the new wrench menu. Turning
on by default. Will watch how this goes.
BUG=45757
TEST=Look at the menu. The size of the "cut," "copy" and "paste" buttons
should be equal.
Review URL: http://codereview.chromium.org/2961001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44620
TEST=none
Review URL: http://codereview.chromium.org/2920004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for windows, linux platforms resp.
BUG=48597
TEST=None
Review URL: http://codereview.chromium.org/2958002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL contains the following:
-Use lower case names for enum values in the create/update properties (eg 'page' instead of 'PAGE')
-Make the top-level API name plural (contextMenus instead of contextMenu)
-Don't fire onclick handlers for a parent menu item when one of its children is clicked on.
-Remove the enabledContexts property for now, to eventually be replaced with a way to programmatically enable/disable.
There are a few more things in the bug that I'll be doing in subsequent CL's.
BUG=48198
TEST=Extensions using the context menu API should work with the changes described above.
Review URL: http://codereview.chromium.org/2887013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(and fix it for typed urls).
BUG=45883
TEST=sync extension/typed url/autofill, verify delete propagation
Review URL: http://codereview.chromium.org/2920002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes issue with Mac AddressBook "me" profiles where nil address returned was causing DCHECK.
BUG=48629
TEST=Manual, create AddressBook "me" card address with empty address fields but valid country, relaunch debug version of Chrome.
Review URL: http://codereview.chromium.org/2904007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=7721
TEST=PrintingLayoutTextTest.Complex
Review URL: http://codereview.chromium.org/2939003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=automation tests with --login-screen=login should work.
Review URL: http://codereview.chromium.org/2968001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes case where DCHECK was failing in presence of Autocomplete cancel logic. The DCHECK in this case was erroneous. The new logic handles the cancel case
appropriately.
BUG=none
TEST=AutoFillManagerTest.GetFieldSuggestionsForAutocompleteOnly
Review URL: http://codereview.chromium.org/2945003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2881013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48671
TBR=suzhe
Review URL: http://codereview.chromium.org/2945008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(https://bugs.webkit.org/show_bug.cgi?id=41697)
BUG=36438
TEST=DevToolsSanityTest.TestMessageLoopReentrant
Review URL: http://codereview.chromium.org/2965002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabling AccessibilityWinBrowserTest.TestRendererAccessibilityTree, and
the media/video-volume-slider.html layout test on mac.
BUG=48655
TEST=none
Review URL: http://codereview.chromium.org/2951005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35524
TEST=Open chromium while on a "normal" network. Switch to a network that does dns hijacking. Type a single-word query into omnibox and hit return. No "Did you mean to go to http://query" infobar should open.
Review URL: http://codereview.chromium.org/2910001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserTest.ThirtyFourTabs on Mac. (This test takes <3 seconds on my
machine). Suspect low memory conditions (or whatever) on the bot;
this test is not problematic per se.
BUG=http://crbug.com/43862
TEST=bots stay green
Review URL: http://codereview.chromium.org/2900002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ResourceDispatcherHost::RemovePendingRequest.
R=davidben
BUG=48210
TEST=none
Review URL: http://codereview.chromium.org/2962001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is not a big deal, as the crash does not occur on the netbook.
I encountred a crash when I was trying to run chrome for chrome os with
libcros.so on my Ubuntu workstation. Note that building libcros.so outside
of chroot is very tricky, so no one else probably wants to do that.
TEST=manually
BUG=none
Review URL: http://codereview.chromium.org/2884015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes PersonalDataManager to filter out empty profiles and credit card information before saving to the database.
BUG=47742
TEST=PersonalDataManagerTest.SetEmptyProfile, PersonalDataManagerTest.SetEmptyCreditCard
Review URL: http://codereview.chromium.org/2897005
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/2904005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/48114
TEST=none (depends on bug 47428)
Review URL: http://codereview.chromium.org/2949002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was causing gmock warning in browser tests.
Changed cros mocks to StrictMock so that uninteresting call will fail.
BUG=none
TEST=browser tests will not have gmock warning "Uninterested mock function call"
Review URL: http://codereview.chromium.org/2929001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes PersonalDataManager to filter out empty profiles and credit card information before saving to the database.
BUG=47742
TEST=PersonalDataManagerTest.SetEmptyProfile, PersonalDataManagerTest.SetEmptyCreditCard
Review URL: http://codereview.chromium.org/2897005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2880022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51899 0039d316-1c4b-4281-b951-d872f2087c98
|