summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* In DefaultPolicy::OnCertError, if a cert error is allowed,wtc@google.com2008-09-161-21/+20
| | | | | | | | | | | | | | | | | | | | we should skip the code that determines what to do about a sub-resource. This is because in some HTTPS implementations, we continue to get errors on a cert after we have ignored that cert's errors. The current code works with WinHTTP because WinHTTP stops sending errors on a cert after we have ignored that cert's errors. This changelist allows the code to work with both kinds of HTTPS implementations. Fix nits (extra semicolons and insufficient whitespace) reported by cpplint.py. R=abarth,jcampan BUG=1272567 Review URL: http://codereview.chromium.org/2816 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2252 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where bookmark bar wouldn't animate away but would rather snap ↵beng@google.com2008-09-161-3/+5
| | | | | | | | | closed (new frames) B=1031854 Review URL: http://codereview.chromium.org/3052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2251 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to fix the memory problems in NavigationController. The previous onebrettw@google.com2008-09-151-5/+9
| | | | | | | | | issued a DCHECK when I manlually deleted the NavigationController because the tabs were still there. Calling destroy fixes this, although I have to manually NULL out some test pointers to prevent double-frees. Review URL: http://codereview.chromium.org/3070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2247 0039d316-1c4b-4281-b951-d872f2087c98
* Adding sync plugin messages, and plugin broadcasts to the renderer processeszork@google.com2008-09-153-16/+60
| | | | | | Review URL: http://codereview.chromium.org/2411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2246 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my last fix for a memory leak in the navigation controller tests. Thisbrettw@google.com2008-09-151-2/+2
| | | | | | | causes an assertion in debug mode. I think this needs to be done another way. Review URL: http://codereview.chromium.org/2873 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2239 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in the unit tests.brettw@google.com2008-09-151-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2237 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unittest bustage due to NULL pointer deref (only in unittest mode, I hope).pkasting@chromium.org2008-09-153-12/+18
| | | | | | | | | | | Also commit some comment changes which were supposed to go in my original patch but missed it. TBR=sky BUG=1291 Review URL: http://codereview.chromium.org/2870 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2233 0039d316-1c4b-4281-b951-d872f2087c98
* Make the GoogleURLTracker only fetch the Google hostname if the user's ↵pkasting@chromium.org2008-09-155-30/+162
| | | | | | | | | | | default search engine is Google. Our existing restrictions still apply: no fetches before five seconds after startup, and no more than one fetch per run. Because of lazy initialization everywhere, this was hairier than I'd hoped. We have to ensure we don't try to fetch until the profile has been created, lest GetDefaultRequestContext() return NULL. Note that this was actually a bug in the existing product: if you set your startup page to, say, about:blank, and started the browser and did nothing at all for five seconds, we'd crash. BUG=1291 Review URL: http://codereview.chromium.org/1942 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2223 0039d316-1c4b-4281-b951-d872f2087c98
* Add preferences for the clear browsing data dialog so thattc@google.com2008-09-152-5/+33
| | | | | | | | | | | the user choices are persistent. Patch by Arthur Lussos <developer0420@gmail.com> Original issue at http://codereview.chromium.org/3014 Review URL: http://codereview.chromium.org/3059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2222 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unneeded pending entry from the unit tests.brettw@google.com2008-09-151-17/+0
| | | | | | Review URL: http://codereview.chromium.org/2859 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2220 0039d316-1c4b-4281-b951-d872f2087c98
* Occasionally GetLastActiveBrowserWindow fails on the build bots, probably ↵beng@google.com2008-09-151-1/+1
| | | | | | | | | | because of the locked desktop. Replace this call in the non-interactive ui tests with a call to GetBrowserWindow(0), which is what GetActiveTab (called a few lines earlier) does anyway. B=2235 Review URL: http://codereview.chromium.org/2844 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2210 0039d316-1c4b-4281-b951-d872f2087c98
* Hit test zone for the new tab button should follow its visible shape.beng@google.com2008-09-141-1/+57
| | | | | | | B=2270 Review URL: http://codereview.chromium.org/2843 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2209 0039d316-1c4b-4281-b951-d872f2087c98
* Revert these changes now the experiment is complete.beng@google.com2008-09-142-3/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2208 0039d316-1c4b-4281-b951-d872f2087c98
* Yet another test, this time with a tweak to the find test.beng@google.com2008-09-142-1/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2207 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a debug assertin when running the web contents unit test. The error is inbrettw@google.com2008-09-141-0/+3
| | | | | | | | the test since it would give the same page ID to two different pages in the same site instance, which should not happen. Review URL: http://codereview.chromium.org/2842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2206 0039d316-1c4b-4281-b951-d872f2087c98
* A couple of tweaks to the AeroGlassNonClientView:beng@google.com2008-09-141-2/+2
| | | | | | | | | | - fix broken window resizing using the sizing borders... || should have been an &&, resulted in all non-client areas being treated as window caption. - use the width of the client view to size the tabstrip rather than the width of the non-client view. this was causing the new tab button to be clipped. B=2218,2267 Review URL: http://codereview.chromium.org/2841 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2205 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back frame test now buildbots have cycled.beng@google.com2008-09-141-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2204 0039d316-1c4b-4281-b951-d872f2087c98
* Test frames on the builders again to see if notification change helped.beng@google.com2008-09-141-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2203 0039d316-1c4b-4281-b951-d872f2087c98
* Include the area to the right of the tabstrip underneath the window controls ↵beng@google.com2008-09-141-3/+11
| | | | | | | | | in the window caption area. B=1031854 Review URL: http://codereview.chromium.org/2840 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2202 0039d316-1c4b-4281-b951-d872f2087c98
* This is almost a complete rewrite of DidNavigate and the associated ↵brettw@google.com2008-09-1422-988/+1298
| | | | | | | | | | NavigationController logic. The approach is that the NavigationController should be responsible for the logic and memory management of navigation. Previously, half the logic and memory management lived in WebContents which made it very hard to figure out what was going on. I split out the various navigation types into separate functions, which then copy and update any existing NavigationEntry as necessary. Previously, WebContents would make a new one which would be manually populated with random fields (I think some were forgotten, too), and then the NavigationController may or may not commit it. Review URL: http://codereview.chromium.org/479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2201 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back frames now test run is complete.beng@google.com2008-09-141-1/+0
| | | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2188 0039d316-1c4b-4281-b951-d872f2087c98
* Test new frames on buildbots again.beng@google.com2008-09-141-0/+1
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2183 0039d316-1c4b-4281-b951-d872f2087c98
* Fix interactive UI tests...beng@google.com2008-09-143-8/+15
| | | | | | | | | | - in the UI tests, SimulateOSClick was taking screen coordinates and the browser automation provider was treating them as client. For a click, screen coordinates seems better and is what most users were sending. This was causing the focus tests to fail since tabs weren't getting clicked on. Not sure why this wasn't affecting non-new-frames! - a math error in BrowserView2 was leading to incorrect window sizing in constrained window tests. - new frames mean layout is slightly different, and a constant in the constrained window test needed to be adjusted. Review URL: http://codereview.chromium.org/2828 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2180 0039d316-1c4b-4281-b951-d872f2087c98
* Get the new frames to pass the accessibility UI tests.beng@google.com2008-09-142-1/+43
| | | | | | | | B=2235 Review URL: http://codereview.chromium.org/3039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2177 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an include path.paulg@google.com2008-09-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2176 0039d316-1c4b-4281-b951-d872f2087c98
* Move the Save Page code to the browser/download/ directory.paulg@google.com2008-09-1419-89/+93
| | | | | | Review URL: http://codereview.chromium.org/3040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2174 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustagebeng@google.com2008-09-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2172 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustagebeng@google.com2008-09-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2171 0039d316-1c4b-4281-b951-d872f2087c98
* Move more UI stuff into browser/viewsbeng@google.com2008-09-1353-109/+109
| | | | | | | B=2205 Review URL: http://codereview.chromium.org/2825 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2169 0039d316-1c4b-4281-b951-d872f2087c98
* turn off new frames again.beng@google.com2008-09-131-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2168 0039d316-1c4b-4281-b951-d872f2087c98
* testing new frames on one cycle of buildbotsbeng@google.com2008-09-131-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2167 0039d316-1c4b-4281-b951-d872f2087c98
* Move the download code to new directories:paulg@google.com2008-09-1333-92/+94
| | | | | | | | | browser/download/ browser/views/ Review URL: http://codereview.chromium.org/2826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2166 0039d316-1c4b-4281-b951-d872f2087c98
* Back r2151 since it causes ui tests failures.maruel@google.com2008-09-135-550/+181
| | | | | | Review URL: http://codereview.chromium.org/3037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2161 0039d316-1c4b-4281-b951-d872f2087c98
* Move XPFrame, VistaFrame to views/old_framesbeng@google.com2008-09-1319-328/+87
| | | | | | | | | | | | Also remove WindowClippingInfo, since it's not used by anyone. And fix a couple of header include issues. B=2205 Review URL: http://codereview.chromium.org/2820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2158 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to commit these two files.beng@google.com2008-09-132-2/+2
| | | | | | | B=2205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2157 0039d316-1c4b-4281-b951-d872f2087c98
* Move importer files into an importer subdirectory.beng@google.com2008-09-1325-316/+113
| | | | | | | | | Also delete title chomper no one uses it. B=2205 Review URL: http://codereview.chromium.org/3035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2154 0039d316-1c4b-4281-b951-d872f2087c98
* Added routines to MetricsService to parse the server response and respond to ↵petersont@google.com2008-09-135-181/+550
| | | | | | | | the request to cease uploading with some probability. Review URL: http://codereview.chromium.org/1633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2151 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some files and directories we no longer use (We can resurrect them ↵beng@google.com2008-09-124-782/+6
| | | | | | | | | | from svn history later) B=2205 Review URL: http://codereview.chromium.org/2817 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2150 0039d316-1c4b-4281-b951-d872f2087c98
* Fix black flash when detaching tabs.beng@google.com2008-09-121-3/+3
| | | | | | | | B=2199 Review URL: http://codereview.chromium.org/3028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2145 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where history view was not showing star state correctly.sky@google.com2008-09-121-3/+5
| | | | | | | | | BUG=2117 TEST=See bug Review URL: http://codereview.chromium.org/3027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2144 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the change that fixed the encoding when viewing source in subframes.brettw@google.com2008-09-1228-212/+126
| | | | | | | | | This makes view source for some pages (for example Google Reader) not work properly. I speculate that telling WebKit to change the encoding (which causes a reload) right after starting the real load makes it confused. Review URL: http://codereview.chromium.org/3022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2143 0039d316-1c4b-4281-b951-d872f2087c98
* forgot these files, fixing clobber buildbeng@google.com2008-09-1210-10/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2142 0039d316-1c4b-4281-b951-d872f2087c98
* Move View components of the Browser's tab strip into the browser_views ↵beng@google.com2008-09-1215-85/+89
| | | | | | | | | project, and into the views/ subdirectory on disk. B=2198 Review URL: http://codereview.chromium.org/3020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2140 0039d316-1c4b-4281-b951-d872f2087c98
* Removing static initializers.jcampan@chromium.org2008-09-124-113/+103
| | | | | | | | BUG=None TEST=Make sure download bar is still working fine. Review URL: http://codereview.chromium.org/2431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2137 0039d316-1c4b-4281-b951-d872f2087c98
* Allows OSDD files to contain https.sky@google.com2008-09-123-13/+15
| | | | | | | | | BUG=2153 TEST=covered by unit tests Review URL: http://codereview.chromium.org/2454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2119 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent constrained popup windows from trying to become realerg@google.com2008-09-121-2/+8
| | | | | | | | | windows by using alert(). B=1372216 Review URL: http://codereview.chromium.org/1970 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2116 0039d316-1c4b-4281-b951-d872f2087c98
* Actually fix the javascript alert crasher in a way thaterg@google.com2008-09-122-1/+16
| | | | | | | | | doesn't introduce new crashes. B=1368898 Review URL: http://codereview.chromium.org/1966 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2104 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing bug 1951: Browser crash on View-Source of an https page.finnur@google.com2008-09-111-4/+5
| | | | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=1951 We load the page in view-source mode, then request the favicon to show in the tab. The SSLManager gets notified about OnRequestStarted for both the page and the favicon, but the favicon request gets redirected from: https://www.solomobile.ca/favicon.ico ... to ... http://www.solomobile.ca/Error.aspx?aspxerrorpath=/Page-Not-Found.aspx The SSLManager sees this as mixed content and while handling that it writes a debug message to the console, but in the process of writing the debug message we crash when GetTabContents(TAB_CONTENTS_WEB) returns NULL (since the current tab is TAB_CONTENTS_VIEW_SOURCE). Given that this is a debug message we are trying to write with a function that is only implemented on WebContents we should just NULL check the GetTabContents(TAB_CONTENTS_WEB) return value (and not log the debug message). Review URL: http://codereview.chromium.org/2445 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2090 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting constrained window change. Seems to break tests on TOT.erg@google.com2008-09-112-13/+1
| | | | | | Review URL: http://codereview.chromium.org/2447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2088 0039d316-1c4b-4281-b951-d872f2087c98
* As described in bug 2136, this test is flaky.jcampan@chromium.org2008-09-111-1/+2
| | | | | | | Temporarily disabling it. Review URL: http://codereview.chromium.org/1955 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2087 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-10-26 19:30:15 +0000