summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Changes the bookmark bubble to have the following logic:sky@google.com2008-12-1510-60/+96
| | | | | | | | | | | | | | | | | | . We only apply edits when the bubble is closed (previously selecting a different folder resulted in an immediate action). . Hitting escape cancels any edits. . When the bubble is shown for newly bookmarked items hitting escape removes the bookmark. . If you click 'Edit...' or select 'Choose another folder...' any edits are applied immediately before the editor is shown. BUG=5015 TEST=thorougly test the bookmark bubble to make sure I haven't broken anything. Review URL: http://codereview.chromium.org/14074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6991 0039d316-1c4b-4281-b951-d872f2087c98
* A new shot at the old system monitor changelist.mbelshe@google.com2008-12-1311-152/+88
| | | | | | Review URL: http://codereview.chromium.org/12883 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6974 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all the CHECKs I added to debug issue 4749.wtc@google.com2008-12-132-24/+1
| | | | | | | | TBR=eroman BUG=4749 Review URL: http://codereview.chromium.org/14108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6972 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6966.ericroman@google.com2008-12-131-8/+18
| | | | | | | this failed UI tests catastrophically Review URL: http://codereview.chromium.org/14103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6968 0039d316-1c4b-4281-b951-d872f2087c98
* Use automatic memory management for URLRequestContext's members.ericroman@google.com2008-12-131-18/+8
| | | | | | | | Also make ProxyService refcounted so the sharing between profiles is explicit. Review URL: http://codereview.chromium.org/13701 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6966 0039d316-1c4b-4281-b951-d872f2087c98
* revert r6938estade@chromium.org2008-12-121-1/+1
| | | | | | | (i.e. reapply 6935, with fix) Review URL: http://codereview.chromium.org/14087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6953 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a CHECK in RemovePendingRequest that asserts awtc@google.com2008-12-121-2/+10
| | | | | | | | | | condition that could be false in the new HTTP stack. R=rvargas BUG=4749 Review URL: http://codereview.chromium.org/13799 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6951 0039d316-1c4b-4281-b951-d872f2087c98
* Move skia_utils into the skia namespace.brettw@google.com2008-12-124-19/+19
| | | | | | Review URL: http://codereview.chromium.org/14079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6948 0039d316-1c4b-4281-b951-d872f2087c98
* Test to make sure issue 4737 doesn't regress.erg@google.com2008-12-121-0/+13
| | | | | | Review URL: http://codereview.chromium.org/13800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6942 0039d316-1c4b-4281-b951-d872f2087c98
* Have GRIT generate files into a common directory.tc@google.com2008-12-123-10/+3
| | | | | | | | | | | | | | | Joi has convinced me that GRIT should generate platform specific resources files. This is easier than parsing .rc files because GRIT effectively has an .rc parser. To that end, we need to convert some existing .rc files to .grd files (e.g., net_resources.rc and webkit_resources.rc). Rather than having every grd file output to a different place and -I all the different paths, have GRIT generate all files into one directory. This directory is grit_derived_sources. Review URL: http://codereview.chromium.org/13776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6940 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6935.ojan@google.com2008-12-121-1/+1
| | | | | | | Broke compile Review URL: http://codereview.chromium.org/14083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6938 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the memory mapped file class for posix.estade@chromium.org2008-12-121-1/+1
| | | | | | Review URL: http://codereview.chromium.org/14073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6935 0039d316-1c4b-4281-b951-d872f2087c98
* Move Image operations and convolver to the skia namespace and clean up a few ↵brettw@google.com2008-12-123-9/+8
| | | | | | | | (but not all) base types. Review URL: http://codereview.chromium.org/13726 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6921 0039d316-1c4b-4281-b951-d872f2087c98
* Add PropertyBag to TabContents. Convert the autocomplete state as a proof of ↵brettw@google.com2008-12-123-17/+22
| | | | | | | | | concept. Add necessary const accessors to property bag. BUG=5260 Review URL: http://codereview.chromium.org/13707 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6920 0039d316-1c4b-4281-b951-d872f2087c98
* Add a MemoryMappedFile class to file_util.estade@chromium.org2008-12-122-56/+12
| | | | | | | | Factor out windowisms from the spell checker. Review URL: http://codereview.chromium.org/14041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6919 0039d316-1c4b-4281-b951-d872f2087c98
* During tab dragging if you hover over a browser window we now move itsky@google.com2008-12-123-1/+43
| | | | | | | | | | | | | | to front after a delay. Also made docking to another window bring the other window to front. BUG=2038 TEST=Create two window with two tabs each. Drag a tab from one window onto the other window (not the tab area), hold it for a second and make sure the other window comes to front. Review URL: http://codereview.chromium.org/14057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6909 0039d316-1c4b-4281-b951-d872f2087c98
* Fix onblur= handelers getting called on popup window creation. This ↵erg@google.com2008-12-121-1/+4
| | | | | | | | | regressed in r5417. ISSUE=http://crbug.com/4737 Review URL: http://codereview.chromium.org/13271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6907 0039d316-1c4b-4281-b951-d872f2087c98
* Makes open all work again on the bookmark bar's context menu.sky@google.com2008-12-121-0/+1
| | | | | | | | | | BUG=4540 TEST=Right click on the bookmark bar (not over a button) and make sure open all opens all the bookmarks on the bookmark bar. Review URL: http://codereview.chromium.org/13790 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6904 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bookmark menus so that they align properly when rtl.sky@google.com2008-12-121-4/+9
| | | | | | | | | BUG=5418 TEST=see bug Review URL: http://codereview.chromium.org/14053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6902 0039d316-1c4b-4281-b951-d872f2087c98
* Changes bookmark manager's import to show a description in the filessky@google.com2008-12-121-6/+2
| | | | | | | | | | | | | | | of type instead of *.html. BUG=4479 TEST=Bring up the bookmark manager, click tools->import. Make sure the import dialog 'files of type' has something like 'Chrome Document' (although this depends upon your registry), and that selecting it shows all html and htm files. Additionally make sure you have 'all files' in the 'files of type' combobox too. Review URL: http://codereview.chromium.org/14025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6890 0039d316-1c4b-4281-b951-d872f2087c98
* Port flush_cache tool and perf_tests.phajdan.jr@chromium.org2008-12-123-89/+97
| | | | | | | | | BUG=4160,4263 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6815 Review URL: http://codereview.chromium.org/9639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6886 0039d316-1c4b-4281-b951-d872f2087c98
* browser porting, part 2 - importerphajdan.jr@chromium.org2008-12-1213-47/+216
| | | | | | Review URL: http://codereview.chromium.org/12688 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6885 0039d316-1c4b-4281-b951-d872f2087c98
* Once we've decided that a path doesn't exist, reserve it by creating an ↵abarth@chromium.org2008-12-122-24/+25
| | | | | | | | | | | empty file so that we don't later think that the same path doesn't exist. BUG=3662 R=paulg Review URL: http://codereview.chromium.org/13336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6878 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the amount of space between the location bar and the bookmark bar by ↵glen@chromium.org2008-12-124-14/+34
| | | | | | | | allowing the bookmark bar to overlap the toolbar when 'always shown'. This reduces the total height of the toolbar stack by 4 pixels and makes it look better. Review URL: http://codereview.chromium.org/12668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6868 0039d316-1c4b-4281-b951-d872f2087c98
* Move to using data URLs for unload tests and generallyojan@google.com2008-12-112-75/+95
| | | | | | | | cleanup the unload tests in preparation for adding in tests for beforeunload. Review URL: http://codereview.chromium.org/14017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6839 0039d316-1c4b-4281-b951-d872f2087c98
* Changes new tab page to show recently closed window correctly.sky@google.com2008-12-112-8/+90
| | | | | | | | | BUG=4804 TEST=none Review URL: http://codereview.chromium.org/13760 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6836 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ViewHandle to NativeView et al.agl@chromium.org2008-12-112-2/+2
| | | | | | | | | | | ViewHandle is a very unfortunate name when we actually start dealing with views, so we are renaming the cross-platform typedefs to make it clear that they refer to platform specific native UI elements. Review URL: http://codereview.chromium.org/13754 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6826 0039d316-1c4b-4281-b951-d872f2087c98
* Change the sense of a CHECK to see if the oppositewtc@google.com2008-12-111-1/+1
| | | | | | | | | | condition is ever false. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/13370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6822 0039d316-1c4b-4281-b951-d872f2087c98
* A follow-up to a recent unforking of WebCore/platform/text/TextCodecICU.cpp ↵jungshik@google.com2008-12-113-7/+7
| | | | | | | | | | | | | | | (r6540). Up to now, we canonicalized to EUC-KR, TIS-620 and GB2312, but with unforking, we'd better canonicalize to windows-949, windows-874 and GBK. Another change is necessary in Webkit (Document.cpp), which I'll do it while unforking it. BUG=3703 Review URL: http://codereview.chromium.org/13645 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6817 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6815.phajdan.jr@chromium.org2008-12-113-97/+89
| | | | | | Review URL: http://codereview.chromium.org/14006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6816 0039d316-1c4b-4281-b951-d872f2087c98
* Port flush_cache tool and perf_tests.phajdan.jr@chromium.org2008-12-113-89/+97
| | | | | | | BUG=4160,4263 Review URL: http://codereview.chromium.org/9639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6815 0039d316-1c4b-4281-b951-d872f2087c98
* Try and make some spellcheck code more obvious by using typedefs.pkasting@chromium.org2008-12-115-49/+48
| | | | | | | I am not convinced this patch is a net win. Please share your thoughts on if using a Language/Languages set of types is better or worse than what we're doing now. Review URL: http://codereview.chromium.org/13367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6807 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up about box for unofficial builds.phajdan.jr@chromium.org2008-12-111-0/+6
| | | | | | | | | | Currently unofficial builds (Chromium) display there an error message that update server is unavailable. This is obvious (there is no update server for trunk builds), but looks bad. This patch removes the message for unofficial builds. Review URL: http://codereview.chromium.org/13352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6806 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a stale comment. net::ERR_CERT_UNABLE_TO_CHECK_REVOCATIONwtc@google.com2008-12-111-1/+1
| | | | | | | | | | | | now causes the security style to be set to authentication broken. (The security style is set elsewhere, not here, but this comment is still confusing.) R=jcampan BUG=4749 Review URL: http://codereview.chromium.org/13371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6805 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extensions_service_unittest on Linux.phajdan.jr@chromium.org2008-12-111-3/+17
| | | | | | | | | | I was getting failures which are not present on buildbot, I don't know why. But with these changes it should be more solid. This also prevents a segfault which I got (out of bounds array access). Review URL: http://codereview.chromium.org/13258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6792 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6787. inteded to commit other changelist.phajdan.jr@chromium.org2008-12-111-17/+3
| | | | | | Review URL: http://codereview.chromium.org/13387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6789 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extensions_service_unittest on Linux.phajdan.jr@chromium.org2008-12-111-3/+17
| | | | | | | | | | I was getting failures which are not present on buildbot, I don't know why. But with these changes it should be more solid. This also prevents a segfault which I got (out of bounds array access). Review URL: http://codereview.chromium.org/13258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6787 0039d316-1c4b-4281-b951-d872f2087c98
* Move file enumeration to filepaths.avi@google.com2008-12-118-32/+37
| | | | | | Review URL: http://codereview.chromium.org/13315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6784 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a handful of related bookmark manager bugs/requests:sky@google.com2008-12-115-9/+97
| | | | | | | | | | | | | | | . Adds a search field before the text field. . When the search node is selected and there are no results or no search text, a descriptive label is drawn on top of the table telling the user what's happening. . In the bookmark menus Edit... is now Rename... for folders. BUG=5272 5319 5273 4165 TEST=see individual bugs Review URL: http://codereview.chromium.org/13724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6777 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two session restore bugs:sky@google.com2008-12-112-2/+17
| | | | | | | | | | | | | | | | . If the user launches incognito we don't attempt to restore last session and instead just do default launch behavior (new tab page). . Don't show the session restore info bar when launched incognito. I'm assuming that if the user launched in incognito they were previously running incognito so that there is nothing to restore. BUG=4381 5119 TEST=turn on session restore and launch with --incognito, make sure the incognito window comes up. Review URL: http://codereview.chromium.org/13368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6776 0039d316-1c4b-4281-b951-d872f2087c98
* Missed this file in my previous cleanup patch.pkasting@chromium.org2008-12-111-2/+2
| | | | | | Review URL: http://codereview.chromium.org/13729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6766 0039d316-1c4b-4281-b951-d872f2087c98
* Only allow bookmark keyboard shortcut for tabbed browsers.sky@google.com2008-12-111-1/+9
| | | | | | | | | BUG=5055 TEST=make sure control-d does nothing for apps and popup windows Review URL: http://codereview.chromium.org/13363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6764 0039d316-1c4b-4281-b951-d872f2087c98
* Better build bustage fix: Commit the rest of the original patch. Rolls back ↵pkasting@chromium.org2008-12-113-16/+15
| | | | | | the previous blind fix I tried. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6760 0039d316-1c4b-4281-b951-d872f2087c98
* Blind attempt at build fix. I don't know why this should be necessary.pkasting@chromium.org2008-12-111-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6759 0039d316-1c4b-4281-b951-d872f2087c98
* Make the autocomplete system and various other connected bits of code use ↵pkasting@chromium.org2008-12-1027-273/+296
| | | | | | | | GURL instead of wstring where appropriate. Original patch by phajdan.jr@gmail.com, r=me,sky. See http://codereview.chromium.org/13205 . BUG=715234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6758 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempted, untested build fix.pkasting@chromium.org2008-12-101-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6753 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression with Find in page focus on trunk. finnur@google.com2008-12-104-8/+66
| | | | | | | | | | | | Basically, if the Find box is open, pressing Ctrl+F should set focus to the text field. This regressed when the Find box moved into web_contents_view. I have added a UI test to catch this in the future. Review URL: http://codereview.chromium.org/13721 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6748 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unneeded CHECKs. Add a CHECK to determinewtc@google.com2008-12-102-10/+15
| | | | | | | | | | | whether the recursive call to RemovePendingRequest is removing the same or a different request. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/13329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6746 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 6.pkasting@chromium.org2008-12-107-110/+99
| | | | | | | | | | | | | | | | | | | | | Lots of small things (mostly in spellcheck code), e.g.: * L"" -> std::wstring() * type *var; -> type* var; * Fix parameter line-wrapping to comply with style guide * Remove unnecessary classname scoping inside class delcaration * Remove empty declaration * Add/remove blank lines in hopes of increasing readability * Add block ("{", "}") around local use of a temporary that is later redefined * Fold temps into other statements where obvious * Use std::find() instead of hand-rolling the same functionality * Combine distinct cases in switch statements when they all do the same thing * Range-check to avoid some algorithmic work when it's not needed * at() -> [] ...and various others. Pretty much every change stands on its own. Do not hesitate to complain about changes you think are unhelpful to the code, this change is something of a dumping ground. (I did try to avoid the sort of gratuitous "const"-adding that has gotten me in trouble before :). ) Review URL: http://codereview.chromium.org/13688 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6745 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 5.pkasting@chromium.org2008-12-102-341/+381
| | | | | | | | | | | Reorder identifiers, functions, initalization statements, etc. to all match. This preserves the original groups Ben created but makes a couple of changes: * Within each group, the order is now "by GUI order" instead of random. This can be subjective, but when I tried doing alphabetical order, it resulted in related functionality being separated pretty arbitrarily. * I moved the "window management" functions next to (but above) the "page-related" functions (this seemed a little more logical, but maybe not) I also renamed UpdateNavigationCommands() to try and reflect that it updates a lot more than navigation commands, and moved some unconditionally-initialized commands (profile stuff) in there over to InitCommandState() where they belong. Review URL: http://codereview.chromium.org/13681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6721 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 15:55:33 +0000