summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Attempting backout of r10495 due to ui_tests:mark@chromium.org2009-02-261-1/+0
| | | | | | | | | | ResourceDispatcherTest.CrossSiteAfterCrash PageLoadTest.Reliability CrashRecoveryUITest.Reload CrashRecoveryUITest.LoadInNewTab Review URL: http://codereview.chromium.org/28208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10505 0039d316-1c4b-4281-b951-d872f2087c98
* This CL addresses several issues with focus in application mode:jcampan@chromium.org2009-02-263-2/+6
| | | | | | | | | | | | | - when started, the focus was not on the page (it was on the location bar, which is not shown) - ALT-F4 would not work at that point since the location bar was focused but not showing - since the location bar was focusable, tabbing through would focus it (causing the focus to go to the top window). BUG=8124,6046,8126 TEST=See bugs. R=sky Review URL: http://codereview.chromium.org/28202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10504 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so windows opened from links in Windows Live Messenger cause the ↵ben@chromium.org2009-02-261-3/+1
| | | | | | | | | | | | | | | window to appear instead of being invisible. The discovery is that Windows enforces that you call ShowWindow with the value of STARTUPINFO's wShowWindow field first before calling it with any other value, otherwise all subsequent calls are ignored. I used to have code that flattened the return value of a function into something that would ensure the window is visible, but what I actually needed to do was show the window twice in this case. Ick. http://crbug.com/3126 TEST=Have someone send you a link in a Windows Live Messenger window, click it without Chrome running (Chrome must be default browser), and a Chrome window should appear, visible, loading the link. Also try running chrome.exe from bash to make sure that still works. Review URL: http://codereview.chromium.org/27190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10502 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change made in http://codereview.chromium.org/10925.mad@chromium.org2009-02-261-9/+4
| | | | | | | | | | It was mistakenly resting the wrong iterator, so I also renamed the outer one to avoid confusion. BUG=2569 Review URL: http://codereview.chromium.org/28200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10500 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit tests.brettw@chromium.org2009-02-261-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10495 0039d316-1c4b-4281-b951-d872f2087c98
* Add a missing header from r10487.jhawkins@chromium.org2009-02-261-0/+1
| | | | | | TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10492 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 8063: Find-in-page remains open on History/Downloads page.finnur@google.com2009-02-263-6/+48
| | | | | | | | | | Added a UI test to catch this in the future. Also, in some of the UI tests I added a generic URL for pages that don't care about the content of the page and are just testing visibility of the Find box, etc. TEST=Covered by tests already. BUG=8063 Review URL: http://codereview.chromium.org/28162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10490 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing crash in StartFinding (2nd attempt).finnur@google.com2009-02-261-4/+6
| | | | | | | | | | | | | | | | | | | | The first attempt to fix this was unsuccessful and crashes showed up again during the automated ui testing. I still can't reproduce locally, but when I look again at the crash dump I think that the fact that it looked like the FindBarView was destroyed is misleading and the real issue is the same as with the crash in StopFinding (that web_contents has been destroyed moments before we receive the request). I am therefore removing the code I added earlier and replacing it with a null check for web_contents. TEST=Covered by automated ui tests. BUG=8048 Review URL: http://codereview.chromium.org/27219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10489 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the following:jcampan@chromium.org2009-02-262-6/+9
| | | | | | | | | | | | | | When restoring a session, the browser is shown after a tab is selected causing the focus to be on the location bar (not tab contents for web pages). This CL ensures the tab decides where the focus should be after the browser is shown. BUG=6000 TEST=See bug R=sky Review URL: http://codereview.chromium.org/28156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10488 0039d316-1c4b-4281-b951-d872f2087c98
* More URL constants replacement.brettw@chromium.org2009-02-2613-37/+43
| | | | | | Review URL: http://codereview.chromium.org/28170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10487 0039d316-1c4b-4281-b951-d872f2087c98
* Remove view_source_contents.cc from the porting list as this file was ↵jhawkins@chromium.org2009-02-261-1/+0
| | | | | | | | | removed in r10346. TBR=brettw Review URL: http://codereview.chromium.org/28195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10486 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent the display of the resize corner bitmap on top of the download shelf ↵mad@chromium.org2009-02-261-5/+14
| | | | | | | | | when the browser window is maximized. BUG=8025 Review URL: http://codereview.chromium.org/28168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10485 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the base64 stop sign graphic and use CSS instead. (R=agl)evan@chromium.org2009-02-261-13/+18
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10483 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in extension install.erikkay@google.com2009-02-261-1/+11
| | | | | | Review URL: http://codereview.chromium.org/27215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10482 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling ThirtyFourTabs test.kuchhal@chromium.org2009-02-261-2/+2
| | | | | | | | | | TBR=jam BUG=8119 Review URL: http://codereview.chromium.org/28190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10475 0039d316-1c4b-4281-b951-d872f2087c98
* Make render_view_context_menu.cc compile on Posix.jhawkins@chromium.org2009-02-263-9/+17
| | | | | | Review URL: http://codereview.chromium.org/27193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10474 0039d316-1c4b-4281-b951-d872f2087c98
* Add the IDC_GO mapping for the go button widget.deanm@chromium.org2009-02-261-0/+5
| | | | | | | | We previously crashed with a NOTREACHED() when you clicked the go button. Review URL: http://codereview.chromium.org/27205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10473 0039d316-1c4b-4281-b951-d872f2087c98
* Remove zombie hunting on startup.deanm@chromium.org2009-02-261-2/+0
| | | | | | | | | | | We are hopefully over our zombie problems, and this can cause other troubles. This should also improve startup performance, since we don't need to iterate all processes on the system on startup. BUG=6468 Review URL: http://codereview.chromium.org/27203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10471 0039d316-1c4b-4281-b951-d872f2087c98
* We have localization (w00t!). Using it.avi@chromium.org2009-02-261-3/+8
| | | | | | Review URL: http://codereview.chromium.org/28188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10470 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting key change (again); this breaks every keyboard layout test there ↵avi@chromium.org2009-02-264-6/+12
| | | | | | | | is. Will fix and recommit. Review URL: http://codereview.chromium.org/28186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10469 0039d316-1c4b-4281-b951-d872f2087c98
* Try a new approach to fixing IAT unpatch crashes when the DLL is gone.deanm@chromium.org2009-02-262-44/+70
| | | | | | | | | | | | Have the IAT patcher take some "ownership" of the DLL, by taking a library name and then calling LoadLibrary() / FreeLibrary() to manage the reference count. This means as long is there isn't some other reference count balancing bug happening in the process, the DLL will never be unloaded while we are patched. This effectively reverts r9929, the VirtualQuery additional checks are removed. BUG=7701 Review URL: http://codereview.chromium.org/21453 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10467 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing WebKeyboardEvent. For reals this time.avi@chromium.org2009-02-264-12/+6
| | | | | | | A recommit of http://codereview.chromium.org/27056 . Review URL: http://codereview.chromium.org/28136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10464 0039d316-1c4b-4281-b951-d872f2087c98
* Wire up resource bundles on the mac:thomasvl@chromium.org2009-02-261-2/+0
| | | | | | | | | | | | | - compile resource_bundle - add resource_bundle_mac by cloning the linux and using some NSBundle to find the files. - enable resource bundles on the mac in the calling code. - added script to app target to repack .pak files into larger chunks (chrome, theme, and localized bits). - added script to copy repacked files into the app bundle. Review URL: http://codereview.chromium.org/28171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10460 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 10456.hbono@chromium.org2009-02-262-21/+1
| | | | | | Review URL: http://codereview.chromium.org/28180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10458 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes Issue 7377: Regression: Omnibox trims URL ending with 0x85hbono@chromium.org2009-02-262-1/+21
| | | | | | | | | | To fix this issue, this change adds a new function TrimWhitespaceUTF8(), which trims space characters (including non-printable characters and broken UTF-8 characters) from either end of a UTF-8 string. Please feel free to give me your comments since I'm not sure this implimentation is correct. (Maybe this implementation trims too aggressively.) BUG=7377 Review URL: http://codereview.chromium.org/20219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10456 0039d316-1c4b-4281-b951-d872f2087c98
* Developer tools messages are forwarded as wrapped IPC::Messages(previously ↵yurys@google.com2009-02-2624-3/+474
| | | | | | | | | | | | | | they were represented as int type+string body). I stole IPC::Message serialization code from jam's CL(http://codereview.chromium.org/20413). jam: please look at message forwarding code. When tools messages are send from browser to renderer they are also wrapped(unlike worker messages which are unwrapped and sent as is). It allows to describe developer tools messages in its own file instead of putting all of them into render_messages_internal.h brettw: please check if it's OK to have ForwardMessageToToolsClient in WebContentsView Review URL: http://codereview.chromium.org/21540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10455 0039d316-1c4b-4281-b951-d872f2087c98
* Make web_drag_source.cc compile on Posix.jhawkins@chromium.org2009-02-263-19/+38
| | | | | | Review URL: http://codereview.chromium.org/27192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10443 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add splash screenagl@chromium.org2009-02-266-3/+106
| | | | | | | | In preparation for an internal launch, this adds a splash screen as the startup URL for Linux which has a few FAQs. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10442 0039d316-1c4b-4281-b951-d872f2087c98
* Make IPC::Logging register to watch for message loop destruction.jam@chromium.org2009-02-261-3/+1
| | | | | | | | BUG=8029 Review URL: http://codereview.chromium.org/28154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10441 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fixes for tab contents switchingagl@chromium.org2009-02-264-5/+7
| | | | | | | | Previously, removing a view_ from its container destroyed it. We fix this by disabling GTK's auto reference stealing. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10440 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix GDK error when switching tab contentsagl@chromium.org2009-02-263-17/+18
| | | | | | | | | | | | | | When we remove a drawing area from a container, GTK destroys the X window. However, the BackingStore remembers the old X window id and emits X requests using the wrong id. This change makes the window id an argument to ShowRect and makes the pixmaps from the root window instead. Review: http://codereview.chromium.org/27169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10439 0039d316-1c4b-4281-b951-d872f2087c98
* OS_MAC should be OS_MACOSX.wtc@chromium.org2009-02-261-1/+1
| | | | | | | R=brettw Review URL: http://codereview.chromium.org/28157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10438 0039d316-1c4b-4281-b951-d872f2087c98
* Coalesce more hardcoded schemes to using predefined constants.brettw@chromium.org2009-02-2628-81/+97
| | | | | | Review URL: http://codereview.chromium.org/31008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10437 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome_plugin_host.cc and chrome_plugin_util.cc compile on Posix.jhawkins@chromium.org2009-02-267-23/+40
| | | | | | Review URL: http://codereview.chromium.org/27150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10436 0039d316-1c4b-4281-b951-d872f2087c98
* Implements a method to enable/disable the "Remove All" buttontc@google.com2009-02-262-0/+8
| | | | | | | | | | | | | | | | in the password manager. This method is called whenever the password manager window is opened and disables the button if there are no passwords stored. It is also called when all of the stored passwords are removed. BUG=7228 Original patch by Kyle Nahrgang <kpn24@drexel.edu> in http://codereview.chromium.org/28063/show Review URL: http://codereview.chromium.org/27191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10435 0039d316-1c4b-4281-b951-d872f2087c98
* Create ProfilePersonalization in the ctor of ProfileImpl instead of lazily ↵munjal@chromium.org2009-02-261-3/+5
| | | | | | | | creating it. Review URL: http://codereview.chromium.org/28143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10433 0039d316-1c4b-4281-b951-d872f2087c98
* Hide profiles behind a command-line switch since the user-data-dir stuffmunjal@chromium.org2009-02-263-3/+15
| | | | | | | | | | wouldn't work on Mac. See bug http://code.google.com/p/chromium/issues/detail?id=7987 Review URL: http://codereview.chromium.org/28093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10432 0039d316-1c4b-4281-b951-d872f2087c98
* Fix fullscreen mode opacity issues on Aero glass. We need to not extend the ↵pkasting@chromium.org2009-02-265-41/+64
| | | | | | | | | | | glass into the client area at all in fullscreen mode or text over it becomes semitransparent. Because I can't use "IsTabStripVisible()" to indicate "do we need to goof with the window frame" anymore, I've introduced "IsNormalMode()" instead, and tried to change callers of the former to use the latter where appropriate. BUG=8066 Review URL: http://codereview.chromium.org/28159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10431 0039d316-1c4b-4281-b951-d872f2087c98
* Add an identity (id) to system drag & drop.tc@google.com2009-02-261-1/+7
| | | | | | | | | | | | | | | | | Used for gears file drag & drop in chrome, assign a drag id (identity) to each drag and drop session. Send the identity to the renderer WebViewImpl in drag enter notifications, provide a getter method. BUG=7995 Original patch by noel.gordon@gmail.com in: http://codereview.chromium.org/28108/show Review URL: http://codereview.chromium.org/28158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10430 0039d316-1c4b-4281-b951-d872f2087c98
* We can get into a state where the automation framework presses the Close ↵finnur@google.com2009-02-261-11/+15
| | | | | | | | | | | | | button in the Find box after the tab has been destroyed. This causes the Find box to act on a NULL web_contents_ pointer. We now guard against this by checking for NULL web_contents before performing any work that relies on it. (I can't reproduce this bug manually or by running the automation testing locally, but this is an attempt to fix the crash by using the information gathered from looking at the crash dump). Review URL: http://codereview.chromium.org/27173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10414 0039d316-1c4b-4281-b951-d872f2087c98
* We can get into a state where the automation framework sends a search ↵finnur@google.com2009-02-261-0/+4
| | | | | | | | | | | | string, which ends up in a handler in the FindBarView that has already been destroyed, causing a crash. We now explicitly null the controller for the text field when destroying the view so that if it is still receiving messages they will be ignored by the view. (I can't reproduce this bug manually or by running the automation testing locally, but this is an attempt to fix the crash by using the information gathered from looking at the crash dump). Review URL: http://codereview.chromium.org/27172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10413 0039d316-1c4b-4281-b951-d872f2087c98
* Auto install and update extensions from a registry defined location. This ↵erikkay@google.com2009-02-263-270/+488
| | | | | | | | allows developers to install a chrome extension and manage its update process completely indepdendently of Chrome's built-in mechanism. Review URL: http://codereview.chromium.org/28040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10412 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the p13n NTP handler.nick@chromium.org2009-02-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/27174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10411 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send the receiver function name in the ↵ananta@chromium.org2009-02-258-17/+10
| | | | | | | | | | ExternalHostBindings::ForwardMessageToExternalHost CPP binding exposed for sending messages from Chrome to an external host, Review URL: http://codereview.chromium.org/27125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10407 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Implement accelerators in the gtk port" at avi's request.erg@google.com2009-02-258-157/+68
| | | | | | | This reverts commit 1dbbeb791d5a9ae0740afb5d7eb57710c93b7f38. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10403 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 10400.jcampan@chromium.org2009-02-252-9/+6
| | | | | | | Reverting broke the linux build Review URL: http://codereview.chromium.org/27178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10402 0039d316-1c4b-4281-b951-d872f2087c98
* When restoring a session, the browser is shown after a tab is selected ↵jcampan@chromium.org2009-02-252-6/+9
| | | | | | | | | | | | | causing the focus to be on the location bar (not tab contents for web pages). This CL ensures the tab decides where the focus should be after the browser is shown. BUG=6000 TEST=See bug R=sky Review URL: http://codereview.chromium.org/28152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10400 0039d316-1c4b-4281-b951-d872f2087c98
* Add the hunspell project to Chrome.app and get spellchecker compilingshess@chromium.org2009-02-253-3/+3
| | | | | | | | for Mac. Review URL: http://codereview.chromium.org/28053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10399 0039d316-1c4b-4281-b951-d872f2087c98
* Add bug links for ProcessSingleton.evan@chromium.org2009-02-251-2/+3
| | | | | | Review URL: http://codereview.chromium.org/28142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10395 0039d316-1c4b-4281-b951-d872f2087c98
* Implement accelerators in the gtk port.erg@google.com2009-02-258-68/+157
| | | | | | | | | | | - Adds accelerators to all the menu items that had them on windows. - Adds accelerators to back (Alt+left), forward (Alt+right), reload (Ctr+R) and focus the URL box (Ctr+L). Review URL: http://codereview.chromium.org/28105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10387 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 14:04:28 +0000