summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Revert accidental commits: r25115 and r25116mpcomplete@chromium.org2009-09-0112-167/+88
| | | | | | Review URL: http://codereview.chromium.org/183045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25120 0039d316-1c4b-4281-b951-d872f2087c98
* Minor tweaks to how pin tabs look:sky@chromium.org2009-09-013-3/+31
| | | | | | | | | | | | | . Increases the width by 8 pixels. . Animates the position of the favicon when the tab changes from pinned to unpinned. Without this the favicon jumps noticably. BUG=none TEST=none Review URL: http://codereview.chromium.org/183040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25118 0039d316-1c4b-4281-b951-d872f2087c98
* formattingmpcomplete@chromium.org2009-09-011-1/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25116 0039d316-1c4b-4281-b951-d872f2087c98
* Merge branch 'api' of /src/chrome/src into apimpcomplete@chromium.org2009-09-0112-88/+165
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25115 0039d316-1c4b-4281-b951-d872f2087c98
* Disable two DevToolsSanityTests. They started failing after ↵dglazkov@chromium.org2009-09-011-2/+2
| | | | | | | | | | | | http://trac.webkit.org/changeset/47944 came downstream. TBR=pfeldman BUG=20835 TEST=none Review URL: http://codereview.chromium.org/180073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25114 0039d316-1c4b-4281-b951-d872f2087c98
* Add skeleton for an about:net-internal page.eroman@chromium.org2009-09-011-1/+13
| | | | | | | | | | | | | | | | | | This page contains low-level debug information that is of interest to power users, and bug investigators. The output can be filtered by using special sub-URLs. The sub-URLs themselves are listed when visiting about:net-internal, but to give an idea: about:net-internal -- everything about:net-internal/proxyservice -- all things proxy about:net-internal/proxyservice.config -- current settings about:net-internal/hostresolver.hostcache -- dns cache BUG=http://crbug.com/14478 R=darin Review URL: http://codereview.chromium.org/173024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25109 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP cleanuparv@google.com2009-09-013-81/+50
| | | | | | | | | | | | | | | - Fix bookmark sync background color - Make hidden elements not take up space at the bottom of the NNTP - Simplify sync and set as home page - Fix issue where middle clicking on the sync link opened a new tab BUG=19538 TEST=None Review URL: http://codereview.chromium.org/178065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25107 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: handle external protocols, e.g. mailto: links.mdm@chromium.org2009-09-011-77/+12
| | | | | | | | | BUG=20696 TEST=click a mailto: link, it should open your default MUA Review URL: http://codereview.chromium.org/177040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25100 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb request interception into the appcache library for both chrome and ↵michaeln@google.com2009-09-017-4/+71
| | | | | | | | | | | | | | | | | | | | | | | | test_shell. AppCache library: * Added AppCacheInterceptor, which is derived from URLRequest::Interceptor. Chrome: * Each UserProfile instantiates a ChromeAppCacheService, which is derived from an appcache library class. * Each ChromeURLRequestContext associated with that profile has a reference to that instance. * ResourceDispatcherHost pokes AppCacheInterceptor when initiating URLRequests and when returning the response head. TestShell: * Added SimpleAppCacheSystem which bundles together appcache lib components for use in a single process with an UI and IO thread. * TestShellWebKit instantiates and initializes an instance of the above, aimed at at temp directory that will get cleaned up when the test run is over. * SimpleResourceLoaderBridge pokes the system when initiating URLRequests and when returning the response head. TEST=none, although many existing tests exercise this stuff BUG=none Review URL: http://codereview.chromium.org/173406 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25099 0039d316-1c4b-4281-b951-d872f2087c98
* (Mac) Added unit tests for ClickHoldButtonCell and DelayedMenuButton.viettrungluu@chromium.org2009-09-015-36/+219
| | | | | | | | | | | | Also added some comments and cleaned up some code. BUG=20693 TEST=Run unit tests. Also make sure back/forward buttons (and menus) \ work correctly. Review URL: http://codereview.chromium.org/179043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25088 0039d316-1c4b-4281-b951-d872f2087c98
* Escape the URL for the CSS url function.arv@google.com2009-09-011-1/+11
| | | | | | | | | | | | | | | | | This fixes issues where the thumbnail on the NTP wasn't showing. BUG=18380 TEST=Make sure that the following pages show thumbnails on the new tab page: http://digg.com/?\ http://code.google.com/p/chromium/issues/list?can=2&q=&sort=-id&colspec=ID+Stars+Pri+Area+Type+Status+Summary+Modified+Owner http://code.google.com/p/chromium/issues/list?can=2&q=&sort=-id&colspec=ID%20Stars%20Pri%20Area%20Type%20Status%20Summary%20Modified%20Owner Review URL: http://codereview.chromium.org/178061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25081 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use rounded corners in AutocompletePopupViewGtk.erg@google.com2009-09-011-14/+12
| | | | | | Review URL: http://codereview.chromium.org/173646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25080 0039d316-1c4b-4281-b951-d872f2087c98
* Remove un-needed method (updateLoadingAnimations).pinkerton@chromium.org2009-09-013-16/+1
| | | | | | | | BUG=8281 TEST=none. Review URL: http://codereview.chromium.org/181037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25077 0039d316-1c4b-4281-b951-d872f2087c98
* Squash the bookmark bar into the toolbar by 4 pixels.estade@chromium.org2009-09-016-64/+67
| | | | | | | | | | On windows they do this by having the two views overlap. We can't so instead move the bottom 4 pixels of padding from the toolbar widget into the bookmark bar widget. When the bookmark bar is closed/hidden, it still shows those 4 pixels. When it opens, it is able to make use of those 4 pixels. Since we get 4 extra pixels, we can make the overall height of the bookmark bar 4 pixels less. BUG=18570 Review URL: http://codereview.chromium.org/178029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25075 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Make the toolbar star button a drag source.estade@chromium.org2009-09-015-21/+39
| | | | | | | | | | Also refactor URI list/named url packing code. BUG=19008 Review URL: http://codereview.chromium.org/175036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25067 0039d316-1c4b-4281-b951-d872f2087c98
* Porting textfield to toolkit_views Gtk.jcampan@chromium.org2009-09-015-18/+14
| | | | | | | | | | | BUG=None TEST=Run the view unit-tests. See original review: http://codereview.chromium.org/165512/show Review URL: http://codereview.chromium.org/180061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25063 0039d316-1c4b-4281-b951-d872f2087c98
* Set the window type hint for the options dialog andtony@chromium.org2009-09-012-0/+6
| | | | | | | | | | | | | | task manager to GDK_WINDOW_TYPE_HINT_NORMAL. This allows the dialogs to go behind browser windows in metacity. I did it for these two dialogs mainly because they have links to web pages. The links should be able to open on top of the dialog. Review URL: http://codereview.chromium.org/179014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25057 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak the world. Turns out SetProfile(NULL) causes a DCHECK failure.pkasting@chromium.org2009-09-012-10/+3
| | | | | | | | | TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/177055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25053 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: The Theme Installed Infobar's "Undo" button should work with GTK ↵erg@google.com2009-09-015-3/+84
| | | | | | | | | | Themes. http://crbug.com/20629 Review URL: http://codereview.chromium.org/181022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25050 0039d316-1c4b-4281-b951-d872f2087c98
* Restrict use of tab positioning animation on a new tab to when there are ↵pinkerton@chromium.org2009-09-011-7/+8
| | | | | | | | | | more than one tab. Don't use animation on new tab button BUG=none TEST=NTB shows up correctly and doesn't show during drags. Review URL: http://codereview.chromium.org/174579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25049 0039d316-1c4b-4281-b951-d872f2087c98
* Move Mozilla FTP LIST response parsing code to net/third_party directory.phajdan.jr@chromium.org2009-09-011-3/+39
| | | | | | | | | | | This should make licensing terms and third-party origin of the code more clear. TEST=none BUG=none Review URL: http://codereview.chromium.org/179041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25047 0039d316-1c4b-4281-b951-d872f2087c98
* Disable MessagingContentScript test due to flakinessdglazkov@chromium.org2009-09-011-1/+1
| | | | | | | | | | TBR=mpcomplete BUG=20795 TEST=none Review URL: http://codereview.chromium.org/176061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25046 0039d316-1c4b-4281-b951-d872f2087c98
* When running on chrome OS about:version now shows OS version.sky@chromium.org2009-09-016-25/+258
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/179063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25045 0039d316-1c4b-4281-b951-d872f2087c98
* More work fixing miscellaneous issues in the autocomplete code, probably ↵pkasting@chromium.org2009-09-0111-185/+182
| | | | | | | | | | | | | | | | | none of which will help my crasher :( * Force the query to stop if the user deletes a match. This makes more sense from a UI perspective and allows some code to be simpler. * Prevent us from potentially doing a "minimal changes" match in a different profile (hard to trigger, likely no practical effects) * Remove unneeded Reset() call on a repeating timer (which will auto-reset itself) * Rename one of the notifications and move its listener to the edit, since that's who really cares about it anyway. * Make the controller's Stop(true) notify the popup via the normal observer pipeline rather than coding something special into the popup's StopAutocomplete(). * Rename |paste_and_go_controller| |synchronous_controller| and use it instead of using the main popup controller to do the synchronous query when calling URLsForDefaultMatch(). This makes things both simpler and safer. BUG=none TEST=Using the omnibox still works fine Review URL: http://codereview.chromium.org/178049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25044 0039d316-1c4b-4281-b951-d872f2087c98
* more bookmark tests, plus fix a couple of API bugserikkay@chromium.org2009-09-015-16/+26
| | | | | | | | | BUG=19099,17288 TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Bookmarks Review URL: http://codereview.chromium.org/183020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25036 0039d316-1c4b-4281-b951-d872f2087c98
* Make all of our unit tests be PlatformTests to get an autorelease pool.pinkerton@chromium.org2009-09-0135-37/+71
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/178037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25035 0039d316-1c4b-4281-b951-d872f2087c98
* (Mac) Make mashing the close tab button work.viettrungluu@chromium.org2009-09-015-17/+110
| | | | | | | | | | | | | | | | | | To do this, I had to commit several crimes against humanity. In particular, Cocoa doesn't generate the required extra hit tests during animations, so we have to. Sometimes, it gets really messed up and ends up hitting the "drag blocking view". Moreover, we have to account for the possibility of the mouse down hitting a moving tab, and going up on the close button, etc. BUG=17720 TEST=Mash the close tabs button under a wide variety of situations. \ Also make sure that the handling of the tabs (dragging, etc.) \ hasn't accidentally been messed up. Review URL: http://codereview.chromium.org/174461 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25029 0039d316-1c4b-4281-b951-d872f2087c98
* A few more fixes to chrome://extensions/.aa@chromium.org2009-09-015-85/+127
| | | | | | | | | | | | | | | * Pull PackExtensionJob out into its own file so that it could more easily be reused in the future. * Disable OK button while PackExtnesionJob is running to give a bit of feedback that something is happening. * Fix title-casing. Apparently sentence-casing is Google UX stanard. Review URL: http://codereview.chromium.org/176047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25013 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a DCHECK corner case.yusukes@google.com2009-09-011-2/+1
| | | | | | | | | | | Allow (current + new == max) case. BUG=20673 TEST=none Review URL: http://codereview.chromium.org/176037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25010 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix a typo that breaks tab dragging when another gtk window is minimized.jhawkins@chromium.org2009-09-011-1/+1
| | | | | | | | BUG=20228,20513 TEST=Extensive tab dragging. Review URL: http://codereview.chromium.org/182034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25007 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser tests for extensions tab API.asargent@chromium.org2009-09-014-0/+26
| | | | | | | | | BUG=18442 TEST=none Review URL: http://codereview.chromium.org/174633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25006 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the position of the throbber for pinned tabs. It was wrong before,tony@chromium.org2009-09-011-13/+5
| | | | | | | | | | | | but we repainted the whole pinned tab so it wasn't as obvious. With this change, the throbber is placed where the favicon will go. BUG=20626 Review URL: http://codereview.chromium.org/175038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25005 0039d316-1c4b-4281-b951-d872f2087c98
* Set the info bubble popups as _NET_WM_WINDOW_TYPE_UTILITY so theytony@chromium.org2009-09-011-0/+3
| | | | | | | | | don't show up in the task bar. Review URL: http://codereview.chromium.org/177046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25002 0039d316-1c4b-4281-b951-d872f2087c98
* Update hunspell DEPS to 1.2.8mhm@chromium.org2009-09-012-5/+5
| | | | | | | | | BUG=14756 TEST=Ran valgrind and unit_tests for SpellCheckTest and all passed successfully. Review URL: http://codereview.chromium.org/176046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24998 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup temporary files created by the extension updater unit test.thestig@chromium.org2009-09-011-3/+7
| | | | | | | | BUG=None TEST=Run unit_tests --gtest_filter=ExtensionUpdaterTest.*, make sure there's no extra temporary files after the test finishes. Review URL: http://codereview.chromium.org/173635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24996 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 24982.mirandac@chromium.org2009-09-011-1/+1
| | | | | | Review URL: http://codereview.chromium.org/175041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24987 0039d316-1c4b-4281-b951-d872f2087c98
* This is only for 195; will be reverted immediately.mirandac@chromium.org2009-09-011-1/+1
| | | | | | Review URL: http://codereview.chromium.org/179052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24982 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: about:memoryagl@chromium.org2009-09-0111-276/+503
| | | | | | | | | | | | | (based on http://code.google.com/p/chromium/issues/detail?id=16251) Add about:memory support to Linux. Rather than try and copy the Windows output, we use a couple of metrics which make more sense on Linux: USS and PSS. http://codereview.chromium.org/177024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24979 0039d316-1c4b-4281-b951-d872f2087c98
* RDH: Don't attempt to sniff the mime type of requests thatrvargas@google.com2009-09-012-6/+158
| | | | | | | | | | | don't have a body. BUG=16873 TEST=unittests Review URL: http://codereview.chromium.org/173536 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24977 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Simplify omnibox selection code and stop taking back selection.derat@chromium.org2009-08-312-25/+22
| | | | | | | | | | | | | | | | | | | | | | | | This fixes a long-time bug (mentioned at the end of my description in http://codereview.chromium.org/159185 but reported more recently) where Chrome would steal back the PRIMARY selection the first time that another app takes it. I tested by going through my test cases from the following earlier changes and also confirming that the selection-stealing issue is also fixed: http://codereview.chromium.org/151006 http://codereview.chromium.org/155971 http://codereview.chromium.org/159185 http://codereview.chromium.org/164539 http://codereview.chromium.org/173098 BUG=20460 TESTED=see above Review URL: http://codereview.chromium.org/176029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24971 0039d316-1c4b-4281-b951-d872f2087c98
* Delete first run dialog on Linux when done.kuchhal@chromium.org2009-08-311-0/+1
| | | | | | | | BUG=18429 Review URL: http://codereview.chromium.org/182037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24966 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly including the redirect status with the AutomationURLResponse info.tommi@chromium.org2009-08-312-3/+13
| | | | | | | | | | | Before we were always defaulting to 301. TEST=run automation tests. BUG=none Review URL: http://codereview.chromium.org/178041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24962 0039d316-1c4b-4281-b951-d872f2087c98
* Paint the hover animation state when painting just the favicon.tony@chromium.org2009-08-311-0/+20
| | | | | | | | | BUG=20658 Review URL: http://codereview.chromium.org/173630 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24960 0039d316-1c4b-4281-b951-d872f2087c98
* Change when we enable Apple's Crash reporter.jeremy@chromium.org2009-08-311-1/+1
| | | | | | | | | | | | | | | | | | | | Enable Apple Crash Reporter for Browser process in Non-Debug builds. * Introduce mac_util::IsBackgroundProcess(). * Invert logic around Breakpad Enabling/Disabling to make it clearer. * Honor the kDisableBreakpad switch. Our new policy: * Breakpad is enabled/disabled based on the user stats reporting opt-in flag - this hasn't changed. * Always disable Apple Crash in background processes (plug-in, renderer, etc). * If Breakpad is enabled browser crashes will be passed to Crash Reporter. * If Breakpad is NOT enabled browser [or any other foreground app] crashes will be passed to Crash Reporter in Release builds. Effectively this means that we now enable Crash Reporter for the browser process in Chromium release builds so these will no longer crash silently with no trace. Review URL: http://codereview.chromium.org/180048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24959 0039d316-1c4b-4281-b951-d872f2087c98
* Fix comment grammar. No code change.mdm@chromium.org2009-08-311-3/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/182036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24946 0039d316-1c4b-4281-b951-d872f2087c98
* Update BackingStore to handle the case where our Cocoa view hasamanda@chromium.org2009-08-313-40/+119
| | | | | | | | | | not been inserted into a window yet. BUG=20009 TEST=tabs opened in the background should not be blank when you switch to them. Review URL: http://codereview.chromium.org/175027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24941 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix operation of Control key in Omnibox.shess@chromium.org2009-08-311-5/+3
| | | | | | | | | | | http://crbug.com/20455 TEST=Enter "this" into address bar. Hold Control, should see "www.this.com" as first item. Release, and it should go back to "this" immediately. Review URL: http://codereview.chromium.org/182021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24939 0039d316-1c4b-4281-b951-d872f2087c98
* OSX: Remove some nsnotificationcenter observers more reliably.shess@chromium.org2009-08-312-3/+10
| | | | | | | | | | | | There are some crashers which show up as an objc_msgSend when posting a notification. So I went around reviewing our observers looking for places where it's possible that we weren't unregistering correctly. These may have already been correct, but this change would seem to make unregistration more reliable. Review URL: http://codereview.chromium.org/174480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24938 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix Option-return in Omnibox.shess@chromium.org2009-08-311-0/+12
| | | | | | | | | | | | | Option-return inserted a literal newline, did not want. Also fixed Option-tab to not insert literal tab. http://crbug.com/17914 TEST=Type text, option-tab should not insert literal tab, option-return should not insert newline. Both should do nothing. Review URL: http://codereview.chromium.org/181024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24936 0039d316-1c4b-4281-b951-d872f2087c98
* I was too aggressive when placing this check. With rapid typing and ↵pkasting@chromium.org2009-08-311-1/+1
| | | | | | | | | | | deletion it's perfectly reasonable for the controller to be running a query when the popup is not open. TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/177041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24931 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-09 00:04:09 +0000