summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Reverting 16569.ben@chromium.org2009-05-212-2/+0
| | | | | | Review URL: http://codereview.chromium.org/113689 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16574 0039d316-1c4b-4281-b951-d872f2087c98
* Fix release build by adding intermediate dir to release build include dirs too.ben@chromium.org2009-05-212-0/+2
| | | | | | | TBR=sky Review URL: http://codereview.chromium.org/115620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16569 0039d316-1c4b-4281-b951-d872f2087c98
* views/ should use resources from app/resources. Move dependent images to ↵ben@chromium.org2009-05-2127-13/+33
| | | | | | | | | this location. http://crbug.com/11387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16567 0039d316-1c4b-4281-b951-d872f2087c98
* Don't get stuck in an allocate loop on closing the download shelf.estade@chromium.org2009-05-212-8/+16
| | | | | | Review URL: http://codereview.chromium.org/113674 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16565 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to handle notification observing.pkasting@chromium.org2009-05-214-16/+10
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/115607 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16560 0039d316-1c4b-4281-b951-d872f2087c98
* Use NotificationRegistrar to handle notification observing.pkasting@chromium.org2009-05-216-37/+20
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/115606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16559 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Hook up more of extension uninstall."aa@chromium.org2009-05-2121-791/+514
| | | | | | | | This reverts commit ebb5f616663f9d5ee78584187da16bba4ce96811. Review URL: http://codereview.chromium.org/113680 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16557 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in bookmark editor. We crash when we don't have a selected folder, ↵erg@google.com2009-05-211-5/+11
| | | | | | | | | | but we don't select a folder by default when we're adding a new bookmark. Review URL: http://codereview.chromium.org/115598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16556 0039d316-1c4b-4281-b951-d872f2087c98
* Need to disable two print test temporarily to green the tree.levin@chromium.org2009-05-212-2/+2
| | | | | | | | | | TBR=dimich BUG=12363 TEST=none, just disabling some unit test temporarily. Review URL: http://codereview.chromium.org/115610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16552 0039d316-1c4b-4281-b951-d872f2087c98
* Remove widget_win.h dependency from fullscreen_exit_bubble.h. It is unused inbrettw@chromium.org2009-05-202-1/+1
| | | | | | | the header so I moved it to the .cc. Review URL: http://codereview.chromium.org/115578 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16548 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up more of extension uninstall.aa@chromium.org2009-05-2021-514/+791
| | | | | | | | | | | Also removed all external dependencies from ExtensionsService. It now only sends out notifications, which other services consume. This should allow us to unit test the ExtensionsService frontend, but I haven't added that yet. Review URL: http://codereview.chromium.org/113493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16547 0039d316-1c4b-4281-b951-d872f2087c98
* About box development.jrg@chromium.org2009-05-205-5/+296
| | | | | | | | | | | BUG=http://codereview.chromium.org/112044 Note pieces of chrome.gyp come from a different CL (keystone_glue work associated with this). Review URL: http://codereview.chromium.org/113614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16545 0039d316-1c4b-4281-b951-d872f2087c98
* Development of keystone glue.jrg@chromium.org2009-05-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | BUG=http://codereview.chromium.org/112044 chrome.gyp caught in a different CL but here is the relevant part of the diff: --- chrome.gyp (revision 16158) +++ chrome.gyp (working copy) @@ -2679,6 +2682,11 @@ ], 'sources': [ 'app/breakpad_mac_stubs.mm', + # *NO* files in chrome/app have unit tests (except keystone_glue)!!! + # It seems a waste to have an app_unittests target, so for now + # I add keystone_glue.m explicitly to this target. + 'app/keystone_glue.m', + 'app/keystone_glue_unittest.mm', # All unittests in browser, common, and renderer. 'browser/autocomplete/autocomplete_unittest.cc', 'browser/autocomplete/autocomplete_popup_view_mac_unittest.mm', Review URL: http://codereview.chromium.org/113613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16540 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent setting the checkbox value in menus from activating the menu item.erg@google.com2009-05-201-0/+21
| | | | | | | | http://crbug.com/11942 Review URL: http://codereview.chromium.org/115589 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16539 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Revert "Hook up more of extension uninstall."aa@chromium.org2009-05-2021-791/+514
| | | | | | | | This reverts commit 5b2fc12fbca26b20ed4176ac740c58fe49360c4a. Review URL: http://codereview.chromium.org/113664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16538 0039d316-1c4b-4281-b951-d872f2087c98
* Add HKLM + HKCU lookup for COM history indexercpu@google.com2009-05-201-16/+43
| | | | | | | | | | | | - slight refactor TEST= there are no tests BUG= http://b/issue?id=1860803 Review URL: http://codereview.chromium.org/113605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16534 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: reject empty file filters for file chooser dialogs.estade@chromium.org2009-05-201-3/+10
| | | | | | | | | | Note that this is temporary in that, in the long run, we should be using mime type filters rather than shell-style globs. TEST=right click/save as on a link. There should be no "*." filter. Review URL: http://codereview.chromium.org/113660 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16533 0039d316-1c4b-4281-b951-d872f2087c98
* mac_util::SetOverrideAppBundle() are handled in class ChromeTestSuite.jrg@chromium.org2009-05-201-10/+0
| | | | | | | | | They should not be modified here (and especially should not be undone in TearDown since it breaks things for following unit tests). Review URL: http://codereview.chromium.org/115554 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16530 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up more of extension uninstall.aa@chromium.org2009-05-2021-514/+791
| | | | | | | | | | | Also removed all external dependencies from ExtensionsService. It now only sends out notifications, which other services consume. This should allow us to unit test the ExtensionsService frontend, but I haven't added that yet. Review URL: http://codereview.chromium.org/113493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16529 0039d316-1c4b-4281-b951-d872f2087c98
* Implement process singleton on linux so if the user tries totc@google.com2009-05-202-15/+281
| | | | | | | | | | | | | | open multiple chrome processes, the first one just opens a new window. This is based on http://codereview.chromium.org/88067 by Nikita Ofitserov (himikof). BUG=8073 Review URL: http://codereview.chromium.org/115572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16528 0039d316-1c4b-4281-b951-d872f2087c98
* Convert most of the Find UI tests to InProcBrowser tests. I might be able to ↵finnur@chromium.org2009-05-202-194/+230
| | | | | | | | | | | | | convert the remaining ones, but this is enough for a first pass. I also added a new disabled test, which will soon be enabled. BUG=None TEST=This whole changelist is about tests. :) Review URL: http://codereview.chromium.org/113646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16527 0039d316-1c4b-4281-b951-d872f2087c98
* Enable IDC_CLOSE_WINDOW on linux.estade@chromium.org2009-05-202-5/+1
| | | | | | | | I filed http://crbug.com/12334 to fix the ifdefed-out block in ui_test.cc. Review URL: http://codereview.chromium.org/113655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16526 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add background image theming to bookmark bar.estade@chromium.org2009-05-203-25/+57
| | | | | | | | | | I got rid of the border padding in an attempt to more closely match windows, where the bookmark bar is very compact. BUG=http://crbug.com/12216 Review URL: http://codereview.chromium.org/115551 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16524 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetPixbufNamed to ThemeProvider. GetPixbufNamed converts a loaded theme ↵jhawkins@chromium.org2009-05-205-25/+73
| | | | | | | | bitmap to a GdkPixbuf and caches the image so ThemeProvider users don't need to release them ala ResourceBundle::GetPixbufNamed. Review URL: http://codereview.chromium.org/113626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16520 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in bookmark bar where we had conflicting ids.erg@google.com2009-05-203-11/+42
| | | | | | | | http://crbug.com/12304 Review URL: http://codereview.chromium.org/115581 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16519 0039d316-1c4b-4281-b951-d872f2087c98
* Change RenderWidgetHostViewGtk::Destroy() to call gtk_widget_destroy().willchan@chromium.org2009-05-201-0/+8
| | | | | | | | | BUG=http://www.crbug.com/11847. TEST=Navigate to an interstitial page. Click on Proceed. It should not crash. Review URL: http://codereview.chromium.org/115549 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16518 0039d316-1c4b-4281-b951-d872f2087c98
* Support multi-touch gestures for back&forward.pinkerton@chromium.org2009-05-201-0/+21
| | | | | | Review URL: http://codereview.chromium.org/115579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16505 0039d316-1c4b-4281-b951-d872f2087c98
* Copy first_run.cc to first_run_win.cc for history preservation.evan@chromium.org2009-05-201-0/+667
| | | | | | | | A subsequent change will modify these files. (Retrying previous change.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16504 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r16502.evan@chromium.org2009-05-201-667/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16503 0039d316-1c4b-4281-b951-d872f2087c98
* Copy first_run.cc to first_run_win.cc for history preservation.evan@chromium.org2009-05-201-0/+667
| | | | | | A subsequent change will modify these files. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16502 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary function overload in FontDisplayView.yutak@chromium.org2009-05-201-20/+0
| | | | | | | | | FontDisplayView::SetFontType is overloaded and has two function signatures, but one of them became obsolete (its implementation is not synchronized with the other) and is no longer used. TEST=none Review URL: http://codereview.chromium.org/113610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16501 0039d316-1c4b-4281-b951-d872f2087c98
* Alert dialogs only get one button.avi@chromium.org2009-05-201-4/+6
| | | | | | Review URL: http://codereview.chromium.org/113638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16500 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent an extra copy of data types that get passed into IPC messages whenmpcomplete@google.com2009-05-201-5/+5
| | | | | | | | | | sending them. This makes it so that types sendable via IPC no longer need copy constructors. BUG=12296 Review URL: http://codereview.chromium.org/112042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16497 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't display empty tooltips on folders in the bookmark bar.erg@google.com2009-05-201-1/+3
| | | | | | Review URL: http://codereview.chromium.org/115576 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16496 0039d316-1c4b-4281-b951-d872f2087c98
* Translate the canvas used to render gtk tabs by the tab bounds in order to ↵jhawkins@chromium.org2009-05-202-21/+28
| | | | | | | | | render at (0,0) to match windows metrics. This helps eliminate differences between the two tab rendering implementations. TEST=Open multiple tabs. Make sure the tabs are rendered correctly (close button, elided title text, favicon, sad tab crash animation). Review URL: http://codereview.chromium.org/113623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16495 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disabling throbber to see if startup tests bot goes back to normal.pinkerton@chromium.org2009-05-201-0/+4
| | | | | | Review URL: http://codereview.chromium.org/113648 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16494 0039d316-1c4b-4281-b951-d872f2087c98
* Moves GetFavIcon from BookmarkNode to BookmarkModel. I'm doing thissky@chromium.org2009-05-209-44/+48
| | | | | | | | | | | | | | | | for two reasons: . it cuts down on each node needing a reference to the model. . it makes it clear nodes shouldn't need to talk with the model. I'm primarily doing this for the last point as I'm going to populate nodes on a background thread shortly and I don't want to risk the chance of someone trying to talk with the model. BUG=none TEST=none Review URL: http://codereview.chromium.org/113617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16491 0039d316-1c4b-4281-b951-d872f2087c98
* Use GTM's l10n class to substitute the correctly branded string for "Quit ↵pinkerton@chromium.org2009-05-203-0/+62
| | | | | | | | Chromium" at runtime. Update the string grd files to have this string. BUG=11486. TEST=check the quit menu item in the app menu for the correct branding. Review URL: http://codereview.chromium.org/115574 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16489 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Modify Omnibox to notice when the window loses key, too.shess@chromium.org2009-05-202-2/+34
| | | | | | | | | http://crbug.com/12252 TEST=Type "word" in omnibox. Click on some other window. Popup should dissappear. Review URL: http://codereview.chromium.org/115573 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16488 0039d316-1c4b-4281-b951-d872f2087c98
* Change some NOTIMPLMENTED() to tracking bugs because they are polluting the ↵shess@chromium.org2009-05-202-2/+2
| | | | | | | | ui_tests output. Review URL: http://codereview.chromium.org/113608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16484 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for alternate window station.nsylvain@chromium.org2009-05-202-22/+33
| | | | | | | | | | TEST: Start chrome, make sure it loads pages, then user process explorer to make sure the WindowStation handle name is not the same as the browser process. BUG:10996 Review URL: http://codereview.chromium.org/113190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16483 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Now that dev tools window is opened using Browser::CreateForApp ↵pfeldman@chromium.org2009-05-201-3/+3
| | | | | | | | (that works on Mac & Linux), devtools window closing can hardly be tested by means of InProcessBrowserTest. Disabling for now, looking for the better solution. Review URL: http://codereview.chromium.org/115570 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16482 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Get rid of views in DevTools.pfeldman@chromium.org2009-05-2010-397/+114
| | | | | | Review URL: http://codereview.chromium.org/115562 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16481 0039d316-1c4b-4281-b951-d872f2087c98
* When loading, change the tag on the "go button" to IDC_STOP so it executes ↵pinkerton@chromium.org2009-05-202-1/+14
| | | | | | | | the correct command. Update the unit test to verify. BUG=12260 TEST=click stop button while loading page. Review URL: http://codereview.chromium.org/115540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16478 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash on browser exit after opening TaskManager.phajdan.jr@chromium.org2009-05-205-0/+53
| | | | | | | | | | | | | | | | | | | | | TaskManager is a singleton, so it's destroyed by AtExitManager. At the time of destruction it cannot register AtExit callbacks (AtExitManager requires that). It turns out that some Windows view code wants to register an AtExit callback during destruction. For more info about view code, see http://src.chromium.org/viewvc/chrome?view=rev&revision=9161 The fix is to destroy the view early, using EnsureShutdown static method of TaskManager. It was also necessary to delete child views a bit earlier to avoid another crashed. Added a regression browser_test and verified that it's broken without this fix. http://crbug.com/11180 Review URL: http://codereview.chromium.org/114031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16474 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Enable dev tools ui sanity tests, take 2.pfeldman@chromium.org2009-05-201-4/+4
| | | | | | Review URL: http://codereview.chromium.org/115560 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16470 0039d316-1c4b-4281-b951-d872f2087c98
* tabs.onUpdated now sends 'url' when 'state' has changed to 'loading' when ↵rafaelw@chromium.org2009-05-204-110/+254
| | | | | | | | | | | | | navigating to a new url. If a reload is in progress, 'loading' will not be accompanied by 'url'. Also, refactored some code so that string constants are defined and shared. BUG=11200 R=erikkay Review URL: http://codereview.chromium.org/113552 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16467 0039d316-1c4b-4281-b951-d872f2087c98
* Reuse ChildProcessSecurityHost for worker processes.jam@chromium.org2009-05-202-2/+10
| | | | | | Review URL: http://codereview.chromium.org/115550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16466 0039d316-1c4b-4281-b951-d872f2087c98
* More progress on ForceHTTPS.abarth@chromium.org2009-05-206-5/+57
| | | | | | | | | | | Instead of turning on strict HTTPS error processing for every site, we now track which sites have opted in. Our implementation is still experimental and hidden behing the command line switch --force-https. R=darin TEST=No tests yet because this is just an experiment. Review URL: http://codereview.chromium.org/113503 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16464 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TRACK_HWND_CREATION/TRACK_HWND_DESTRUCTION macro since the bug it was ↵jam@chromium.org2009-05-202-5/+0
| | | | | | | | created for has long been closed. This code causes crashes when the browser is closed with the task manager open (in debug builds at the very least). Review URL: http://codereview.chromium.org/115553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16462 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 22:52:43 +0000