| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
directory.
We now assume that nacl64.exe is in the same directory as chrome.dll (and not as chrome.exe as we assumed before).
BUG=28176
TEST=none
Review URL: http://codereview.chromium.org/668130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/668194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a boolean preference to specify whether to use the Mac user's Address Book "me" card as a source of information for AutoFill addresses. This CL adds the Mac UI and the preference setup only. It does not cover the functionality for fetching the actual Address Book data. The changes to AutoFillDialog.xib add the checkbox UI and bind the checkbox to the |auxiliaryEnabled| property in the controller class. The |addressSection_| outlet is set to the spacer following the new checkbox. Unit tests are included for the addition of the preference at the mac dialog controller level.
BUG=36496
TEST=PersonalDataManagerTest, AutoFillDialogControllerTest
Review URL: http://codereview.chromium.org/668171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This removes an extraneous ALLOW_THIS_IN_INITIALIZER, and also adds to a comment in browser_init.cc the relevant bug.
TBR=aa,tfarina
Review URL: http://codereview.chromium.org/668181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added separate containers for sitcky, non sticky notifications.
I copied most of desktop notification unittest. I'll refactor it and reduce duplicate in next CL.
BUG=33306
TEST=added desktop_notification_unittests for chromeos.
Review URL: http://codereview.chromium.org/661289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32553,30001
TEST=none
Review URL: http://codereview.chromium.org/661223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Populate the tree view with appcaches
* Delete selected appcaches from the tree view
* Delete the date range indicated in the browsing data remover
TEST=manual
BUG=34634
Review URL: http://codereview.chromium.org/660423
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- better UI for why libcros failed to load
- fix enable/disable wifi menu item
- call new ConnectToNetwork method that works with cellular
BUG=1682
TEST=none
Review URL: http://codereview.chromium.org/661392
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=BillingAddressTest
Review URL: http://codereview.chromium.org/669141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
through a GPU channel.
Probably only works in windows only so far.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/657046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor the implementation for x-platform happiness.
Add simple pyauto script that uses it (but needs http://crbug.com32292
fixed before it works without tweaking).
Review URL: http://codereview.chromium.org/670001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
update to the sync model on model association.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661337
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There seems to be a timing issue in renderer deletion and io thread
deletion, and the resource that has to be deleted before io thread are not
deleted by the time io thread is deleted. Since this will soon be changed,
i just chagned this to be created on demand for now.
This also reverts commit dd6c4ab11002a308bf8eede36bb632e95d3a1382.
TBR=sky@chromium.org
BUG=32641
TEST=none
Review URL: http://codereview.chromium.org/669196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=ui tests should pass.
BUG=32048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like I was not reading it correctly, or maybe I just
started seeing what I want to see...
TBR=cira
BUG=37109
TEST=None
Review URL: http://codereview.chromium.org/668178
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/668180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
domain. The default remains at 1.
Command line usage to set it to 13:
chrome.exe --use-spdy --max-spdy-sessions-per-domain=13
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the suppression
BUG=37168
TEST=Run Valgrind
Review URL: http://codereview.chromium.org/661428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
between windows.
BUG=http://crbug.com/37445
TEST=as in bug
Review URL: http://codereview.chromium.org/669185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I have been monitoring the buildbots to see if it has flaked out
in the last two days and it looks like it has not.
TBR=cira
BUG=37109
TEST=This CL is about enabling automated tests.
Review URL: http://codereview.chromium.org/668178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36797
TEST=make sure pinned tabs work on linux.
Review URL: http://codereview.chromium.org/669163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=No visible impact. Status bubble should look exactly the same as before when moving the mouse around.
Review URL: http://codereview.chromium.org/669179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
already to avoid re-enabling sync everytime the machine boots.
BUG=37164
TEST=unit test
Review URL: http://codereview.chromium.org/669099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crash happens while
sending the AutomationMsg_GetCookiesFromHost request for a NULL channel. Fix is to use the
AutomationResourceMessageFilter::Send method which checks for the same and also deletes the message
if the channel is NULL.
The AutomationResourceMessageFilter also implements the OnFilterRemoved notification on the IPC message
filter to clear out the channel just in case.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=37512
Bug=37512
Review URL: http://codereview.chromium.org/668163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37418
TEST=none
Review URL: http://codereview.chromium.org/668122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This creates notifications when ExtensionFunctionDispatcher is created and destroyed. This mirrors the creation of any extension view. extensions_ui now listens to this to update it's list of active views.
BUG=28423
Review URL: http://codereview.chromium.org/669028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
location bar would not bring back the translate infobar.
BUG=36463
TEST=Navigate to a page in a different language so it brings up
the translate infobar, close the infobar. Click on the
location bar and press enter. The page should be reloaded
and the translation infobar should be shown again.
Review URL: http://codereview.chromium.org/661301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementation. This is because we needed a menu (not combobox) with
languages in another part of Chromium (CL 661475).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40605
Review URL: http://codereview.chromium.org/666001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
As part of awakeFromNib a dangerous download would set it's state and trigger a layout grabbing the initial size before the proper localized text was loaded and the view sized. This made the item "stick" at the wrong size. Now setState: doesn't trigger a layout and instead only force a layout when the dangerous state is cleared.
BUG=28446,28705,32775
TEST=see bugs
Review URL: http://codereview.chromium.org/668161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
running
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669019
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/668165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32553,30001
TEST=none
Review URL: http://codereview.chromium.org/661223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/668080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37271
TEST=Go fullscreen. Open a folder on the bookmarkbar and hover over one of its subentries. Overlay should not scroll back up.
Review URL: http://codereview.chromium.org/669086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no change visually
Review URL: http://codereview.chromium.org/668159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/646022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds ContentSettingImageModel to provide icon and tooltips for platform-specific ContentBlockedImageView.
(in preparation for:
http://codereview.chromium.org/650180/show
)
TEST=chrome/browser/content_setting_image_model_unittest.cc
Review URL: http://codereview.chromium.org/660279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
StorageArea::setItem.
TEST=none
BUG=37350
Review URL: http://codereview.chromium.org/669072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the world.
TEST=Start with --no-referrers, neither headers nor document.referrer should ever get set
BUG=none
Review URL: http://codereview.chromium.org/668065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35338
TEST=none
Review URL: http://codereview.chromium.org/660283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
request does not generate a separate row in the history
database.
BUG=34350
Review URL: http://codereview.chromium.org/668051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dialog. It was a trivial fix that set the SetAllowCharacterBreak property to true for the message label. As a result, the hostname url does not truncate and wraps to the next line.
Original patch by Abhishek Arya <aarya@google.com>
BUG=36772
TEST=Try a hostname url longer than 42 chars to see that it wraps correctly and wraps to the next line.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a regression appearing in revision 39455 by adding an additional NULL check.
TEST=Open Chromium, close all open windows, open bookmark manager, double click any bookmark. Chromium shouldn't crash.
BUG=37386
Review URL: http://codereview.chromium.org/669078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37466
TEST=none
Review URL: http://codereview.chromium.org/668126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also changed the way we reload an extension when toggling it for incognito.
Also fixed a small bug this exposed with the browser action container where it
would shrink to 0 size when reloading an extension.
BUG=36292
Review URL: http://codereview.chromium.org/668107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/669044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/669042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=37440
Review URL: http://codereview.chromium.org/669097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was the load state poller may call OnUploadProgress() while a redirect is in progress.
It should be safe to remove the CHECK(), since it was recently added and execution used to pass through previously in this case.
BUG=37035
TBR=wtc
Review URL: http://codereview.chromium.org/669117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40684 0039d316-1c4b-4281-b951-d872f2087c98
|