summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Fix build break.mpcomplete@google.com2009-03-061-1/+2
| | | | | | | TBR=aa Review URL: http://codereview.chromium.org/39283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11169 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Purify UMR and MLK due to ExtensionViewTest:mpcomplete@google.com2009-03-062-1/+5
| | | | | | | | | | | | - UMR was caused by stubbing out GetHistoryListCount, which RenderViewHost expected to initialize its out params. - MLK was (I think) caused by the IPC reply message to the javascript alert never getting freed. BUG=8364 Review URL: http://codereview.chromium.org/39157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11167 0039d316-1c4b-4281-b951-d872f2087c98
* Implement accelerators in the gtk port (try 2).erg@google.com2009-03-069-52/+142
| | | | | | | | | | | - Adds accelerators to all the menu items that had them on windows. - Adds accelerators to back (Alt+left), forward (Alt+right), reload (Ctr+R) and focus the URL box (Ctr+L). Review URL: http://codereview.chromium.org/39278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11166 0039d316-1c4b-4281-b951-d872f2087c98
* Add url to AutomationMsg_DidNavigate amit@chromium.org2009-03-061-1/+2
| | | | | | | | | | Automation clients can now find out the url navigated to instead of just index in the history. Review URL: http://codereview.chromium.org/39205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11159 0039d316-1c4b-4281-b951-d872f2087c98
* RenderWidgetHost now only accepts a new NativeWebKeyboardEvent which owns a ↵erg@google.com2009-03-0616-39/+57
| | | | | | | | | | | | | copy of the native os event. Only the WebKeyboardEvent is sent over the IPC barrier, but the full structure passed to the unhandled key event handler. BUG=4772 Review URL: http://codereview.chromium.org/40065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11152 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a command line flag, --user-scripts-dir=..., to specify a directory to usemark@chromium.org2009-03-061-2/+9
| | | | | | | | | | | | in place of the default user scripts location. This eases development of userscripts since you can simply point the browser at your SCM checkout location instead of needing to try to sync things into your local userscripts directory. Code review URL: http://codereview.chromium.org/37011 Checking in for slightlyoff git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11146 0039d316-1c4b-4281-b951-d872f2087c98
* Fix renderer hang that occurs when a RenderWidget with outstanding ↵jam@chromium.org2009-03-062-0/+10
| | | | | | | | | synchronous XHR requests is closed. Currently we cancel all the pending URLRequestJobs, however at that point it doesn't have a pointer to get to the SyncResourceHandler object. BUG=1575301 Review URL: http://codereview.chromium.org/39246 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11141 0039d316-1c4b-4281-b951-d872f2087c98
* Test to see if we can reduce some crashes by deferring delegate destruction ↵ben@chromium.org2009-03-0624-24/+22
| | | | | | | | until WM_NCDESTROY. This involves adding a specific method to allow delegates to destroy themselves to WindowDelegate, and moving all delete this calls into implementations of that method (to allow delegates to still respond to WM_DESTROY which is legit). Review URL: http://codereview.chromium.org/40192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11132 0039d316-1c4b-4281-b951-d872f2087c98
* - Developer tools frontend is served from chrom-ui://devtools/tools.htmlyurys@google.com2009-03-062-3/+18
| | | | | | | | | - Serve Web Inspector JS files from chrom-ui://devtools/ domain in addition to chrom-ui://inspector/. We cannot simply reuse "inspector" domain for now as we need different tab content types for console debugger and new developer tools front-end. When developer tools support all console debugger and web inspector features we will remove "inspector" domain from the source list. Review URL: http://codereview.chromium.org/40222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11109 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run unload tests that hang the renderer in single-process mode, since ↵jam@chromium.org2009-03-061-0/+16
| | | | | | | | now the browser thread waits for the renderer thread on shutdown. Review URL: http://codereview.chromium.org/39245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11093 0039d316-1c4b-4281-b951-d872f2087c98
* Rename browser_toolbar_view_gtk.{h,cc} to browser_toolbar_gtk.{h,cc}estade@chromium.org2009-03-064-6/+6
| | | | | | Review URL: http://codereview.chromium.org/39237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11092 0039d316-1c4b-4281-b951-d872f2087c98
* Create a dropdown menu for the GTK download shelf.estade@chromium.org2009-03-062-1/+121
| | | | | | Review URL: http://codereview.chromium.org/39236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11074 0039d316-1c4b-4281-b951-d872f2087c98
* Redo my single process cleanup. The problem was that Stop() had to be ↵jam@chromium.org2009-03-062-14/+10
| | | | | | | | called in RendererMainThread's dtor, not Thread's, otherwise the vtable lookup won't use RendererMainThread's CleanUp function. Review URL: http://codereview.chromium.org/40199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11073 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the download shelf context menu in preparation for porting.estade@chromium.org2009-03-065-256/+202
| | | | | | | | | | | * Delete DownloadDestinationContextMenu, which is not used anywhere. * Delete the unused download menu item types from the ContextMenuCommands enum. * Merge BaseContextMenu and DownloadShelfContextMenu, move them from download_util.{h,cc} to download_shelf.{h,cc} * Take the windows-specific code from the new DownloadShelfContextMenu and put it in DownloadShelfContextMenuWin in download_item_view.cc (the only place it's used). DownloadShelfContextMenuWin extends DownloadShelfContextMenu and Menu::Delegate. Review URL: http://codereview.chromium.org/40184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11068 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing two small regressions in the Find box:finnur@chromium.org2009-03-061-3/+11
| | | | | | | | | | | | 1) If the Find textfield is populated when the Find box is shown, the FindPrevious and FindNext buttons should also be enabled. (issue 8369) 2) If you search for something that is not on the page, you get "0 of 0" in red. Press Esc and Ctrl+F and the label is gone but the red background color for the label remains (no bug on file, found during testing). BUG=8369 TEST=Open about:blank in Chrome. Press Ctrl+F, search for 'e' (get 0 of 0), close the Find box, reopen the Find box. Observe 'e' is in box, it is highlighted and no red is visible. Also, FindPrevious and FindNext buttons should be enabled. Review URL: http://codereview.chromium.org/39233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11063 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 11048 because it caused crashes in the ui_tests single process.nsylvain@chromium.org2009-03-052-6/+14
| | | | | | Review URL: http://codereview.chromium.org/39231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11058 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the session_history ui tests because it failsnsylvain@chromium.org2009-03-051-0/+4
| | | | | | | | too often. I filed bug 8444. Review URL: http://codereview.chromium.org/39226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11056 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command-line disable-p13n and use that to disablemunjal@chromium.org2009-03-055-8/+16
| | | | | | | | p13n related features. Review URL: http://codereview.chromium.org/39029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11050 0039d316-1c4b-4281-b951-d872f2087c98
* Instead of destruction RendererMainThread objects via a singelton, which may ↵jam@chromium.org2009-03-052-14/+6
| | | | | | | | make them get destructed after browser shutdown, make them a member variable of BrowserRenderProcessHost. Review URL: http://codereview.chromium.org/39218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11048 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Rewrite IPC's interaction with FileDescriptoragl@chromium.org2009-03-054-10/+8
| | | | | | | | | | | | | | | | | | | The FileDescriptor API is clearly too hard to use. It's the only IPC data type which is non-POD and serialising an invalid file descriptor is fatal to Chrome on POSIX. The use of Maybe is possibly non-obvious to non-functional programmers. This patch merges Maybe and FileDescriptor so that serialising invalid file descriptors is permitted and results in -1 at the other end. (Serialising /closed/ a file descriptor is still fatal.) Also, it adds a pointer in base/file_descriptor.h to instructions for its use with IPC. Although it's generally bad practice to mention IPC in base, in this case I cannot find another suitable location. Review URL: http://codereview.chromium.org/39208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11041 0039d316-1c4b-4281-b951-d872f2087c98
* The new history and download tab caused a regression where opening the NTP ↵jcampan@chromium.org2009-03-058-13/+11
| | | | | | | | | | | | | | | would not focus the location bar. DOM UI now by default focus the page. The NTP one focus the location bar. Also removed some unused fields from the history and download DOM UI. BUG=8356 TEST=Open NTP, focus should be on location bar Review URL: http://codereview.chromium.org/39173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11034 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE.maruel@google.com2009-03-0568-161/+273
| | | | | | | Split the lines >80 cols. (Part 1) Review URL: http://codereview.chromium.org/39206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11032 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the chrome view contents tab contents type. Nobody uses it.brettw@chromium.org2009-03-051-1/+4
| | | | | | Review URL: http://codereview.chromium.org/39212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11030 0039d316-1c4b-4281-b951-d872f2087c98
* Several little style cleanups in GTK download shelf code.estade@chromium.org2009-03-054-8/+23
| | | | | | Review URL: http://codereview.chromium.org/40174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11029 0039d316-1c4b-4281-b951-d872f2087c98
* Try #2 of "make JavaScript alerts reflect the URL of the frame they came from,brettw@chromium.org2009-03-0514-32/+58
| | | | | | | | | | | not the enclosing frame." The diffrence between this one and the previous version of this patch is the addition of test_webview_delegate. BUG=1686837 Review URL: http://codereview.chromium.org/39163 Review URL: http://codereview.chromium.org/40175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11026 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the TAB_CONTENTS_NEW_TAB_UI tab contents type. This was not actually usedbrettw@chromium.org2009-03-056-14/+9
| | | | | | | now, so everytime this appears was dead code. Review URL: http://codereview.chromium.org/39200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11024 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the bug: Scrolling the Spell-checker drop-down box adds the languages ↵sidchat@google.com2009-03-052-2/+44
| | | | | | | | | scrolled. Basically, when a spell check language changes, it is added to the accept languages list so that it is remembered later. However, when the list gets scrolled, it keeps adding all the languages it scrolled. So, I decided to fix this by adding only the latest language selected as the spell check dictionary language in the drop down. Issue=8374 Review URL: http://codereview.chromium.org/40145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11022 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the height of options on the Languages panel.mal@chromium.org2009-03-051-2/+2
| | | | | | | | | | | | | I changed two instances of kUnrelatedControlLargeVerticalSpacing to the shorter kUnrelatedControlVerticalSpacing. Tested on XP (Luna, no theme) and Vista Aero. BUG= 5511 R= ben Review URL: http://codereview.chromium.org/40148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11016 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11002.brettw@chromium.org2009-03-0514-58/+32
| | | | | | Review URL: http://codereview.chromium.org/39203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11008 0039d316-1c4b-4281-b951-d872f2087c98
* Make JavaScript alerts reflect the URL of the frame they came from, not thebrettw@chromium.org2009-03-0514-32/+58
| | | | | | | | | enclosing frame. BUG=1686837 Review URL: http://codereview.chromium.org/39163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11002 0039d316-1c4b-4281-b951-d872f2087c98
* Changes bookmark sorting to sort folders first.sky@google.com2009-03-052-7/+49
| | | | | | | | | BUG=8338 TEST=covered by unit tests Review URL: http://codereview.chromium.org/39175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10993 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 10975 and 10972 because it broke the purify nsylvain@chromium.org2009-03-052-28/+0
| | | | | | | | | | | | | | | | | | | | | | | tests, and it might have caused a unit tests failure. purify error : UMR in URLRequest::response_data_file failing test: URLFetcherHeadersTest.Headers: c:\b\slave\chromium-rel-builder\build\src\chrome\browser\net\url_fetcher_unittest.cc(222): error: Value of: source->response_headers()->GetNormalizedHeader("cache-control", &header) Actual: false Expected: true c:\b\slave\chromium-rel-builder\build\src\chrome\browser\net\url_fetcher_unittest.cc(223): error: Value of: header Actual: "" Expected: "private" c:\b\slave\chromium-rel-builder\build\src\chrome\browser\net\url_fetcher_unittest.cc(181): error: Value of: response_code Actual: 404 Expected: 200 Release only. Review URL: http://codereview.chromium.org/39191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10988 0039d316-1c4b-4281-b951-d872f2087c98
* Get history and download HTML UIs into Mac/Linux builds along with ↵pinkerton@chromium.org2009-03-055-17/+26
| | | | | | | | supporting icon scaffolding. Review URL: http://codereview.chromium.org/39132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10986 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CRLF and trailing white spaces.maruel@chromium.org2009-03-05125-432/+432
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
* Make startup_tests build and run on Linux (except reference tests).phajdan.jr@chromium.org2009-03-053-13/+7
| | | | | | Review URL: http://codereview.chromium.org/27240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10978 0039d316-1c4b-4281-b951-d872f2087c98
* Highlights of changes:hclam@chromium.org2009-03-052-0/+28
| | | | | | | | | | | | | | | | | | | 1. Added entry to ResourceResponseHead so that it contains either a base::PlatformFile (OS_WIN) or base::FileDescriptor (OS_POSIX) for passing the file handle from browser to renderer process. 2. Also added IPC messages for reporting download progress and ACK message for it. ResourceLoaderBridge::Peer::OnDownloadProgress is added so that the peer is notified of the download progress in the renderer process. 3. Load flag to kick start the resource loading for media files. LOAD_MEDIA_RESOURCE is added so that ResourceDispatcherHost knows how to use a different ResourceHandler for handling media resource request. Review URL: http://codereview.chromium.org/27168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10972 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes Issue 7377: Regression: Omnibox trims URL ending with 0x85 (Take 2)hbono@chromium.org2009-03-052-1/+21
| | | | | | | | | This is the same change as "http://codereview.chromium.org/20219/show", which I reverted it because it caused build breaks on sandbox. To investigate this build break, it seems this build break is somehow caused by "base/string_util.cc" that includes the TrimWhiteSpaceUTF8() function. To fix this build break, I moved the TrimWhiteSpaceUTF8() function to "base/string_util_icu.cc". BUG=7377 Review URL: http://codereview.chromium.org/28310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10970 0039d316-1c4b-4281-b951-d872f2087c98
* Put the dropdown menu button on the linux download shelf.estade@chromium.org2009-03-056-49/+146
| | | | | | | | | | Also set the background color. Also extend NineBox a little bit. Review URL: http://codereview.chromium.org/40139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10969 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in chrome.exe caused by the external tab container instance ↵ananta@chromium.org2009-03-052-7/+18
| | | | | | | | | | | | | | getting destroyed without going through the proper window shutdown sequence when the external host crashes. The fix is to ensure that we clean up correctly when the external tab instance goes away. Will add a unit test in a subsequent CB. Bug=1688967 Review URL: http://codereview.chromium.org/39086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10962 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that we display a sad face for a windowed plugin when the plugin ↵ananta@chromium.org2009-03-052-21/+45
| | | | | | | | | | | | | | | process crashes. This was a regression introduced by creating the plugin parent on the browser UI thread, which remains valid when the plugin process crashes. The fix is to track plugin wrapper windows in the PluginProcessHost class and destroy any remaining windows in the destructor. Removed the DestroyWindowTask which destroys the windows on the UI thread. We can achieve the same result by posting WM_CLOSE messages to these windows. This fixes http://code.google.com/p/chromium/issues/detail?id=7673 Bug=7673 Review URL: http://codereview.chromium.org/40120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10960 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a notimplemented with a bug about full screen mode.tc@google.com2009-03-051-2/+4
| | | | | | | Review URL: http://codereview.chromium.org/40142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10956 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a toolbar width TODO.evan@chromium.org2009-03-051-4/+3
| | | | | | Review URL: http://codereview.chromium.org/39168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10954 0039d316-1c4b-4281-b951-d872f2087c98
* Changes spellcheck_unittest to read dictionaries directly from the src tree. ↵shess@chromium.org2009-03-051-12/+20
| | | | | | | | | Removes the build rules to copy test dictionaries to Dictionaries/. Review URL: http://codereview.chromium.org/40082 Patch from rohitrao. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10951 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression where bookmark manager would show black backgroundsky@google.com2009-03-051-3/+6
| | | | | | | | | | | | when not results are found for a search string. Using your halo methods does the trick. BUG=8367 TEST=see bug Review URL: http://codereview.chromium.org/39165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10944 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the browser about URL handler to not derive from WebContents. It isbrettw@chromium.org2009-03-048-353/+343
| | | | | | | | | | | | | | | | | | | | instead integrated in the BrowserURLHandler for special schemes. This solves a number of problems and cleans things up nicely. Most of the functions were not necessary to have in the header file of the browser about handler, so I made them local to the .cc file. I moved everything around, but there was no change to any of the About...() functions. This improves the about:memory page to not include the memory of the new tab page it replaced. The entry for itself also has the proper title. This works by using a meta refresh to the actual page, the the process transition no longer happens at the same time as the about:memory page computation. This also fixes problems with the about:network and about:ipc dialogs opening blank pages and also re-opening the dialog when you close the browser. Review URL: http://codereview.chromium.org/27238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10941 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup of backing_store_win.cccpu@google.com2009-03-042-60/+42
| | | | | | | | | | | | | | | | | | - Fix a small leak (solved by re-selecting the initial bitmap into the dc at dtor time) - Remove one set of GetDC(NULL) + GetDeviceCaps() + ReleaseDC() - Remove some dead code The removal of GetDC(NULL) might speed up Vista drawing a little bit, as is rummored that this operation is expensive when DWM + Aero is enabled. The integer overflow check is no longer possible. I'll file a bug so it is not lost. TEST= existing test suffice Review URL: http://codereview.chromium.org/21516 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10938 0039d316-1c4b-4281-b951-d872f2087c98
* Take two at hooking up title bar on linux.tc@google.com2009-03-042-24/+24
| | | | | | | | | | | | The only change from before is moving a method from a windows #ifdef section to outside it. TBR=evan Review URL: http://codereview.chromium.org/39158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10937 0039d316-1c4b-4281-b951-d872f2087c98
* Add download items to the download shelf in linux.estade@chromium.org2009-03-046-5/+182
| | | | | | Review URL: http://codereview.chromium.org/40136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10935 0039d316-1c4b-4281-b951-d872f2087c98
* Fix transparency for dragged downloads and links by using the halo textbrettw@chromium.org2009-03-042-62/+9
| | | | | | | routines. This also removes CreateDragImageForLink which is never called. Review URL: http://codereview.chromium.org/39082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10934 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r9953 since it caused regressions like: ben@chromium.org2009-03-042-0/+6
| | | | | | | | | http://crbug.com/8287 Eyeballing the code in RootView, this change seems wrong. Review URL: http://codereview.chromium.org/40124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10929 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 09:58:57 +0000