summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Change NineBox to render into a GtkWidget. This offers a minor speedup and ↵jhawkins@chromium.org2009-03-268-142/+104
| | | | | | | | simplification of code because we get rid of the pixbuf middleman. Review URL: http://codereview.chromium.org/42620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12620 0039d316-1c4b-4281-b951-d872f2087c98
* Fix our browser window close path to be more like windows.tc@google.com2009-03-262-8/+38
| | | | | | | | | | | We try to run onbeforeunload handlers (and cause the renderer to hang) and we close all the tabs first which properly destroys the tabcontents and webcontents. Review URL: http://codereview.chromium.org/53083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12616 0039d316-1c4b-4281-b951-d872f2087c98
* More NOTIMPLEMENTEDs into bugs.evan@chromium.org2009-03-263-7/+15
| | | | | | Review URL: http://codereview.chromium.org/42668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12615 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unintialized variable (only affected unit test).evan@chromium.org2009-03-261-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12613 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary fix to avoid crash in typing in Omnibox. The crash happenssky@chromium.org2009-03-262-6/+30
| | | | | | | | | | | | | | | | | | | | | if you have a lower case string that is longer than the mixed case string and we get a match at the end of the string. This crashed because the offset is now past the end of the string. This fix is temporary in that it avoids the crash by not highlighting a match in the string. The right fix will be better parsing so we correctly recognize how the two strings line up, but that'll happen later. BUG=9335 TEST=Create a bookmark with the title on the page http://www.google.com/support/forum/p/Chrome/thread?fid=3b64f0cdd1e29e94000466022c425763&hl=en , then type in i and make sure we don't crash. This is also covered by unit tests now, so don't feel you need to test it. Review URL: http://codereview.chromium.org/42664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12612 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when trying to handle keyboard acceleratorstc@google.com2009-03-261-3/+15
| | | | | | | | | | while the current tab contents is no longer in the view hierarchy (ie., it got switched out). Review URL: http://codereview.chromium.org/45068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12610 0039d316-1c4b-4281-b951-d872f2087c98
* Fix/punt on a bunch of NOTIMPLEMENTEDs.evan@chromium.org2009-03-263-5/+15
| | | | | | Review URL: http://codereview.chromium.org/53065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12604 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily work around a hang in unimplemented drag and drop.evan@chromium.org2009-03-262-0/+14
| | | | | | Review URL: http://codereview.chromium.org/53105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12601 0039d316-1c4b-4281-b951-d872f2087c98
* Make it more obvious when our backing store has failed us.evan@chromium.org2009-03-261-1/+3
| | | | | | Review URL: http://codereview.chromium.org/53104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12600 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in visitdb. As far as I can tell the archive_db_sky@chromium.org2009-03-261-0/+3
| | | | | | | | | | | is NULL, leading to this crash. BUG=8932 TEST=none Review URL: http://codereview.chromium.org/53112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12599 0039d316-1c4b-4281-b951-d872f2087c98
* This CL is a work around for the following 2 issues:xji@chromium.org2009-03-261-0/+22
| | | | | | | | | | | | | | | | | | | issue 7252 --[New Tab] page, the underline of linked text should be under all text http://crbug.com/7252 issue 7697 -- RTL: New Tab page - bad display of page titles with RTL text http://crbug.com/7697 The bug is caused by WebKit not rendering text-overflow:ellipsis correctly for mixed bidi text with rtl directionality. The workaround is to change text-overflow to 'clip' for text with 'rtl' directionality. (The workaround we thought by changing 'text-overflow' to 'clip' in the style, such as in 'html[dir='rtl'] .thumbnail-title', does not work well. 'text-overflow:clip' caused pure English text overlap with the right-aligned favicon in RTL New Tab page). Review URL: http://codereview.chromium.org/42636 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12598 0039d316-1c4b-4281-b951-d872f2087c98
* Fix fast shutdowntc@google.com2009-03-262-2/+1
| | | | | | | | | | The check for unload handlers was backwards. This bug was introduced in r7901 <http://codereview.chromium.org/17453>. Also, remove the call to process_.Close(). When we Terminate the process, we get a IPC channel error and BrowserRenderProcessHost::OnChannelError gets called. This method needs the handle so it can call DidProcessCrash. It also does the call to process_.Close() for us. Review URL: http://codereview.chromium.org/42653 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12597 0039d316-1c4b-4281-b951-d872f2087c98
* Fix buildjrg@chromium.org2009-03-261-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12593 0039d316-1c4b-4281-b951-d872f2087c98
* Expose whether we're in private browsing mode to plugins.I chose to ↵jam@chromium.org2009-03-263-2/+8
| | | | | | | | | implement this for multi-process mode only and not --single-process or --in-process-plugins, since I wanted to send this data from the browser process, not the renderer (in case it's exploited). BUG=158 Review URL: http://codereview.chromium.org/52037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12588 0039d316-1c4b-4281-b951-d872f2087c98
* Minor tweaks to get chrome-ui://extensions working on the Mac.jrg@chromium.org2009-03-262-102/+109
| | | | | | Review URL: http://codereview.chromium.org/42627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12586 0039d316-1c4b-4281-b951-d872f2087c98
* Linux download shelf:estade@chromium.org2009-03-264-7/+35
| | | | | | | | | - Show status text. - Pack new items on the left. Review URL: http://codereview.chromium.org/53084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12582 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up ctrl+tab and ctrl+shift+tab for switching tabs in linuxtc@google.com2009-03-263-15/+46
| | | | | | | | | | | | We can't just add accelerators for these because GDK_Tab and GDK_ISO_Left_Tab are not valid accelerator keys: http://www.google.com/codesearch/p?hl=en#ycarM8Ghiog/gtk+-2.4.0/gtk/gtkaccelgroup.c&q=gtk_accel_groups_activate&l=805 Instead, handle these keys in keypress and forward the event on to BrowserWindowGtk::OnAccelerator directly. We stash a pointer to BrowserWindowGtk on the GtkWindow. Review URL: http://codereview.chromium.org/42611 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12581 0039d316-1c4b-4281-b951-d872f2087c98
* Make the standard tab width wider to better match windows.pinkerton@chromium.org2009-03-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12575 0039d316-1c4b-4281-b951-d872f2087c98
* Enable child RWHVs on the Mac.avi@google.com2009-03-264-8/+94
| | | | | | | | http://crbug.com/8824 Review URL: http://codereview.chromium.org/45040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12573 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where first login attempt to hotmail after session restoresky@chromium.org2009-03-263-103/+24
| | | | | | | | | | | | | | | | | wouldn't work. The problem was we weren't storing post URLs at all (because of bug 1361980). This resulted in session restore trying to restore some redirects along the way that likely had bogus state in them (perhaps referencing cookies that were nuked), resulting in the first login failing. The fix is to persist POST URLs to disk for session restore, but not the actual POST data. This way there shouldn't be any problems as outlined in 1361980. BUG=7727 TEST=see bug Review URL: http://codereview.chromium.org/42619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12568 0039d316-1c4b-4281-b951-d872f2087c98
* WebContentsView became more than just an interface with 48103 (r12483). If ↵avi@google.com2009-03-267-80/+65
| | | | | | | | we move web_contents_ to the base class, we might as well finish the job. Review URL: http://codereview.chromium.org/49041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12555 0039d316-1c4b-4281-b951-d872f2087c98
* Passing a foreground window to the google update code so that if it triggers ↵robertshield@google.com2009-03-263-10/+34
| | | | | | | | UAC prompts, they can launch in the foreground. Review URL: http://codereview.chromium.org/42606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12554 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete TODOs.pinkerton@chromium.org2009-03-261-9/+1
| | | | | | Review URL: http://codereview.chromium.org/49042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12552 0039d316-1c4b-4281-b951-d872f2087c98
* Allow live tabs to be dragged out of a window. Change TabStripModel such thatpinkerton@chromium.org2009-03-2611-47/+129
| | | | | | | the caller must now explicitly show the newly created browser rather than it happening automatically. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12550 0039d316-1c4b-4281-b951-d872f2087c98
* Revert Linux Omnibox color changes in r12516.deanm@chromium.org2009-03-261-3/+3
| | | | | | | | | This just reverts the Omnibox portion of the change. This code is structured to match Windows, and will eventually be pulled from LocationBarView. Review URL: http://codereview.chromium.org/53093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12544 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 8649 -- RTL: Wrong parenthesis direction is displayed on ↵xji@chromium.org2009-03-261-2/+6
| | | | | | | | | | | | | | "About Google Chrome" dialog (http://crbug.com/8649). The fix is to adjust the string according to locale, so that the pure English string in RTL locale is surrounded by left-right-embedding mark for parenthesis to be displayed correctly. Review URL: http://codereview.chromium.org/42096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12540 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the path layout in both bookmark manager and download location. (issue 8997)xji@chromium.org2009-03-261-10/+19
| | | | | | | | | | | | http://crbug.com/8997 Previously, the path itself and every single path component are marked with LTR marks. The fix is only mark the path as a whole (but not every single path component)with LTR marks. Review URL: http://codereview.chromium.org/49034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12539 0039d316-1c4b-4281-b951-d872f2087c98
* Fix purify error for DOM UI unit test.brettw@chromium.org2009-03-261-2/+1
| | | | | | Review URL: http://codereview.chromium.org/42633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12533 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: First pass to make it possible to havervargas@google.com2009-03-252-5/+10
| | | | | | | | | | | | multiple instances of BackendImpl. We need multiple objects to be able to support media files on the cache. After this change, histograms will be the only thing that get messed up by multiple disk caches. Review URL: http://codereview.chromium.org/49027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12520 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding since it was breaking the Release build (because of missing includes).jcampan@chromium.org2009-03-251-0/+12
| | | | | | | | | | | | | | | | | | Moving the mouse-wheel message rerouting code out of the focus manager. This is part of the effort of making the focus manager not window specific. BUG=None TEST=Make sure mouse-wheel scrolls the Chrome window under the cursor (try with a Chrome window, the option window, the task manager table) when it is active and when it is inactive. Also try using the mouse-wheel on a plugin with a scroll-view (for example http://java.sun.com/products/plugin/1.4/demos/plugin/jfc/SwingSet2/SwingSet2.html) when the browser window is not active, the plugin should scroll. TBR=ben Review URL: http://codereview.chromium.org/42624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12517 0039d316-1c4b-4281-b951-d872f2087c98
* Linux UI theming:estade@chromium.org2009-03-252-5/+7
| | | | | | | | | - Improve appearance of menus by setting background to white (matching windows and fitting better with the overall appearance). - Disable user theming of native widgets: since our widgets are a hodge-podge of native and custom-drawn, there's no way we can support user theming. Eventually users will be able to choose a theme for chromium; until then make everything look like chrome. Review URL: http://codereview.chromium.org/49035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12516 0039d316-1c4b-4281-b951-d872f2087c98
* Make the bookmarks bar disappear when the load after the new tab page commitsbrettw@chromium.org2009-03-257-80/+292
| | | | | | | | | | | | | | | | | | | rather than when it is pending. This makes it change at the same time the page changes. To support this, we now have to keep track of both a pending and a committed DOMUI object. This is tracked by the RenderManager, which does a similar swapping between pending and committed RenderViewHosts. Previous review URL: http://codereview.chromium.org/42512 The only difference is I swapped the order of creating the DOM UI in RenderViewHostManager::Navigate. BUG=8963 Review URL: http://codereview.chromium.org/42623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12515 0039d316-1c4b-4281-b951-d872f2087c98
* Use the correct g_free instead of free when freeing memory passed to us from ↵jhawkins@chromium.org2009-03-251-1/+1
| | | | | | | | gtk. Review URL: http://codereview.chromium.org/53072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12510 0039d316-1c4b-4281-b951-d872f2087c98
* Add an exception to DownloadManager::GenerateExtension() for .tar.gz files ↵thestig@chromium.org2009-03-252-1/+21
| | | | | | | | | with mime_type "application/x-tar". BUG=5772 Review URL: http://codereview.chromium.org/42622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12509 0039d316-1c4b-4281-b951-d872f2087c98
* Restore revision 12329, which I accidentally clobbered whenaa@chromium.org2009-03-251-5/+17
| | | | | | | | | | | | I moved this file. See: http://codereview.chromium.org/49011 http://codereview.chromium.org/42435 Review URL: http://codereview.chromium.org/42585 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12508 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark menu work. Notes:jrg@chromium.org2009-03-2514-58/+324
| | | | | | | | | | | | | - "add bookmark" menu item enable state (e.g. disabled if no windows) - bookmark menus built dynamically (like before) - bookmark menus rebuild when a bookmark is added/removed - bookmark menus take the current browser to where you want to go - works with multiple windows (main window goes to bookmark location) - works with no windows (bookmarks open a new window) Review URL: http://codereview.chromium.org/49005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12501 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 12498.jcampan@chromium.org2009-03-251-12/+0
| | | | | | Review URL: http://codereview.chromium.org/53073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12500 0039d316-1c4b-4281-b951-d872f2087c98
* Wire the alternate desktop shortcut textcpu@google.com2009-03-252-5/+6
| | | | | | | | | | | | | - second set of changes, one small one to come - adds a parameter on the desktop shortcut creator function that indicate the text to use - plumbs the master preference and the command line parameter BUG=1522969 Review URL: http://codereview.chromium.org/42586 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12499 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the mouse-wheel message rerouting code out of the focus manager.jcampan@chromium.org2009-03-251-0/+12
| | | | | | | | | | This is part of the effort of making the focus manager not window specific. BUG=None TEST=Make sure mouse-wheel scrolls the Chrome window under the cursor (try with a Chrome window, the option window, the task manager table) when it is active and when it is inactive. Also try using the mouse-wheel on a plugin with a scroll-view (for example http://java.sun.com/products/plugin/1.4/demos/plugin/jfc/SwingSet2/SwingSet2.html) when the browser window is not active, the plugin should scroll. Review URL: http://codereview.chromium.org/53037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12498 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher due to improperly initializing variables.avi@google.com2009-03-251-1/+1
| | | | | | Review URL: http://codereview.chromium.org/45060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12497 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix/punt on a bunch of NOTIMPLEMENTEDs."evan@chromium.org2009-03-253-15/+5
| | | | | | This reverts commit r12489. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12492 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the black line from the bottom of the status bubble.brettw@chromium.org2009-03-251-2/+3
| | | | | | | | | | TEST=Make the Chrome window on top of a white window with a link at the very bottom of the window. Hover over the link so that the status bubble moves outside the chrome window and over the background. The bottom line should be consistent and not have the part under the text be black. Review URL: http://codereview.chromium.org/53068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12491 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 12479 which reverted 12470.willchan@chromium.org2009-03-252-7/+29
| | | | | | | This change is the same as 12470, except with HttpRequestInfo::priority initialized in the initializer list, which should fix the purify errors. Review URL: http://codereview.chromium.org/53066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12490 0039d316-1c4b-4281-b951-d872f2087c98
* Fix/punt on a bunch of NOTIMPLEMENTEDs.evan@chromium.org2009-03-253-5/+15
| | | | | | Review URL: http://codereview.chromium.org/53065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12489 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome changes to support cached form submissions.darin@chromium.org2009-03-251-13/+13
| | | | | | | | | | | | | | | | | | | | | | The solution is to add a user-defined identifier to UploadData. If that identifier is set, and if the request method is POST, then HttpCache will enable caching for the response. (The cache key will be a composition of the identifier and the URL.) A subsequent POST request to the same URL with the same identifier will "hit" the previously generated cache entry. Reuse from the cache is subject to all of the standard rules. For reference, here are the corresponding net changes: http://codereview.chromium.org/52028 Here are the corresponding WebKit changes: http://trac.webkit.org/changeset/41919 BUG=2636 R=sky Review URL: http://codereview.chromium.org/52040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12485 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor some widget creation code in web_contents_view and ↵estade@chromium.org2009-03-2516-145/+86
| | | | | | | | | | render_widget_host_view. This only affects popups. The advantages of this refactoring are to get rid of a TODO and allow some unforking of web_contents_view_*. Review URL: http://codereview.chromium.org/48103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12483 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: write images to clipboard.estade@chromium.org2009-03-251-5/+5
| | | | | | | | Writing a bitmap to the clipboard is a rather slow operation, as it involves piping it over IPC and then converting it to a PNG. Review URL: http://codereview.chromium.org/42592 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12482 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 12470.willchan@chromium.org2009-03-252-29/+7
| | | | | | | caused purify errors Review URL: http://codereview.chromium.org/45055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12479 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 12469.brettw@chromium.org2009-03-256-286/+80
| | | | | | Review URL: http://codereview.chromium.org/53062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12476 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in chrome/browserphajdan.jr@chromium.org2009-03-2510-56/+55
| | | | | | | | | | - make more things const - remove unreferenced declaration of GetGoButton - fix indentation in one place Review URL: http://codereview.chromium.org/53053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12475 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-29 03:57:34 +0000