| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
TBR=tsepez
Review URL: http://codereview.chromium.org/6721021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chromeos/webui/login/browser.
Patch from Ryan Harrison <rharrison@chromium.org>
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/6726022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removes useless dependencies on themeing from content/
- Renames BrowserThemeProvider to ThemeService, along with name variants such
as GtkThemeService. BrowserThemeProvider has grown by a lot to be more than
an implementation of the ui::ThemeProvider interface. This change touches
everything.
- Rename theme_service.{h,cc} (which defined ThemeServiceFactory) to
theme_service_factory.{h,cc}.
BUG=77155
TEST=compiles.
Review URL: http://codereview.chromium.org/6727005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72519
TEST=Create a page A that has a <link rel=prefetch> hint for another page B. In page B, add a <link rel=prefetch> hint for page A. Visit A and observe the prefetch for A only starts on navigation to B.
Review URL: http://codereview.chromium.org/6625066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=ClientSideDetectionHostTest
Review URL: http://codereview.chromium.org/6705007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59767
TEST=Set the policy, and users can't change the Translate preference anymore.
Review URL: http://codereview.chromium.org/6722024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=vangelis@chromium.org
R=arv@chromium.org
Review URL: http://codereview.chromium.org/6723019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Avoids the need to be on the checkperms whitelist
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6705025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chromeos.
BUG=77168
TEST=none
TBR=jcivelli@chromium.org
R=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/6726025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser and there are only non-normal browsers open.
BUG=40293
TEST=see bug, also covered by unit test
R=ben@chromium.org,jcivelli@chromium.org
Review URL: http://codereview.chromium.org/6722008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: this was a TODO for viettrungluu).
BUG=23581
TEST=None
R=avi@chromium.org
Review URL: http://codereview.chromium.org/6723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=zelidrag@chromium.org
Review URL: http://codereview.chromium.org/6724023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6538064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents
Moves the tab's instance of AutofillManager from TabContents to TabContentsWrapper as a helper class.
BUG=77087
TEST=FormStructureBrowserTest.*:TranslateManagerTest.*
Review URL: http://codereview.chromium.org/6722018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents.
BUG=77091
TEST=none
R=jam@chromium.org
Review URL: http://codereview.chromium.org/6724014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The DesktopNotificationService gets empty GURLs in case of file scheme urls. This CL deals with the that to fix breaking regression tests. The root cause of the problem remains to be fixed.
BUG=76693
TEST=desktop_notification_service_unittest.cc
Review URL: http://codereview.chromium.org/6719021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it simpler for developers to deal with the release/set event pair generated by setting a cookie that already exists, and gives them more information about general cookie removal (e.g. that the cookie wasn't "removed" actively but expired).
BUG=70101
TEST=net_unittests
Review URL: http://codereview.chromium.org/6698023
Patch from Mike West <mkwst@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12007
TEST=Manual. Open chrome:sim-unlock.
Review URL: http://codereview.chromium.org/6708087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change just adds 'if (cr.isChromeOS)' to the JS code that depends on the 'language-options-ui-restart-button' button to prevent raising JS exceptions on Windows. (It seems r76621 <http://crrev.com/76621> removed the button on Windows without changing the JS code that depends on it.)
R=csilv@chromium.org,stuartmorgan@chromium.org,arv@chromium.org,jhawkins@chromium.org,estade@chromium.org
BUG=none
TEST=Verify that we can change the language without JS exceptions.
Review URL: http://codereview.chromium.org/6715023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add the ability to have different experiments based on brand code.
BUG=76594
TEST=For the en-US locale, take an old build and a build that includes this fix. Install the old build, set the brand code in the registry to SKPN and set the clock forward by more than a month. Install the new build and make sure you get a toast that references Skype. Change the brand code to anything else, ABCD for example, and make sure you get the generic toast (there are four possible). Then try with locale 'ja' and make sure you get a Japanese toast. Please test this also with system-install of Chrome (enough to just do Skype brand code, I guess).
Review URL: http://codereview.chromium.org/6712015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ran try
Review URL: http://codereview.chromium.org/6708080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=jam@, saintlou@
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reduce the chance that a long stream of expensive 3D commands will cause the watchdog to go off by checking the watchdog after every 3D command.
BUG=76603
TEST=none
Review URL: http://codereview.chromium.org/6715006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a URL that resulted in failing the provisional load. This typically
indicates the user initiated a download. Since instant blocks
downloads, we need to reload on enter.
BUG=74556
TEST=see bug, covered by browser test too.
R=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/6676091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=60101
TEST=check_perms is green
TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/6705018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(note this is a resubmit of Issue 6718004)
BUG=76919, 76976
TEST=none
Review URL: http://codereview.chromium.org/6716024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
move drag related messages to their own file.
TBR=tsepez
Review URL: http://codereview.chromium.org/6705012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
|buffer_| when DownloadFileManager takes ownership.
CID=13944
BUG=none
TEST=none
R=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/6722001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also added support for filtering based on resource type, tabId, and windowId.
BUG=60101
TEST=covered by apitests
Review URL: http://codereview.chromium.org/6685010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=15760
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6719003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to start cleanning up the ExtensionInstallUI class.
BUG=66730
TEST=None
R=aa@chromium.org
Review URL: http://codereview.chromium.org/6680020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of the process to remove refcounting from URLRequestJob.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6717012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bug that the comment's refer was marked as Won't Fix. So doesn't make sense
keeping this TODO around.
BUG=None
TEST=None
R=mirandac@chromium.org
Review URL: http://codereview.chromium.org/6722007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=15844
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6715031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
STLDeleteValues helper function.
CID=15401
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6716029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also rename it to ModelTypePayloadMap.
BUG=None
TEST=
Review URL: http://codereview.chromium.org/6718024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In software rendering list logic, ChromeOS is identified as Linux. Therefore, all the GPU drivers that are blacklisted in Linux are blacklisted in ChromeOS. This change identifies ChromeOS specifically and bypasses the software rendering list logic.
BUG=chromium-os:13342
TEST=GPU acceleration restored in Chromium OS with Intel GPU.
Review URL: http://codereview.chromium.org/6715030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change merges devtools_resources.pak into resources.pak and
puts the code to load files from disk behind a command line switch.
If --debug-devtools is passed on the command line, we enable the code
to load from disk (so the developer can make changes to the .js
files without having to recompile or restart the browser).
I also tried to make sure we no longer include the resources directory
in release packages, but I probably missed something.
This time, make sure to include the devtools_resources.pak in
Chromium.app on OSX.
BUG=35793
TBR=pfeldman
Review URL: http://codereview.chromium.org/6708093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
have a custom constructor anymore. While I was at it, I explicity put values for the other parameters.
TBR=tsepez
Review URL: http://codereview.chromium.org/6723005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=14285
BUG=none
TEST=none
R=akalin@chromium.org
Review URL: http://codereview.chromium.org/6717023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tsepez
Review URL: http://codereview.chromium.org/6726004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=68350
TEST=TabContentsTest.CrossSiteNavigationBackPreempted
TEST=NavigationControllerTest.RestoreNavigate
Review URL: http://codereview.chromium.org/6709056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6713068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved ServerInformation into its own header and added ServerList typedef.
Added notifier_options_util.{h,cc}.
BUG=None
Review URL: http://codereview.chromium.org/6708076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=63646
TEST=See bug description for repro steps.
Review URL: http://codereview.chromium.org/6708053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Start a session with prerender enabled and check the histograms to see the count increasing with every successful prerender.
Review URL: http://codereview.chromium.org/6697037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6675016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the final CL for a sequence of CLs that will add in the display infrastructure that I have built for the DOM Login and touch keyboard. I have created a reference CL for what the end product of this sequence is intended to be, so that I can give context for the CL under review. This can be found at: http://codereview.chromium.org/6577003/
This CL adds in DOMBrowserView, DOMBrowserFrame, and related classes to touchui==1 and chromeos==1 builds. DOMBrowserView classes inherit from the equivalent chromeos::BrowserView classes. DOMBrowserFrame classes inherit from TouchBrowserFrame classes, since it has the keyboards implemented in it. In addition to the direct parent I have had to make changes to other classes in the hiearchy as needed to ease implementation. Additional checks and refatoring have been done to get the build to work and minize the size of this CL. I have actively chosen to not refactor chromeos::BrowserViewLoayout out of the file it current resides in since DOMBrowserViewLayout wouldn't inherit much from it if I subclassed it.
Patch from Ryan Harrison <rharrison@chromium.org>
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/6692001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
occurs in the external
tab container while running unload handlers on the page, specifically when attempting to
send a reply back to IE because the reply message is NULL. It is not clear how the reply message
is NULL.
Added a NULL check at the corresponding location with a NOTREACHED to help catch this in debug
builds. Also set the reply message member variable before invoking the browser function to
run the unload handlers as a crash could occur if the before unload handler notifications arrive
in this context. Does not seem to be the case here though.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=76998
BUG=76998
R=amit
Review URL: http://codereview.chromium.org/6708077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79017 0039d316-1c4b-4281-b951-d872f2087c98
|