| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
aren't prompted twice in the case when they have extensions disabled.
Theme installation confirmation will be done through an infobar (allowing you to preview a lot of themes quickly without dealing with dialogs) - see CL 119235.
BUG=none
TEST=Install a theme, verify that you don't get prompted. Install an extension and verify that you do get prompted.
Review URL: http://codereview.chromium.org/119232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Factor out shared code into bookmark_utils_gtk.*.
Fix a leak with toolbar button dragging.
BUG=13110
TEST=Added extra DCHECKs. Also, you can drag between the right half of the bookmark manager and the bookmark bar with no crashes.
Review URL: http://codereview.chromium.org/119220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the bottom, allow the custom url list to expand.
BUG=11507
Review URL: http://codereview.chromium.org/118203
Patch from Matt Mueller <mattm@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change the bookmarks API to be async functions, so that they can delay their
response until the bookmark system is loaded.
BUG=12353
TEST=none
Review URL: http://codereview.chromium.org/114079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed DCHECK.
BUG=13246
TEST=In chrome debug build, do not select anything to import and click "Import".
Review URL: http://codereview.chromium.org/119104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extension.
BUG=12960
TEST=none
Review URL: http://codereview.chromium.org/118198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/13107
TEST=Start typing in omnibox. Click in the popup and drag mouse off before releasing. Shouldn't crash.
Review URL: http://codereview.chromium.org/112097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13151
TEST=custom home pages table. adding to it, removing. use current. enabling and disabling when applicable.
Review URL: http://codereview.chromium.org/119242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Window reopening.
BUG=12956
Review URL: http://codereview.chromium.org/119178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
benchmarking from within Chrome. Because the JS resides
in the renderer and the HTTP logic resides in the browser,
this required creation of two new, control messages which
can be sent from the renderer to the browser.
These are controlled under a new commandline option
"--enable-benchmarking"
BUG=6754
TEST=none
Review URL: http://codereview.chromium.org/119191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
IPC channel (doh!).
BUG=119052
TEST=covered by ui test that Amit added
Review URL: http://codereview.chromium.org/119158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11678
TEST=Make a theme with bad references to images and try to install it. Or just verify that the InstallTheme unit_test passes.
Review URL: http://codereview.chromium.org/119137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
between the IPC layer and the audio hardware interface.
We have completely moved away from being blocking in
AudioRendererHost.
Since we'll be using PushSource for a longer period
of buffering. It's necessary to have
Play/Pause functionality in the AudioOutputStream,
this is simulated by start/stop the AudioOutputStream
multiple times.
Review URL: http://codereview.chromium.org/114069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR
Review URL: http://codereview.chromium.org/119225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some dicitoaries provided by an SDCH server may be larger than
allowed by Chromium (which holds the dictionary memory-resident).
This CL prevents Chromium from endlessly re-trying such dicitonary loads,
BUG=7722
r=huanr
Review URL: http://codereview.chromium.org/119198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This relands http://src.chromium.org/viewvc/chrome?view=rev&revision=17605
which was reverted in 17638.
It also disables MassiveConcurrentLookupTest, which was a stress test,
and is partially obsolete since the class now responds to congestion
produced by NOT resolving all names.
BUG=13356
TBR=willchan
Review URL: http://codereview.chromium.org/119196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mouse is over it.
On windows, when the render view regains focus it receives a mouse move event with the coordinates of the pointer. We don't on linux, so we have to fake this. Without this, webkit doesn't know where the pointer is, so can have a wrong cursor or other graphical glitches.
TEST=bug is fixed
BUG=12879
Review URL: http://codereview.chromium.org/113987
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
re-open. Evmar, willchan, and I are still investigating.
TEST=none
BUG=13388
Review URL: http://codereview.chromium.org/119219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure that the browser window is informed of the download
shelf visibility status at the end of the show / hide animation.
BUG=13369
Review URL: http://codereview.chromium.org/118278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
They're ASCII anyway.
TEST=covered by existing tests
Review URL: http://codereview.chromium.org/119131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make Task Manager Table view a scoped_ptr so it and its columns are deleted regardless of whether or not the HWND has been constructed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
automation.lib, common.lib, debugger.lib, plugin.lib, renderer.lib.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents::GetSSLEVText methods.
This is discovered by Fumitoshi Ukai.
R=jcampan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Change by Chase Phillips <cmp@google.com>
http://crbug.com/9576
TEST=open a standalone GMail shortcut window, attempt to drop a tab from an existing browser window into it. It should not be added.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13342
Review URL: http://codereview.chromium.org/119207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
test for the new behavior.
TEST=covered by unittest
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
visibly differ from the model's text.
In most cases, this doesn't come up, because focus is usually not in
the field (so there wouldn't be local changes), but when opening NTP
you can type between when the tab opens in the browser and when the
renderer finishes loading it. In that case, the model and toolbar
both have "" as the url text, so this case is hit.
http://crbug.com/13109
TEST=Browse to www.google.com. Command-t for new tab and type http as fast as you can. Before this fix, you sometimes got "tp" or something of the sort.
Review URL: http://codereview.chromium.org/119125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with multiple chrome windows).
BUG=none
TEST=drag a bookmark icon from one a bookmark bar to a bar in another window without crashing.
Review URL: http://codereview.chromium.org/119114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window decorations.
This is mostly just an experiment. The window currently looks bad
because of no rounded corners. It's also not possible to resize in
this state and if you have too many tabs, you can't move.
Review URL: http://codereview.chromium.org/114075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
numbers.
BUG=12761
TEST=Verify that the inactive tab background lines up with the frame image in maximized and unmaximized mode - you will need a heavily patterned theme to test with.
Review URL: http://codereview.chromium.org/118221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=13075
TBR=ben
TEST=On XP, verify that Chrome doesn't crash when a theme is installed or reset.
Review URL: http://codereview.chromium.org/118252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
builders? Fix 2.
TBR=beng
Review URL: http://codereview.chromium.org/112094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
want it.
TBR=beng
Review URL: http://codereview.chromium.org/119194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BlockedPopupContainer into something that can be cross-platform.
- BlokedPopupContainers are no longer ConstrainedWindows.
- There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement.
This version has minor windows compile fixes that changed from under me.
Original Review URL: http://codereview.chromium.org/119006
TBR=beng
TEST=Popup notification still works.
Review URL: http://codereview.chromium.org/119107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
RenderViewHosts created via window.open don't have their enabled_bindings_
set.
Review URL: http://codereview.chromium.org/119134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Set a consistent padding between toolbar buttons by grouping controls
that have different paddings into hboxes. E.g., back/forward are in a
grouped hbox and the menu buttons are in an hbox.
2) Hook the home button up to the user pref.
3) Change how we show the various widgets so home button only shows up
when the pref is enabled.
Review URL: http://codereview.chromium.org/118195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Allows the window to be resized smaller than its current size by setting a minimum size before initiating the drag.
Fixes a crash in TabContentsViewGtk due to a NULL delegate deref.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are resolved asap"
This reverts git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17605 0039d316-1c4b-4281-b951-d872f2087c98
TBR=jar
Review URL: http://codereview.chromium.org/118239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
looks more like Glen's mock.
BUG= http://crbug.com/9233
TEST= Run Chrome with --first-run option. Notice that first run info bubble does not go away within the first second even if you click on or away from the browser.
Review URL: http://codereview.chromium.org/118143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Note: I was never able to directly reproduce the 13082 bug, the error mode is clear (there was no selected tab during a call to tabs.getSelected()). This fix will address that issue and we should stop seeing this crash reports.
R=erikkay
BUG=13082
Review URL: http://codereview.chromium.org/119117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12687
Review URL: http://codereview.chromium.org/119168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crazy.
For example, pressing ctrl while you have an inline autocomplete toggles the autocomplete
on and off, etc.
commit 51b37c5ce628836b22f68aa94ad871ce8cb1f66b
Author: estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon Jun 1 21:38:11 2009 +0000
GTK: respect control key for setting TLD=com.
BUG=13096
Review URL: http://codereview.chromium.org/118086
git-svn-id: svn://chrome-svn/chrome/trunk/src@17356 0039d316-1c4b-4281-b951-d872f2087c98
Review URL: http://codereview.chromium.org/119169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
interacts. Will re-enable tomorrow.
TBR=jcampan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sizing border.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also implement DNS congestion avoidance in the pre-fetch system.
BUG=13276
r=mbelshe
Review URL: http://codereview.chromium.org/118149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change pulls in the new googleurl, which contains the ability to parse
partial IPv6 literals.
Add a test for chromium's SegmentURL, to verify that it's working.
BUG=none
TEST=Ran "unit_tests" in Debug and Release mode.
Patch by pmarks@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17598 0039d316-1c4b-4281-b951-d872f2087c98
|