| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1764001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WifiConfigView - support networks with 802.1x authentication by prompting the user to enter an ID, select a certificate/private key file, and enter a password for the key file, if any.
Pass these values down the stack into ConnectToWifiNetwork().
TEST=Compiles and login dialog shows new fields when security is 802.1x.
BUG=none
TBR=njw
Review URL: http://codereview.chromium.org/1692005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
action icon.
BUG= 41374
TEST= install a page action extension. "installed bubble" points at the icon that was installed. it should work for multiple icons.
Review URL: http://codereview.chromium.org/1762001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
nib changes: Added two static strings, button.
BUG=http://crbug.com/22009
TEST=as in bug
Review URL: http://codereview.chromium.org/1759001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
read-only mode. Also improve data collection a little. See bug for details.
BUG=42151
TEST=none
Review URL: http://codereview.chromium.org/1691002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41743
TEST=See bug
Review URL: http://codereview.chromium.org/1758001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1707005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We need to change the window groupings before we make the new dialog.
BUG=37426
TEST=none
Review URL: http://codereview.chromium.org/1732002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
On dark gtk themes with light text, the cursor is often white, so in chrome-theme mode we had a white cursor on white background.
BUG=40094
TEST=none
Review URL: http://codereview.chromium.org/1723001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
tbr:njw
TEST=Compiles and login dialog shows new fields when security is 802.1x
BUG=none
Review URL: http://codereview.chromium.org/1712003
TBR=chocobo@chromium.org
Review URL: http://codereview.chromium.org/1743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=chocobo@chromium.org
Review URL: http://codereview.chromium.org/1697005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a chromeos OptionsWindowView that hosts options pages in a ChromeWindow
so that it has a frame; This piece of code is based on Chrome's
OptionsWindowView. Ideally, we should use Chrome's options view but
we still missing underlying controls such as Tree and Table.
- Use last active browser window as options dialog's parent;
This makes optiosn dialog transient for the browser window and window
manager will no longer treat it as top-level window and will not move
and resize it;
- If user switches to a new browser window and invokes options dialog again,
close the existing one and re-opens it for the current browser window.
This is currently supported by window manager;
- Update CustomerFrameView and WindowDelegate to make client edge optionaly;
Options dialog has no client area padding and does not have a client
edge per UI mock;
- Make NativeViewHost respects its background. This solves the problem that
tab pane background is not properly cleared when hosting a native GtkVBox
pane in TabbedPane;
BUG=<http://crosbug.com/1885>
TEST=Verify ChromeOS settings dialog looks like the mocks in http://www.chromium.org/chromium-os/user-experience/settings
Review URL: http://codereview.chromium.org/1672003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
tbr:njw
TEST=Compiles and login dialog shows new fields when security is 802.1x
BUG=none
Review URL: http://codereview.chromium.org/1712003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=bauerb
Review URL: http://codereview.chromium.org/1716002
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/1735002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use this in sync_backend_host.cc to avoid dispatching to a data type
controller except when we're on the DTC's home thread.
BUG=41824
TEST=during manual testing of 2-client sync; this code is never active
during add/deletes and associates/disassociates.
Review URL: http://codereview.chromium.org/1741001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
into |PrefStore|.
In order to implement platformspecific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests.
Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|.
BUG=40259
TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.*
Review URL: http://codereview.chromium.org/1687001
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/1688004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Retry of http://codereview.chromium.org/1731001
Try servers not helpful since this includes a binary file.
Unfortunately I did a --gtest_filter=BookmarkBar\* to self-test
which did not include BookmarkButton* tests :-(
Only change is "size" to "cellSize" on 2nd to last line of TEST_F(BookmarkButtonCellTest, FolderArrow)
)
UI review follow-up for m5 bookmark bar deliverables
Remove border of the (empty) bookmark item.
Add arrow icons for folders in bookmark bar folder windows (but not on the bar)
Scroll wheel events now scroll the bookmark bar folder windows (mostly
works; has a little leak-thru)
BUG=42026
TEST=see description
xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView
Review URL: http://codereview.chromium.org/1709004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=make sure file uploading to Flickr still works.
Review URL: http://codereview.chromium.org/1718005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pointed to by the filebrowser.
BUG=chromium-os:2547
TEST=NONE
Review URL: http://codereview.chromium.org/1690001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes makes histograms dynamically defined by external metrics
clients,
instead of hardcoding them in Chrome source. This is important because
making even simple changes to Chrome is laborious and takes a fair
amount of
learning. Unfortunately user actions still require code in Chrome,
because
of a pre-processing script that extracts them from the source.
BUG=NONE
TEST=the included unit test
Review URL: http://codereview.chromium.org/1718003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compiles
(Patch from Thiago Farina <thiago.farina@gmail.com> http://codereview.chromium.org/1664003/show)
Review URL: http://codereview.chromium.org/1750002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DEPENDS_ON=1648004 (http://codereview.chromium.org/1648004/show)
DEPENDS_ON=1596023 (http://codereview.chromium.org/1596023/show)
DEPENDS_ON=1568033 (http://codereview.chromium.org/1568033/show)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1551029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=bauerb
Review URL: http://codereview.chromium.org/1716002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests.
Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|.
BUG=40259
TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.*
Review URL: http://codereview.chromium.org/1687001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
download.
To test this, the CL adds an automation message AutomationMsg_NavigateAsyncWithDisposition, and a method NavigateToURLAsyncWithDisposition to TabProxy.
The only functional change is in TabContents::OnStartDownload, the rest of the changes is for testing.
BUG=10764
TEST=DownloadTest.CloseNewTab
Manual test: go to http://build.chromium.org/buildbot/continuous/mac/LATEST/, open the link "chrome-mac.zip" in a new tab. The tab should close as soon as the download starts.
Review URL: http://codereview.chromium.org/1151007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove Shift+space following alcor's offline suggestion. He said we should not use the key combination since it will be used if the user holds down shift while TYPING A STRING.
- Add Shift+Alt. The combination seems to be popular at least in Windows:
http://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts (see the "Toggle between installed keyboard languages" part.)
Let's ship R7 with "Alt+`" and "Shift+Alt" and then get feedback from users.
BUG=crosbug.com/492
TEST=manual
Review URL: http://codereview.chromium.org/1568041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/2639
TEST=ran browser_tests
Review URL: http://codereview.chromium.org/1645012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove border of the (empty) bookmark item.
Add arrow icons for folders in bookmark bar folder windows (but not on the bar)
Scroll wheel events now scroll the bookmark bar folder windows (mostly
works; has a little leakthru)
BUG=42026
TEST=see description
xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView
Review URL: http://codereview.chromium.org/1731001
TBR=jrg@chromium.org
Review URL: http://codereview.chromium.org/1727004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove border of the (empty) bookmark item.
Add arrow icons for folders in bookmark bar folder windows (but not on the bar)
Scroll wheel events now scroll the bookmark bar folder windows (mostly
works; has a little leak-thru)
BUG=42026
TEST=see description
xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView
Review URL: http://codereview.chromium.org/1731001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now whenever you drag bookmarks into the bookmark manager, the extension
code tells it there is new dragData via bookmarkManager.onDragEnter. This data
sticks around and is never cleared for various reasons, and when you drop random
text onto "Other bookmarks" the JS thinks it has valid drag data, but the data
in the actual dragging clipboard is invalid. This just checks for that and
bails early.
The reason onDragEnded is never called is because we call preventDefault during
onDragStart. Fixing this won't be sufficient because the JS dragdata will still
be populated if you drag in from an external app.
BUG=41087
TEST=See bug for repro steps.
Review URL: http://codereview.chromium.org/1717003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40062
TEST=FaxFieldTest
Review URL: http://codereview.chromium.org/1706005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/2717
Review URL: http://codereview.chromium.org/1551040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove dead code that papered over the fact certain columns don't sort, replace with NOTREACHED pothole
- allow sorting by the javascript memory column.
- allow sorting by goats teleported (useful for debugging)
- stabilize \# of goats teleported (remove observer effect)
BUG=42037
TEST=sort by these columns in the task manager
Review URL: http://codereview.chromium.org/1706002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also add some space between apps.
Review URL: http://codereview.chromium.org/1744001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
search engine experimental dialog.
BUG= 37564
TEST= none
Review URL: http://codereview.chromium.org/1709003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42093
TEST=Open a Core Animation plugin in one tab, and the NTP (with floating bookmark bar) in another. Change back and forth. The plugin should not animate to the correct location.
Review URL: http://codereview.chromium.org/1729002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Landing http://codereview.chromium.org/1701002/show for sosa@chromium.org
Moves the emission of the event indicating that login has succeded to a time before we've mounted teh user's encrypted home directory, and also touches a file on disk to indicate that this has occurred.
Review URL: http://codereview.chromium.org/1713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2555
TEST=none
Review URL: http://codereview.chromium.org/1662004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The extension_context_menu_controller was removing the pref observer in its
dealloc method, but since incognito windows have their profile destroyed when
the window is closed this would crash the browser when we try to access it. Now
it is accessed during the browser_closed notification
BUG=41025
TEST=See bug
Review URL: http://codereview.chromium.org/1619030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
sync-specific) and can be used by other services needing XMPP notifications. This is in preparatoion of moving these set of classes to common.
BUG=None
TEST=Test Bookmarks sync. The sync unit-tests have been modified accordingly.
Review URL: http://codereview.chromium.org/1650009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When no task is selected, the end process button shouldn't be enabled. When
an entry is removed, we should check to see if we removed the currently
selected item.
BUG=40836
TEST=none
Review URL: http://codereview.chromium.org/1723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1710001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1568033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use BaseBookmarkModelObserver when all events funel into a single method.
Using it, instead of BookmarkModelObserver, we can simplify the
BookmarkContextMenuController.
BUG=None
TEST=everything should works as before.
Review URL: http://codereview.chromium.org/1692001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=AutoFillManagerTest.*
Review URL: http://codereview.chromium.org/1733001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42146
TEST=Launch an Extension App and make sure it is visually differently drawn than anything else.
Review URL: http://codereview.chromium.org/1689002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19991
TEST=manual
Review URL: http://codereview.chromium.org/1660007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
don't know the original language: if the browser specifies undefined for the source language, we use the translate element in the page to detect the language.
BUG=40857
TEST=See bug.
Review URL: http://codereview.chromium.org/1508030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2. Change "GetSearchEngineType" function to use the short name to get the search engine type if we can't choose by prepopulate_id.
3. Disable the close button. (Next CL will remove it, if possible, but this requires adding a method to window_delegate.h).
4. Close the search engine view immediately if the user launches the keyword editor view. Pass the SearchEngineViewObserver object (the FirstRunView) to the keyword editor, who will call back to the waiting observer when closed.
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/1539044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45092 0039d316-1c4b-4281-b951-d872f2087c98
|