summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Merge 33599 - Unload the entire extension when any part of it crashes.aa@chromium.org2009-12-132-0/+33
| | | | | | | | | | | | | | Also enable the task_manager_browsertest.cc (where I added the new test) on Linux. TEST=Covered by browser_tests. BUG=21635 Review URL: http://codereview.chromium.org/465007 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/491072 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34448 0039d316-1c4b-4281-b951-d872f2087c98
* Merge of r33685, which gives a notification if the user tries to sync ↵mirandac@chromium.org2009-12-113-2/+16
| | | | | | | | | | | bookmarks and is already synched. BUG= 28795 TEST= sync bookmarks with promo; then try to sync again by clicking on promo. message should appear. Review URL: http://codereview.chromium.org/491060 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34384 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32547 - gtk: Show page action popup bubbles.derat@chromium.org2009-12-111-9/+20
| | | | | | | | | | | | | | | | | | | | Focus is a bit weird within these; I suspect that it's the same with the browser action bubbles. It looks like the same issue that the bookmark bubble had: the bubble grabs the pointer; when a widget within it (e.g. combobox) gets clicked it steals the grab; when it ungrabs it the grab is released instead of being transferred back to the bubble. Unsure of what the correct fix is for this. BUG=28061 TEST=installed two separate extensions with page action popups and clicked on their icons Review URL: http://codereview.chromium.org/412001 TBR=derat@chromium.org Review URL: http://codereview.chromium.org/490022 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34383 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33770 - Add ExtensionsQuotaService to limit abusive amounts of requeststim@chromium.org2009-12-0911-37/+1009
| | | | | | | | | | | | | | | | | | to mutating extension functions, as discussed on chromiumdev and in Extensions quotaserver design doc. Add a hook in the dispatcher to have the quota service assess the request. Wire up bookmarks.{create, move, remove, update} to the service. BUG=19899 TEST=ExtensionsQuotaServiceTest, QuotaLimitHeuristicTest (both new) Review URL: http://codereview.chromium.org/441006 Review URL: http://codereview.chromium.org/464076 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34128 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33914 - Fix nullpointer crash.abarth@chromium.org2009-12-071-0/+3
| | | | | | | | | | | BUG=29444 Review URL: http://codereview.chromium.org/469001 TBR=abarth@chromium.org Review URL: http://codereview.chromium.org/463043 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33982 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33862 - Linux: Show the private memory usage by default instead of the ↵thestig@chromium.org2009-12-051-2/+2
| | | | | | | | | | | | | shared memory usage. (which shows 0 for me) BUG=none TEST=Task manager shows the interesting stats by default. Review URL: http://codereview.chromium.org/468017 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/460092 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33903 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the sync menu item from Linux.zork@chromium.org2009-12-051-2/+0
| | | | | | | | | BUG=29425 TEST=Open the wrench menu. There should not be a sync menu item. Review URL: http://codereview.chromium.org/467022 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33898 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33798 - Fix download dialog truncation in German locale.finnur@chromium.org2009-12-041-4/+13
| | | | | | | | | | | | BUG=23178 TEST=Requires manual inspection for text trunction on lang=de (when closing Chrome while downloading) Review URL: http://codereview.chromium.org/465041 TBR=finnur@chromium.org Review URL: http://codereview.chromium.org/460066 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33803 0039d316-1c4b-4281-b951-d872f2087c98
* Remove promo footer from linux, but retain puzzle piece.mirandac@chromium.org2009-12-031-5/+11
| | | | | | | | | | | | | This will only be merged into 249, NOT into ToT. BUG=29204 TEST= puzzle piece on linux, but no promo footer. mac and windows unchanged. REVIEWED at http://codereview.chromium.org/455043/show Review URL: http://codereview.chromium.org/467007 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33718 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33530 - Delete old version directories of installed extensions during ↵mpcomplete@chromium.org2009-12-023-8/+43
| | | | | | | | | | | | | | | garbage collection. BUG=28884 Review URL: http://codereview.chromium.org/455026 TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/460024 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33602 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33541 - Ok, here is a different approach at this change.mal@chromium.org2009-12-023-0/+27
| | | | | | | | | | | | | | | Instead of storing pointers into a vector, store offsets. That way, if the vector resizes, we should still be OK. Also, add a DCHECK that we only enter this method once, which is my current assumption. Review URL: http://codereview.chromium.org/457028 TBR=aa@chromium.org Review URL: http://codereview.chromium.org/462004 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33560 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33380 - This fixes an issue where view source on a local file would ↵mal@chromium.org2009-12-021-1/+1
| | | | | | | | | | | | | | | | | | | | | return a blank page. This bug was introduced by the fix for issue 26129 (r30418), which was to limit view source so that it wouldn't be able to load javascript or data URLs, but that change forgot to allow file urls. This fixes the above omission by allowing file URLs again. TEST=works:viewsource:file:///tmp/test.html, doesn't work:viewsource:javascript:alert('foo') BUG=27409 Review URL: http://codereview.chromium.org/434094 TBR=gspencer@google.com Review URL: http://codereview.chromium.org/460009 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33544 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33461 - Fix a bug where not all autocomplete entries were being shown whentony@chromium.org2009-12-011-6/+6
| | | | | | | | | | | | | | | | | | | | | the popup got resized smaller. To repro: go to the chrome issue tracker (crbug.com) search for "aaaa" and "aaa" clear the search field and paste "aaaa" into the box press backspace At this point, you should see both autocomplete suggestions. BUG=29042 Review URL: http://codereview.chromium.org/457024 TBR=tony@chromium.org Review URL: http://codereview.chromium.org/450042 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33495 0039d316-1c4b-4281-b951-d872f2087c98
* Disable extensions on Mac.mal@chromium.org2009-12-012-0/+10
| | | | | | | | | BUG= http://crbug.com/29086 TEST = Try installing and running extensions. Review URL: http://codereview.chromium.org/450039 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33490 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33434 - linux: don't try to create plugin container if view_ is NULLpiman@chromium.org2009-12-011-2/+13
| | | | | | | | | | | | | This can only happen for extensions with delayinitialized RenderWidgetHost. BUG=28715 Review URL: http://codereview.chromium.org/450029 TBR=piman@chromium.org Review URL: http://codereview.chromium.org/452030 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33474 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33379 - Makes the chevron throb after a user sync'ed his bookmarks (if ↵tim@chromium.org2009-12-013-46/+60
| | | | | | | | | | | | | | | | | | | the overflow menu is shown) This also makes the chevron throb when no bookmarks is added during a sync and merge. BUG=24306 TEST=sync with over 10 bookmarks in the bookmark bar so that the chevron is visible. Patch by Bruno Calvignac<BrunoCalvignac@gmail.com> Original Review: http://codereview.chromium.org/306054/show Review URL: http://codereview.chromium.org/454010 TBR=tim@chromium.org Review URL: http://codereview.chromium.org/449060 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33456 0039d316-1c4b-4281-b951-d872f2087c98
* Manually merge r33152 into the 249 branch. The merge could not be done ↵idana@chromium.org2009-12-012-7/+39
| | | | | | | | | | | | | | automatically due to conflicts. Original code review URL: http://codereview.chromium.org/418044 BUG=26551 TEST=See bug description. TBR=tim@chromium.org Review URL: http://codereview.chromium.org/452024 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33392 0039d316-1c4b-4281-b951-d872f2087c98
* Revert changes 33261,33262,33275aa@chromium.org2009-12-0111-424/+19
| | | | | | | | | These changes merged the completion of browser action popups to trunk, which we've decided we don't want. Review URL: http://codereview.chromium.org/449035 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33382 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33164 - Changed shared worker code so incognito windows do not have ↵atwilson@chromium.org2009-11-305-42/+70
| | | | | | | | | | | | | | access to nonincognito shared workers. BUG=27883 TEST=added new uitest Review URL: http://codereview.chromium.org/441022 TBR=atwilson@chromium.org Review URL: http://codereview.chromium.org/450016 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33375 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33119 - Make cancel button not pop up when you make a bad login.chron@chromium.org2009-11-301-12/+13
| | | | | | | | | | | | BUG=27543 TEST=Manually tested Review URL: http://codereview.chromium.org/437033 TBR=chron@google.com Review URL: http://codereview.chromium.org/452019 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33339 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32853 - Make extension updates use omaha id when talking to omaha.asargent@chromium.org2009-11-303-1/+145
| | | | | | | | | | | | | BUG=b/2168147 TEST=Extensions autoupdates should still work. Review URL: http://codereview.chromium.org/403026 TBR=asargent@chromium.org Review URL: http://codereview.chromium.org/457007 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33323 0039d316-1c4b-4281-b951-d872f2087c98
* merge r32449 into 249 branch:estade@chromium.org2009-11-301-0/+8
| | | | | | | | | | | | | | | | | | | ------------------------------------------------------------------------ r32449 | estade@chromium.org | 2009-11-18 16:36:21 -0800 (Wed, 18 Nov 2009) | 7 lines GTK: Fix popup menu positioning. Don't go off end of screen. push_in doesn't actually work as well as one might hope. BUG=27800 Review URL: http://codereview.chromium.org/408017 ------------------------------------------------------------------------ TBR=laforge Review URL: http://codereview.chromium.org/450014 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33304 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33287 - Mac: improve apparent zorder problems when switching Spaces.viettrungluu@chromium.org2009-11-303-12/+33
| | | | | | | | | | | | | | | | | | | | Remove the status bubble as child window when hidden, rather than just setting its opacity to 0. I'm not sure about the effects, if any, of doing this rather than destroying the window completely. This doesn't eliminate zorder problems with Spaces, but should improve it considerably. This may also ameliorate the problems with moving windows between Spaces using Expose. BUG=28107, 24956 TEST=Create a bunch of windows; get the status bubble to appear in the active (key) window and then get it to disappear; switch to another spaces and back; make sure the active window is on top; repeat. Review URL: http://codereview.chromium.org/434120 TBR=pinkerton@chromium.org, thakis@chromium.org, viettrungluu@chromium.org Review URL: http://codereview.chromium.org/457001 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33297 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33291 - Clear the target/action of the close button when the view goes ↵pinkerton@chromium.org2009-11-302-1/+12
| | | | | | | | | | | | into the closing state in an attempt to prevent errant messages to dead objects. BUG=24987 TEST=open a ton of tabs, rapidly click the close box, hope nothing crashes and the tabs still close correctly. TBR=pinkerton@chromium.org Review URL: http://codereview.chromium.org/452012 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33295 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33269 - Revert 33255 Report active extensions in crash reports. This ↵aa@chromium.org2009-11-303-24/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | only implements Windows right now. Mac and linux will be separate CLs. "Active" is overloaded to mean different things depending on the process type: browser: all enabled extensions renderer: unique set of extensions from all user scripts extension: extensions running in the process BUG=27169 Review URL: http://codereview.chromium.org/437078 There are thousands of new crashes with reivison 33256 and 33255, so i'm reverting. the crashes are in chrome_2610000!child_process_logging::SetActiveURL TBR=aa@chromium.org Review URL: http://codereview.chromium.org/448006 TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/451005 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33274 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32587 - Fix build.levin@chromium.org2009-11-301-1/+1
| | | | | | | | | | | | | TBR=jam@chromium.org TEST=None BUG=None Review URL: http://codereview.chromium.org/414023 TBR=levin@chromium.org Review URL: http://codereview.chromium.org/448008 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33273 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32586 - Fix unitialized memory access in workers.levin@chromium.org2009-11-302-6/+71
| | | | | | | | | | | | | | | | | | | | | | | The primary issue was that OnDestroy didn't change the entangled port to have its entangled port be none. A secondary issues that came up is that in very rare circumstances (like a crash happening early in a worker process), it seemed like it may be possible that one of the message ports may think it is entangled and the other half may not, so the Erase method guards against this. Also, some code was added to verify the internal structure before running code and after. BUG=27839 TEST=valgrind on linux running ui tests, specifically WorkerTest.WorkerFastLayoutTests. Review URL: http://codereview.chromium.org/402106 TBR=levin@chromium.org Review URL: http://codereview.chromium.org/452007 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33271 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32980 - o Updates the browser action buttons when a tab is changed. ↵aa@chromium.org2009-11-303-1/+17
| | | | | | | | | | | | | | | This is needed for tabspecific browser action buttons. o If a tooltip is not present on a browser action button, clear the tooltip of the button. BUG=28719 TEST=Load chrome/test/data/extensions/api_test/browser_tab_specific_state, play around with it in different tabs and make sure that the state remains the same per tab. Review URL: http://codereview.chromium.org/434047 TBR=andybons@chromium.org Review URL: http://codereview.chromium.org/448004 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33262 0039d316-1c4b-4281-b951-d872f2087c98
* Adds popups to browser actions, completing the feature.aa@chromium.org2009-11-3010-18/+407
| | | | | | | | | Adds functionality to choose between two different InfoBubbleView types: white background and gradient background. TBR=andybons@chromium.org Review URL: http://codereview.chromium.org/453003 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33261 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33255 - Report active extensions in crash reports. This only ↵aa@chromium.org2009-11-303-0/+24
| | | | | | | | | | | | | | | | | | | | implements Windows right now. Mac and linux will be separate CLs. "Active" is overloaded to mean different things depending on the process type: browser: all enabled extensions renderer: unique set of extensions from all user scripts extension: extensions running in the process BUG=27169 Review URL: http://codereview.chromium.org/437078 TBR=aa@chromium.org Review URL: http://codereview.chromium.org/445005 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33257 0039d316-1c4b-4281-b951-d872f2087c98
* Put kUserClosedAboutNotification back on the 249 branch.mark@chromium.org2009-11-292-0/+7
| | | | | | | | | | | This fell out when I merged r32598 at r33242. This constant is not used on the trunk as of r32551, but r32551 was not merged to the 249 branch. BUG=none TEST=the 249 branch builds Review URL: http://codereview.chromium.org/450003 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33248 0039d316-1c4b-4281-b951-d872f2087c98
* Merge r33241 to the 249 branch.mark@chromium.org2009-11-2817-62/+2047
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In-application Keystone ticket promotion. The concept of "ticket promotion" is added to the application when Keystone is in use. Ticket promotion is used to turn a user Keystone ticket, which Chrome normally establishes when it launches, into a system Keystone ticket, after successful user authentication and authorization. Having a system Keystone with a system ticket means that updates are applied with root privileges instead of user privileges, essentially eliminating the possibility that a user will fall off of the auto-update train because they can read and execute but not write the application. Two principles of promotion apply: - An application on a user ticket NEEDS promotion if it determines that it doesn't have permission to write to itself. Being on a user ticket, an update attempt would fail. - An application on a user ticket WANTS promotion if it already NEEDS promotion. Additionally, if it is installed in a system-wide location such as /Applications, it will WANT promotion, even if it does not NEED it. If promotion is needed, an info bar will show up on launch requesting it. This info bar works similarly to the default browser info bar: it has a "don't bother me again" button, it will only show up after the first launch, it won't disappear on navigation if the navigation happens very quickly, and it won't show itself if another info bar is up. This means that if both the default browser info bar and the promotion info bar have a shot at showing, only one will win. In my experience, each wins about half of the time. If promotion is needed, the update UI in the About window will be hidden. Checking for updates and offering to apply them doesn't make much sense when the update won't be able to install successfully. All of the auto-update machinery is still working in the background, but the About window UI is hidden. If promotion is wanted, the About window will contain a new button allowing the user to enter promotion. This gives access to the same promotion routine as the promotion info bar. It can be used even from an administrative account that is able to update the application without promotion. It's intended to be used by the system administrator of the family without requiring them to switch to one of the kids' accounts. BUG=16360 TEST=Exhaustively, please. Review URL: http://codereview.chromium.org/437053 TBR=mark@chromium.org Review URL: http://codereview.chromium.org/449004 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33243 0039d316-1c4b-4281-b951-d872f2087c98
* Merge r32598 to the 249 branch.mark@chromium.org2009-11-282-6/+14
| | | | | | | | | | | | | | | | | | Mac: remove cursor turd from About dialog. (The cursor was displayed with full keyboard accessibility enabled.) Changes to About.xib: changed the class of the view containing the legal text to |AboutLegalTextView| (from |NSTextView|). BUG=25570 TEST=Enable Full Keyboard Access, All controls in System Preferences; look in the About Chromium/Google Chrome; there should be no cursor displayed (at the end of the text). Review URL: http://codereview.chromium.org/414028 TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/443026 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33242 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33182 - Throttle websocket live experimentukai@chromium.org2009-11-261-0/+8
| | | | | | | | | | | | | | 0.5% of users will participate websocket live experiment. BUG=28843 TEST=none Review URL: http://codereview.chromium.org/434110 TBR=ukai@chromium.org Review URL: http://codereview.chromium.org/444012 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33190 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32919 - Reduce DLOG in websocket codeukai@chromium.org2009-11-262-31/+1
| | | | | | | | | | | | BUG=28657 TEST=none Review URL: http://codereview.chromium.org/440005 TBR=ukai@chromium.org Review URL: http://codereview.chromium.org/443017 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33189 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32462 - Enable WebSocketExperiment backukai@chromium.org2009-11-261-4/+0
| | | | | | | | | | | | | | r32311 fixes the cause of the crash, so enable WebSocket experiment again. BUG=28096,27856 TEST=none Review URL: http://codereview.chromium.org/399065 TBR=ukai@chromium.org Review URL: http://codereview.chromium.org/442021 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33186 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32311 - Hold histograms in static variables instead of allocating heap.ukai@chromium.org2009-11-262-112/+94
| | | | | | | | | | | | | | | | | | | | If instance variables holding pointers to Histograms, it would cause crash bug when the instance is torn down and the metrics services use and recording of their contents. The current "standard" patten for using Histograms includes making sure that the Histogram instances are not destroyed prematurely, held in static variables. BUG=28096 TEST=none Review URL: http://codereview.chromium.org/404022 TBR=ukai@chromium.org Review URL: http://codereview.chromium.org/441027 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33185 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33162 - For now, let's clear local storage whenever we clear cookies.jorlow@chromium.org2009-11-265-0/+43
| | | | | | | | | | | BUG=28788 TEST="Clear private data..." from the menu, check cookies, and tell it ok. Data in "Local Storage" inside the profile's data dir should be deleted and any open websites that were using that data should no longer be able to see it. Review URL: http://codereview.chromium.org/441012 TBR=jorlow@chromium.org Review URL: http://codereview.chromium.org/440034 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33173 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33146 - Fix incognito with LocalStorage.jorlow@chromium.org2009-11-261-5/+5
| | | | | | | | | | | | BUG=28807 TEST=Incognito has seprate data from the main window and is reset when you close the incognito window. Review URL: http://codereview.chromium.org/434099 TBR=jorlow@chromium.org Review URL: http://codereview.chromium.org/440033 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33172 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33144 - RESUBMIT of http://codereview.chromium.org/404025/showjorlow@chromium.org2009-11-265-65/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Start the WebKit thread when we initialize the resource dispatcher host. NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing. TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread. Originally landed in r33063, reverted in r33101 due to coincidence with Modules Linux startup test failures. TBR=jorlow, darin TEST=The WebKit thread gets spun up early in the initialization process. BUG=24144,28364 Review URL: http://codereview.chromium.org/441025 TBR=chase@chromium.org Review URL: http://codereview.chromium.org/443014 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33170 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33108 - Enable the RTL UI support in the extensions_ui ↵jshin@chromium.org2009-11-252-13/+88
| | | | | | | | | | | | | | | | (chrome://extensions). While doing so, make it use the fontfamily and fontsize (84% by default) set in locale_settings for the current UI language. The body font size used to be 87%. To make up for the difference between two, the font sizes given in percentage are adjusted (increased) accordingly in the rest of the file. BUG=28202 TEST=1. Run Chrome with 'lang=he' or 'lang=ar' on Windows (or 'LANGUAGE=he chrome' / 'LANGUAGE=ar chrome' on Linux) and go to 'chrome://extensions'. Strings are not yet translated, but the overall UI should be RTL. 2. Run Chrome in enUS (or your favorite LTR language) and go to 'chrome://extensions'. It should look the same as before. Review URL: http://codereview.chromium.org/434024 TBR=jshin@chromium.org Review URL: http://codereview.chromium.org/434105 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33158 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32701 - Don't do work in the SharedIOBuffer constructor; mal@chromium.org2009-11-251-5/+11
| | | | | | | | | | | | | | | use an Init method instead. This eliminates instances of allocatedbutinvalid SharedIOBuffers. Also clean up some CHECKs and TODOs associated with the bug. The upshot is that we no longer crash in AsyncResourceHandler::OnResponseCompleted() when we can't allocate shared memory. We now crash (properly, I believe) in the renderer process if the shared memory that failed to allocate was the TransportDIB, since the renderer can't communicate with the browser without it. BUG=16371 TEST=none Review URL: http://codereview.chromium.org/391009 TBR=hawk@chromium.org Review URL: http://codereview.chromium.org/437070 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33126 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33107 - Plumb through sitespecific quirks setting with a command line ↵dglazkov@chromium.org2009-11-251-0/+2
| | | | | | | | | | | | | | | | | switch. Quirks are enabled by default. R=darin BUG=19586 TEST=wikileaks.org should now have its sidebar in the proper place. Review URL: http://codereview.chromium.org/442010 TBR=dglazkov@chromium.org Review URL: http://codereview.chromium.org/442015 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33114 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33079 - Mac: give visual feedback for bookmark button drags.viettrungluu@chromium.org2009-11-256-13/+151
| | | | | | | | | | | | | | | | | | Draw an "ugly black bar" (where "black" is actually a theme colour) to indicate where a bookmark button that's being dragged will end up if dropped. This is a stopgap measure for the beta. Later, we will make the buttons move around instead (even if implementable in the time remaining, such animations would be a crash risk). BUG=17608 TEST=Drag bookmark bar buttons around. Make sure that the bar indicating where a button will be dropped is visible enough and accurate. Repeat with various themes. Review URL: http://codereview.chromium.org/437051 TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/437066 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33105 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32986 - Stop opening _all_ notification location changes in a new tab. ↵johnnyg@chromium.org2009-11-252-20/+60
| | | | | | | | | | | | | | | | | That was allowing unwanted popups from a notification with script that sets window.location=foo. Instead override some RVHDelegate::View methods to allow popups to be blocked, and newtab links to open in new tabs; now regular links will navigate the toast. The view methods are implemented using the standard helper. BUG=28015 TEST=none Review URL: http://codereview.chromium.org/434041 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/434089 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33097 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33057 - Fixing 27834 by always deleting ExtensionMessageService onhuanr@chromium.org2009-11-252-6/+18
| | | | | | | | | | | | | | | UI thread. BUG=27834 TEST=none Review URL: http://codereview.chromium.org/440012 TBR=huanr@chromium.org Review URL: http://codereview.chromium.org/435047 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33090 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32928 - disable extension toolstrips by default, addingaa@chromium.org2009-11-252-0/+8
| | | | | | | | | | | | | | enableextensiontoolstrips BUG=24475 TEST=Extension*Toolstrip* Review URL: http://codereview.chromium.org/434026 TBR=erikkay@chromium.org Review URL: http://codereview.chromium.org/440021 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33086 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 33069 - Adds back the ability to filter cookies by origin in the ↵ian@chromium.org2009-11-254-20/+109
| | | | | | | | | | | | | cookies options view. BUG=27657 TEST=Typing "google" in the search field pulls up origins containing "google" in their name Review URL: http://codereview.chromium.org/435024 TBR=ian@chromium.org Review URL: http://codereview.chromium.org/434086 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33085 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32829 - Fixing GCC 4.4 build fix (landing a patch for hbono)ian@chromium.org2009-11-251-1/+1
| | | | | | | | | | | | | | | | | This patch was written by hbono, landing for him as he can't land this until tomorrow, and it's a patch to fix a build. Reviewed at http://codereview.chromium.org/414025 BUG=none TEST=GCC 4.4 compiles Review URL: http://codereview.chromium.org/436003 TBR=ian@chromium.org Review URL: http://codereview.chromium.org/434084 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33083 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32522 - Sort the origins in the cookies_tree_model by effective TLD, ↵ian@chromium.org2009-11-252-8/+87
| | | | | | | | | | | | | | | as opposed to a lexicographical sort on the entire origin as a string. BUG=28192 TEST=cookies_tree_model_unittest.cc Review URL: http://codereview.chromium.org/404039 TBR=ian@chromium.org Review URL: http://codereview.chromium.org/441019 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@33082 0039d316-1c4b-4281-b951-d872f2087c98