| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
TEST=Install the extension "declarative_request_headers_match.crx" attached to BUG 143662. If this feature is working correctly it should cancel every navigation.
BUG=143662, 112155
TBR=yoz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11038031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This information would be useful to invetigate issues where the local
file system metadata is out of sync.
Along the way, replace SetString() with SetDouble() for the largest
changestamp values. The largest change stamp should be small enough to
fit in double without losing precision.
BUG=155473
TEST="Largetst Changestamp (local)" is added in chrome:drive-internals
Review URL: https://chromiumcodereview.appspot.com/11106009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This checkbox was enabled/disabled depending on the NetworkLibrary's Lock
flag. This interfered with the disabling done by the pref_ui element. I changed
the code to use the pref_ui element's "setDisable" method.
BUG=chromium:153350
Review URL: https://chromiumcodereview.appspot.com/11026065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
local- and remote-side file services.
(The service code is currently mostly just a skeleton)
BUG=155505
Review URL: https://codereview.chromium.org/11048054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
some common code.
Review URL: https://chromiumcodereview.appspot.com/11093060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename Start/StopUpdates() in DriveFileSystemInterface to
Start/StopPolling() so that what they do is clear.
BUG=none
TEST=compiles
Review URL: https://chromiumcodereview.appspot.com/11167003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=153598
TEST=Open an incognito window, enter "chrome://history". The history tab should be opened in a normal window, not the incognito window.
Review URL: https://chromiumcodereview.appspot.com/11051015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Drive metadata prefetching was disabled in crrev.com/160812
to stabilize M23. We should re-enable this in M24.
BUG=154763
TEST=log in using a new account on the device; wait for a minute or so; open Files.app and click on Drive; confirm that files on Drive are shown immediately.
Review URL: https://chromiumcodereview.appspot.com/11148037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL includes:
- Initialization of DriveMetadataStore and DriveMetadataDB,
- Add {Update,Delete,Read}Entry to manipulate metadata entry,
- Add tests for them.
BUG=152612
Review URL: https://chromiumcodereview.appspot.com/10986062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MagnificationManager controls the full screen magnifier from chrome-browser side (not ash side. Note that MagnificationController is on ash side).
MagnificationManager does:
- Watch logged-in. Change the behavior between the login screen and user desktop.
- Watch change of the pref. When the pref changes, the setting of the magnifier will interlock with it.
In addition, this patch make the magnifier settings per-user instead of per-device.
BUG=151891
TEST=manual, browser_test passes.
Review URL: https://chromiumcodereview.appspot.com/11065008
TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/11169002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=155871
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/11143034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MagnificationManager controls the full screen magnifier from chrome-browser side (not ash side. Note that MagnificationController is on ash side).
MagnificationManager does:
- Watch logged-in. Change the behavior between the login screen and user desktop.
- Watch change of the pref. When the pref changes, the setting of the magnifier will interlock with it.
In addition, this patch make the magnifier settings per-user instead of per-device.
BUG=151891
TEST=manual, browser_test passes.
Review URL: https://chromiumcodereview.appspot.com/11065008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split from http://codereview.chromium.org/10986062/ to maintain file history.
This CL renames RemoteMetadataStore to DriveMetadataStore.
BUG=152612
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/11146030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This also disables the frameless constrained window dialog for the one other dialog where it was enabled on Windows. We don't intend to address that dialog at the current time.
BUG=155898
Review URL: https://chromiumcodereview.appspot.com/11142022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for the default service.
BUG=156012
Review URL: https://chromiumcodereview.appspot.com/11151034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch just replaces the names.
We are planning to use 'getPreference' and 'setPreference' to pass not only drive-specific preferences but file manager preferences.
BUG=154730
TEST=none
R=oreg@chromium.org, mkearney@chromum.org
TBR=asargent@chromium.org
# TBRing for simple changing of chrome/browser/extensions
Review URL: https://chromiumcodereview.appspot.com/11093014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The TODO is to test launching platform apps with command line arguments with ChromeOS, which does not support command line arguments. The TODO has been replaced by a comment explaining this.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11150014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
allows us to remove the dependency on drive_file_system.h, which will make testing easier.
TBR=sky@chromium.org
BUG=155479
Review URL: https://codereview.chromium.org/11113006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this CL:
1. Reforms the JS UI to look more like Chrome|Settings, including look/feel and use of overlays for progress and error reporting.
2. Redesigns the UI to support maintaining on the extension side a record of captures, including their URLs and the cache state resulting from their initial capture run. Allows the user to add new captures to the record, delete unwanted ones, and run any he'd like.
Later CLs:
3. Actually implements the underlying FileSystem-using code to do this, as opposed to current mockup.
4. Adds C++-side code to allow C++ directories to be copied to and from FileSystem sandbox directories.
5. Adds means of interrupting ongoing sub-browser sessions so that captures and replays may be cancelled from UI.
6. Improves stats reporting, including nice-looking charts instead of present rather nasty line-by-line text dump of runtimes per URL.
Snapshots:
Capture tab: http://imgur.com/Jb3UG
Message overlay: http://imgur.com/afFVL
Playback tab: http://imgur.com/PUGhx
Playback w/o chosen capture: http://imgur.com/biKK1
Playback w/ no captures available: http://imgur.com/Zv4Bp
Aaron's initial mockup/spec:
https://moqups.com/aboodman/wDjKAEXR/p:aed59f081
Somewhat dated original design doc for the first version:
https://docs.google.com/a/chromium.org/document/d/1HyiPO4DBfCzLtVKOMx6rGGa7Vw_GzNZX_FObc-mWiZo/edit?hl=en_US&sai=true
Review URL: https://chromiumcodereview.appspot.com/10832191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=138118
Review URL: https://chromiumcodereview.appspot.com/11103042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
-[NSEvent description] is what gdb's po command would print against
the event. It is basically an ASCII serialization of the event.
BUG=154483
Review URL: https://chromiumcodereview.appspot.com/11140040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
always running the internal device tracking code.
BUG=155652
Review URL: https://codereview.chromium.org/11151010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
OperatingSystemArchitecture().
Review URL: https://chromiumcodereview.appspot.com/11140015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=152010
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/11151008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=155603
TEST=Covered by unit test.
R=csharp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11154013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
intent menu items and a webstore link. Removes the command this deprecates from browser_commands.
BUG=137953
Review URL: https://chromiumcodereview.appspot.com/11073009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=136075
Review URL: https://chromiumcodereview.appspot.com/10993089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
|extension_| may be NULL in ExtensionInstallPrompt::FetchOAuthIssueAdviceIfNeeded() function. ShowConfirmation() tries to dereference |extension_|. Therefore, modified code to call ShowConfirmation() only when |extension_| is not NULL.
CID=106034
BUG=none
TEST=none
TBR=kalman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11013035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ThumbnailService is a ProfileKeyedService which currently forwards all calls
to TopSites. On the other side I split the one and only ThumbnailGenerator class
into a base and two classes inheriting from it: one suited for working with
TopSites and another working with ThumbnailService.
In the next step I plan to flesh out ThumbnailGeneratorRecent and introduce
PrettyThumbnailServiceImpl. Between these two classes, we will try out ways
for generating nicer (and more) thumbnails.
BUG=155269
Review URL: https://chromiumcodereview.appspot.com/11054020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the preferences dictionary.
Whenever a gallery is added, check to see if there is any gallery info exists for the added gallery. If so, verify the existing gallery information with the new details. If there is a mismatch, update the gallery information accordingly.
This is a part of reverted CL (r159752).
Original CL: https://chromiumcodereview.appspot.com/10991030
BUG=152808
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11155014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we navigate to 'http://www.google.com', then navigate to '' (empty src), reading <browser>.src would now give us (expected) 'http://www.google.com' since we ignore setting empty src attribute in browser_plugin.cc.
BUG=149001
TEST=In web inspector, setting src on <browser> element and reading it.
Added platform app test for verifying the change.
Ran content_browsertests for BrowserPluginTest* and BrowserPluginHostTest*
Review URL: https://chromiumcodereview.appspot.com/11111020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removing Chrome-specific factories and inlining what they used to do. One was (after the bulk of this change) just adding a single pref to the PrefChangeRegistrar, the other was used in only one place.
TBR=usageupdate@chromium.org,ben@chromium.org
BUG=155525,122215
Review URL: https://chromiumcodereview.appspot.com/11110014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently ConstrainedWindowMac2 manages its own lifetime. This CL changes things so that ConstrainedWindowMac must explicitly be deleted.
Here's a summary of how the memory management used to work and how it works now:
https://docs.google.com/document/d/1rlZRfHtaBdqDeTj2vNJ3vCPxCwZ3zscHpBmLJtrsVeI/edit
BUG=152010
TBR=ben@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161987
Review URL: https://codereview.chromium.org/11139010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that some of our APIs are out of experimental, the ones still in
experimental should append the command line individually in their tests as
needed.
BUG=155430
Review URL: https://chromiumcodereview.appspot.com/11145006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to support old dasher domains.
BUG=154158
TEST=When signing in to an older dasher-style domain, like google/com/a/example.com,
the one-click sign in infobar no longer appears. User can still use the
infobar with a dash account by logging into that account at gmail.com or other
similar google property.
Review URL: https://chromiumcodereview.appspot.com/11143017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently ConstrainedWindowMac2 manages its own lifetime. This CL changes things so that ConstrainedWindowMac must explicitly be deleted.
Here's a summary of how the memory management used to work and how it works now:
https://docs.google.com/document/d/1rlZRfHtaBdqDeTj2vNJ3vCPxCwZ3zscHpBmLJtrsVeI/edit
BUG=152010
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11139010
TBR=sail@chromium.org
Review URL: https://codereview.chromium.org/11150033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/11146006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change addresses two sources of jank in extended-instant-api. We currently
flash the native omnibox popup before the HTML-popup comes in, which looks very
bad. We also avoid a dark-gray flash that occurs when the NTP contents have
been hidden and before the Instant overlay is shown (by leaving the NTP
contents and making sure Instant is stacked at the top).
We could rip out InlineOmniboxPopupView completely, but at this time, we are
not fully committed to the web-based implementation so leaving it in until that
is settled. That will also involve a larger change to refactor OmniboxPopup so
that its model doesn't directly interact with the view.
TESTED=manually, as per bugs.
BUG=154951,152852,154972
Review URL: https://chromiumcodereview.appspot.com/11066103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
API and the existing desktop notification UI.
Next step will be to create a new peer class to the existing desktop notification class, then create a new IPC message (or alter the existing one) to invoke it. Then we will have a subsystem that's entirely our own to start UI iteration.
Review URL: https://chromiumcodereview.appspot.com/11116016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently ConstrainedWindowMac2 manages its own lifetime. This CL changes things so that ConstrainedWindowMac must explicitly be deleted.
Here's a summary of how the memory management used to work and how it works now:
https://docs.google.com/document/d/1rlZRfHtaBdqDeTj2vNJ3vCPxCwZ3zscHpBmLJtrsVeI/edit
BUG=152010
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11139010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=125307
Review URL: https://codereview.chromium.org/11145027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Populate this field from TabNavigation objects (specifically,
the internal value of the timestamp).
BUG=128449
Review URL: https://chromiumcodereview.appspot.com/11098002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Panel fitting is used by mirror display mode on Chrome OS.
This GPU feature type will tell if it is supported by GPU hardware.
Initially enable it only for Ivy Bridge GPU via blacklisting everything else.
Also add a disable_panel_fitting command flag,
to be able to quickly turn the feature off.
When hardware supports panel fitting,
and there are no common modes between the internal and the external displays,
configure the internal display to the external's resolution,
and let the panel fitter take care of displaying it correctly.
BUG=chromium-os:34442
TEST=Panel Fitting should appear as Hardware Accelerated in about:gpu
on IVB Chrome OS, Unavailable everywhere else.
TEST=Tested mirror mode on device.
Review URL: https://chromiumcodereview.appspot.com/10909242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/11112022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DriveSearch content directory should be drive root since the search is done
over the whole drive.
Since change-directory is not dispatched when search starts, breadcrumbs should
be updated on scan-started.
TEST=manual
BUG=154742
Review URL: https://chromiumcodereview.appspot.com/11090030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Installing inline extensions stopped working on Mac.
In r161306 I switched the extension install prompt to be a constrained window.
This requires a window to attach the install prompt onto. The inline install code path was not setting a parent window causing us not to show the prompt.
Fix was to pass a window.
BUG=155732
TEST=Navigate to http://chrome.angrybirds.com/ and choose "Install to play offline". Verified that the install prompt was shown.
Review URL: https://chromiumcodereview.appspot.com/11145010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebContentsUserData for things that hang off TabContents.
Remove unnecessary include of tab_contents.h.
BUG=140037
Review URL: https://chromiumcodereview.appspot.com/11111018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to the "chrome_browser_net" namespace.
R=erikwright@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11151021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=jhawkins@chromium.org
R=smckay@chromium.org,gbillock@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11033041
TBR=groby@chromium.org
Review URL: https://codereview.chromium.org/11140036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Omnibox).
R=shess@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11135002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161953 0039d316-1c4b-4281-b951-d872f2087c98
|