summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* GTK: shift-enter in find bar searches backwards.estade@chromium.org2009-06-111-1/+3
| | | | | | | | | BUG=13520 TEST=use shift enter in find bar Review URL: http://codereview.chromium.org/122047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18196 0039d316-1c4b-4281-b951-d872f2087c98
* Use the MessageLoopForUI::Observer interface to listen for mouse motion ↵jhawkins@chromium.org2009-06-112-34/+27
| | | | | | | | | | events instead of hooking up to the global gdk event handler. Once we hook up to the global handler and disconnect from it, the MessageLoopForUI will be broken because we stole the handler from it. BUG=none TEST=Exhaustively test dragging tabs in and out of multiple tabstrips. Review URL: http://codereview.chromium.org/126001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18194 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "BUG=12114"tc@google.com2009-06-117-337/+112
| | | | | | | | | | | This reverts commit r18189. TBR=rafaelw Review URL: http://codereview.chromium.org/125004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18193 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=12114rafaelw@chromium.org2009-06-117-112/+337
| | | | | | | | R=erikkay,wtc Review URL: http://codereview.chromium.org/115682 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18189 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 3791: SavePageTest.* is crapidanan@chromium.org2009-06-111-14/+20
| | | | | | | | | | | | | Modifying flaky test so that it waits for a file to stop being written rather than starts existing. Otherwise the compare check fails some times. I know Windows has a more efficient API to do this but for the sake of multiplatform compatibility, the solution is completely generic. BUG=3791 Review URL: http://codereview.chromium.org/123026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18187 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in ExtensionsService when skipping loadedaa@chromium.org2009-06-111-8/+6
| | | | | | | | extensions. Review URL: http://codereview.chromium.org/122021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18186 0039d316-1c4b-4281-b951-d872f2087c98
* Get tab HWND directly as result of CreateExternalTab automation call.stoyan@chromium.org2009-06-113-3/+9
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/119448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18181 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Forward certain key strokes from the find bar to the render view.estade@chromium.org2009-06-112-4/+55
| | | | | | | | | | | The choice of keystrokes matches windows. BUG=12697 TEST=press up or down in find bar; page should scroll (assuming it can scroll) Review URL: http://codereview.chromium.org/122014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18176 0039d316-1c4b-4281-b951-d872f2087c98
* Start the resize animation after a delay once the mouse has left the ↵jhawkins@chromium.org2009-06-112-21/+115
| | | | | | | | | | tabstrip zone. BUG=13471 TEST=Open enough tabs in a browser window so that they must resize. Close a few tabs in the middle of the tabstrip. The tabs should not resize. Now move the mouse outside of the tabstrip zone (40 pixels below). The tabs should resize after a short delay. Review URL: http://codereview.chromium.org/123005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18174 0039d316-1c4b-4281-b951-d872f2087c98
* Another fix for issue 13724: Don't hard code chrome.exeagl@chromium.org2009-06-111-1/+4
| | | | | | | | | | | | Use chrome::kBrowserProcessExecutableName instead. BUG=13724 http://codereview.chromium.org/123022 (By Edward Crossman) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18172 0039d316-1c4b-4281-b951-d872f2087c98
* Move renderer_preferences.h from chrome/browser into chrome/common. Wetc@google.com2009-06-114-28/+3
| | | | | | | | | | include the file in chrome/renderer and chrome/browser so to make check deps happy, I'm putting the file in chrome/common. Review URL: http://codereview.chromium.org/123001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18166 0039d316-1c4b-4281-b951-d872f2087c98
* Revert mad's backing store changes, it completely hosed Linux painting.deanm@chromium.org2009-06-119-228/+90
| | | | | | | | | This was r18090, reverted in r18092, recommitted without review in 18130. Review URL: http://codereview.chromium.org/122034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18158 0039d316-1c4b-4281-b951-d872f2087c98
* Final touches on the Linux BookmarkBubble.deanm@chromium.org2009-06-114-12/+59
| | | | | | | | | | | | | - Implement "close on escape" with a top level accelerator. - Fix an invalid read when opening the editor from the folder combo. - Clean up some signal handlers (returning bool from a void function, etc). BUG=11738 Review URL: http://codereview.chromium.org/118493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18154 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Keep Resources panel enabled status upon frame navigate.pfeldman@chromium.org2009-06-111-1/+0
| | | | | | Review URL: http://codereview.chromium.org/118508 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18153 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser window crash on windows.thakis@chromium.org2009-06-111-0/+8
| | | | | | | | | | | | | BUG=13681 (http://crbug.com/13681) TEST=Follow these steps -Ctrl+Shift+N to Incognito window. -Download a file -Close the Incognito window after download is finished. Review URL: http://codereview.chromium.org/120001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18151 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash on interstitial page when the renderer crashed.willchan@chromium.org2009-06-113-3/+43
| | | | | | | | | | | Simply add a NULL check to make sure the view is still there before showing it. Also fix a debug crash since the ResourceDispatcherHost assumes that it should always find the pid & route_id key, which is not true if the renderer crashed. BUG=http://crbug.com/13795 TEST=See bug for repro instructions. Review URL: http://codereview.chromium.org/122025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18150 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add support to the automation provider to test sending browser"aa@chromium.org2009-06-115-230/+2
| | | | | | | | This reverts commit 4775c631c09be565706f8a6ce3c4659bc89097e4. Review URL: http://codereview.chromium.org/122024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18149 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to the automation provider to test sending browseraa@chromium.org2009-06-115-2/+230
| | | | | | | | | | | | events to extensions. Implements an initial test that send all known window, tab, page action, and bookmark events and makes sure the extension received them. Original review: http://codereview.chromium.org/119325 Review URL: http://codereview.chromium.org/123010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18148 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add support to the automation provider to test sending browser"aa@chromium.org2009-06-115-230/+2
| | | | | | | | This reverts commit 9b7fbb1e720ab2071b30531fd0266918c4e68d12. Review URL: http://codereview.chromium.org/122022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18147 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to the automation provider to test sending browseraa@chromium.org2009-06-115-2/+230
| | | | | | | | | | | | | events to extensions. Implements an initial test that send all known window, tab, page action, and bookmark events and makes sure the extension received them. Original review: http://codereview.chromium.org/119325 Review URL: http://codereview.chromium.org/123009 Patch from Roger Tawa <rogerta@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18146 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extension loading code to properly filter out non-themesaa@chromium.org2009-06-112-19/+31
| | | | | | | | | | | when extensions are disabled. BUG=12076 TEST=Added a unit test. Also, install an extension, then create a new version of it and overinstall. You should not see two of them. Review URL: http://codereview.chromium.org/123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18140 0039d316-1c4b-4281-b951-d872f2087c98
* Linux bookmark manager:estade@chromium.org2009-06-114-91/+278
| | | | | | | | | - Add more dragging. - Make right pane updating less clobbery. Review URL: http://codereview.chromium.org/122005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18136 0039d316-1c4b-4281-b951-d872f2087c98
* If widget is too small to render a nine box, just return (don't DCHECK).estade@chromium.org2009-06-112-14/+11
| | | | | | | | | | | When I initially added that DCHECK, we did not have any animations, so it was always a mistake to have a widget that was too small. Now that we do have animations, this is no longer true. Instead of having to work around this DCHECK with minimum size hacks, get rid of the hack and paint nothing. TEST=download a safe thing and an unsafe thing. Open and close the bookmark bar and findbar a lot. Everything looks ok and doesn't crash. http://crbug.com/13343 Review URL: http://codereview.chromium.org/118393 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18135 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple problems with DownloadItemGtk.estade@chromium.org2009-06-111-12/+4
| | | | | | | | | | 1) We were crashing after removing a download item because g_signal_handler_find() was not working as expected. 2) We had a graphical glitch with the dangerous download dialog because GtkAlignments doesn't normally redraw on allocate. BUG=13659 Review URL: http://codereview.chromium.org/118403 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18132 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding reverted patch 18090.mad@google.com2009-06-119-90/+228
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18130 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple CHECK()s in hopes of helping to track down a crash.pkasting@chromium.org2009-06-111-0/+7
| | | | | | | | BUG=13500 TEST=none Review URL: http://codereview.chromium.org/118453 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18128 0039d316-1c4b-4281-b951-d872f2087c98
* Add helper for creating table of labeled controls.mattm@chromium.org2009-06-112-44/+15
| | | | | | | | BUG=none Review URL: http://codereview.chromium.org/118489 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18120 0039d316-1c4b-4281-b951-d872f2087c98
* Save as dialog should show html filesmhm@chromium.org2009-06-111-0/+2
| | | | | | | | | | | | Currently "htm" files are hardcoded, that is the reason why its only seen. Adding "html" to the vector extension would fix this issue. BUG=13429 (http://crbug.com/13429) TEST=Can now see html in the save file dialog. Review URL: http://codereview.chromium.org/119409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18119 0039d316-1c4b-4281-b951-d872f2087c98
* Fix HWND for Importer Dialogmhm@chromium.org2009-06-111-4/+2
| | | | | | | | | | | | Instead of grabbing the HWND from the browser, we can grab it from the current view since each view has a Widget who is associated with a HWND (NativeView). By doing that, we can assure the parent hwnd is that. Before, it was retrieving the hwnd from Browser* which caused this bug. BUG=13154 (http://crbug.com/13154) TEST=Launched Options>Importer>Import and it brought up the Options dialog. Review URL: http://codereview.chromium.org/119408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18118 0039d316-1c4b-4281-b951-d872f2087c98
* Hide URL from extension pages.mhm@chromium.org2009-06-111-0/+5
| | | | | | | | | | | We can't do the same as we do for NTP because NTP is a DOMUI whereas chrome-extensions is just a normal webpage. Adding functionality within TabContents::ShouldDisplayURL() would be sufficient to tell the ombibox not to display the URL. BUG=12371 (http://crbug.com/12371) TEST=Tested chrome-extension://id/hello_world.html Review URL: http://codereview.chromium.org/119406 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18117 0039d316-1c4b-4281-b951-d872f2087c98
* Disable extensions in incognito mode.mpcomplete@google.com2009-06-1110-26/+90
| | | | | | | | | | | Add a browsertest to make sure we don't crash with an incognito window open. Had to finagle utility_process_host to make it work in a browsertest. BUG=12326 TEST=none Review URL: http://codereview.chromium.org/118476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18116 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a notimplemented with a link to the bug report.jhawkins@chromium.org2009-06-101-1/+1
| | | | | | | TBR=tony Review URL: http://codereview.chromium.org/122001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18114 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement BlockedPopupContainerView for linux.erg@google.com2009-06-1010-29/+383
| | | | | | | | | | | | | | | | This doesn't have: - rounded corners - gradient background - animating in or out. - graphical polish but it is fucntionally complete. http://crbug.com/12843 Review URL: http://codereview.chromium.org/118480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18113 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18109, 18111: Windows UI tests failed.agl@chromium.org2009-06-106-362/+27
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18112 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor zygote supportagl@chromium.org2009-06-106-27/+362
| | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxZygote * Move Chrome specific bits out of base * Move away from the idea of reserved file descriptors (which don't really work with zygotes) * Load resources before forking renderers (means that we don't need communication between the zygote process and the renderers) * Make sure that gdb works against the browser again * Make sure that we have different ASLR between the renderers and the browser. http://codereview.chromium.org/119335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18109 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at tall titlebar and custom window frame.tc@google.com2009-06-104-28/+196
| | | | | | | | | | | | | | | | | | | This implements the tall titlebar with the XP frame buttons, which should work if your window manager supports them. The titlebar background is drawn by the containing hbox. It would be nice if the tab strip could be made transparent so it wouldn't need to paint a background itself, but I didn't know how to do that. I still need to implement the frame resizing, frame coloring and move the context menu from the tab strip to the titlebar. BUG=13430 Review URL: http://codereview.chromium.org/119371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18107 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in unit_testsbrettw@google.com2009-06-101-14/+9
| | | | | | | | BUG=13733 Original review: http://codereview.chromium.org/119444 Patch by Meelap Shah git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18106 0039d316-1c4b-4281-b951-d872f2087c98
* Add an exact-match Keychain search, with unit tests; groundwork for a more ↵stuartmorgan@chromium.org2009-06-103-38/+315
| | | | | | | | | | complete Keychain implementation. BUG=none TEST=none Review URL: http://codereview.chromium.org/119377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18103 0039d316-1c4b-4281-b951-d872f2087c98
* Show the remaining time in the downloads page.arv@google.com2009-06-101-2/+2
| | | | | | | | | | BUG=13386 TEST=Download a large file and make sure that you see the speed in the donwloads page. Review URL: http://codereview.chromium.org/119428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18102 0039d316-1c4b-4281-b951-d872f2087c98
* Fix UMR in ExtensionCreator.aa@chromium.org2009-06-101-2/+3
| | | | | | Review URL: http://codereview.chromium.org/119443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18101 0039d316-1c4b-4281-b951-d872f2087c98
* Do not allow URL drops on app windows to cause a navigation awaytc@google.com2009-06-108-0/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | from the currently loaded site. We are careful in this patch to continue to allow dropping URLs in text fields within the app window, and behavior for normal browser windows remains as before. There is a slight glitch when dragging a to an app window on the border of the window. Even though it is very brief, it is still disturbing. BUG=7171 TEST=Open Chrome (1), load google.com. Open Chrome (2), load yahoo.com. Drag a link from 1 to 2 and a link from 2 to 1 (both allowed). Create an app shortcut from 1, drag a link from 1 to 2 (allowed) and a link from 2 to 1 (denied). Verify that link scan be dragged to the omnibox and to text fields. Patch by Chase Phillips <chase@chromium.org> via http://codereview.chromium.org/119298 Review URL: http://codereview.chromium.org/121003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18100 0039d316-1c4b-4281-b951-d872f2087c98
* Use the convenience function gdk_screen_get_window_stack to enumerate ↵jhawkins@chromium.org2009-06-101-11/+14
| | | | | | | | | | top-level gdk windows instead of querying Xlib directly, which doesn't work across many window managers. BUG=none TEST=Exhaustive tab dragging in multiple window managers (Compiz, Metacity, KWM). Review URL: http://codereview.chromium.org/119345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18098 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tree bustagecpu@google.com2009-06-101-1/+0
| | | | | | | | | | | TEST=none BUG=none TBR=nsylvain Review URL: http://codereview.chromium.org/120003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18096 0039d316-1c4b-4281-b951-d872f2087c98
* Fix uninitialized ExtensionView::pending_preferred_width_.mpcomplete@google.com2009-06-101-1/+1
| | | | | | | BUG=13103 Review URL: http://codereview.chromium.org/119389 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18095 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix Firefox profile path for import.kuchhal@chromium.org2009-06-101-0/+2
| | | | | | | | BUG=13270 Review URL: http://codereview.chromium.org/118526 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18094 0039d316-1c4b-4281-b951-d872f2087c98
* UI part of the try chrome toastcpu@google.com2009-06-102-1/+276
| | | | | | | | | | | | | - experimental. 'en' only - modal dialog is farily custom BUG=none TEST=none Review URL: http://codereview.chromium.org/118510 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18093 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18090jrg@chromium.org2009-06-109-221/+90
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18092 0039d316-1c4b-4281-b951-d872f2087c98
* To help resolve the performance issue introduced when enabling the resize ↵mad@google.com2009-06-109-90/+221
| | | | | | | | corner, we now keep all non-intersecting rects separately and send an array of invalidation bitmaps via IPC as opposed to a single unionized rect :-) Review URL: http://codereview.chromium.org/108040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18090 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors tab overview and gets the rest of the chunks working. I'vesky@chromium.org2009-06-1013-310/+916
| | | | | | | | | | | | | | | | refactored it so that there is a clear object responsible for dragging and the controller now controls it all. There is some common code between TabOverviewDragController and DraggedTabController. I will try and share some code between these two later. BUG=none TEST=none Review URL: http://codereview.chromium.org/118513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18089 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the prepended manifest from the crx format. Now we just have the ↵aa@chromium.org2009-06-106-130/+109
| | | | | | | | header, the public key, the signature, and the zip. Review URL: http://codereview.chromium.org/118490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18088 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-11 11:53:18 +0000