summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Use the right frame type on startup, do proper swapping of frames when ↵glen@chromium.org2009-05-316-6/+21
| | | | | | | | | | | themes change. Leave the native frame decision up to the ThemeProvider. BUG=12890 TEST=In Aero, unstall a theme, reset to default, install again, restart, reset theme to default. Make sure that the Aero frame changes to the themed frame and back again appropriately. Review URL: http://codereview.chromium.org/118053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17301 0039d316-1c4b-4281-b951-d872f2087c98
* Address post-lgtm comment from Evan. No functionality change.thakis@chromium.org2009-05-311-1/+1
| | | | | | | | | | | | BUG=none TEST=none TBR=evanm Review URL: http://codereview.chromium.org/118054 Review URL: http://codereview.chromium.org/118054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17299 0039d316-1c4b-4281-b951-d872f2087c98
* Don't crash on find on OS X and Linux. Bug introduced by r17285.thakis@chromium.org2009-05-311-1/+1
| | | | | | | | | BUG=none TEST=Hit ctrl-f in Linux or OS X and check that chrome doesn't crash. Review URL: http://codereview.chromium.org/115979 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17298 0039d316-1c4b-4281-b951-d872f2087c98
* Linux and Mac support chrome://history by now. Remove NOTIMPLEMENTED.thakis@chromium.org2009-05-311-4/+0
| | | | | | | | | | | | Review url: http://codereview.chromium.org/115976 BUG=none TEST=On Linux, open google.com, then wikipedia.com in the same tab. Then click and hold on back button, select "Show Full History" in the appearing popup, and make sure a tab with the history opens. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17297 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Windows build by adding necessary headers.brettw@chromium.org2009-05-312-0/+2
| | | | | | Review URL: http://codereview.chromium.org/115975 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17296 0039d316-1c4b-4281-b951-d872f2087c98
* Split out the views table functions into separate header files. Many users onlybrettw@chromium.org2009-05-3119-11/+39
| | | | | | | | | | | | | | need either the view or model observers and that's it. I moved the model constructors to a .cc file so we don't have to include l10n_util.h for everybody. A surprising number of files were getting l10n_util from the table code, so I had to add it in a bunch of places. There should be no code change except I made the table column cosntructors take wstring references instead of copies. Review URL: http://codereview.chromium.org/115969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17295 0039d316-1c4b-4281-b951-d872f2087c98
* Add a "User Data" tab to the options, remove the "minor tweaks" tabmhm@chromium.org2009-05-303-378/+487
| | | | | | | | | | | | Add new option fields to the "User Data" tab and reorganize the "Under the Hood" to fit a better User Experience. RELANDING http://codereview.chromium.org/113896 TBR=ben Review URL: http://codereview.chromium.org/115971 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17294 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 17288 - Test failures.mhm@chromium.org2009-05-303-489/+378
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/115968 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17289 0039d316-1c4b-4281-b951-d872f2087c98
* Create a "User data" tab and remove the "minor tweaks" tab. The mockup is ↵mhm@chromium.org2009-05-303-378/+489
| | | | | | | | | | | | | included in the issue. Add new option fields to the "User Data" tab and reorganize the "Under the Hood" to fit a better User Experience. BUG=11435 (http://crbug.com/11435) TEST=Opened the option dialog and checked if functional. Review URL: http://codereview.chromium.org/113896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17288 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage by fixing defines not to include windows.ben@chromium.org2009-05-302-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17286 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to make a browser window come up with TOOLKIT_VIEWS.ben@chromium.org2009-05-305-0/+16
| | | | | | | | | | | TBR=sky BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17271 Review URL: http://codereview.chromium.org/116007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17285 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux compilation for printmhm@chromium.org2009-05-301-0/+2
| | | | | | Review URL: http://codereview.chromium.org/115966 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17284 0039d316-1c4b-4281-b951-d872f2087c98
* Add --print command line argument to print a webpagemhm@chromium.org2009-05-301-0/+7
| | | | | | | | | | | | Added a new chrome switch called "print" and after the urls are being loaded, I call the last active browser and print the selected tab. BUG=6942 (http://crbug.com/6942) TEST=Added command line arguments [chrome.exe --print http://google.ca and the print dialog appeared for the selected tab component. based on: http://codereview.chromium.org/100027 Review URL: http://codereview.chromium.org/118048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17283 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce a max length for document titles.abarth@chromium.org2009-05-301-0/+5
| | | | | | | | | | R=deanm BUG=http://crbug.com/12810 TEST=None Review URL: http://codereview.chromium.org/113969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17282 0039d316-1c4b-4281-b951-d872f2087c98
* Fix project file for reverting 17273mhm@chromium.org2009-05-301-2/+1
| | | | | | Review URL: http://codereview.chromium.org/115965 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17280 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 17273 - Fails reliability testsmhm@chromium.org2009-05-308-124/+157
| | | | | | Review URL: http://codereview.chromium.org/118047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17279 0039d316-1c4b-4281-b951-d872f2087c98
* linux: save window positions.evan@chromium.org2009-05-303-10/+36
| | | | | | | | | | | | | I followed the Windows code rather than the Mac code, and saved whenever the window is moved. Note that we only restore window *size*, not position. We looked at every software we could find and none restored position. BUG=12374 Review URL: http://codereview.chromium.org/115932 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17277 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity underground warfare: Uninitalized membercpu@google.com2009-05-301-1/+5
| | | | | | | | | | | | - Fix ctor to init members - CID 4186 BUG = none TEST = well, it is a unit test Review URL: http://codereview.chromium.org/112076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17276 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity underground warfare: Uninitalized membercpu@google.com2009-05-301-1/+3
| | | | | | | | | | | | - Fix ctor to init members - CID 4187 BUG = none TEST = none Review URL: http://codereview.chromium.org/118035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17275 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 17271.ben@chromium.org2009-05-305-16/+0
| | | | | | Review URL: http://codereview.chromium.org/118040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17274 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land the password store work from bug 8205, with changes that should fix ↵stuartmorgan@chromium.org2009-05-3018-155/+1339
| | | | | | | | | | bug 12479. The Linux pieces are still disabled, however. BUG=8205 TEST=Password autofill should continue to work on Windows. Review URL: http://codereview.chromium.org/114057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17273 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to make a browser window come up with TOOLKIT_VIEWS.ben@chromium.org2009-05-305-0/+16
| | | | | | | | | TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/116007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17271 0039d316-1c4b-4281-b951-d872f2087c98
* Revert Changes to stop tests breaking.sidchat@google.com2009-05-302-5/+0
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/112077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17270 0039d316-1c4b-4281-b951-d872f2087c98
* Possible fix for UnitTestFailuresidchat@google.com2009-05-301-1/+1
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/115962 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17268 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 6223 - Drag and drop a new tab from RTL Chrome: the ↵xji@chromium.org2009-05-291-1/+4
| | | | | | | | | | | | | | docked window usually showing out of current screen The problem is that the dragged tab view is not rendered correctly in RTL locale. The view should be rendered in a position that the mouse is on tabstrip, which is consistent with the position in which the view will be docked when mouse release. The root cause is the dragged tab view's width is calculated incorrectly in RTL locale. BUG=http://crbug.com/6223 TEST=Open Chrome in Hebrew, drag and drop a tab, observe the tab view while dragging, the view should be rendered in a position that the mouse is on tabstrip. Review URL: http://codereview.chromium.org/115938 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17263 0039d316-1c4b-4281-b951-d872f2087c98
* Changed the status bar size to adapt to the size of the font,mirandac@chromium.org2009-05-293-32/+45
| | | | | | | | | | | | | instead of being a const. BUG= http://crbug.com/1275 TEST=Set Windows XP font size to large or extra-large. Open Chrome. Hover over a link to bring up the status bubble. Text should sit comfortably in bubble, without being squeezed. Review URL: http://codereview.chromium.org/113490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17262 0039d316-1c4b-4281-b951-d872f2087c98
* The ShelfItemDialog has an accelerator for Enter.jcampan@chromium.org2009-05-292-2/+9
| | | | | | | | | | | | Since it also had a default button (that would also register an accelerator for Enter), there would be an assertion failure when unregistering the first accelerator. Also removed the Esc accelerator (it is already handled by the dialog by default). BUG=12922 TEST=Repro the scenario described in bug. Review URL: http://codereview.chromium.org/115956 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17260 0039d316-1c4b-4281-b951-d872f2087c98
* Do not autocorrect words in capital letters, or having capital letters in ↵sidchat@google.com2009-05-292-0/+5
| | | | | | | | | | between, as they may refer to acronyms or terms not in the dictionary. BUG = www.crbug.com/12921 TEST = Type CLD (a library), should not change back to LCD Review URL: http://codereview.chromium.org/118008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17259 0039d316-1c4b-4281-b951-d872f2087c98
* Really theme the find bar. We were previously getting the ↵glen@chromium.org2009-05-292-2/+2
| | | | | | | | | | | | | | DefaultThemeProvider (whose accessor was mistakenly named 'getDIALOGthemeprovider') BUG=11702 TEST=Install a theme and verify that the find bar matches it. TBR=finnur Review URL: http://codereview.chromium.org/115729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17257 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some review comments I missed in the previous checkin of this file.brettw@chromium.org2009-05-291-4/+11
| | | | | | | Previous review: http://codereview.chromium.org/113909/diff/16/17 Patch my Meelap Shah git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17256 0039d316-1c4b-4281-b951-d872f2087c98
* More views on gtk work: NativeViewPhotoboothGtk, adds a missing methodsky@chromium.org2009-05-293-0/+76
| | | | | | | | | | | to NativeViewHostGtk and location bar view colors. BUG=none TEST=none Review URL: http://codereview.chromium.org/115958 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17255 0039d316-1c4b-4281-b951-d872f2087c98
* When copying urls in the render view context menu, copy them to PRIMARY as ↵estade@chromium.org2009-05-294-12/+27
| | | | | | | | | | well as CLIPBOARD. BUG=12716 Review URL: http://codereview.chromium.org/115949 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17254 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a slew of random link/compile errors for views on gtk.sky@chromium.org2009-05-299-13/+109
| | | | | | | | | BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/115948 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17246 0039d316-1c4b-4281-b951-d872f2087c98
* Revert Revision 17224glen@chromium.org2009-05-292-2/+2
| | | | | | | | | BUG=none TEST=non Review URL: http://codereview.chromium.org/115951 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17245 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the Omnibox when changing tabs while its contents have been deleted.pkasting@chromium.org2009-05-299-26/+51
| | | | | | | | | To do this, I needed to add a new TabStripModelObserver call that fired before the tab had been changed, since when the Omnibox asks for the current permanent_text_ it gets it from the selected tab's navigation controller. BUG=6850 Review URL: http://codereview.chromium.org/113983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17241 0039d316-1c4b-4281-b951-d872f2087c98
* Allow themes to be installed without any commandline flag, still require ↵glen@chromium.org2009-05-294-41/+104
| | | | | | | | | | | flag for Extensions. Expand themes unittests. BUG=12205,12231 TEST=Without any flags, try installing an extension and a theme. The extension should fail and the theme should succeed. Attempts to install a theme with extension components in the manifest should similarly result in failure. Review URL: http://codereview.chromium.org/115798 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17240 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 17223 (http://codereview.chromium.org/115943). Seems to make ↵robertshield@google.com2009-05-291-4/+3
| | | | | | | | | | interactive UI tests unhappy. TBR=tommi Review URL: http://codereview.chromium.org/118029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17239 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up temporary files/folders in firefox importer tests.munjal@chromium.org2009-05-291-0/+4
| | | | | | Review URL: http://codereview.chromium.org/115930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17238 0039d316-1c4b-4281-b951-d872f2087c98
* Be less aggressive about resizing Chrome windows when restoring them. ↵pkasting@chromium.org2009-05-292-153/+137
| | | | | | | | Original patch by Yuzo Fujishima (see http://codereview.chromium.org/115180 ), r=me. BUG=9587 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17233 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore the insert key so we don't switch into overtype mode (which surprises ↵pkasting@chromium.org2009-05-291-0/+5
| | | | | | | | | | users since there's no indicator of it). BUG=6856 TEST=In Omnibox or in a native textfield (e.g. the "Add a site" URL field for the Options dialog's "Open these sites at startup" pref), type text, set cursor at beginning, hit insert, and type. Your text should prepend to the existing text instead of replacing it. Review URL: http://codereview.chromium.org/115934 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17231 0039d316-1c4b-4281-b951-d872f2087c98
* Properly display mnemonics in some gtk menus where they were not being ↵estade@chromium.org2009-05-292-15/+12
| | | | | | | | | | | escaped and showed up as &. Get rid of manual escaping in bookmark context menu gtk. BUG=12868 Review URL: http://codereview.chromium.org/118024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17228 0039d316-1c4b-4281-b951-d872f2087c98
* Remove code path that passes a file handle to the rendererhclam@chromium.org2009-05-299-241/+10
| | | | | | | | | | | | | | | | | | | | | | Since the code now does range request without any caching the code path for passing file handle is not used any more. Changes: 1. Remove response_data_file in webkit_glue::ResourceResponseHead 2. Remove response_data_file in net::ResourceInfo 3. Remove code that passes file handle using IPC 4. Remove code that passes file hadnle from network layer to ResourceDispatcherHost 5. Remove MediaResourceHandler 6. Remove code in disk_cache that expose the file handle 7. Remove ChromeURLRequestContext::CreateOffTheRecordForMedia() so no more OTR request context for media, in OTR mode simply memory cache is used 8. Reset cache size for media cache to default BUG=12249 BUG=12256 Review URL: http://codereview.chromium.org/113931 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17227 0039d316-1c4b-4281-b951-d872f2087c98
* Really theme the find bar. We were previously getting the ↵glen@chromium.org2009-05-292-2/+2
| | | | | | | | | | | DefaultThemeProvider (whose accessor was mistakenly named 'getDIALOGthemeprovider') BUG=11702 TEST=Install a theme and verify that the find bar matches it. Review URL: http://codereview.chromium.org/115729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17224 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid DCHECKING on NEW_FOREGROUND_TAB and NEW_BACKGROUND_TAB dispositions in ↵robertshield@google.com2009-05-291-3/+4
| | | | | | | | ExternalTabContainer by re-routing those dispositions to new popups. Review URL: http://codereview.chromium.org/115943 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17223 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a browser crash that occurs if the extension unpacker process crashesmpcomplete@google.com2009-05-291-2/+15
| | | | | | | | | | after it sends a response to the browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/113867 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17222 0039d316-1c4b-4281-b951-d872f2087c98
* Renames BackForwardMenuModelWin to BackForwardMenuModelViews.sky@chromium.org2009-05-295-27/+28
| | | | | | | | | BUG=NONE TEST=none Review URL: http://codereview.chromium.org/118001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17221 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: show tab context menu on mousedown rather than mouse up.estade@chromium.org2009-05-291-2/+2
| | | | | | | | TEST=right click on a tab and see a context menu popup (i.e. no regression). Also, right click, hold, drag, release to select an item. Review URL: http://codereview.chromium.org/118023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17218 0039d316-1c4b-4281-b951-d872f2087c98
* Put findbar close button back where it belongs.estade@chromium.org2009-05-291-1/+1
| | | | | | | | TBR=deanm Review URL: http://codereview.chromium.org/115935 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17217 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Bookmark bar slide animation.estade@chromium.org2009-05-292-6/+52
| | | | | | | also improve the look of the instructions label. Review URL: http://codereview.chromium.org/112070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17216 0039d316-1c4b-4281-b951-d872f2087c98
* Gets TabIconView compiling on linux.sky@chromium.org2009-05-291-2/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115905 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17210 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 06:29:57 +0000