summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Minimize dependency of user scripts.mad@chromium.org2009-10-204-11/+20
| | | | | | | | | | | And made some minor lint fixes and code refactoring on the way, based on CR comments of previous attempt. BUG=none TEST=Make sure that the extension resources can still be properly localized and that they also load correctly when they are not localized. Review URL: http://codereview.chromium.org/267051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29512 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: change PIDs to base::ProcessId (or pid_t, as appropriate).viettrungluu@chromium.org2009-10-202-2/+2
| | | | | | | | | | | We probably want to discourage the use of ints for PIDs. This is a start; there are many other places where we should fix this. BUG=25272 TEST=none Review URL: http://codereview.chromium.org/300010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29511 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29457, because this is making ExtensionBrowserTest.PageAction crash ↵nsylvain@chromium.org2009-10-207-48/+87
| | | | | | | | | | | | | | | | | | | | on Vista Original description: Implement badges for page actions. Also add badge text color API. Also change color APIs from wanting ARGB to RGBA. BUG=24635 BUG=24644 BUG=25215 Review URL: http://codereview.chromium.org/291003 TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/306004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29509 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle extension reloading in the task manager.phajdan.jr@chromium.org2009-10-207-5/+69
| | | | | | | | | BUG=18693 TEST=Added new tests to browser_tests. Review URL: http://codereview.chromium.org/300005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29498 0039d316-1c4b-4281-b951-d872f2087c98
* add enableWebSockets in WebKit APIukai@chromium.org2009-10-201-2/+0
| | | | | | | | | | | | and remove experimentalWebSocketsEnabled from WebPreferences/Settings. Patch for http://bugs.webkit.org/show_bug.cgi?id=29896 will remove Settings::experimentalWebSocketsEnabled(), so we need to remove it from WebPreferences too. This is because such configuration in Settings confuses other WebKit developers and such control is only required for chromium. Instead add WebKit::enableWebSockets() in this change to control WebSockets feature. Review URL: http://codereview.chromium.org/292012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29497 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome.browserAction.setIcon({path:...});aa@chromium.org2009-10-203-103/+132
| | | | | | | | BUG=22575 Review URL: http://codereview.chromium.org/269103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29495 0039d316-1c4b-4281-b951-d872f2087c98
* Add the first event ui test + a bunch of refactoring.jorlow@chromium.org2009-10-201-26/+80
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/271020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29491 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit up to 49830 and fix a build error caused by that revision.jorlow@chromium.org2009-10-201-1/+1
| | | | | | | | | | TBR=yutak TEST=none BUG=none Review URL: http://codereview.chromium.org/294017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29489 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK.thakis@chromium.org2009-10-202-0/+8
| | | | | | | | | BUG=none TEST=Focus background of google.com, hit "a". Shouldn't DCHECK. Review URL: http://codereview.chromium.org/297017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29488 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use gtk_dialog_run for extension install errors becausetony@chromium.org2009-10-203-6/+6
| | | | | | | | | | it blocks the main message loop. BUG=19441 Review URL: http://codereview.chromium.org/294014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29482 0039d316-1c4b-4281-b951-d872f2087c98
* Add dialog to tell user to close Firefox during import, if it's open and ↵mirandac@chromium.org2009-10-203-2/+53
| | | | | | | | | | | blocking. OS-Mac only. BUG= http://crbug.com/20899 TEST= Open Firefox; start up Chrome and try to import settings from Firefox. Dialog box warns you to close Firefox. Review URL: http://codereview.chromium.org/283023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29481 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate PathService::Get(..., wstring*) and use FilePath instead.evan@chromium.org2009-10-197-28/+39
| | | | | | | | | | | | I tried fixing all the Windows code but there's a *ton* of it. This change will at least prevent people from adding new code that uses the deprecated version (as that won't compile on Lin/Mac). BUG=24672 Review URL: http://codereview.chromium.org/293013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29472 0039d316-1c4b-4281-b951-d872f2087c98
* (Copy of previous CL that existed in a client I lost)cevans@chromium.org2009-10-191-3/+10
| | | | | | | | | | | | | - Don't treat the body of an "authentication required" response as a valid dictionary! - In the event of a 200 status code, check the response actually looks like a dictionary. BUG=24486 TEST=Verified the appearance of new dictionaries after changing spell-check language; verified spell-checking on new dictionaries. TBR=sidchat Review URL: http://codereview.chromium.org/295014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29471 0039d316-1c4b-4281-b951-d872f2087c98
* Delete unused themes from disk on shutdown.tony@chromium.org2009-10-193-1/+27
| | | | | | | | | | | | This reduces the size of the Preferences file and frees up some disk space. The smaller Preferences file should help improve startup time for users who have installed lots of themes. BUG=24377 Review URL: http://codereview.chromium.org/303006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29468 0039d316-1c4b-4281-b951-d872f2087c98
* Degrade the https color and lock icon for the page that has a worker that ↵dimich@google.com2009-10-195-43/+135
| | | | | | | | | | | loads subresource with bad cert. The idea is to make UI reflect loading of resources with bad certificates that were previously approved by the user. bug=20176 TEST=SSLUITest.TestUnsafeContentsInWorker unit_test. Review URL: http://codereview.chromium.org/268006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29461 0039d316-1c4b-4281-b951-d872f2087c98
* Make window cycling work even if you change it to something else than cmd-` ↵thakis@chromium.org2009-10-196-49/+83
| | | | | | | | | | | | | in sysprefs. Instead of just dispatching to the menu after a key comes back from the renderer, do a complete re-dispatch to NSApp (so that the event gets to the menu and cmd-` handlers) but then ignore it when it comes back to the web (because we already sent this event to the renderer once). BUG=24817 TEST=Open sysprefs, change keyboard shortcut for "Move focus to next window in active application" to e.g. cmd-\. Open two chrome windows, focus the web, hit cmd-\. It should switch windows. All other keyboard shortcuts should still work (test that ctrl-tab works when web has focus, test backspace when text field is focussed in web, when background is focussed in web, when IME is active, test hitting cmd-1/2 when omnibox or web have focus, hit cmd-left when omnibox, textbox in web, background in web has focus, test that cmd-f in docs still opens doc's find interface) Review URL: http://codereview.chromium.org/303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29458 0039d316-1c4b-4281-b951-d872f2087c98
* Implement badges for page actions. Also add badge text color API.mpcomplete@chromium.org2009-10-197-87/+48
| | | | | | | | | | | | Also change color APIs from wanting ARGB to RGBA. BUG=24635 BUG=24644 BUG=25215 Review URL: http://codereview.chromium.org/291003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29457 0039d316-1c4b-4281-b951-d872f2087c98
* Parse input with explicit schemes better. Before, if the user typed ↵pkasting@chromium.org2009-10-192-26/+59
| | | | | | | | | | "http://..." we always parsed as a URL. Now we parse more like we would without the scheme, so that we can reject various kinds of invalid inputs. BUG=none TEST=Input "http://foo:bar" (without quotes) in the address bar, and the default action should be search, not navigate. Review URL: http://codereview.chromium.org/292003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29450 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/272036 for Thiago:sky@chromium.org2009-10-1910-36/+36
| | | | | | | | | | | | | | Rename GetType and SetType using the Unix style to match with the other usages in BookmarkNode. GetType -> type SetType -> set_type BUG=None TEST=None Review URL: http://codereview.chromium.org/297005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29443 0039d316-1c4b-4281-b951-d872f2087c98
* Beef-up a DCHECK_NE case in browser_sync::ChangeProcessor to return early if ↵tim@chromium.org2009-10-191-4/+8
| | | | | | | | | | | | one of the permanent nodes are changed by a bookmark model event. I think we may hit a roadblock a bit deeper down right now and not actually poison the user's cloud state, but it seems best to catch this at first-chance. BUG=25067 Review URL: http://codereview.chromium.org/295007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29437 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the spellchecker and associated messages and functions to use string16brettw@chromium.org2009-10-1920-181/+183
| | | | | | | | | | | | for words instead of wstring. I also changed some places where it converted the word to a string to do that conversion at the last possible second before giving it to Hunspell (since this conversion isn't needed for Mac). TEST=Covered by unit tests BUG=none Review URL: http://codereview.chromium.org/274077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29435 0039d316-1c4b-4281-b951-d872f2087c98
* Support the Bookmark bar and Other bookmarks titles in titlecase.thomasvl@chromium.org2009-10-191-0/+6
| | | | | | | | TEST=the bookmark bubble menu should have title case items for the two. BUG=24912 Review URL: http://codereview.chromium.org/297004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29431 0039d316-1c4b-4281-b951-d872f2087c98
* Use SSL to fetch the "known plug-ins" list.cevans@chromium.org2009-10-191-1/+1
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/280002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29430 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the history URL provider to handle input of type QUERY. This helps in ↵pkasting@chromium.org2009-10-197-157/+97
| | | | | | | | | | | | | | | | the case where the user types something that on its own isn't navigable, but might be the prefix of something else navigable. While there are no tests for this directly, another change of mine to treat more inputs with explicit schemes as queries (e.g. "http:/") relies on this, and does unittest for it. In order to fit the new relevance scores into the table, I went through and simplified the relevance scoring so that generally providers used the same scores for more input types. The effects of this should be barely noticeable (it affects the ranking of past search queries that are old against results from the secondary search provider), and it simplifies the code noticeably. This also fixes a "bug" that the NavSuggest results were incremented backwards, but since we only score one of these right now there's no visible effect. BUG=none TEST=none Review URL: http://codereview.chromium.org/291005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29428 0039d316-1c4b-4281-b951-d872f2087c98
* Make importer obey import_search_engine preference even if FRUI is enabled.kuchhal@chromium.org2009-10-1911-28/+91
| | | | | | | | | | | | With this change importer will give preference to the value specified in master preference for import_search_engine instead of ignoring it like before. BUG=23649 TEST=Specified in above bug. Review URL: http://codereview.chromium.org/274081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29426 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetDistroBooleanPreference return troolean value.kuchhal@chromium.org2009-10-191-9/+17
| | | | | | | | | BUG=23649 TEST=installer_util_unittests, setup_unittests Review URL: http://codereview.chromium.org/269107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29423 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix compile errors in extension_creatorevan@chromium.org2009-10-191-9/+18
| | | | | | | | | | | | New code added more fwrite calls where the return code isn't handled, causing compile errors on Fedora and other platforms. While we're at it, use the new PLOG interface. BUG=24347 Review URL: http://codereview.chromium.org/300007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29421 0039d316-1c4b-4281-b951-d872f2087c98
* When Chrome hands off a URL to be opened by the external host by the ↵ananta@chromium.org2009-10-194-5/+6
| | | | | | | | | | | | | | | | | | | | | | | ViewHostMsg_OpenURL IPC, it needs to pass the referrer as well. The Chrome fixes in this CL are mostly related to passing the HTTP referer off to the browser and from there to the ExternalTabContainer to ChromeFrame and back. The ChromeFrame changes are basically around the same lines with one exception. When we handle the AutomationMsg_OpenURL IPC in the activex and the active document we pass the referer if applicable to the WebBrowser2::Navigate2 interface, which is then read by the BHO in BeforeNavigate2. We then save away an AddRef'ed BHO pointer in TLS which is then referenced by the Active document for reading the referer and passing it off to Chrome in the NavigateInExternalTab message. Added a unit test in ChromeFrame which tests this case. This fixes http://code.google.com/p/chromium/issues/detail?id=22994 Bug=22994 Review URL: http://codereview.chromium.org/274071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29420 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a crash where RenderWidgetHostViewWin tries to access a ↵eroman@chromium.org2009-10-191-1/+8
| | | | | | | | | | deleted RenderWidgetHost during OnFinalMessage(). BUG=24248 Review URL: http://codereview.chromium.org/284019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29418 0039d316-1c4b-4281-b951-d872f2087c98
* Do work necessary to make Views About panel work on Chrome OS. This is to be ↵davemoore@chromium.org2009-10-197-25/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | used for forcing Chrome OS updates. There were many things that needed to be fixed for this to work. Make skia's canvas return height of font for size of strings, instead of the actual height of the characters to bring it in line with Windows. Make average character widths use pango metrics and windows dialog units. Make this lazy, to avoid most calls. Fix bug in About panel that failed to adjust the embedded links to allow for the padding that Link adds so they can be focused. Support gtk about panel in regular build, views in chrome os only. Fix WindowGtk to call WindowClosing() Fix canvas_linux::SetupPangoLayout() to wrap correctly, if passed a width Fix Label::ComputeMultiLineFlags() to turn off eliding. With eliding the pango routines always return 1 line. Enable focus manager in dialogs. Version loader crashed in debug. Review URL: http://codereview.chromium.org/282002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29414 0039d316-1c4b-4281-b951-d872f2087c98
* First fix to minimize copying of image data.erg@google.com2009-10-1924-89/+112
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is the first of multiple patches that clean up handling of memory regarding images. Previously, the code did several memcpy()s or equivalents. This change: - Creates an abstract interface RefCountedMemory which provides access to the front() of a memory range and the size() of it. It is a RefCountedThreadSafe. - Adds a RefCountedStaticMemory class which isa RefCountedMemory. - Pushes RefCountedBytes up into base/ from chrome/ and make it conform to RefCountedMemory. - Have ResourceBundle return RefCountedStaticMemory to the mmaped() or DLL loaded resources instead of memcpy()ing them. - General cleanups to minimize copies in constructing RefCountedBytes. - Use the above consistent interface in the BrowserThemeProvider, along with special casing the loading of the new tab page background. This patch is mostly cleanups and there should only be a slight performance gain if any. Most of the real speedups should come in subsequent patches. BUG=http://crbug.com/24493 TEST=Slightly faster on Perf bot; does not introduce crashes. Review URL: http://codereview.chromium.org/288005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29412 0039d316-1c4b-4281-b951-d872f2087c98
* Add NOTREACHED for someone trying to change the title on the bookmark bar ↵thomasvl@chromium.org2009-10-191-0/+5
| | | | | | | | | | folder or other bookmarks folders. TEST=none BUG=25067 Review URL: http://codereview.chromium.org/293006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29409 0039d316-1c4b-4281-b951-d872f2087c98
* Adding bug link to TODOs; no code change.avi@chromium.org2009-10-192-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/304002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29407 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused code; the code that now implements this is in ↵avi@chromium.org2009-10-191-14/+0
| | | | | | | | | | | chrome_browser_window.mm as of r28613. BUG=none TEST=none Review URL: http://codereview.chromium.org/304001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29406 0039d316-1c4b-4281-b951-d872f2087c98
* Don't delay menu item fixup when the number of tabs change.pinkerton@chromium.org2009-10-191-1/+5
| | | | | | | | BUG=24878 TEST=cmd-w/cmd-shift-w are always correct for close-tab/close-window when window layering changes. Review URL: http://codereview.chromium.org/283017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29397 0039d316-1c4b-4281-b951-d872f2087c98
* Short-circuit events rwhvmac if it's focussed.thakis@chromium.org2009-10-193-38/+35
| | | | | | | | | | | This way the key view loop can't steal our events. This effectively reverts part of http://codereview.chromium.org/242069 and instead takes a bit from http://codereview.chromium.org/271054 . BUG=24921 TEST=Open 2 tabs. Focus web. Ctrl-tab should switch tabs. Cmd-1/2 should switch tabs. Hitting backspace should go back if no textbox is focusses in the web, else it should delete in the textbox. Hitting cmd-f in docs should still open docs custom search interface. Review URL: http://codereview.chromium.org/300002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29396 0039d316-1c4b-4281-b951-d872f2087c98
* Make backspace not go back while IME is active.thakis@chromium.org2009-10-195-4/+12
| | | | | | | | | | | Linux does this in GtkIMContextWrapper::ProcessFilteredKeyPressEvent() by setting hardware_keycode to 0. It's a pain to change an NSEvent, so I just added a bool "skip" to NativeWebKeybordEvent and set it to "true" for rawkeydowns while ime is active. BUG=25000 TEST=Open webpage. Focus text field. Type something, hit backspace. Text should be deleted. Focus background, hit backspace. Browser should go back one page. Focus text field, start IME (either by going to syspref->international->input menu and enabling e.g. "Kotoeri" and then selecting this in the top right corner and typing a single "a", or by just activating dead key ime on an us layout by hitting opt-u, opt-i, or opt-e), hit backspace. Browser should not go back but end IME mode. Review URL: http://codereview.chromium.org/295003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29388 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=23107 Last character of completed path in Omnibar is the wrong color ↵suzhe@chromium.org2009-10-191-7/+37
| | | | | | | | | | | | after inline autocomplete BUG=24818 Funky behavior in omnibar editing TEST=Run chromium with a clean profile, then access go/go (or similar url) for several times to make sure inputting 'g' can trigger inline autocomplete. Then input "go/go" and then check if the last char is gray. TEST=Input something into omnibox to trigger inline autocomplete, then press ctrl-right and hold ctrl key, to move the cursor and clear the text selection, then release ctrl key, the text added by inline autocomplete should not be removed. Review URL: http://codereview.chromium.org/287005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29387 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up use of scoped_nsobject<NSAutoreleasePool>. I have a CL coming laterdmaclach@chromium.org2009-10-191-2/+2
| | | | | | | | | | | that will protect us against these in the future. BUG=none TEST=none Review URL: http://codereview.chromium.org/283026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29382 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome_url_overides to work with packed extensions.erikkay@chromium.org2009-10-172-30/+22
| | | | | | | | | | | | | | The InitFromValue code was modifying the JSON with some local data which was then being re-used by the unpacker and sent up to the browser which caused it to use this temporary local data as if it was the original manifest source. BUG=24398 TEST=pack and install override_igoogle extension Review URL: http://codereview.chromium.org/276074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29376 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ProfileSyncService unit test.nick@chromium.org2009-10-176-86/+80
| | | | | | | | | | | | | | | | | | | | | Create TestHttpBridge for use by ProfileSyncServiceUnittest, so it doesn't crash. DoInitialize has been changed to take a HttpPostProviderFactory before the core initialization. The HttpBridge is now created on the UI thread instead of the core thread. Create fake tagged nodes in the order that they are requested. Make the request order consistent and in visual order since this is the most natural way to request them. TEST=Ran the affected unit tests on Windows, tested basic sync functionality with two concurrent browsers. BUG=25021 Review URL: http://codereview.chromium.org/292008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29368 0039d316-1c4b-4281-b951-d872f2087c98
* Set os_error to net::ERR_ABORTED instead of 0 or net::ERR_FAILED whenwtc@chromium.org2009-10-172-2/+2
| | | | | | | | | | | we set the status of a URLRequestStatus to URLRequestStatus::CANCELED. R=eroman BUG=24674 TEST=none Review URL: http://codereview.chromium.org/269064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29367 0039d316-1c4b-4281-b951-d872f2087c98
* Allow slightly larger browser and page action icons.aa@chromium.org2009-10-176-31/+52
| | | | | | | | | | | | | | | | | | | | | | | This allows 19px icons to be able to be used for both browser and page icons. I think it looks nicer with the page actions slightly smaller, and that is what we also usually do in Chrome, but some Chrome location bar icons use 18px for soft edges, so I guess this will just have to be something we advise developers on. We can actually fit up to 21 (whoa nelly) pixels on Windows, but apparently the space is slightly smaller on mac. Also minor layout fix. We were sizing the browser action buttons 1px too short. BUG=24881 TEST=Load chrome/test/data/extensions/samples/icon_size_test. Icons should be 17px for the page action and 19px for the browser action and centered nicely in the space. Review URL: http://codereview.chromium.org/286001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29365 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Make theme install bubble prettier (for compositing WMs)estade@chromium.org2009-10-172-23/+68
| | | | | | | | | BUG=none TEST=screenshot Review URL: http://codereview.chromium.org/289004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29362 0039d316-1c4b-4281-b951-d872f2087c98
* Use the proper extension id when creating browser action buttons.estade@chromium.org2009-10-171-1/+1
| | | | | | | | | BUG=25066 TEST=none Review URL: http://codereview.chromium.org/274083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29361 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CHROME_PERSONALIZATION to BROWSER_SYNC.nick@chromium.org2009-10-1764-208/+191
| | | | | | | | | | Avoid #ifdef in general, favoring #if defined(). In one spot, use PlatformThread::Sleep instead of rolling our own. Review URL: http://codereview.chromium.org/267125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29360 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sync bug where notifications were being sent for unsuccessful commit ↵chron@chromium.org2009-10-162-2/+8
| | | | | | | | | | | attempts. BUG=24996 TEST=Manually tested Review URL: http://codereview.chromium.org/284008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29357 0039d316-1c4b-4281-b951-d872f2087c98
* Sniff 204 responses as text/plain to avoid creating unwanted downloads.abarth@chromium.org2009-10-162-8/+34
| | | | | | | | | BUG=24391 TEST=ResourceDispatcherHostTest.MimeSniff204 Review URL: http://codereview.chromium.org/274075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29355 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Remove an unused variable in bookmark_manager_gtk.cc. estade@chromium.org2009-10-161-2/+0
| | | | | | | | | | | | BUG=None TEST=None patch by Thiago Farina original review: http://codereview.chromium.org/268040/show Review URL: http://codereview.chromium.org/290004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29354 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: properly resize bookmark bar when going from attached to detached on ↵estade@chromium.org2009-10-161-2/+3
| | | | | | | | | | NTP fullscreen. BUG=24463 Review URL: http://codereview.chromium.org/287015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29353 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 09:00:10 +0000