summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Linux: tweak find bar.estade@chromium.org2009-05-048-27/+28
| | | | | | | | | - (attempt to) fix find bar z ordering in a simpler way - get "close without animation" right. Review URL: http://codereview.chromium.org/100286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15225 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate wstring version of PathService::Get() in unit tests.thestig@chromium.org2009-05-046-48/+44
| | | | | | Review URL: http://codereview.chromium.org/100292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15221 0039d316-1c4b-4281-b951-d872f2087c98
* Change in enable-spellcheck checkbox in Languages Options Tab should not be ↵sidchat@google.com2009-05-042-4/+6
| | | | | | | | | considered unless OK is clicked. Issue=11013 Review URL: http://codereview.chromium.org/99095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15219 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Linux find bar look a bit better.deanm@chromium.org2009-05-045-12/+27
| | | | | | | | | | - Fake some anti-aliasing so the text entry matches the next/prev images. - Match padding pixel perfect with Windows. Review URL: http://codereview.chromium.org/99275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15217 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "output=chrome" as the Suggest team has deprecated it server-side.pkasting@chromium.org2009-05-041-3/+2
| | | | | | | BUG=1660988 Review URL: http://codereview.chromium.org/102024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15212 0039d316-1c4b-4281-b951-d872f2087c98
* Reset the omnibox contents when the user reloads the page. Patch by Yusuke ↵pkasting@chromium.org2009-05-048-0/+24
| | | | | | | | Sato (see http://codereview.chromium.org/100198 ), r=me. BUG=2985 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15211 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Wire existing shortcutto out of process devtools.pfeldman@chromium.org2009-05-041-16/+20
| | | | | | Review URL: http://codereview.chromium.org/99345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15210 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some recently small size / position regressions in Linux Omnibox.deanm@chromium.org2009-05-042-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/100343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15204 0039d316-1c4b-4281-b951-d872f2087c98
* Fix find in page. When fixing the conflict after updating, I accidentallybrettw@chromium.org2009-05-041-0/+5
| | | | | | | removed the code that updates the find in page commands. Review URL: http://codereview.chromium.org/100331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression that the sad tab favicon is not displayed when a tab crashes.brettw@chromium.org2009-05-042-2/+8
| | | | | | | | | | | | | | This regressed in my favicon/title updating change because the crashed state is not updated on the codepath, since it comes from the tab. The other approach would have been to make this call through the "update everything" codepath for tbe state changing, but that's executed on a timer, and it's nice to show the tab crash right away since the check is very inexpensive. BUG=http://crbug.com/10756 Review URL: http://codereview.chromium.org/99341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15201 0039d316-1c4b-4281-b951-d872f2087c98
* More linux build fixesbrettw@chromium.org2009-05-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15197 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux build.brettw@chromium.org2009-05-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/99339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15196 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the mac build from my WebContents rename.brettw@chromium.org2009-05-042-3/+2
| | | | | | Review URL: http://codereview.chromium.org/100329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15195 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-04174-1391/+1189
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* linux: set the window icon (used in alt-tab list, etc.)evan@chromium.org2009-05-042-0/+13
| | | | | | | | BUG=11354 Review URL: http://codereview.chromium.org/100303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15192 0039d316-1c4b-4281-b951-d872f2087c98
* roll back r15177ben@chromium.org2009-05-0416-16/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15191 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15180.ben@chromium.org2009-05-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/100323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15188 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15181.ben@chromium.org2009-05-041-2/+1
| | | | | | Review URL: http://codereview.chromium.org/100322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15187 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15182.ben@chromium.org2009-05-047-56/+56
| | | | | | Review URL: http://codereview.chromium.org/101024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15186 0039d316-1c4b-4281-b951-d872f2087c98
* Bustage fix:ben@chromium.org2009-05-047-56/+56
| | | | | | | | | | Add back these files which I removed earlier since Linux is using them. The resources are duplicate until I collapse them into src/app/ later this week. Review URL: http://codereview.chromium.org/100320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15182 0039d316-1c4b-4281-b951-d872f2087c98
* Make the header include of views_strings.h here windows-only, temporarily ↵ben@chromium.org2009-05-041-1/+2
| | | | | | (we duplicate the strings in generated_resources.h) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15181 0039d316-1c4b-4281-b951-d872f2087c98
* Bustage fix for mac and linux:ben@chromium.org2009-05-041-1/+1
| | | | | | | | | | Duplicate views strings and rename them to uniquify them to get mac and linux going again. TODO(beng): move these strings into the forthcoming app/ dependency so that mac linux and windows can rely on it. Review URL: http://codereview.chromium.org/99335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15180 0039d316-1c4b-4281-b951-d872f2087c98
* Extract all views resources into:ben@chromium.org2009-05-0416-2/+16
| | | | | | | | | | | | | views_strings.[grd,vcproj] views_resources.[grd,vcproj] Moves views images (.png files) from app/theme to views/resources dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15177 0039d316-1c4b-4281-b951-d872f2087c98
* Blind fix for ChromeBot crashes.mal@chromium.org2009-05-031-1/+3
| | | | | | | | | | | | | | | | | | | | | A ChromeBot run for 172.17 was very top heavy (77/103 crashes) with: [vector:703] std::vector<PasswordManagerTableModel::PasswordRow *,std::allocator<PasswordManagerTableModel::PasswordRow *> >::size() [browser_init.cc:140] `anonymous namespace'::NotifyNotDefaultBrowserTask::Run() [message_loop.cc:308] MessageLoop::RunTask(Task *) I'm going to try a null check on |tab| before we invoke tab->infobar_delegate_count(). This applies the change made to 172 to trunk. TBR= jcampan,ben BUG= 11388 Review URL: http://codereview.chromium.org/99331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15176 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two bugs in the omnibox2 popup:ben@chromium.org2009-05-031-11/+12
| | | | | | | | | - popup frequently flashes white after being updated. This was because rows weren't being laid out after being added so they had zero size after async changes to the model. - text ran off the right side because DrawStringFragment wasn't clamping the output width to the available width. Does this now, and so eliding works. Review URL: http://codereview.chromium.org/101023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15171 0039d316-1c4b-4281-b951-d872f2087c98
* Fix multiple instances of first run dialog appearing when Chrome is started ↵robertshield@google.com2009-05-035-23/+50
| | | | | | | | | | again while a first run dialog is visible. Also cause the original first run dialog to come to foreground. BUG=http://crbug.com/10765 Review URL: http://codereview.chromium.org/99281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15170 0039d316-1c4b-4281-b951-d872f2087c98
* Allowing the client to handle escape and keyup events.tommi@google.com2009-05-022-7/+15
| | | | | | Review URL: http://codereview.chromium.org/99293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15142 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the following CL (it was breaking the UI tests because ajcampan@chromium.org2009-05-025-3/+143
| | | | | | | | | | | | | | | | | | | | | | | | | NOTREACHED() would be triggered in that case). If Chrome is not the default browser, tell the user, unless: - it is the first run - the user already said not to warn him/her about it - an info-bar is already showing. BUG=9049 TEST=Run a new install of chrome, proceed through the first run flow, don't make Chrome your default browser. No info-bar warning about Chrome not being the default browser should be shown. Restart Chrome, such an info-bar should be shown. Click the x on the info-bar to close it. Restart Chrome. The info-bar should be shown. Select "Set as default". Restart Chrome, the info-bar should not be shown. Start IE, make it your default browser (Tools menu, 'Internet option', Programs tab). Restart Chrome, it should show the default browser info-bar. Select "Don't ask me again". Restart Chrome, the info-bar should not be shown. Review URL: http://codereview.chromium.org/100287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15137 0039d316-1c4b-4281-b951-d872f2087c98
* Yet more deprecation of the wstring version of PathService::Get() for UI tests.thestig@chromium.org2009-05-0212-44/+37
| | | | | | Review URL: http://codereview.chromium.org/99298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15127 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome/chromium icons as PNGs.ben@chromium.org2009-05-022-2/+6
| | | | | | | | | | | | Also, add support to NativeButton for rendering as default independently of behaving as default. This will be used by the default browser infobar. Adds methods to the infobar delegate interface to allow the delegate to specify that it wants its Accept button to appear as the default button. http://crbug.com/9049 Review URL: http://codereview.chromium.org/100288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15125 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15115, it sadly breaks the ui tests.jcampan@chromium.org2009-05-015-140/+3
| | | | | | | TBR=beng Review URL: http://codereview.chromium.org/100285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15122 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix inverted infobubble logic.evan@chromium.org2009-05-011-1/+1
| | | | | | Review URL: http://codereview.chromium.org/100282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15118 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try and install extensions when --enable-extensions isn'taa@chromium.org2009-05-011-12/+28
| | | | | | | | | | | on. Also, pop up a dialog telling the user they probably forgot to turn on the flag. Review URL: http://codereview.chromium.org/99295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15116 0039d316-1c4b-4281-b951-d872f2087c98
* If Chrome is not the default browser, tell the user, unless:jcampan@chromium.org2009-05-015-3/+140
| | | | | | | | | | | | | | | | | | | | | | - it is the first run - the user already said not to warn him/her about it - an info-bar is already showing. BUG=9049 TEST=Run a new install of chrome, proceed through the first run flow, don't make Chrome your default browser. No info-bar warning about Chrome not being the default browser should be shown. Restart Chrome, such an info-bar should be shown. Click the x on the info-bar to close it. Restart Chrome. The info-bar should be shown. Select "Set as default". Restart Chrome, the info-bar should not be shown. Start IE, make it your default browser (Tools menu, 'Internet option', Programs tab). Restart Chrome, it should show the default browser info-bar. Select "Don't ask me again". Restart Chrome, the info-bar should not be shown. Review URL: http://codereview.chromium.org/99301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15115 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the issue with Options menu fonts display bigger than size of fonts ↵sidchat@google.com2009-05-012-18/+43
| | | | | | | | actually set. This was happening because Windows Font Picker returns font size in points, whereas the corresponding pref members for serif, sans-serif and fixed-width fonts expect font size in pixels.Issue=7806TEST: Go to options > fonts and languages > fonts tab and change serif font to 16 and click OK. Then open a new Tab page - the corresponding fonts should be that size.NOTE: I don't know why the div element set to 16pt serif font is not the same height as that shown by the font picker. That is a separate issue I think. Review URL: http://codereview.chromium.org/100228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15114 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes Chrome on par with Firefox in terms of 'GetSuggestedFilename' ↵jungshik@google.com2009-05-0110-6/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | for file download via context-menu. For a download initiated with a click on a link in a web page, a webkit-side change is necessary, which will be done later. Add a field (referrer_charset) to URLRequestContext and DownloadCreateInfo. It's set to the character encoding of a document where the download request originates from when it's known (download initiated via "save as" in the context menu). If it's not known (a download initiated by clicking on a download link or typing a url directly to the omnibox), it's initialized to the default character encoding in the user's preference. I guess this is marginally better than leaving it empty (in that case, step 2b below will be skipped and step 2c will be taken) because a user has a better control over how raw 8bit characters in C-D are interpreted (especially on Windows where a reboot is required to change the OS default codepage). This is later passed to GetSuggestedFilename and used as one of fallback encodings (1. UTF-8, 2. origin_charset, 3. default OS codepage). With this change, we support the following: 1. RFC 2047 2. Raw-8bit-characters : a. UTF-8, b. origin_charset, c. default os codepage. 3. %-escaped UTF-8. In this CL, for #3, I didn't add a fallback similar to one used for #2. If necessary, it can be added easily. New entries are added to 3 existing tests. What's previously not covered (raw 8bit Content-Disposition header) is now covered in all 3 tests. BUG=1148 TEST=net unit test: NetUtilTest.GetFileNameFromCD NetUtilTest.GetSuggestedFilename unittest : DownloadManagerTest.TestDownloadFilename Review URL: http://codereview.chromium.org/83002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15113 0039d316-1c4b-4281-b951-d872f2087c98
* Make the findbar slide in/out.estade@chromium.org2009-05-017-50/+97
| | | | | | | | | | Change SlideAnimatorGtk so that its GtkFixed doesn't have its own window. Giving that fixed its own GdkWindow meant that as a client of SlideAnimatorGtk you were pretty much cornered into having rectangular widgets (unless you want to perform a lot of expensive operations during every frame of the slide). We solve the clipping problem this creates by making a "render area" vbox in BrowserWindowGtk that is all part of a single GdkWindow hierarchy. This isn't yet perfect as there are sometimes occlusion problems with infobars. That will probably need to be solved in the same way it was solved for the tab contents container. This patch is already hard enough to grok, so I'm going to leave that problem for another patch. Review URL: http://codereview.chromium.org/102021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15112 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in session restore on linux/mac. We were pickling thetc@google.com2009-05-012-14/+7
| | | | | | | | | | | | | | page title as a wstring, but reading it back as a string16. This allows the SessionRestoreUITests to pass. Also enable the inspector ui test which is currently disabled, but the code compiles fine on linux/mac. BUG=10516 Review URL: http://codereview.chromium.org/99297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15109 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first part of the PageAction implementation. More work is ↵finnur@chromium.org2009-05-0116-22/+529
| | | | | | | | | | | | | | | | required, but this is a good checkpoint. Design doc: http://dev.chromium.org/developers/design-documents/extensions/page-actions-api This checkin only covers Tab scoped page actions (not type "permanent"). It works end to end (if you have an extension that supplies the page action info -- I created an RSS page action that links to Google Reader). Please note that TabIndex is hard coded to 0 until the extension system can provide the tab id to the extensions (which I understand is in progress). This means that page action(s) only show up for the first tab in the tabstrip. :) BUG=None TEST=There is a unit test for the API, but apart from that it is not possible to test this manually without writing an extension that adds a PageAction. My RSS page action is not ready to be checked in but I can provide it if there is interest in a sneak preview during review/QA. Review URL: http://codereview.chromium.org/99253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15105 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that the underlying web_contents has focus in the external tab containerananta@chromium.org2009-05-011-0/+1
| | | | | | | | | when it receives the SetInitialFocus notification from the client. Review URL: http://codereview.chromium.org/102022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15104 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Add a macro for handling EINTR.agl@chromium.org2009-05-014-17/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On POSIX systems, system calls can be interrupted by signals. In this case, they'll return EINTR, indicating that the system call needs to be restarted. (The situation is a little more complicated than this with SA_RESTART, but you can read man 7 signal if you like.) The short of it is that you need to catch EINTR and restart the call for these system calls: * read, readv, write, writev, ioctl * open() when dealing with a fifo * wait* * Anything socket based (send*, recv*, connect, accept etc) * flock and lock control with fcntl * mq_ functions which can block * futex * sem_wait (and timed wait) * pause, sigsuspend, sigtimedwait, sigwaitinfo * poll, epoll_wait, select and 'p' versions of the same * msgrcv, msgsnd, semop, semtimedop * close (although, on Linux, EINTR won't happen here) * any sleep functions (careful, you need to handle this are restart with different arguments) We've been a little sloppy with this until now. This patch adds a macro for dealing with this and corrects every case of these system calls (that I found). The macro is HANDLE_EINTR in base/eintr_wrapper.h. It's safe to include on Windows and is a no-op there. On POSIX, it uses GCC magic to return the correct type based on the expression and restarts the system call if it throws EINTR. And you can use it like: HANDLE_EINTR(close(fd)); Or: ssize_t bytes_read = HANDLE_EINTR(read(fd, buffer, len)); *BEWARE* that it will evaluate the argument multiple times, so this is not safe: HANDLE_EINTR(close(FireMissiles())); http://groups.google.com/group/chromium-dev/browse_thread/thread/41a35b2a457d73a0 http://codereview.chromium.org/100225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15102 0039d316-1c4b-4281-b951-d872f2087c98
* Enable user_script_master_unittest for Mac since DirectoryWatcher was ported.shess@chromium.org2009-05-012-8/+10
| | | | | | | | [See http://crbug.com/10967 ] Review URL: http://codereview.chromium.org/99280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15099 0039d316-1c4b-4281-b951-d872f2087c98
* Run workers in separate processes.jam@chromium.org2009-05-015-42/+120
| | | | | | Review URL: http://codereview.chromium.org/99016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15098 0039d316-1c4b-4281-b951-d872f2087c98
* Pass down the opener tab when a message channel is opened to an extension.mpcomplete@google.com2009-05-019-159/+196
| | | | | | | | | | | Also did a bunch of cleanup of ExtensionMessageService. I converted it to primarily UI-thread habitation, with one function that needs to be on the IO thread so it can handle a synchronous IPC message. TEST=N/A Review URL: http://codereview.chromium.org/99261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15097 0039d316-1c4b-4281-b951-d872f2087c98
* Remove StopAutocomplete() helper from AutocompletePopupViewMac.shess@chromium.org2009-05-013-6/+2
| | | | | | | | When the code was originally written, GetModel() was not required by AutocompletePopupView, now it's easy enough to use that instead. Review URL: http://codereview.chromium.org/99278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15094 0039d316-1c4b-4281-b951-d872f2087c98
* Measure IPC latency for audiohclam@chromium.org2009-05-011-5/+32
| | | | | | | | | | | | | | | | | | | | | | | With this patch there's totally 5 measurements for audio IPC 1. Total round trip time browser request a packet until it gets a packet 2. Browser receive latency time for a packet to arrive browser from renderer 3. Browser process time time for browser to process the packet 4. Renderer receive latency time for a packet to arrive renderer from browser 5. Renderer process time process time on a packet in renderer They are all using low resolution timer with accuracy of ~1-15ms. Since we have a budget of ~200ms (for now) without clicks, I think the accuracy shouldn't be a big problem, unless for case 1 where we want to measure exact amount of clicks. Review URL: http://codereview.chromium.org/99213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15063 0039d316-1c4b-4281-b951-d872f2087c98
* Release the autocomplete popup panel when not visible.shess@chromium.org2009-05-011-0/+8
| | | | | | Review URL: http://codereview.chromium.org/100260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15061 0039d316-1c4b-4281-b951-d872f2087c98
* Making CloseWindow and CloseTab automation APIhuanr@chromium.org2009-05-012-2/+22
| | | | | | | | | | | | | synchronous and robust. Adding automation APIs with corresponding IPC messages to count and find normal browser windows. Review URL: http://codereview.chromium.org/99268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15058 0039d316-1c4b-4281-b951-d872f2087c98
* More focus fixing.avi@google.com2009-05-011-1/+2
| | | | | | Review URL: http://codereview.chromium.org/99262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15055 0039d316-1c4b-4281-b951-d872f2087c98
* Only send events to renderers that are listening to an event.Notify browser ↵erikkay@google.com2009-05-016-8/+74
| | | | | | | | when a renderer is listening to an event. Review URL: http://codereview.chromium.org/100214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15050 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 05:53:26 +0000