summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Remove the Menu object, converting all the remaining callers to use Menu2. ↵ben@chromium.org2009-06-1219-216/+270
| | | | | | | | | | | I'll rename Menu2->Menu afterwards. TEST=none BUG=none Review URL: http://codereview.chromium.org/122027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18315 0039d316-1c4b-4281-b951-d872f2087c98
* DEPS cleanup.thestig@chromium.org2009-06-121-1/+0
| | | | | | Review URL: http://codereview.chromium.org/118317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18312 0039d316-1c4b-4281-b951-d872f2087c98
* Revert thakis's changes to download_file.cc from r17595.estade@chromium.org2009-06-121-15/+8
| | | | | | | | BUG=13991 Review URL: http://codereview.chromium.org/126066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18307 0039d316-1c4b-4281-b951-d872f2087c98
* Change some DCHECKs to CHECKs in hope of tracking down a crash.pkasting@chromium.org2009-06-121-2/+2
| | | | | | | | BUG=13986 TEST=none Review URL: http://codereview.chromium.org/125066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18302 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the focus manager to not subclass HWNDs (but for the ↵jcampan@chromium.org2009-06-1235-119/+200
| | | | | | | | top-windows).Components that have HWND now need to specifically let the FocusManager know when they get the native focus.This is the reason for the new GotFocus() notification on the RenderWidgetHostViewWin class.BUG=NoneTEST=Run the interactive tests, the unit-tests. Test that the focus is remembered correctly when switching windows, switching tabs. Test that focus traversal in the browser and in the option dialog works as expected. Review URL: http://codereview.chromium.org/122002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18301 0039d316-1c4b-4281-b951-d872f2087c98
* Fix object ownership and cleanup issues between ExtensionHost and ↵erikkay@google.com2009-06-122-3/+9
| | | | | | | | | | | | ExtensionView. This was leading to crashes at shutdown as well as shutdown code not cleaning up properly. BUG=13974 TEST=none Review URL: http://codereview.chromium.org/126064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18296 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 6103 -- Individual download items on the download shelf ↵xji@chromium.org2009-06-121-27/+36
| | | | | | | | | | | | | | | | | are not mirrored on RTL locales, and issue 13217 -- Dangerous File warning on the shelf in RTL seems to misplace the buttons Enable UI mirroring for DownloadItemView. During painting each download items, for those items without corresponding mirrored images, flip the canvas to paint the mirrored image. And flip canvas back to normal to paint others. BUG=http://crbug.com/6103 BUG=http://crbug.com/13217 Test=Open Hebrew Chrome, go to "http://build.chromium.org/buildbot/continuous/LATEST/", download mini_installer.exe, the layout of the warning should be "cancel_button ok_button warning_message warning_icon" from left to right. Click "ok" to download, the layout of the download item in download shelf should be "drop_down_icon download_file_name(or download_file_name with download_status) download_progress_animation and download icon" from left to right. Review URL: http://codereview.chromium.org/118260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18292 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor zygote supportagl@chromium.org2009-06-126-27/+362
| | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxZygote * Move Chrome specific bits out of base * Move away from the idea of reserved file descriptors (which don't really work with zygotes) * Load resources before forking renderers (means that we don't need communication between the zygote process and the renderers) * Make sure that gdb works against the browser again * Make sure that we have different ASLR between the renderers and the browser. http://codereview.chromium.org/119335 (This is a reland. First landed in r18109, reverted in r18112.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18291 0039d316-1c4b-4281-b951-d872f2087c98
* This makes the network column in the task manager not display NA as network ↵jcampan@chromium.org2009-06-122-10/+3
| | | | | | | | | | usage is available. BUG=http://crbug.com/13958 TEST=Open the task manager, the network column for the browser process should be showing 0. Type something in the location bar, the value should change. Review URL: http://codereview.chromium.org/125056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18290 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Change BlockedPopupContainerView to a cairo implementation.erg@google.com2009-06-121-42/+43
| | | | | | | | http://crbug.com/12843 Review URL: http://codereview.chromium.org/126017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18285 0039d316-1c4b-4281-b951-d872f2087c98
* Histogram count of number of command line argumentsjar@chromium.org2009-06-121-1/+20
| | | | | | | | | | This should help us evaluate which users are manually switching on non-standard options, which in turn may impact stability. r=huanr Review URL: http://codereview.chromium.org/126024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18281 0039d316-1c4b-4281-b951-d872f2087c98
* Add back in log info about histogram hashesjar@chromium.org2009-06-121-0/+8
| | | | | | | | | | | | | | | This was seemingly inadvertently deleted in a CL http://src.chromium.org/viewvc/chrome?view=rev&revision=16023 The change should have no semantic impact on the running of the program (unless the user enables logging), and it helps me isolate actual names of histograms for unknown hashes that appear on the histogram dashboard. r=evanm,dpranke Review URL: http://codereview.chromium.org/125011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18280 0039d316-1c4b-4281-b951-d872f2087c98
* Adds wiring for tab overview.sky@chromium.org2009-06-122-0/+310
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18267 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing memleak found by purify.finnur@chromium.org2009-06-121-0/+2
| | | | | | | | | | | | | | | | This should fix leaks at: extensions_service.cc:495 and 498 ... and since the providers are getting cleaned up, it should take care of: extensions_service.cc:211 ... as well. TBR=erikkay TEST=Covered by automated tests. BUG=None Review URL: http://codereview.chromium.org/126037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18251 0039d316-1c4b-4281-b951-d872f2087c98
* Allow external hosts to handle the context menu and thus be able to ↵ananta@chromium.org2009-06-1218-14/+198
| | | | | | | | | | | | | | | | | | | | customize it. Changes include 1. A HandleContextMenu function which can be implemented by a TabContentsDelegate. Currently only ExternalTabContainer implements this. 2. Removed InitMenu calls from the RenderViewContextMenu subclass constructors, We need the subclasses to be able to override individual AddMenuItem calls. The newly added RenderViewContextMenuExternalWin class derives from RenderViewContextMenuWin whose constructor calls InitMenu. This happens at a time when the vtable is not yet setup. To fix this we added an Init function to the RenderViewContextMenu base class which then calls a virtual function DoInit, which derived classes can override to perform specific initializations. 3. Added automation messages to send over context menu events to external hosts and back amit, please review everything. estade please review changes to tab_contents_view_gtk.cc and render_view_context_menu_gtk.cc. pinkerton please review changes to tab_contents_view_mac.mm and render_view_context_menu_mac.mm Review URL: http://codereview.chromium.org/119429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18250 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out the code that deals with installing external extensions through ↵finnur@chromium.org2009-06-129-236/+578
| | | | | | | | | | | | Registry and Preferences into separate classes. While I was at it, I removed the EXTERNAL_INSTALL file, since we now keep track of this in the Preferences. This also takes care of the virtualization problem in the unit tests for vista (see bug). BUG=13063 TEST=None, covered by automated tests. Review URL: http://codereview.chromium.org/122004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18247 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in my interstitial page test.willchan@chromium.org2009-06-122-2/+2
| | | | | | | | | | Re-enable leaky web_contents_unittest.cc interstitial test. Remove purify suppressions for leaky test. BUG=http://crbug.com/13937 Review URL: http://codereview.chromium.org/125033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18246 0039d316-1c4b-4281-b951-d872f2087c98
* Spaces are not URL-encoded in the Omnibarmhm@chromium.org2009-06-121-1/+1
| | | | | | | | | | BUG=13818 (http://crbug.com/13818) TEST=tests urls with spaces as well as files Review URL: http://codereview.chromium.org/126025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18241 0039d316-1c4b-4281-b951-d872f2087c98
* Oops, disable the correct test this time :)willchan@chromium.org2009-06-121-3/+3
| | | | | | | | http://crbug.com/13937 Review URL: http://codereview.chromium.org/126026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18239 0039d316-1c4b-4281-b951-d872f2087c98
* Disable leaky web_contents_unittest.cc interstitial test.willchan@chromium.org2009-06-121-1/+2
| | | | | | | | BUG=http://crbug.com/13937. Review URL: http://codereview.chromium.org/125029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18237 0039d316-1c4b-4281-b951-d872f2087c98
* * Avoid doing concurrent DNS resolves of the same hostname in HostResolver.ericroman@google.com2009-06-124-17/+26
| | | | | | | | | | | | | | | | * Add a 1 minute cache for host resolves. * Refactor HostResolver to handle multiple requests. * Make HostResolver a dependency of URLRequestContext. operate the HostResolver in async mode for proxy resolver (bridging to IO thread). TEST=unittests BUG=13163 Review URL: http://codereview.chromium.org/118100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18236 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Special case focus handling so that we don't tell webkit it's lost ↵estade@chromium.org2009-06-116-17/+50
| | | | | | | | | | | focus when a context menu is showing. BUG=13404,13554 TEST=copy/paste *via the right-click context menu* works as expected in gmail. Review URL: http://codereview.chromium.org/118339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18225 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix icon theme double free on shutdown by eliminating dupes from icon ↵estade@chromium.org2009-06-112-10/+4
| | | | | | | | | | theme array. Simplify some code in DownloadItemGtk that I previously thought was related to the crash, and so had made complicated. Review URL: http://codereview.chromium.org/124001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18222 0039d316-1c4b-4281-b951-d872f2087c98
* UI tweaks for the tab strip on linux.sky@chromium.org2009-06-112-2/+18
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18219 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a layout bug in the fonts and languages dialog wheretc@google.com2009-06-111-13/+7
| | | | | | | | | | | | | | | buttons get cut off on the right side of the dialog. Instead of sizing the label text based on a constant from the localized resources, use the default text size (no-multiline text). I also tightened up the font preview box to just use the size of the text + a constant padding on all sides. BUG=13366 Review URL: http://codereview.chromium.org/125013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18217 0039d316-1c4b-4281-b951-d872f2087c98
* Change DnsMaster to only access HostResolver only on the IO thread.ericroman@google.com2009-06-115-81/+197
| | | | | | | | | | | | | | | And plumb through an (unused) HostResolver dependency into DnsMaster. This is in preparation for <http://codereview.chromium.org/118100> which turns HostResolver into a (non-thread-safe) shared dependency of the URLRequestContext. After CL 118100, DnsMaster will be issuing host resolves through the main URLRequestContext's HostResolver (now on the IO thread). This will have the effect of warming the shared HostResolver's internal cache. BUG=13163 TEST=existing unit tests Review URL: http://codereview.chromium.org/122028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18212 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure view-source: is applied to RenderView when it is reused for a newbrettw@google.com2009-06-113-1/+60
| | | | | | | | | | | | | | | | | | | | | navigation. On page loading errors, WebFrameImpl::DidFail() will call RenderView::OnEnableViewSourceMode(false) not to show error pages in view source mode. We should overwrite the mode for new navigations not to show view-source: added inputs in non view-source mode. This fix is related to http://code.google.com/p/chromium/issues/detail?id=4516 But this doesn't resolve reloading case. BUG=none TEST=1) View some site using view-source:. 2) let the site return error for example 404 Not Found, and then view using view-source:. 3) make it 200 again and view using view-source:. It must show source code. Original review: http://codereview.chromium.org/119233 Patch by tyoshino@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18211 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to import the home page of the default browser. The import ↵gwilson@google.com2009-06-111-0/+2
| | | | | | | | | | | | always existed, but was never hooked up to an installerdata preference. R=cpu BUG=13752 TEST=Run the installer with a line in the distribution block of the installerdata that reads: "import_home_page" : true. The home page of the previous default browser should be imported. Review URL: http://codereview.chromium.org/118512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18210 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Graphical polish on the BlockedPopupContainerView. Specifically, ↵erg@google.com2009-06-112-17/+69
| | | | | | | | | | rounded borders and background gradient. http://crbug.com/12843 Review URL: http://codereview.chromium.org/125007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18207 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: shift-enter in find bar searches backwards.estade@chromium.org2009-06-111-1/+3
| | | | | | | | | BUG=13520 TEST=use shift enter in find bar Review URL: http://codereview.chromium.org/122047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18196 0039d316-1c4b-4281-b951-d872f2087c98
* Use the MessageLoopForUI::Observer interface to listen for mouse motion ↵jhawkins@chromium.org2009-06-112-34/+27
| | | | | | | | | | events instead of hooking up to the global gdk event handler. Once we hook up to the global handler and disconnect from it, the MessageLoopForUI will be broken because we stole the handler from it. BUG=none TEST=Exhaustively test dragging tabs in and out of multiple tabstrips. Review URL: http://codereview.chromium.org/126001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18194 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "BUG=12114"tc@google.com2009-06-117-337/+112
| | | | | | | | | | | This reverts commit r18189. TBR=rafaelw Review URL: http://codereview.chromium.org/125004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18193 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=12114rafaelw@chromium.org2009-06-117-112/+337
| | | | | | | | R=erikkay,wtc Review URL: http://codereview.chromium.org/115682 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18189 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 3791: SavePageTest.* is crapidanan@chromium.org2009-06-111-14/+20
| | | | | | | | | | | | | Modifying flaky test so that it waits for a file to stop being written rather than starts existing. Otherwise the compare check fails some times. I know Windows has a more efficient API to do this but for the sake of multiplatform compatibility, the solution is completely generic. BUG=3791 Review URL: http://codereview.chromium.org/123026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18187 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in ExtensionsService when skipping loadedaa@chromium.org2009-06-111-8/+6
| | | | | | | | extensions. Review URL: http://codereview.chromium.org/122021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18186 0039d316-1c4b-4281-b951-d872f2087c98
* Get tab HWND directly as result of CreateExternalTab automation call.stoyan@chromium.org2009-06-113-3/+9
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/119448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18181 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Forward certain key strokes from the find bar to the render view.estade@chromium.org2009-06-112-4/+55
| | | | | | | | | | | The choice of keystrokes matches windows. BUG=12697 TEST=press up or down in find bar; page should scroll (assuming it can scroll) Review URL: http://codereview.chromium.org/122014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18176 0039d316-1c4b-4281-b951-d872f2087c98
* Start the resize animation after a delay once the mouse has left the ↵jhawkins@chromium.org2009-06-112-21/+115
| | | | | | | | | | tabstrip zone. BUG=13471 TEST=Open enough tabs in a browser window so that they must resize. Close a few tabs in the middle of the tabstrip. The tabs should not resize. Now move the mouse outside of the tabstrip zone (40 pixels below). The tabs should resize after a short delay. Review URL: http://codereview.chromium.org/123005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18174 0039d316-1c4b-4281-b951-d872f2087c98
* Another fix for issue 13724: Don't hard code chrome.exeagl@chromium.org2009-06-111-1/+4
| | | | | | | | | | | | Use chrome::kBrowserProcessExecutableName instead. BUG=13724 http://codereview.chromium.org/123022 (By Edward Crossman) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18172 0039d316-1c4b-4281-b951-d872f2087c98
* Move renderer_preferences.h from chrome/browser into chrome/common. Wetc@google.com2009-06-114-28/+3
| | | | | | | | | | include the file in chrome/renderer and chrome/browser so to make check deps happy, I'm putting the file in chrome/common. Review URL: http://codereview.chromium.org/123001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18166 0039d316-1c4b-4281-b951-d872f2087c98
* Revert mad's backing store changes, it completely hosed Linux painting.deanm@chromium.org2009-06-119-228/+90
| | | | | | | | | This was r18090, reverted in r18092, recommitted without review in 18130. Review URL: http://codereview.chromium.org/122034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18158 0039d316-1c4b-4281-b951-d872f2087c98
* Final touches on the Linux BookmarkBubble.deanm@chromium.org2009-06-114-12/+59
| | | | | | | | | | | | | - Implement "close on escape" with a top level accelerator. - Fix an invalid read when opening the editor from the folder combo. - Clean up some signal handlers (returning bool from a void function, etc). BUG=11738 Review URL: http://codereview.chromium.org/118493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18154 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Keep Resources panel enabled status upon frame navigate.pfeldman@chromium.org2009-06-111-1/+0
| | | | | | Review URL: http://codereview.chromium.org/118508 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18153 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser window crash on windows.thakis@chromium.org2009-06-111-0/+8
| | | | | | | | | | | | | BUG=13681 (http://crbug.com/13681) TEST=Follow these steps -Ctrl+Shift+N to Incognito window. -Download a file -Close the Incognito window after download is finished. Review URL: http://codereview.chromium.org/120001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18151 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash on interstitial page when the renderer crashed.willchan@chromium.org2009-06-113-3/+43
| | | | | | | | | | | Simply add a NULL check to make sure the view is still there before showing it. Also fix a debug crash since the ResourceDispatcherHost assumes that it should always find the pid & route_id key, which is not true if the renderer crashed. BUG=http://crbug.com/13795 TEST=See bug for repro instructions. Review URL: http://codereview.chromium.org/122025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18150 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add support to the automation provider to test sending browser"aa@chromium.org2009-06-115-230/+2
| | | | | | | | This reverts commit 4775c631c09be565706f8a6ce3c4659bc89097e4. Review URL: http://codereview.chromium.org/122024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18149 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to the automation provider to test sending browseraa@chromium.org2009-06-115-2/+230
| | | | | | | | | | | | events to extensions. Implements an initial test that send all known window, tab, page action, and bookmark events and makes sure the extension received them. Original review: http://codereview.chromium.org/119325 Review URL: http://codereview.chromium.org/123010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18148 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add support to the automation provider to test sending browser"aa@chromium.org2009-06-115-230/+2
| | | | | | | | This reverts commit 9b7fbb1e720ab2071b30531fd0266918c4e68d12. Review URL: http://codereview.chromium.org/122022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18147 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to the automation provider to test sending browseraa@chromium.org2009-06-115-2/+230
| | | | | | | | | | | | | events to extensions. Implements an initial test that send all known window, tab, page action, and bookmark events and makes sure the extension received them. Original review: http://codereview.chromium.org/119325 Review URL: http://codereview.chromium.org/123009 Patch from Roger Tawa <rogerta@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18146 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extension loading code to properly filter out non-themesaa@chromium.org2009-06-112-19/+31
| | | | | | | | | | | when extensions are disabled. BUG=12076 TEST=Added a unit test. Also, install an extension, then create a new version of it and overinstall. You should not see two of them. Review URL: http://codereview.chromium.org/123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18140 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 10:28:56 +0000