summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Revert 83168 - Revert "Revert 83100 - Remove weird dependency on ↵aa@chromium.org2011-04-2717-99/+119
| | | | | | | | | | extensions from webui.Re-plumb extension request messages in a more sane way.Before, each RVH had ProcessWebUIMessage(), which wasserving as a manual way of plumbing both WebUI andextension messages to the right place, even though onlya few RVHD responded to either message.Instead of this, we now just teach more of the stack howto handle IPC messages in general, and delegate them upthrough the stack, giving each layer a chance to handlethem if it knows how.The result is simpler and smaller:179 insertions(+), 252 deletions(-)BUG=80311Review URL: http://codereview.chromium.org/6901021"This reverts commit 643b280cedd9f0b76948686f39f50f295aba362f.TBR=mpcomplete@chromium.org" This reverts commit ba6603c3cc46f1b83219be906ab36f8f2b3372e2. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83188 0039d316-1c4b-4281-b951-d872f2087c98
* Close bookmark folder menus before opening bookmark edit dialog.maf@chromium.org2011-04-271-0/+1
| | | | | | | | R=mrossetti@chromium.org BUG=80636 Review URL: http://codereview.chromium.org/6883181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83185 0039d316-1c4b-4281-b951-d872f2087c98
* Moved mru_cache from content/common to base/memory.agayev@chromium.org2011-04-273-7/+6
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6883187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83182 0039d316-1c4b-4281-b951-d872f2087c98
* Undo raw DNS resolver changes, this will be implemented differently, on ↵agayev@chromium.org2011-04-271-18/+1
| | | | | | | | | | | IO-thread. BUG=60149 TEST=None Review URL: http://codereview.chromium.org/6893007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83177 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent a panel from blowing up when touched.sadrul@chromium.org2011-04-271-16/+73
| | | | | | | | | | | An event on touchui does not usually have an associated GDK event, so trying to access that causes a crash. So use the views API to get to the native event instead. BUG=touch a balloon/panel on chromeos, chrome crashes. TEST=manually Review URL: http://codereview.chromium.org/6902073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83175 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Integrate with the Unity desktop environment.erg@google.com2011-04-275-6/+166
| | | | | | | | | | | | | - When we're maximized and unity is active, don't draw the min/max/close buttons. Unity will take care of that in the title bar. - When unity is active and we're downloading a file, badge the dock icon like we do on other platforms. BUG=75485 TEST=Using a custom frame, maximize the window while running unity. We shouldn't draw our own min/max/close buttons. TEST=Download a file on Natty; download count/progress bar should appear on dock icon. Review URL: http://codereview.chromium.org/6903017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83173 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83168 - Revert "Revert 83100 - Remove weird dependency on extensions ↵acolwell@chromium.org2011-04-2717-119/+99
| | | | | | | | | | | from webui.Re-plumb extension request messages in a more sane way.Before, each RVH had ProcessWebUIMessage(), which wasserving as a manual way of plumbing both WebUI andextension messages to the right place, even though onlya few RVHD responded to either message.Instead of this, we now just teach more of the stack howto handle IPC messages in general, and delegate them upthrough the stack, giving each layer a chance to handlethem if it knows how.The result is simpler and smaller:179 insertions(+), 252 deletions(-)BUG=80311Review URL: http://codereview.chromium.org/6901021"This reverts commit 643b280cedd9f0b76948686f39f50f295aba362f.TBR=mpcomplete@chromium.org TBR=aa@chromium.org This is still causing check_deps failures. Review URL: http://codereview.chromium.org/6902074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83172 0039d316-1c4b-4281-b951-d872f2087c98
* file manager: Add strings we might need for M12rginda@chromium.org2011-04-272-0/+54
| | | | | | | | | BUG=chromium-os:14564 TEST=manual testing of chromeos-chrome on linux Review URL: http://codereview.chromium.org/6883180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83169 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 83100 - Remove weird dependency on extensions from ↵aa@chromium.org2011-04-2717-99/+119
| | | | | | | | | | webui.Re-plumb extension request messages in a more sane way.Before, each RVH had ProcessWebUIMessage(), which wasserving as a manual way of plumbing both WebUI andextension messages to the right place, even though onlya few RVHD responded to either message.Instead of this, we now just teach more of the stack howto handle IPC messages in general, and delegate them upthrough the stack, giving each layer a chance to handlethem if it knows how.The result is simpler and smaller:179 insertions(+), 252 deletions(-)BUG=80311Review URL: http://codereview.chromium.org/6901021" This reverts commit 643b280cedd9f0b76948686f39f50f295aba362f. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83168 0039d316-1c4b-4281-b951-d872f2087c98
* Address review comments I missed.sky@chromium.org2011-04-271-5/+5
| | | | | | | | | | | TBR=oshima@chromium.org R=oshima@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6905058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83165 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing webdriver advanced controls APIs for chromedriver.kkania@chromium.org2011-04-274-10/+142
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6857001 Patch from Hisayori Noda <hnoda@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83164 0039d316-1c4b-4281-b951-d872f2087c98
* Use standard way to create a temporary db file.qsr@google.com2011-04-271-6/+6
| | | | | | | | | | BUG=none TEST=tests pass Review URL: http://codereview.chromium.org/6905057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83158 0039d316-1c4b-4281-b951-d872f2087c98
* Directly observe the disabled schemes policy instead of via a PrefMember.bauerb@chromium.org2011-04-277-96/+9
| | | | | | | | | | | | Also, remove some now-obsolete pref code and clean up PrefService a bit. BUG=80025 TEST=none Review URL: http://codereview.chromium.org/6900056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83157 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move AutocompleteEditViewWin/autocomplete_edit_view_win.* to ↵tfarina@chromium.org2011-04-2710-262/+238
| | | | | | | | | | | | | | | | ui/views/omnibox directory. - Rename AutocompleteEditViewWin to OmniboxViewWin. - Move autocomplete_edit_view_win.* to omnibox_view_win.* BUG=80186 TEST=None R=pkasting@chromium.org Review URL: http://codereview.chromium.org/6902055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83156 0039d316-1c4b-4281-b951-d872f2087c98
* Migrates NotificationPanel code to using Widget API instead ofsky@chromium.org2011-04-271-39/+50
| | | | | | | | | | | | WidgetGtk. BUG=none TEST=none R=ben@chromium.org,oshima@chromium.org Review URL: http://codereview.chromium.org/6878083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83155 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent creation of more than one TCW for a TC.avi@chromium.org2011-04-271-0/+1
| | | | | | | | | BUG=80479 TEST=none; this is preventative Review URL: http://codereview.chromium.org/6893043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83154 0039d316-1c4b-4281-b951-d872f2087c98
* Fix find-in-page for popups.avi@chromium.org2011-04-271-1/+4
| | | | | | | | | BUG=80479 TEST=as in bug Review URL: http://codereview.chromium.org/6905042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83153 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Show 3G promo notification on a first usage of the cellular network ↵nkostylev@chromium.org2011-04-279-25/+162
| | | | | | | | | | | as a primary connection. BUG=chromium-os:13286 TEST=Manual. Signed in with a new user and 3G connection active. Review URL: http://codereview.chromium.org/6899061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83147 0039d316-1c4b-4281-b951-d872f2087c98
* Add 1st cut of QuotaManager codekinuko@chromium.org2011-04-274-0/+34
| | | | | | | | | | | | | | No persistent storage support yet. Some notes: - There are a lot of TODOs especially for persistent type storage handling. - QuotaTask base class is for now only subclassed by QuotaInitializeTask, but it is planned to add more subclasses. BUG=61676,79639 TEST=QuotaManagerTest.* Review URL: http://codereview.chromium.org/6826052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83145 0039d316-1c4b-4281-b951-d872f2087c98
* Add resources for ibus-zinnia-japaneseyusukes@google.com2011-04-273-0/+9
| | | | | | | | | BUG=chromium-os:14421 TEST=ran Chrome on ChromeOS and checked ui.LATEST log. Review URL: http://codereview.chromium.org/6883184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83144 0039d316-1c4b-4281-b951-d872f2087c98
* Profile shouldn't own ProfilePolicyConnector. Introduce ↵jknotten@chromium.org2011-04-2711-28/+108
| | | | | | | | | | | | | | | | | | BrowserPolicyConnector::Create. ProfilePolicyConnector is now owned by ProfilePolicyConnectorFactory, using Profile has a key. This uses the ProfileKeyedService infrastructure originally created for ThemeServiceFactory. Also introduce BrowserPolicyConnector::Create method to faciliate stubbing out for binary-size reduction purposes. BUG=77155 TEST=Existing Review URL: http://codereview.chromium.org/6902036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83143 0039d316-1c4b-4281-b951-d872f2087c98
* Extension App provider should include packaged apps as well. They have nofinnur@chromium.org2011-04-271-3/+4
| | | | | | | | | | | web launch URL (which is why they don't show up right now), but they have a local extension url we can launch. BUG=80504 TEST=Install a packaged app, such as SparkChess, and make sure it appears in Omnibox when you type in SparkChess. Review URL: http://codereview.chromium.org/6901025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83139 0039d316-1c4b-4281-b951-d872f2087c98
* Trusteer's rooksdol.dll version 3.5.1008.40 is said to fix the browser ↵finnur@chromium.org2011-04-271-1/+1
| | | | | | | | | | crashes experienced by some users. BUG=80552 TEST=about:conflicts should not complain about Trusteer version 3.5.1008.40 or above. Review URL: http://codereview.chromium.org/6880202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83138 0039d316-1c4b-4281-b951-d872f2087c98
* Move |printing_enabled_| preference into PrintJobManager.bauerb@chromium.org2011-04-274-37/+30
| | | | | | | | | | BUG=80025 TEST=none Review URL: http://codereview.chromium.org/6896055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83135 0039d316-1c4b-4281-b951-d872f2087c98
* Add and use gfx::ScopedNSGraphicsContextState ↵rsesek@chromium.org2011-04-2714-121/+99
| | | | | | | | | | | | (ui/gfx/scoped_ns_graphics_context_state_mac.h). BUG=none TEST=covered by tests Review URL: http://codereview.chromium.org/6904026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83125 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the URLRequestTestHTTP.NetworkDelegateTunnelConnectionFailed net ↵ananta@chromium.org2011-04-271-1/+3
| | | | | | | | | | | | | | | | test failures with ChromeFrame. This started occurring with a change in the URLRequestJob class to notify the network delegate about the request status in the URLRequestJob::NotifyStartError function. This is invoked for requests which fail right at the start, i.e. we fail to connect to the server etc. Fix is to invoke the NotifyStartError function on similar lines in the URLRequestautomationJob class. BUG=none TEST=chrome frame net tests should all pass. Review URL: http://codereview.chromium.org/6904017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83124 0039d316-1c4b-4281-b951-d872f2087c98
* Scrap WNDCLASSEX.hCursor, update GetCursorForPoint.msw@chromium.org2011-04-278-68/+29
| | | | | | | | | | | | | | | | | Default to Win arrow in View::GetCursorForPoint & RootView::UpdateCursor. Simplify WidgetWin::SetCursor, avoid sending NULL. Only SetCuror on client events (DWM handles non-client). RIP TextButtonWithHandCursorOver (r57652 through r64531). RIP WindowWin::InitClass & |resize_cursors_|. Add OVERRIDE specifiers liberally. BUG=35356 TEST=Cursor styles shown in Win & Linux toolkit_views. Review URL: http://codereview.chromium.org/6880201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83123 0039d316-1c4b-4281-b951-d872f2087c98
* Create a ThumbnailGenerator for each tab instead of using the global instance.mazda@chromium.org2011-04-274-35/+34
| | | | | | | | | | | | | This way, we can get rid of the property bag hack that relies on some internals of how TabContents and RenderViewHost work. BUG=65936 TEST=in-browser thumbnailing worked as before Review URL: http://codereview.chromium.org/6878039 Patch from Satoru Takabayashi <satorux@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83122 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure ConfigureDataTypes is not called in a re-entrant manner.lipalani@chromium.org2011-04-272-2/+29
| | | | | | | | | BUG=80343 TEST= Review URL: http://codereview.chromium.org/6904036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83117 0039d316-1c4b-4281-b951-d872f2087c98
* Mark KeywordProviderTest.Description disabled until it stops crashing on clangacolwell@chromium.org2011-04-271-1/+1
| | | | | | | | BUG=80612 TBR=maruel@chromium.org TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83115 0039d316-1c4b-4281-b951-d872f2087c98
* Download Safebrowsing url matching should use the standard algorithm, not a ↵mattm@chromium.org2011-04-272-18/+24
| | | | | | | | | | | direct comparison. BUG=80509 TEST=unittest, try downloading http://download.safebrowsingtest.com/download/test?foo Review URL: http://codereview.chromium.org/6904019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83112 0039d316-1c4b-4281-b951-d872f2087c98
* Show the dialog that to try again later if we get a clear pending error from ↵lipalani@chromium.org2011-04-271-2/+3
| | | | | | | | | | | | | the server. The bug was that we were not allowing the UI to transition to the given state. BUG=78550 TEST= Review URL: http://codereview.chromium.org/6901012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83107 0039d316-1c4b-4281-b951-d872f2087c98
* Mark KeywordProviderTest.Edit as disabled until it stops crashing on clang.maruel@chromium.org2011-04-271-1/+2
| | | | | | | | | BUG=80612 TBR=acolwell@chromium.org TEST=none TBR= git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83106 0039d316-1c4b-4281-b951-d872f2087c98
* Mark KeywordProviderTest.Edit as flaky until clang build can be fixed.acolwell@chromium.org2011-04-271-1/+1
| | | | | | | BUG=80612 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83104 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83100 - Remove weird dependency on extensions from webui.Re-plumb ↵aa@chromium.org2011-04-2617-117/+97
| | | | | | | | | extension request messages in a more sane way.Before, each RVH had ProcessWebUIMessage(), which wasserving as a manual way of plumbing both WebUI andextension messages to the right place, even though onlya few RVHD responded to either message.Instead of this, we now just teach more of the stack howto handle IPC messages in general, and delegate them upthrough the stack, giving each layer a chance to handlethem if it knows how.The result is simpler and smaller:179 insertions(+), 252 deletions(-)BUG=80311Review URL: http://codereview.chromium.org/6901021 TBR=aa@chromium.org Review URL: http://codereview.chromium.org/6905045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83103 0039d316-1c4b-4281-b951-d872f2087c98
* Remove weird dependency on extensions from webui.aa@chromium.org2011-04-2617-97/+117
| | | | | | | | | | | | | | | | | | | | | | | Re-plumb extension request messages in a more sane way. Before, each RVH had ProcessWebUIMessage(), which was serving as a manual way of plumbing both WebUI and extension messages to the right place, even though only a few RVHD responded to either message. Instead of this, we now just teach more of the stack how to handle IPC messages in general, and delegate them up through the stack, giving each layer a chance to handle them if it knows how. The result is simpler and smaller: 179 insertions(+), 252 deletions(-) BUG=80311 Review URL: http://codereview.chromium.org/6901021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83100 0039d316-1c4b-4281-b951-d872f2087c98
* Disable tests that are failing.asargent@chromium.org2011-04-261-3/+6
| | | | | | | BUG=80606 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83095 0039d316-1c4b-4281-b951-d872f2087c98
* Converts background_view from using WidgetGtk.sky@chromium.org2011-04-261-4/+1
| | | | | | | | | | BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6905034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83088 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Move AutocompleteEditViewGtk/autocomplete_edit_view_gtk.* to ↵tfarina@chromium.org2011-04-268-265/+258
| | | | | | | | | | | | | | | | ui/gtk/omnibox directory. - Rename AutocompleteEditViewGtk to OmniboxViewGtk. - Move autocomplete_edit_view_gtk.* to omnibox_view_gtk.* BUG=80186 TEST=None R=pkasting@chromium.org,evan@chromium.org Review URL: http://codereview.chromium.org/6905030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83086 0039d316-1c4b-4281-b951-d872f2087c98
* Add four new sync_integration_tests which exercise migration errors.nick@chromium.org2011-04-263-2/+14
| | | | | | | | | TEST=sync_integration_tests BUG=80333,79247 Review URL: http://codereview.chromium.org/6895012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83085 0039d316-1c4b-4281-b951-d872f2087c98
* Adding tests for new webstore beginInstallWithManifest method.asargent@chromium.org2011-04-263-0/+131
| | | | | | | | BUG=75821 TEST=none Review URL: http://codereview.chromium.org/6900059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83080 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and re-enable PrerenderBrowserTest.PrerenderInfiniteLoop.mmenke@chromium.org2011-04-261-4/+16
| | | | | | | | | BUG=80324 TEST=PrerenderBrowserTest.PrerenderInfiniteLoop Review URL: http://codereview.chromium.org/6893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83077 0039d316-1c4b-4281-b951-d872f2087c98
* Fix narrow dropzone of items in the language listkinaba@google.com2011-04-261-3/+17
| | | | | | | | | | | | | | | | | | | | | | | | | BUG=chromium-os:14320 TEST=1. Open "Languages and Input" preference page 2. Add several languages 3. Start dragging the 1st item 4. Drop it between the 2nd and the 3rd item Without this patch, the item is moved only when we drop the item exactly on the border line separating the 2nd and the 3rd item (exception: the left blank zone of the label text accepts the drop whereever we choose). In other words, we cannot drop over the label text. With this patch, we can drop over any area on list items. The cause of the issue is, that the introduction of [x] button http://codereview.chromium.org/6759049 adds <div> element below <li> element. Current implementation accepts drop only over <li> elements. Review URL: http://codereview.chromium.org/6899016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83074 0039d316-1c4b-4281-b951-d872f2087c98
* Ensures detached subtrees have root nodes that retain the previous parent.dtseng@chromium.org2011-04-266-26/+9
| | | | | | | | | Also, removes ReplaceChild, which doesn't seem to be used anymore. BUG=none TEST=BrowserAccessibilityManagerTest.TestReuseBrowserAccessibilityObjects2 Review URL: http://codereview.chromium.org/6902038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83072 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Compile fix for Natty in history menu codeerg@google.com2011-04-261-2/+2
| | | | | | | | | | | (Got lost in the merging) BUG=30213 TEST=compiles on natty Review URL: http://codereview.chromium.org/6904031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83069 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in menu code that would happen if you attempted to show asky@chromium.org2011-04-261-8/+82
| | | | | | | | | | | | | | | context menu while a context menu was already shown. The code would end up attempting to access an object that was since deleted (the MenuItemView). In fixing the crash I realized the logic wasn't quite right for this case either, so fixed that too and added a test. BUG=80392 TEST=see bug R=ben@chromium.org Review URL: http://codereview.chromium.org/6905033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83066 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83062 - Move WebUI ntp files into new ntp directory.And add myself to ↵estade@chromium.org2011-04-2631-65/+65
| | | | | | | | | an ntp watchlist.BUG=noneTEST=trybotsReview URL: http://codereview.chromium.org/6883154 TBR=estade@chromium.org Review URL: http://codereview.chromium.org/6903039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83063 0039d316-1c4b-4281-b951-d872f2087c98
* Move WebUI ntp files into new ntp directory.estade@chromium.org2011-04-2631-65/+65
| | | | | | | | | | | And add myself to an ntp watchlist. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/6883154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83062 0039d316-1c4b-4281-b951-d872f2087c98
* Move GpuProcessHostUIShim and GpuDataManager now that they don't depend on ↵jam@chromium.org2011-04-2611-773/+7
| | | | | | | | grit (which would have caused a circular dependency in gyp). Review URL: http://codereview.chromium.org/6903026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83060 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83044 - Fix CaptureVisibleTabRace to complete deterministically.Also ↵acolwell@chromium.org2011-04-262-2/+10
| | | | | | | | | | | fix expected/actual argument order in chrome.test.assertEq call andthe way we report kInternalVisibleTabCaptureError (we assign it to error_directly in all places but one).BUG=80212TEST=ExtensionApiTest.CaptureVisibleTabRaceReview URL: http://codereview.chromium.org/6894005 This caused ExtensionApiTest.CaptureVisibleTabRace to start failing on Mac 10.5. TBR=mihaip@chromium.org Review URL: http://codereview.chromium.org/6893033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83059 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 22:07:11 +0000