summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* [Mac] Enables animations for the infobar. Changes the control flow for ↵rohitrao@chromium.org2009-11-037-52/+216
| | | | | | | | | | | | | | | infobar opening/closing to match Windows more closely. Nib file changes: - Embedded the InfoBarGradientView inside an AnimatableView. - Rebound [controller view] to the AnimatableView and added an infoBarView_ IBOutlet. - Bound the AnimatableView's delegate_ to the InfoBarController. BUG=http://crbug.com/25599 TEST=Infobars should animate in and out, except for during tab switches. Review URL: http://codereview.chromium.org/354008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30893 0039d316-1c4b-4281-b951-d872f2087c98
* Changes session restore to use a normal load rather than preferringsky@chromium.org2009-11-0314-74/+107
| | | | | | | | | | | | the cache. We need to do this else we don't honor page expiration and end up showing stale data for some sites. BUG=21195 TEST=make sure session restore works. Review URL: http://codereview.chromium.org/341043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30892 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ShowModalDialogTest.BasicTest as FLAKYrafaelw@chromium.org2009-11-031-1/+2
| | | | | | | | | TBR=phajdan.jr,jam BUG=17806 Review URL: http://codereview.chromium.org/346045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30886 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up extension message port data in the renderer.mpcomplete@chromium.org2009-11-031-69/+0
| | | | | | | | BUG=26262 Review URL: http://codereview.chromium.org/344044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30884 0039d316-1c4b-4281-b951-d872f2087c98
* Use ChromeThread::DeleteOnIOThread in a few places where an object must be ↵jam@chromium.org2009-11-037-63/+36
| | | | | | | | | deleted on a certain thread. BUG=25354 Review URL: http://codereview.chromium.org/342090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30882 0039d316-1c4b-4281-b951-d872f2087c98
* Last patch in removing MessageLoop* caching.jam@chromium.org2009-11-0316-142/+104
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/353015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30881 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate QueryOptions::most_recent_visit_only. All non-unittest consumers ↵pkasting@chromium.org2009-11-0314-99/+35
| | | | | | | | | | of this set it to true, so just turn it on unconditionally. BUG=none TEST=none Review URL: http://codereview.chromium.org/341087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30880 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the db_loop_ member variable which is a unused following r30163.eroman@chromium.org2009-11-032-6/+0
| | | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/353023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30876 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prefs window sizing/spacing:thomasvl@chromium.org2009-11-031-24/+22
| | | | | | | | | | | | | - Make some vertical spacing in basics more consistent - Make some vertical spacing in personal stuff more consistent - Make the views a bit wider to avoid some clipping and wrapping in a few languages. - A little code cleanup, no longer allow the pref views to be different widths, this resulted in some really odd looks, so we want to mange the layout ourselves up front (things not always being as wide as the window, etc). TEST=window looks ok (given our strings it won't always look great, but shoot for ok). BUG=26586 Review URL: http://codereview.chromium.org/351027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30871 0039d316-1c4b-4281-b951-d872f2087c98
* Make page and wrench buttons have correct hover look.avi@chromium.org2009-11-031-0/+3
| | | | | | | | | | | | | xib changes: - cell tags changed to make them styled independently - button attribute "bordered" disabled BUG=http://crbug.com/25644 TEST=as in bug Review URL: http://codereview.chromium.org/341088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30869 0039d316-1c4b-4281-b951-d872f2087c98
* Remove context-based dependencies on SyncerSession from ApplyUpdatesCommand.tim@chromium.org2009-11-038-46/+48
| | | | | | | | | | | | | | This helps clarify UpdateApplicator and removes SyncerSession from SyncerUtil. Part of work to separate sync session "context" like the ConflictResolver, ServerConnectionManager, ModelSafeWorker, etc from progress state. BUG=25266 TEST=sync unit tests Review URL: http://codereview.chromium.org/351026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30868 0039d316-1c4b-4281-b951-d872f2087c98
* Add OS version information to the bug report utility for the Mac version.mirandac@chromium.org2009-11-032-3/+8
| | | | | | | | BUG= http://crbug.com/26138 TEST= none Review URL: http://codereview.chromium.org/355013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30867 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark context menu "Edit" starts with current name, not "New Folder".jrg@chromium.org2009-11-035-38/+74
| | | | | | | | | | | | | | | | | | "Add Folder..." from either buttons or bar happier (always adds, doesn't edit). "Add Folder..." now allows you to rename new folders the default name ("New Folder"). BUG=http://crbug.com/26364, http://crbug.com/26407 TEST=Over a bookmark button for a 'mark or folder, context menu --> Edit. Make sure initial name is current name, not "New Folder". Over button for 'mark, for folder, or bar itself: context menu --> Add Folder. Make sure initial name is "New Folder", and that it creates a folder (not a rename). Make sure you are allowed to create a folder named "New Folder". Review URL: http://codereview.chromium.org/345045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30866 0039d316-1c4b-4281-b951-d872f2087c98
* BrowserActionsContainer breaks for nobody... or maybe someonefinnur@chromium.org2009-11-031-1/+2
| | | | | | | | | | | | | | | | | just forgot to hit the breaks. :) This avoids triggering a NOTREACHED in the default case that I hit during testing. BUG=None TEST=Load the set_page_color sample extension in debug build of Chrome and it should not NOTREACH (it should... um... REACH?) when pressing the browser action icon. :) Review URL: http://codereview.chromium.org/351023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30862 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Initialize |restored_bounds_| so new windows always have a proper size.thestig@chromium.org2009-11-031-2/+2
| | | | | | | | BUG=none TEST=Resize window to 400x300, hold down ctrl+N, new windows should all be the same size. Review URL: http://codereview.chromium.org/355007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30855 0039d316-1c4b-4281-b951-d872f2087c98
* Disable open all bookmarks context menu item if there are no bookmarks.jrg@chromium.org2009-11-031-0/+11
| | | | | | | | | | | | | BUG=http://crbug.com/26071 TEST=New empty bookmark bar. Maker sure "Open all bookmarks" in context menu is disabled. (You'll need to click in the bottom of the bar so you don't overlap the text). Add a bookmark. Make sure "Open all bookmarks" in context menu is ENabled. Review URL: http://codereview.chromium.org/351018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30853 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adds a new view that will allow us to animate the height property of ↵rohitrao@chromium.org2009-11-033-0/+204
| | | | | | | | | | views. This class will be the base class for any view that needs to be animated. BUG=None TEST=No visible impact. New unittests should pass. Review URL: http://codereview.chromium.org/350002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30852 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark folder look Mac-yavi@chromium.org2009-11-031-1/+5
| | | | | | | | | BUG=http://crbug.com/26457 TEST=as in bug Review URL: http://codereview.chromium.org/342103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30849 0039d316-1c4b-4281-b951-d872f2087c98
* Check word lengths before adding to dictionary and spellchecking.jschuh@chromium.org2009-11-031-2/+2
| | | | | | | | BUG=20469 TEST=None Review URL: http://codereview.chromium.org/326012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30845 0039d316-1c4b-4281-b951-d872f2087c98
* Convert tabcontentscontainer to use a vbox instead of a fixed. Thetony@chromium.org2009-11-033-53/+11
| | | | | | | | | | | | | | | comment in the code mentions that a vbox would cause a split screen, but looking at the code, it seems like that's not possible because we hide the old TCVG before adding new ones. These days the vbox contains all TCVGs and only shows one at a time (I think in the past we tried to remove them, but we don't have that problem now). This simplifies the code by not having to use our own size-allocate handler. Review URL: http://codereview.chromium.org/354018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30843 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the temp dir created by CreateZip.thestig@chromium.org2009-11-032-7/+13
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/341074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30841 0039d316-1c4b-4281-b951-d872f2087c98
* Allows extension-devtools api to survive page navigation.jamesr@chromium.org2009-11-032-11/+2
| | | | | | | | | | | | | | | The problem was that the ExtensionDevtoolsBridge maintained explicit knowledge of the RenderViewHost is was monitoring. This would be invalidated on page navigations where the inspected RVH would be swapped out from underneath it. This patch removes knowledge of RenderViewHost from the ExtensionDevToolsBridge and makes sure it appropriately unregisters itself. Patch by: Jaime Yap (jaimeyap@google.com) TEST=none BUG=none Review URL: http://codereview.chromium.org/348042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30840 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix Text Encoding menu/submenuviettrungluu@chromium.org2009-11-031-0/+9
| | | | | | | | | | | | | | | (1) Clicking on the Text Encoding menu item should display the submenu, not try to execute a nonexistent command. (2) The Text Encoding menu item shouldn't be disabled, but instead the submenu's contents (so that the submenu is always visible). See Apple's HIG: <http://developer.apple.com/mac/library/DOCUMENTATION/UserExperience/Conceptual/AppleHIGuidelines/XHIGMenus/XHIGMenus.html#//apple_ref/doc/uid/TP30000356-TPXREF122>. Changes to MainMenu.xib: disconnected |-commandDispatch:| from the Text Encoding menu item. BUG=25957,26593 TEST=Check that the Text Encoding submenu is always available, with its contents disabled on the NTP (for example) and enabled (and working) on a normal web page. Check that clicking (and releasing) on the Text Encoding menu item itself shows the submenu. Review URL: http://codereview.chromium.org/345050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30836 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing in-process-browser interactive_ui_tests.rafaelw@chromium.org2009-11-031-5/+0
| | | | | | | | BUG=26540 Review URL: http://codereview.chromium.org/341078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30835 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky (crashing) ExtensionApiTest.Popuprafaelw@chromium.org2009-11-031-1/+3
| | | | | | | | | TBR=mad,twiz BUG=26599 Review URL: http://codereview.chromium.org/353021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30831 0039d316-1c4b-4281-b951-d872f2087c98
* Better handling of UNKNOWN versus QUERY in a couple ways.pkasting@chromium.org2009-11-034-15/+69
| | | | | | | | | | | | First, made it possible to navigate to "invalid" hostnames in a number of additional cases, including when the user types an explicit scheme or when we have a valid TLD and no spaces. The default action for these kinds of inputs is still search, but we'll pull up an accidental search infobar if need be now. Second, made the HistoryURLProvider show a What You Typed match for UNKNOWN inputs when the user explicitly typed "http:" or "https:" at the front, since these have the highest probability of being navigational inputs. BUG=26341 TEST=Type "http://foo bar baz.com" and verify you are given a (non-default) entry in the dropdown to navigate. Review URL: http://codereview.chromium.org/353010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30830 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prefs under the hood work:thomasvl@chromium.org2009-11-032-9/+72
| | | | | | | | | | | | | | | | | - Make all the controls/labels wrap to the width they get. - Make the content vertically shift as it is made to fit its strings. - Add more spacing for the sections as listed in bugs. - Consistent indents for the sections/subsections. - Update the code to use constant naming (was was "under the hood" and some was "advanced" (just so it is clear they are talking about one thing, and not two). - DEPS roll for GTM to pick up support for NSPathControl. TEST=Under the hood content should fit in all languages. BUG=20538 BUG=25595 BUG=25597 Review URL: http://codereview.chromium.org/355011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30825 0039d316-1c4b-4281-b951-d872f2087c98
* Add the plumbing and test code for plugins opening files from the sandbox. Thisbrettw@chromium.org2009-11-032-2/+23
| | | | | | | | | | | | | does not implement the actual opening of the files (currently the chain ends in resource_message_filter.cc), I will do that separately with some additional security review. This current patch just gets the synchronous request to the browser and returns a NULL result. TEST=none BUG=none Review URL: http://codereview.chromium.org/340050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30819 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: correct favicons in bookmarks bar (for pages w/o one and for subfolders).viettrungluu@chromium.org2009-11-032-30/+26
| | | | | | | | | | | Bookmarks for pages without a favicon should display a generic "blank page" icon (this also helps avoid a blank button if the bookmark also doesn't have a title). Also, folders within folders also need to display the folder icon. BUG=23558 TEST=See above; be sure to test things on the bar and in folders, and make sure that pages with favicons are still displayed correctly. Review URL: http://codereview.chromium.org/339087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30818 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Report Bug" dialog to Mac OSX.mirandac@chromium.org2009-11-035-1/+338
| | | | | | | | BUG= http://crbug.com/19282 TEST= Use report bug dialog on Mac OSX. Review URL: http://codereview.chromium.org/340039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30815 0039d316-1c4b-4281-b951-d872f2087c98
* Removes test that we're likely never going to reenable.sky@chromium.org2009-11-031-66/+32
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/340069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30813 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line flag to force all network traffic through a particular ↵mbelshe@google.com2009-11-032-5/+16
| | | | | | | | | | | | | | | | | | server. The command line is: --fixed-server=host:port When set, all traffic will be diverted through this server. This is useful for testing purposes with fixed servers. BUG=none TEST=none Review URL: http://codereview.chromium.org/345034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30798 0039d316-1c4b-4281-b951-d872f2087c98
* Re-commit "Add new user script injection point:aa@chromium.org2009-11-031-0/+5
| | | | | | | | | | | document_idle." Original code review: http://codereview.chromium.org/339064 BUG=26126 TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory problems.jrg@chromium.org2009-11-031-6/+6
| | | | | | | | | | | | Remove some dead code. Remove valgrind suppression which suppressed this error. BUG=http://crbug.com/26489 TEST=Mac valgrind bot stays green for ui_test BrowserEncodingTest.TestEncodingAliasMapping Review URL: http://codereview.chromium.org/355006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30793 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in getting rid of caching MessageLoop pointers.jam@chromium.org2009-11-0339-397/+365
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/345037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mem leak in sync tests by ensuring that the destruction tasks get to run.jam@chromium.org2009-11-031-0/+4
| | | | | | | | BUG=26493 Review URL: http://codereview.chromium.org/353011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30789 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r30784aa@chromium.org2009-11-031-5/+0
| | | | | | TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30787 0039d316-1c4b-4281-b951-d872f2087c98
* Add new user script injection point "document_idle" and make it the default.aa@chromium.org2009-11-031-0/+5
| | | | | | | | | | | | | Semantically, document-idle means "when the DOM is ready and layout has been idle for awhile", or more loosely, "as soon as we get around to it". Right now this uses a simple heuristic. It injects scripts 200ms after DOMContentLoaded, or immediately after onload, whichever happens first. BUG=26126 TEST=Manual. Extensions with content scripts should work. Review URL: http://codereview.chromium.org/339064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30784 0039d316-1c4b-4281-b951-d872f2087c98
* Use more ScopedTempDirs.thestig@chromium.org2009-11-031-11/+9
| | | | | | | | BUG=none TEST=ExtensionsServiceTest shouldn't leak temp files. Review URL: http://codereview.chromium.org/342085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30781 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting change from http://codereview.chromium.org/276029/showmad@chromium.org2009-11-0313-32/+389
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30778 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing DevToolsSanityTests on linux.rafaelw@chromium.org2009-11-031-0/+4
| | | | | | | | BUG=26540 Review URL: http://codereview.chromium.org/341075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30776 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 30766. It caused failures in ui_tests ↵pam@chromium.org2009-11-031-3/+1
| | | | | | | | | | | BrowserTest.SingleBeforeUnloadAfterWindowClose and apparently made the browser_tests crash. BUG=26398 TEST=covered by ui_tests and browser_tests Review URL: http://codereview.chromium.org/354015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30775 0039d316-1c4b-4281-b951-d872f2087c98
* Re-landing of r30726, which was reverted as a possible cause of chromeos ↵estade@chromium.org2009-11-023-1/+28
| | | | | | | | | | | | | | | | | | | buildbot failures Handle GTK enter and leave notification events and pass them to WebKit as mouse move events. This prevents an HTML widget from staying in the mouseover state when the cursor leaves the window. Add a new ui test that checks the specific case that was broken by warping the mouse pointer inside and outside the content area. BUG=24660 TEST=ui_tests patch by Dominic Mazzoni <dmazzoni [at] google> original review: http://codereview.chromium.org/274010/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30771 0039d316-1c4b-4281-b951-d872f2087c98
* Set active_dialog_ before showing it, since showing a dialog can sometimespam@chromium.org2009-11-021-1/+3
| | | | | | | | | | | | actually move to the next one in the queue instead. BUG=26398 TEST=Make sure alert/confirm boxes work properly. Make sure a background tab that shows a (delayed) alert box works. Same with a background browser. Especially make sure http://crbug.com/10699 doesn't recur. Review URL: http://codereview.chromium.org/339094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30766 0039d316-1c4b-4281-b951-d872f2087c98
* Add LoadLog to ClientSocket::Connect().willchan@chromium.org2009-11-022-3/+9
| | | | | | | | TODO: Use LoadLog in FLIP code. Review URL: http://codereview.chromium.org/344026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30765 0039d316-1c4b-4281-b951-d872f2087c98
* bookmark STAR bubble: Disambiguate folders with the same namejrg@chromium.org2009-11-023-20/+67
| | | | | | | | | | | | | | | | | | | | BUG=http://crbug.com/19408 TEST=Create a bookmark. Create 2 bookmark folders both with the same name, "foo". Go to your bookmarked page. Click STAR to get bookmark bubble. Change parent folder to the 1st "foo". Confirm it's there on the bar. Click STAR to get bookmark bubble. Change parent folder to the 2nd "foo". Confirm it's there on the bar. Click STAR to get bookmark bubble. Chose "choose another folder" to be sure that logic still works. Review URL: http://codereview.chromium.org/340042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30762 0039d316-1c4b-4281-b951-d872f2087c98
* disable inactive rendering for ExtensionPopuperikkay@chromium.org2009-11-021-0/+5
| | | | | | | | | BUG=26502 TEST=none Review URL: http://codereview.chromium.org/345043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30758 0039d316-1c4b-4281-b951-d872f2087c98
* Remove themes/default.dll and merge the resources into chrome.dll.tc@google.com2009-11-022-5/+0
| | | | | | | | | | | This gives us one less file to load on startup. This does mean that some tests need to explicitly include theme_resources.rc. BUG=24035 Review URL: http://codereview.chromium.org/348033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30755 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory bug in the new ResizeThenCrash test.creis@chromium.org2009-11-021-2/+3
| | | | | | | | | | | | (Related to http://codereview.chromium.org/348025) BUG=25097 TEST=RenderWidgetHostTest.ResizeThenCrash Review URL: http://codereview.chromium.org/353008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30753 0039d316-1c4b-4281-b951-d872f2087c98
* Fourth patch in getting rid of caching MessageLoop pointers.jam@chromium.org2009-11-0213-315/+239
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/348037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30751 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 02:02:46 +0000