| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
.app bundle, and make them available to the packaging system. This ensures
that the packager uses the correct logic to sign a bundle, and places the
correct Keystone auto-update script into the package. Because things may
move around in the bundle and the proper codesign invocation may change
between versions, it is correct to store the codesign logic with the package
being signed. Similarly, because the correct way to perform an client-side
auto-update may change between versions, it is correct to store the
auto-update script with the code.
BUG=14610 (in support of unbreaking auto-update)
TEST=none
Review URL: http://codereview.chromium.org/261048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't have html popups yet but clicking should work (e.g. print button works).
TODO: port browser_action in proc browser test.
TODO: badges
BUG=23882
TEST=loaded gmail browser action extension, loaded print bookmark bar extension, loaded them both, unloaded, disabled, enabled, etc.
Review URL: http://codereview.chromium.org/273025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Although turning back on the browser focus tests that had been turned off last week because of my previous attempt at performing this refactoring (that change was reverted).
BUG=None
TEST=Build and run the interactive ui tests on Windows and Linux.
Review URL: http://codereview.chromium.org/273029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Javascript can communicate with it. The required html, javascript and nexe files are checked in into the NaCl tree.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28796
Review URL: http://codereview.chromium.org/272005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-[NSApplication sendAction:to:from:] is a central dispatcher for
target-action messages sent by controls. Backtraces from here often
contain only Cocoa messages, making it hard to tell where things are
at when a freed target gets messaged. Add additional info like the
action being requested and the tag of the sender.
http://crbug.com/24460
TEST=Browser continues to work.
Review URL: http://codereview.chromium.org/269039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and verifies that Javascript can communicate with it. The required html, javascript and nexe files are checked in into the NaCl tree.
Review URL: http://codereview.chromium.org/272005
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/270080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Javascript can communicate with it. The required html, javascript and nexe files are checked in into the NaCl tree.
Review URL: http://codereview.chromium.org/272005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
couple of
additional things here:
. Avoid doing anything in OnSizeAllocation if the size hasn't
changed. Because of how gtk works I was getting stuck in a loop if I
OnSizeAllocate did anything if the size hadn't changed.
. Applied similar shortcut to TabContentsViewGtk.
. Made SimpleMenuModel only ask delegate for checked state if the item
is a check.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/261051
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/267069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* changed gyp files so that all files compiled for chrome os will be also compiled when toolkit_views==1
* changed to define OS_CHROMEOS when toolkit_views==1
* changed TabOverbiewMessageListener to use BrowserView instead of BrowserWindowGtk when toolkit_views==1
I left one for CHROME_NOTIFY_FLOATING_TAB_OVER_TOPLEVEL b/c i couldn't figure out how to get gdkwindow
from xid. Looks like I need to register it somewhere
Note: Nicolas updated trybot and buildbot to include chromeos dependency, so this all should compile fine.
BUG=none
TEST=run views unit test and browser.
Review URL: http://codereview.chromium.org/262027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
additional things here:
. Avoid doing anything in OnSizeAllocation if the size hasn't
changed. Because of how gtk works I was getting stuck in a loop if I
OnSizeAllocate did anything if the size hadn't changed.
. Applied similar shortcut to TabContentsViewGtk.
. Made SimpleMenuModel only ask delegate for checked state if the item
is a check.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/261051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/194108
Review URL: http://codereview.chromium.org/271052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
app/gfx in preparation for removing the base_gfx project. This also moves
base/window_impl.cc to app/win/window_impl because this file shouldn't be in
base.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/273017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
breaking the interactive ui tests. It just needs a clobber.
It looks like 2 parts of the code don't agree on the number of
buttons on the bookmark bar. Maybe because part of the code is
compiled with CHROME_PERSONALIZATION = 1 while the test is compiled
with CHROME_PERSONALIZATION = 0. Maybe this new gyp change broke the
define propagation. This is really easy to replicate, and should also
be easy to debug.
Original Log:
Relanding the interactive UI tests GYP factor out, as it turns
out it is not responsible for breaking the interactive ui tests.
Review URL: http://codereview.chromium.org/271046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We can yank it from deps/ following this.
BUG=19895
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/261042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
depends on it).
Review URL: http://codereview.chromium.org/270053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
were all sort of intertwined.
Fixes up patterns in general so that they are all in phase.
Moves the window widget buttons down by two pixels.
Draws overlays correctly.
Fixes up some accessibility issues with the default window widgets.
Gets rid of some out of date files (tab_cell).
BUG=18438, 18547, 19851, 20295, 22213, 23651, 24338
TEST=Launch Chrome. Switch to "dots" theme from the Google themes. Create a couple of tabs. Check to make sure that the background pattern line up with the tabs. Move the tabs around. Check that the hightlight colors and text colors look correct for all of the tabs. Make sure the patterns stay lined up. Resize the window, make sure none of the patterns move around. Create new windows by dragging the tabs out of the windows and make sure a new window is created with the correct pattern. Show the "find" bar. Make sure its pattern lines up correctly with the tabbar. Switch to default theme. Make sure it looks correct and draws properly. Switch to Zen theme and make sure that the overlay at the top draws correctly. Create a new window. make sure that the rollovers in the window widgets work correctly in both the active and inactive window. Mouse down on the zoom button in the inactive window and notice that the window context changes. Move off of the zoom button and mouse up. Mouse down on the miniaturize button on the inactive window and notice that the window context does not change. Move off of the miniaturize button and mouse up. Do the same thing you did for the miniaturize button for the close button. Start up Accessibility Inspector from the developer tools. Make sure that the window widgets report their accessibility information correctly.
Review URL: http://codereview.chromium.org/260009
Patch from dmaclach@chromium.org.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ThemeInstalledInfoBarDelegate
Contributed by Thiago Farina <tfarina@gmail.com>
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- XIB change: The controller has a connection to buttonView_.
- BrowserThemeProviderMac: Fix a bug where we weren't returning
default colors; we returned nil instead.
- The majority of the implementation is actually the cross platform
NtpBackgroundUtil::PaintBackgroundDetachedMode. We do platform
specific drawing on top of the background, though.
TEST=BookmarkBarToolbarViewTest.DisplayAsFloatingBarWithNoImage
TEST=BookmarkBarToolbarViewTest.DisplayAsFloatingBarWithBgImage
BUG=http://crbug.com/17625
Review URL: http://codereview.chromium.org/266027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
out it is not responsible for breaking the interactive ui tests.
See http://codereview.chromium.org/259018/show
TBR=brettw
Review URL: http://codereview.chromium.org/270042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added a command line option to enable verbose logging in the Sandbox. This will be useful when we start looking at the information in ChromeBot.
* Modified the code that splices the homedir path into the Sandbox file. This code is now only used on 10.6 and no longer uses a regex.
* Moved sandbox code out into a sandbox_mac file.
* Changed 10.6 seed release references -> 10.6 .
BUG=21483
TEST=Browser should launch and display NTP correctly on OS X 10.5 & 10.6
Review URL: http://codereview.chromium.org/242165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add some new strings that didn't exit to the grd file needed by Mac prefs.
Update all the strings in the file to use the localizer.
BUG=20538
TEST=Almost all the pref strings should be localized, there area few new ones that won't show up localized until we do a TC run. The controls do *NOT* auto size yet, so there can be clipping/oversized controls.
Review URL: http://codereview.chromium.org/273001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
committing a bunch of local changes individually with
bad commit messages.
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/268024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome Helper.
BUG=24219
TEST=none
Review URL: http://codereview.chromium.org/269018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
both views and gtk.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/265041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
HungRendererDialog.xib: made the "Wait" button's use Return as its normal key
equivalent; changed the "Wait" button's class to MultiKeyEquivalentButton.
BUG=21074
TEST=about:hang. Return, Enter, Esc, and Command-. (period) should all dismiss
the Hung Renderer dialog with "Wait".
Review URL: http://codereview.chromium.org/266026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I'm going to be modifying this file a lot and the single big file
was hard to work with.
Review URL: http://codereview.chromium.org/265040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add high res timer class for mac (we might eventually replace all timer classes with Chrome ones)
- Define POSIX for OS==mac where needed
- Add new liens at the end of some files since otherwise they produce errors on Mac
- Rearrange initializer list of constructors to match declaration order in header; these become warning as error.
- Some chrome.gyp magic
At this point the code compiles but doesn't link due to some missing code on Mac like SSL stuff. But
I thought this was a good check point.
Note that chrome.gyp magic might change in future.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21147
TEST=otool -L "Chromium Framework.framework/Chromium Framework" should show
the current and compatibility numbers as build.patch.0 instead of 0.0.0.
Review URL: http://codereview.chromium.org/265037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=The interactive tests should still build and run on Windows and Linux
Review URL: http://codereview.chromium.org/259018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BoookmarkContextMenuGtk. I need to do this so that views/gtk can use
both BookmarkContextMenu and BookmarkContextMenuGtk.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/261013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when sad tab is showing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/270018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove the alert icon from the download item dangerous download xib.
- Remove the download fav icon from the download shelf xib.
- Update the download shelf to fetch the image from the pak.
- Update the download item to fetch the alert image from the pak.
- Update the bookmark bar to fetch the folder icon from the xib and cache it.
- Remove the three images from the bundles.
BUG=20230
TEST=all three still show their images
Review URL: http://codereview.chromium.org/260012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/18854
TEST=Titles on mouse-over in Expose. No extra title in titlebar.
Review URL: http://codereview.chromium.org/259023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
isolated world. Chromium side of change.
Review URL: http://codereview.chromium.org/262002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Have the system_metrics generated code depend on 'protobuf_lite'.
Review URL: http://codereview.chromium.org/242117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
observe changes.
- implemented power menu button showing remaining battery info.
- implemented clock menu button showing detailed clock info.
- also implemented monitoring of network status change.
- don't show highlighted state for these menu buttons
BUG=23923
TEST=none
Review URL: http://codereview.chromium.org/251099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
original issue: http://codereview.chromium.org/207062
The issue had to do with a symbol collison with the nss libraries (which are currently out-of-date) on the build bots.
HTML Pack Extension Dialog. This removes the views implementation of the ExtensionPackDialog, and implements the dialog in html in the extensions_ui DOMUI.
Additionally, support is added for packaging extensions via ---pack-extension on linux and mac
BUG=20668, 20669
TBR=aa,wtc
Review URL: http://codereview.chromium.org/265032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=rebuild gyp files, open chrome.sln. Observer chrome_frame project.
Review URL: http://codereview.chromium.org/271014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert r28350 aka http://codereview.chromium.org/259023
Passed the trybots because of DCHECK which wasn't there for build
bots.
TBR=zork
Review URL: http://codereview.chromium.org/271015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19895
TEST=AuthWatcherTest
Review URL: http://codereview.chromium.org/246098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/18854
TEST=Titles on mouse-over in Expose. No extra title in titlebar.
Review URL: http://codereview.chromium.org/259023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
falls back to extension subtree.
We look for ext_root/foo/bar.js under ext_root/_locales/fr/foo/bar.js if current locale is fr. If there is no fr specific resource we load ext_root/foo/bar.js instead.
Lots of small refactoring to replace FilePath with ExtensionResource.
BUG=12131
TEST=See unittest for sample tree.
Review URL: http://codereview.chromium.org/256022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1."
This reverts commit c18585b4bd75664122be8af6ff1170cc5c6efc66.
TBR=tc
Review URL: http://codereview.chromium.org/270015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
original issue: http://codereview.chromium.org/207062
Attempting to land this patch earlier resulted in compile failures on linux valgrind and linux perf that I was unable to reproduce.
I am splitting this into two pieces. This piece adds extension packing support via --pack-extension for mac & linux.
BUG=20668,20669
Review URL: http://codereview.chromium.org/266007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/271001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=10051
TEST=none
Review URL: http://codereview.chromium.org/255100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/263006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and onload.""
This reverts commit r28209 and relands r28199.
The failure seems to have been flaky (it passed on the other bots and on the following run). I want to
try to land again. If it fails again, I'll disable the test.
TBR=mattm
Review URL: http://codereview.chromium.org/268003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28268 0039d316-1c4b-4281-b951-d872f2087c98
|