| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move JsTransactionObserver code into JsMutationEventObserver.
Move ChangeObserver methods of JsSyncManagerObserver to
JsMutationEventObserver.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7982049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make EntryKernel/Entry/BaseNode use base::Time instead of int64s.
Add sync/util/time.h, with utility functions to manage the sync proto
time format.
Store times on disk in proto format instead of the local system.
This requires a database version bump (to 77).
Update SessionChangeProcessor/SessionModelAssociator
to use base::Time, too.
Remove hackish Now() function.
Remove ZeroFields() function, and instead zero-initialize in EntryKernel::EntryKernel() directly.
BUG=
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102184
Review URL: http://codereview.chromium.org/7981006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make EntryKernel/Entry/BaseNode use base::Time instead of int64s.
Add sync/util/time.h, with utility functions to manage the sync proto
time format.
Store times on disk in proto format instead of the local system.
This requires a database version bump (to 77).
Update SessionChangeProcessor/SessionModelAssociator
to use base::Time, too.
Remove hackish Now() function.
Remove ZeroFields() function, and instead zero-initialize in EntryKernel::EntryKernel() directly.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7981006
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/7977034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make EntryKernel/Entry/BaseNode use base::Time instead of int64s.
Add sync/util/time.h, with utility functions to manage the sync proto
time format.
Store times on disk in proto format instead of the local system.
This requires a database version bump (to 77).
Update SessionChangeProcessor/SessionModelAssociator
to use base::Time, too.
Remove hackish Now() function.
Remove ZeroFields() function, and instead zero-initialize in EntryKernel::EntryKernel() directly.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7981006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
into theme_resources. This gives us less .vcproj and .xcodeproject
files on Win/Mac making things load a bit quicker.
Also remove unused generated files from
theme_resoures_large.grd.
BUG=None
TEST=compiles
Review URL: http://codereview.chromium.org/7906022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=build it on linux (make/ninja), check no warning of duplicate rule
Review URL: http://codereview.chromium.org/7920025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Define ChangeRecordList and ImmutableChangeRecordList. Pass those around
instead of (ChangeRecord*, size) pairs.
Remove unused OnMigrationNeededForTypes().
BUG=85658,85481
TEST=
Review URL: http://codereview.chromium.org/7918001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rework SharedValue<T> into Immutable<T>, which behaves similarly but is
easier to use and is better documented.
Make everything that used SharedValue<T> use Immutable<T> instead.
Make SyncData use Immutable<T>.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7904021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7885053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change EntryKernelMutationSet to EntryKernelMutationMap so that it can be filled in-place.
Create a new class SharedEntryKernelMutationMap which is a thread-safe
immutable wrapper around an EntryKernelMutationMap. Pass it around instead of the mutation map directly.
Generalize SharedValue and move it to sync/util.
Move the mutation limit to the JsTransactionObserver.
BUG=96483
TEST=
Review URL: http://codereview.chromium.org/7889020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
targets are very simple and used little code from chrome targets. However their dependency on chrome targets was problematic because a lot of code wasn't being built for 64 bit on Windows, and so there were a lot of "dummy" files being added with stub functions and code was also being compiled out in random places for NACL_WIN64.
I've made the NaCl 64 bit windows targets self contained. They do use a few files from common, but those files are self-contained. In the future, we could move these to be in the same 64 bit target as the constants from common. However that won't make a maintenance difference since someone could still introduce link dependencies to other files in common.
Additionally, since we're not using chrome code anymore, we can avoid having both nacl.exe and nacl.dll. nacl.exe is sufficient, and this saves 1.4MB of uncompresed binaries in the installer.
BUG=86322
Review URL: http://codereview.chromium.org/7863024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
grit/format/data_pack class.
Marked tools/data_pack directory for removal when the dependency in third_party file WebKit.gyp has been updated to point to grit.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/7795057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the last set of strings out of autofill_resources.grd into C++ string
literals. Delete autofill_resources.grd and remove it from gyp.
BUG=None
TEST=Covered by unittests.
Review URL: http://codereview.chromium.org/7782037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is not a third party file.
On my machine, this speeds up a full recompile of the 'chrome' target
in Debug mode by about 18%.
BUG=none
TEST=it builds, existing tests pass
Review URL: http://codereview.chromium.org/7706011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default app CRXs in the build/installer output.
BUG=94920
TEST=Do an Official build in mac and win. Ensure that after installing the app, you can find the default apps under the install's directory structure. For win, this is under a default_apps directory, for mac, this is under a "Default Apps" directory.
Review URL: http://codereview.chromium.org/7827021
TBR=stevet@chromium.org
Review URL: http://codereview.chromium.org/7795038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the build/installer output.
BUG=94920
TEST=Do an Official build in mac and win. Ensure that after installing the app, you can find the default apps under the install's directory structure. For win, this is under a default_apps directory, for mac, this is under a "Default Apps" directory.
Review URL: http://codereview.chromium.org/7827021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AFAICT, this target is no longer needed, but just to be safe, I'm
going to remove the dependencies incrementally. This change removes
the third_party entries and loads 5 less vcproj files in chrome.sln.
BUG=94622
Review URL: http://codereview.chromium.org/7828048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
symbol from the binaries.
Review URL: http://codereview.chromium.org/7828043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
embedders. I've only moved a little bit of the code for now, and will do the rest in followup changes.
BUG=90445
Review URL: http://codereview.chromium.org/7817015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=94007, 70276
TEST=sync_integration_tests.exe
Review URL: http://codereview.chromium.org/7621085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change moves the following files from sync/engine to sync/internal_api:
- change_reorder_buffer.{cc,h}
- configure_reason.h
- http_post_provider_interface.h
- http_post_provider_factory.h
- syncapi_server_connection_manager.{cc,h}
As part of the change, the SyncScheduler::ScheduleConfig function was modified
to take a sync_pb::GetupdatesCallerInfo::GetUpdatesSource parameter instead of
a syncapi::ConfigureReason.
The remaining changes were mainly updates to include directives and DEPS
files.
BUG=93816
TEST=
Review URL: http://codereview.chromium.org/7719011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome frame has dialogs in generated_resources.grd that are
not included in the pak files. They should continue to use the
locale dlls.
BUG=94362
Review URL: http://codereview.chromium.org/7760002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows.
We were using .dlls, but the .pak files are smaller and this will
allow us to share more code across platforms.
- Remove app/locales.gyp (used on win to generate the locale
dlls) and references to it in other gyp(i) files.
- Update various packaging scripts.
- Move functions from resource_bundle_posix.cc to
resource_bundle.cc (LoadResourcesDataPak, UnloadLocaleResources,
GetLocalizedString, LoadLocaleResources) and delete the
corresponding functions from resource_bundle_win.cc.
Fixes from previous patch:
- Made dependencies of packed_resources explicit (MSVS can't figure
it out from the inputs).
- Removed a couple cases where we were looking for dlls on Windows
(in l10n_util.cc and l10n_util_unittest.cc).
BUG=92724
TBR=cpu
Review URL: http://codereview.chromium.org/7714028
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/7744053
TBR=battre@chromium.org
Review URL: http://codereview.chromium.org/7759001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were using .dlls, but the .pak files are smaller and this will
allow us to share more code across platforms.
- Remove app/locales.gyp (used on win to generate the locale
dlls) and references to it in other gyp(i) files.
- Update various packaging scripts.
- Move functions from resource_bundle_posix.cc to
resource_bundle.cc (LoadResourcesDataPak, UnloadLocaleResources,
GetLocalizedString, LoadLocaleResources) and delete the
corresponding functions from resource_bundle_win.cc.
Fixes from previous patch:
- Made dependencies of packed_resources explicit (MSVS can't figure
it out from the inputs).
- Removed a couple cases where we were looking for dlls on Windows
(in l10n_util.cc and l10n_util_unittest.cc).
BUG=92724
TBR=cpu
Review URL: http://codereview.chromium.org/7714028
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/7744053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The operative portion of this change simply renames
chrome/app/chrome_exe_main_mac.mm to chrome/app/chrome_exe_main_mac.cc. The
main executables never used any Objective-C anyway. I named the files with .mm
a long time ago because at the time it meant that I didn't need to add a
separate GYP 'exclude' rule to keep other platforms from seeing the file. That
was before we added the rules to automatically exclude files based on platform
suffix like _mac.
This change also adds a "verify" step to the targets that build our main
executables. The verify step will cause a build failure if this ever
regresses.
This works around a bug in 10.5 CFBundlePreflightExecutable, which crashes
when called in a process whose main executable has slid due to PIE when the
main executable also contains an __OBJC,__image_info section. We enabled PIE
at r91243.
BUG=88697
TEST=No more crashes inside CFBundlePreflightExecutable (on our call from
webkit::npapi::PluginLib::ReadWebPluginInfo) on 10.5
Review URL: http://codereview.chromium.org/7726007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were using .dlls, but the .pak files are smaller and this will
allow us to share more code across platforms.
- Remove app/locales.gyp (used on win to generate the locale
dlls) and references to it in other gyp(i) files.
- Update various packaging scripts.
- Move functions from resource_bundle_posix.cc to
resource_bundle.cc (LoadResourcesDataPak, UnloadLocaleResources,
GetLocalizedString, LoadLocaleResources) and delete the
corresponding functions from resource_bundle_win.cc.
Fixes from previous patch:
- Made dependencies of packed_resources explicit (MSVS can't figure
it out from the inputs).
- Removed a couple cases where we were looking for dlls on Windows
(in l10n_util.cc and l10n_util_unittest.cc).
BUG=92724
TBR=cpu
Review URL: http://codereview.chromium.org/7714028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Client loader processes.
Some plug-ins depend on having an executable heap. They write code to data
pages and attempt to execute it without calling mprotect to mark this code
as executable.
Native Client needs to allocate a contiguous 1GB of address space. ASLR may
interfere with there being a "hole" this large in the address space by the
time NaCl makes its request.
Non-executable heaps are only available in 10.7 and later for 32-bit
processes.
PIE/ASLR was formerly disabled for all processes other than the browser
process. This change reenables it for all processes other than the NaCl
loader. PIE/ASLR is available on 10.5 and later, although the implementation
is stronger in 10.7 than in earlier releases.
This change results in two new helpers in addition to the existing
Chromium Helper.app: Chromium Helper EH.app (for executable heaps) and
Chromium Helper NP.app (for no PIE). libplugin_carbon_interpose.dylib moves
out of the helper .app and directly into the versioned directory. The
InfoPlist.strings have been removed from the helper app, but empty .lproj
directories remain.
BUG=90221, 93551
TEST=everything
Review URL: http://codereview.chromium.org/7714018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7694031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7695004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Everything should now be using third_party/leveldatabase.
This requires webkit to be rolled past r93278. I'll launch try jobs then.
BUG=89378
TEST=llvm/Debug/browser_tests --gtest_filter=ExtensionSettings*
Review URL: http://codereview.chromium.org/7677023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Just a refactoring.
Review URL: http://codereview.chromium.org/7677034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7691001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/7633077/
Fragment syncapi.h into sync/internal_api/*
This commit splits syncapi.cc and syncapi.h into many files. Most of these files have been moved to the newly created chrome/browser/sync/internal_api.
Each of the following classes now have their own .cc and .h files:
- BaseNode
- ReadNode
- WriteNode
- BaseTransaction
- ReadTransaction
- WriteTransaction
- UserShare
- SyncManager
Functions formerly declared at file-scope in syncapi.cc and shared among several classes are now declared in engine/syncapi_internal.h. We intend to use DEPS rules to prevent these functions from being included in non-syncapi classes.
Test classes closely related to syncapi.h classes have been moved from engine to internal_api.
This change necessarily touches the #include lists for lots of files and some of the sources lists in .gyp.
This change should have no effect on program behaviour.
BUG=19878
TEST=
Review URL: http://codereview.chromium.org/7624009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This issue was originally http://codereview.chromium.org/7584007/
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7663001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This target generates the locale .pak files on Windows. Since nothing
depends on this target, it doesn't build by default (they're not used
yet).
Specific changes:
- Have locale_settings_win.grd generate .pak files.
- Use pymod_do_main to avoid some shell escaping problems (and it's a bit
faster).
- Rewrite repack_locales.py to work with pymod_do_main.
BUG=92724
Review URL: http://codereview.chromium.org/7648001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
parsing.
Also, rename utility_functions to webdriver_util and alphabetize gyp target.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7522024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7584007
TBR=saintlou@chromium.org
Review URL: http://codereview.chromium.org/7648040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Includes code for the driver itself. Also modifies the browser process as well as service process to register Apple Event handlers. Also changes the service process to allow registration of driver.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7485011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7584007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92329
TEST=manual
Review URL: http://codereview.chromium.org/7497069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove references to event_sys. Moves some files around.
No functional change.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7587009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: This was a TODO for akalin.
BUG=None
TEST=None
R=akalin@chromium.org
Review URL: http://codereview.chromium.org/7497051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some general notes:
- It's a lot of code for a single review, about 1.5K lines (plus tests, plus those generated docs, = 3.5K). Apologies. But it's close to the minimal amount of useful functionality. I've left some TODOs in the code to fix up soon.
- No integration-style tests, but I'll start writing those now. Works from within a browser though.
- Sync not hooked up yet, of course.
- Ditto events.
- Ditto thinking about incognito mode.
- Ditto fun bugs like what happens if you set key "foo.bar" to "baz".
- This is the first significant amount of C++ code I've ever written... so don't hold back.
- The docs (i.e. my changes to extension_api.json) are a little incomplete, and I'm aware of that.
A summary of the implementation:
- There is an ExtensionSettings factory-type object which hands out ExtensionSettingsStorage areas for extensions. You may notice that I basically did the same thing that ExtensionPreferences does (so, lives with the profile, etc).
- ExtensionSettingsStorage is a pure interface, with three implementations.
- the main leveldb implementation.
- a caching decorator, designed to sit on top of the leveldb implementation.
- a "no-op" implementation which gives a trivial in-memory storage area when wrapped with a cache. This is used in the cases where the leveldb database fails to initialise (ExtensionSettings handles this).
- and note that my plan is, when hooking up sync, that this will be implemented as another decorator.
- ... the code is pretty well documented so not much else to say.
For testing, turns out gtest is pretty snazzy. There are a bunch of test fixtrues in extension_settings_storage_unittest.h, so that 3 different configurations are tested: leveldb, leveldb + cache, and no-op + cache.
BUG=47327
TEST=unit tests provided
Review URL: http://codereview.chromium.org/7189029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=77634
TEST=None
R=akalin@chromium.org
Review URL: http://codereview.chromium.org/7550059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for testing Native Client's support for Breakpad on
x86-64. However, ultimately crash_service is only used for testing
(Google Update's crash reporter is what is used in an installation of
the official Chrome build).
Initially, crash_service.exe will only work on x86-32 processes, and
crash_service64.exe will only work on x86-64 processes.
Eventually we will want to make crash_service64.exe work for both
32-bit and 64-bit processes.
It might not be possible to make crash_service.exe work on 64-bit
processes because Windows' ReadMemory() function only works on 64-bit
target processes if the caller is a 64-bit process.
BUG=89730
TEST=NaCl's run_inbrowser_trusted_crash_in_startup_test
Review URL: http://codereview.chromium.org/7541057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=tony@chromium.org
Review URL: http://codereview.chromium.org/7491072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7464040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=84078
TEST=it builds
Review URL: http://codereview.chromium.org/7554019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This simplifies the handling of JS messages, replies, and events.
Made ProcessJsMessage take a WeakHandle to a JsReplyHandler instead of
having a JsEventRouter class (which is now removed).
Add JsBackend parameter to OnInitializationComplete().
Renamed JsFrontend to JsController.
Renamed JsEventHandlerList to SyncJsController.
Handle events that happen before sync is initialized.
Made about:sync work in incognito mode.
BUG=90942,76809
TEST=
Review URL: http://codereview.chromium.org/7518014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Use grit_action.gypi for devtools_frontend_resources. The grd file
is not generated so we should use the gypi.
2) Have devtools_resources depend on the grit source files. This grd
file is generated, so we can't run grit_info.py on it at gyp time.
I've modified grit_info.py --inputs to take no arguments to just list
out all the grit source files. This will at least cause us to rebuild
properly if there is a change to grit.
BUG=none
TEST=Compile resources.pak and make sure there are no spurious rebuilds.
Touch a grit source file and make sure that devtools_frontend_resources
and devtools_resources rebuild.
Review URL: http://codereview.chromium.org/7493084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94792 0039d316-1c4b-4281-b951-d872f2087c98
|