| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/126058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These are archived and submitted to the crash server by the official builder
(coming in a separate buildbot CL).
Review URL: http://codereview.chromium.org/126015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the file easier to find, and for unittests that try to scan it (like tab_switching), they then don't have to walk into the bundle.
Compile tab_switching_test on mac/linux.
Add a dep for app to tab_switching_test so building it also make sure the app is built (since it runs the app)
Update tab_switching_test
Use FilePath in all cases instead of wstring.
Limit how long it will spin looking for the log log file so the test can't hang.
TEST=the new test is built on mac/linux
BUG=none
Review URL: http://codereview.chromium.org/126049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add dependency on the 'theme_dll' target, commented out
to avoid a problem with default.lib not being generated.
* Make the location of the generated chrome_dll_version.rc file consistent
with other uses of SHARED_INTERMEDIATE_DIR.
* Add the necessary generated *_resources.rc to 'sources'.
* Remove 'process_outputs_as_sources' from the 'chrome_dll_version'
action. It's now that it's in its own target.
* Add settings from chrome\app\chrome_dll.vsprops.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
by the (new) 'chrome_dll_version' target, not by rolling its own.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
customize it.
Changes include
1. A HandleContextMenu function which can be implemented by a TabContentsDelegate. Currently only ExternalTabContainer implements this.
2. Removed InitMenu calls from the RenderViewContextMenu subclass constructors, We need the subclasses to be able to override individual AddMenuItem calls. The newly added RenderViewContextMenuExternalWin class derives from RenderViewContextMenuWin whose constructor calls InitMenu. This happens at a time when the vtable is not yet setup. To fix this we added an Init function to the RenderViewContextMenu base class which then calls a virtual function DoInit, which derived classes can override to perform specific initializations.
3. Added automation messages to send over context menu events to external hosts and back
amit, please review everything. estade please review changes to tab_contents_view_gtk.cc and
render_view_context_menu_gtk.cc. pinkerton please review changes to tab_contents_view_mac.mm and
render_view_context_menu_mac.mm
Review URL: http://codereview.chromium.org/119429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Registry and Preferences into separate classes. While I was at it, I removed the EXTERNAL_INSTALL file, since we now keep track of this in the Preferences.
This also takes care of the virtualization problem in the unit tests for vista (see bug).
BUG=13063
TEST=None, covered by automated tests.
Review URL: http://codereview.chromium.org/122004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it will work.
TEST=none
R=pkasting
BUG=none
Review URL: http://codereview.chromium.org/126012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/126003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/122045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a work in progress draft.
Summary of changes:
1. Moved code shared by chrome and test_shell to webkie/glue:
WebMediaPlayerImpl
SimpleDataSource
VideoRendererImpl
2. Since WebMediaPlayerImpl is shared, chrome specific renderers
are enabled by passing the FilterFactoryCollection into
WebMediaPlayerImpl, this is done in RenderView. And
WebMediaPlayerImpl provides some default renderer filters,
which are used by the test shell and also chrome.
Review URL: http://codereview.chromium.org/119229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
include the file in chrome/renderer and chrome/browser so to make check
deps happy, I'm putting the file in chrome/common.
Review URL: http://codereview.chromium.org/123001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
that are re-used by multiple targets.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118516
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
from 'automated_ui_tests' to 'test_support_ui', so they can also
be used by 'unit_tests'.
Review URL: http://codereview.chromium.org/118509
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a browsertest to make sure we don't crash with an incognito window open.
Had to finagle utility_process_host to make it work in a browsertest.
BUG=12326
TEST=none
Review URL: http://codereview.chromium.org/118476
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't have:
- rounded corners
- gradient background
- animating in or out.
- graphical polish
but it is fucntionally complete.
http://crbug.com/12843
Review URL: http://codereview.chromium.org/118480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/wiki/LinuxZygote
* Move Chrome specific bits out of base
* Move away from the idea of reserved file descriptors (which don't
really work with zygotes)
* Load resources before forking renderers (means that we don't need
communication between the zygote process and the renderers)
* Make sure that gdb works against the browser again
* Make sure that we have different ASLR between the renderers and the
browser.
http://codereview.chromium.org/119335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the currently loaded site. We are careful in this patch to
continue to allow dropping URLs in text fields within the app
window, and behavior for normal browser windows remains as
before.
There is a slight glitch when dragging a to an app window on the
border of the window. Even though it is very brief, it is still
disturbing.
BUG=7171
TEST=Open Chrome (1), load google.com. Open Chrome (2), load
yahoo.com. Drag a link from 1 to 2 and a link from 2 to 1 (both
allowed). Create an app shortcut from 1, drag a link from 1 to
2 (allowed) and a link from 2 to 1 (denied). Verify that link
scan be dragged to the omnibox and to text fields.
Patch by Chase Phillips <chase@chromium.org> via
http://codereview.chromium.org/119298
Review URL: http://codereview.chromium.org/121003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
refactored it so that there is a clear object responsible for dragging
and the controller now controls it all.
There is some common code between TabOverviewDragController and
DraggedTabController. I will try and share some code between these two
later.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=4655
Review URL: http://codereview.chromium.org/119415
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Eliminates browser_views.lib as a distinct target due to circular
dependencies.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118492
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* split up extension_shelf into a model and a view (easier to port)
* ExtensionHost now owns ExtensionView rather than vice versa
* dragging reorders extensions on the shelf
* moved ExtensionView* into browser_tests (currently not working)
BUG=12123
TEST=browser_tests.exe --gtest_filter=ExtensionShelfModel* (browser_tests.exe is currently broken)
Review URL: http://codereview.chromium.org/119290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Split chrome_dll_version.rc generation into its own target.
* perf_tests.exe: add missing modules:
browser/safe_browsing/database_perftest.cc,
browser/safe_browsing/filter_false_positive_perftest.cc,
common/json_value_serializer_perftest.cc.
* interactive_ui_tests.exe:
add dependency on installer_util_strings;
add dependency on new chrome_dll_version target;
add missing browser/debugger/devtools_sanity_unittest.cc module;
add missing resources.
* Cleanup: alphabetize sources in test_support_common.
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/119373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of SkBitmaps.
Add command line flag "--thumbnail-store" to enable
using the ThumbnailStore facility instead of the current
ThumbnailDatabase.
Original review: http://codereview.chromium.org/118409
Patch by Meelap Shah
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also few fixes:
- we need an AtExitManager instanciated for some calls to succeed (see browser_test_launcher_in_proc.cc)
- the browser_tests.dll PDB file was getting overridden by the one for browser_tests.exe (making it hard to debug tests...)
- the browser tests require the browser_resources.rc or some tests will fail.
BUG=None
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/119270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13151
TEST=default search popup persistance.
Review URL: http://codereview.chromium.org/119310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119349
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/118422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* perf_tests.exe: add missing modules.
* interactive_ui_tests.exe:
add dependency on installer_util_strings;
add missing browser/debugger/devtools_sanity_unittest.cc module;
add missing resources.
* Cleanup: alphabetize sources in test_support_common.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118400
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=aa
BUG=12114
Review URL: http://codereview.chromium.org/118328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it's a good enough stage that I want to check it in.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119329
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BlockedPopupContainerView class into a windows specific instance owned by the new BlockedPopupContainer.
http://crbug.com/12843
Review URL: http://codereview.chromium.org/118401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=test page and app menus thoroughly.
Review URL: http://codereview.chromium.org/119291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Much of this CL is refactoring; it's not as large as it looks.
(Do I always claim that? It's really true this time.)
Review URL: http://codereview.chromium.org/115150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* ui_tests.exe: add precompiled_wtl to the build.
* unit_tests.exe:
add dependency on installer_util_strings and hunspell;
add modules from tools/convert_dict;
add aditional tests from ../views;
add missing resources.
* perf_tests.exe: add missing modules.
* interactive_ui_tests.exe:
add dependency on installer_util_strings;
add missing browser/debugger/devtools_sanity_unittest.cc module;
add missing resources.
* Cleanup: alphabetize sources in test_support_common.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Minor fixes to coverage related scripts.
Review URL: http://codereview.chromium.org/118298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The browser tests are an alternative to UI tests.
They provide a way to exercise the browser from within the test (without having the test and the browser running in different processes).
In order to ensure atexit hanlders are run after each tests and static initializers start fresh for each test, each test is run in a new process (on Linux and Mac). On Windows, a DLL containing the test is loaded/unloaded for each tests.
BUG=None
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/115896
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to blocked_popup_container_view.{cc,h}, to avoid duplication
with the same-named files in chrome\browser.
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/119253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
implemented yet.)
BUG=11507
patch by Matt Mueller (mattm@google.com)
http://codereview.chromium.org/118280
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Factor out shared code into bookmark_utils_gtk.*.
Fix a leak with toolbar button dragging.
BUG=13110
TEST=Added extra DCHECKs. Also, you can drag between the right half of the bookmark manager and the bookmark bar with no crashes.
Review URL: http://codereview.chromium.org/119220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13151
TEST=custom home pages table. adding to it, removing. use current. enabling and disabling when applicable.
Review URL: http://codereview.chromium.org/119242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17740 0039d316-1c4b-4281-b951-d872f2087c98
|