| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Also, build the reliability_tests target on Linux.
Neither of the new targets have trybots or buildbots yet, however, they do work for me locally.
BUG=19085
Review URL: http://codereview.chromium.org/209022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is currently only used on OS X.
We need a separate process to do profile import for 3 reasons:
1)In Firefox we load external libraries which we have no control over.
2)Conceptually it's safer to run parsing code OOP.
3)quoth chrome/browser/importer/nss_decryptor_mac.mm :
"""
On OS X the nss3 libraries are compiled with depedencies
on one another, referenced using dyld's @executable_path directive.
To make a long story short in order to get the libraries to load, dyld's
fallback path needs to be set to the directory containing the libraries.
To do so, the process this function runs in must have the
DYLD_FALLBACK_LIBRARY_PATH set on startup to said directory.
"""
BUG=14458
TEST=None Possible
Review URL: http://codereview.chromium.org/193131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/208002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
way we don't have to explicitly build xdisplaycheck on all the bots where we run tests.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/207020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r26409.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the infrastructure for detecting out of date plugins and warning
the user about them.
Glen was ok with the infobar, although he notes that there will be a
better 'notifications' UI for this sort of thing in the future.
This UI will trigger at most once a day and only when we load the
plugin information.
This patch appears to duplicate some information from plugins2.xml,
which is the plugins database that the default plugin uses to install
missing plugins. I'm not reusing that information in this patch:
* Note that the names of the plugins are different between the two.
plugins2.xml uses a 'friendly' name, while this code needs to know
the name that the plugin itself uses.
* Also note that URLs are different. plugins2.xml wants a link to an
exe for the installer, while we want a landing page.
* The code for loading and parsing plugins2.xml is in the default
plugin, and thus would require a lot of major refactoring to use
here.
Regarding the second point, above. One could imagine that we open a
tab to "about:update-plugin#MAGICSTRING,application/x-shockwave".
Javascript on that page notes the fragment in the URL and creates a
plugin of the correct type on the page, passing MAGICSTRING to the
plugin. The renderers are updated to know that all plugins on about
pages should be directed to the default plugin.
The default plugin notes the MAGICSTRING argument and uses a new NPAPI
call to validate the string. MAGICSTRING will be a random string,
created once per instance which is needed so that the default plugin
can know that it's running on behalf of the browser, not some random
webpage. When it validates, it doesn't wait for the user to click
inside the plugin to trigger the download. It also doesn't trigger a
page reload afterwards, instead draws text to the effect of
"Successful install".
This alternative design would remove the duplication, at the cost of a
lot of work. Since it's a UI question, I asked Ben and Glen. However,
they didn't get back to me so, for now at least, this simplier
solution will suffice.
BUG=21100
http://codereview.chromium.org/197053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an infobar directing users to tell us if they have problems with printing.
Hide printing behind --enable-printing flag on linux/gtk.
BUG=9847
TEST=none
Review URL: http://codereview.chromium.org/200138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Just a small cleanup.
Review URL: http://codereview.chromium.org/206037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove old main(argc, argv) from syncable_unittest.
- Since the old notifier target had only one unittest,
merge it with the syncer tests.
- Remove listener_unittest.cc entirely.
- Don't compile natserver_main.cc, which has another main()
- Use a test main from the test_support_unit library. This
has the downside of pulling in a lot of deps we don't need,
but it gives us a run_all_unittests.cc.
- Fix a few compile errors in test code.
TEST=unit tests pass
BUG=none
Review URL: http://codereview.chromium.org/205021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings our extension support to about the level it has on linux.
One issue is that the toolstrips are webpages with a background image that just happens to look like the shelf they are on. But the background images are not updated on key->nonkey window changes, so the toolstrip backgrounds look slightly off in one of the two cases. If we decide to keep the shelf, we should fix this, but see the bug for erikkay's stance on this.
Also, the NTP is only loaded after all toolstrips have been loaded for some reason. That's what happens on the other platforms too, I believe.
The extension shelf uses the DownloadShelfView as background view for now.
Screenie: http://imgur.com/wSHgU.png
BUG=19073
TEST=Extensions that live in the shelf should show up. They should be clickable, resize correctly (e.g. the build status extension), and the shelf should interact in a sane way with the status bubble.
Review URL: http://codereview.chromium.org/175025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.
What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.
Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
./third_party/hunspell/hunspell.gyp
./third_party/icu/icu.gyp
./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
-or-
Delete gyp_chromium.gypi and move its content back to common.gypi
Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.
Review URL: http://codereview.chromium.org/206006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing of Anton Muhin's patch (antonm@google.com)
(Reland. First landed in r26264, reverted in r26276. This reland hopefully
doesn't build tcmalloc on Linux.)
Review URL: http://codereview.chromium.org/206017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As before, syncapi is built as a dynamic library, and only
on windows. The difference is that it's built from source,
rather than being pulled in as a binary.
Changes to sync engine code:
* Use OS_WIN instead of OS_WINDOWS (requires build_config.h).
* Rename platform-specific files to match the chrome convention.
This allows them to be excluded by rules that already exist
in chrome.gyp. The convention is either a /win/ directory,
or an _win.cc at the end of the file. Other valid platforms
are _mac, _linux, and _posix
Changes to DEPS:
* On Windows, pull in pthreads-win32.
Changes to chrome.gyp:
* Add new library targets for sync, notifier, sync_proto, and
syncapi.
Review URL: http://codereview.chromium.org/193103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/203076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for using it to position both the Omnibox bubble and InfoBubbles. It now gets the bounds of the location stack, which can be turned into useful coordinates for both items.
This should not result in any visible change.
BUG=21028
TEST=none
Review URL: http://codereview.chromium.org/194110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13156
TEST=Connect view->task manager to first responder's commandDispatch: and give the menu item the tag 40005. Now clicking that menu item should bring up a completely unfunctional task manager window (but it has a localized title and button).
Review URL: http://codereview.chromium.org/200094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r26264.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
user logout, and during system restart and shutdown.
MainMenu.xib changes (because you're not expected to parse nibs yourself):
- The quit menu item's action is changed from the AppController object's
-quit: method (which no longer exists) to the application object's
-terminate: method (the Cocoa standard).
- The application and owner object types are changed from NSApplication to
CrApplication.
- The application menu name is changed from Chromium to
^IDS_SHORT_PRODUCT_NAME. Cocoa doesn't use this anyway, it gets replaced
at runtime with the localized value of CFBundleName, but we shouldn't have
branding-specific strings in our nibs.
BUG=18078
TEST=Use Chrome for a while, quit it from the Dock icon menu, and relaunch.
You should NOT see the "Google Chrome didn't shut down correctly" info bar.
Review URL: http://codereview.chromium.org/201121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing of Anton Muhin's patch (antonm@google.com)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/206017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wrapper. This also moves and renamed the old cookie_monster_sqlite file to
match the class name.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/201099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First pass at adding ChromeOS settings
- a mock wifi selector combobox
- touchpad settings that makes calls to synclient
- on startup, touchpad settings are initialized to what's stored in
preferences
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/203073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds support for a selinux GYP variable which, when set to
one, does the following:
* Removes the seccomp sandbox from the compile
* Removes support for SUID sandboxing from the zygote
* Performs a dynamic transition, in the zygote, to
chromium_renderer_t.
This code requires that the system policy have a sensible set of
access vectors for the chromium_renderer_t type. Such a policy will be
found in sandbox/selinux in the future.
http://codereview.chromium.org/203071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
turned off.
BUG=19763
TEST=per bug. This might not appear to work given how LaunchServices caches and registers applications. You may need to test on a totally clean machine.
Review URL: http://codereview.chromium.org/194116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a result was found, restore focus to the tab contents. This allows for
keyboard navigation using the find bar.
Now with fix for valgrind failure. This CL reverts 26219, which in turn reverted 26214.
BUG=http://crbug.com/12657
BUG=http://crbug.com/21374
TEST=See test case in bug 21374
Review URL: http://codereview.chromium.org/205010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkBarView.
Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added.
Added an interface that both BookmarkBarView and ExtensionShelf implement.
This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not.
Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions).
Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process.
Toolstrip text color values are no longer hard-coded but use the color specified in the theme.
Decreased the timeouts for showing and hiding the toolstrip handle.
Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses.
Known issues:
Some themes expose the fact that:
- The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though.
- Didn't spend much time theming the shelf handle (just used the solid color from the theme).
- When extension shelf is merged with the bookmark bar, there is a painting artifact (horizontal dotted line) that appears (apparently it was known to appear before this change).
BUG=18452, 21272, 21273
TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed.
Review URL: http://codereview.chromium.org/204022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/201116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a result was found, restore focus to the tab contents. This allows for
keyboard navigation using the find bar.
BUG=http://crbug.com/12657
BUG=http://crbug.com/21374
TEST=See test case in bug 21374
Review URL: http://codereview.chromium.org/201061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds automated tests for AutocompleteEditView.
BUG=20422: Autocomplete edit view needs automated testing
TEST=none
Review URL: http://codereview.chromium.org/177052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the compile error on the toolkit builder.
TBR:finnur
Review URL: http://codereview.chromium.org/203064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkBarView.
Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added.
Added an interface that both BookmarkBarView and ExtensionShelf implement.
This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not.
Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions).
Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process.
Toolstrip text color values are no longer hard-coded but use the color specified in the theme.
Decreased the timeouts for showing and hiding the toolstrip handle.
Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses.
Known issues:
Some themes expose the fact that:
- The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though.
- Didn't spend much time theming the shelf handle (just used the solid color from the theme).
BUG=18452, 21272, 21273
TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed.
Review URL: http://codereview.chromium.org/203034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a new file, bubble_border.cc, so that InfoBubble will be able to start using it. This also renames the resources to be more generic.
This should not result in any visual changes.
BUG=21028
TEST=none
Review URL: http://codereview.chromium.org/194107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Localize the http auth dialog.
Add the explanation to the http auth dialog.
Autosize the http auth dialog after putting in the explanation.
TEST=http auto ui should now be localized.
BUG=20532
Review URL: http://codereview.chromium.org/196109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add a unit test module for AppController with a simple DockMenu test.
BUG=21175
TEST=AppControllerTest.DockMenu
Review URL: http://codereview.chromium.org/196103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
strings/images from pak file.
Use the images directly from the pak files instead of having extra copies in the bundle.
TEST=sad tab page still works and has all images. throbbers still work. the app should no longer carry the sadtab and throbber images directly.
BUG=20230
BUG=21076
Review URL: http://codereview.chromium.org/194101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Enable the Manage search engines button in Preferences
* New search engines can be added using the "+" button
* Existing search engines can be edited via double-click
* Existing search engines can be removed with the "-" button
* The "Make Default" button has the same behavior as the list box in the Basics
preferences "Default Search"
BUG=16187
TEST=Go to Preferences, click "Manage" next to "Default Search" and add/edit/remove engines.
Review URL: http://codereview.chromium.org/193040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Note that chrome still does not support _reading_ from the find pasteboard, so hitting cmd-e followed by cmd-g in chrome still doesn't work. Also, cmd-f doesn't write to the find pasteboard yet either.
BUG=14562
TEST=Select some text on a web page, hit cmd-e, go to the same web page in safari, hit cmd-g. Safari should search for the text you selected in chrome.
Review URL: http://codereview.chromium.org/197035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I think I misunderstood nspluginwrapper, and it didn't actually work
on the machine I thought I had tested it on.
Review URL: http://codereview.chromium.org/195075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21598
Review URL: http://codereview.chromium.org/202066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add "New Window" and "New Incognito Window" items to the Dock Menu.
Add a unit test module for AppController with a simple DockMenu test.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/199031
TBR=sgk@google.com
Review URL: http://codereview.chromium.org/196101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add a unit test module for AppController with a simple DockMenu test.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/199031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/199092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15494
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Toolstrip
Review URL: http://codereview.chromium.org/203023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
permissions to that tab.
Cleaned up a few things along the way:
- added a GetExtension() method to
ExtensionFunctionDispatcher and ExtensionFunction since it
was used in more than one place.
- Removed first param from chrome.test.failCallback() since
it wasn't used anywhere.
- Added a convenience CanAccessHost() method to Extension,
since it seems likely to be commonly used.
- Refactored setup of mock host resolver in browsertest,
since the way it was, you could only customize it at the
testsuite level, not the test level.
Review URL: http://codereview.chromium.org/199074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11973
TEST=load an extension with page actions, it should work like on windows.
Review URL: http://codereview.chromium.org/195050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now, as with other extension errors, these are not i18n'd.
The blacklist loading error is though because it is most like
an error to be shown to end users.
BUG=16932
TEST=none
Review URL: http://codereview.chromium.org/173357
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only difference is explicitly calling a FreePerDisplaySurfaces() function from
~GtkThemeProvider() because vtables are set to base class during destructor
calling.
BUG=http://crbug.com/10499
Original Review URL: http://codereview.chromium.org/197046
Review URL: http://codereview.chromium.org/199077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fix the build.
TBR=phajdan
Review URL: http://codereview.chromium.org/201081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
interactive UI tests, so the interactive UI tests can be run isolated.
BUG=None
TEST=Run the the interactive ui tests with the new launcher:
test_launcher --lib=interactive_ui_tests_dll
Review URL: http://codereview.chromium.org/197045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bundles. One part has been there for 2+ weeks, the other 1+ week, at this point anyone that hasn't build/build can do a clobber.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/192066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25858 0039d316-1c4b-4281-b951-d872f2087c98
|