| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=17706
TEST=None
Review URL: http://codereview.chromium.org/414006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds functionality to choose between two different InfoBubbleView types: white background and gradient background.
Screenshot: http://andybons.com/chrome/news_popup.png
BUG=23881
TEST=Install a browser action extension that has a popup, click and observe the popup being shown. Initial unit test added, but disabled.
Review URL: http://codereview.chromium.org/402077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
index to store things with parent id and metahandle instead of parent id and name.
Add a template function for extracting name from proto buffers.
Refactor some unit tests to work without unique naming.
Remove path calls since they make no sense without unique names.
Remove find by parentID and names.
Remove unique name resolution from conflict resolver.
Remove syncable name class.
TEST=included unit tests
Review URL: http://codereview.chromium.org/371029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows was the only platform where they were run in-process.
Arguably running out-of-proc is more stable (a test that crashes won't
crash the entire test suite run).
I timed in-proc/out-of-proc runs, the out-of-proc is also slightly faster.
This as the added benefit that we don't need the --lib flag anymore.
This CL also adds usage and fixes the --help flag.
BUG=27677
TEST=Make sure browser tests run well on Windows. Try using the --help
flag, the --gtest_help flag and a combination of --gtest_filter and
--single-process.
Review URL: http://codereview.chromium.org/402061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25677
Review URL: http://codereview.chromium.org/395007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
higher than _ChromeMain, so that CrashReporter stacks and other symbolized
stacks aren't so confusing. Add a tool to verify that nothing violates this
ordering requirement.
BUG=28257
TEST=verify_order, which is part of the build
Review URL: http://codereview.chromium.org/414003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=mark
Review URL: http://codereview.chromium.org/402090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Splitting may cause merge pain for m4.
Will do this over again in about 2 weeks.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/409006
TBR=bradnelson@google.com
Review URL: http://codereview.chromium.org/414004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Splitting may cause merge pain for m4.
Will do this over again in about 2 weeks.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/409006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed to MainMenu.xib: Added a new menu item under the ^IDS_SHORT_PRODUCT_NAME menu with the name . This menu item has a tag of 40014 corredponsing to IDC_IMPORT_SETTINGS and is connected to the commandDispatch: action of the CrApplication (First Responder).
Changes to Toolbar.xib: Added a new menu item with the name ^IDS_IMPORT_SETTINGS in the same manner as above.
BUG=26157
TEST=Launch Chrome and inspect the current bookmarks and settings. With no browser window open and then with a browser window open choose the "Import Bookmarks and Settings..." menu option found under the "Chromium" menu. Also, with a browser window open, hoose the "Import Bookmarks and Settings..." menu option found under the page's tool menu. Select a browser from the popup, choose the items to be imported, and press OK. Then inspect the bookmarks and other settings to insure that the selected items have indeed been imported.
Review URL: http://codereview.chromium.org/378036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/399095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
little (helpeful to make it use ChildProcessLauncher). Note that the test isn't needed anymore as a unit test because since it was written, there have been a couple of tests that exercise this code path through browser_tests. They use sandboxed utility processes so it's more equivalent to what the user experiences.
Review URL: http://codereview.chromium.org/402074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also mostly fix the placement of the "For quick access, place your bookmarks here [...]" message (when there are no bookmarks). It's not quite right in the new animation (detached <-> normal).
BUG=25600, 27692, 27693
TEST=Go to NTP and press Cmd-Shift-B a few times while watching closely. The detached bar should "morph" smoothly to the normal bar and vice versa. Switch themes and repeat; please test at least the default theme and the Brushed theme.
Review URL: http://codereview.chromium.org/400020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/403020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Run chrome with --enable-sync. While bookmark sync is disabled, click on Wrench Menu->Sync My Bookmarks
Review URL: http://codereview.chromium.org/402059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and Windows versions, except that it uses a gtk dialog and TabContentsContainerGtk to create the window.
BUG=25260
TEST=Call ShowHTMLDialog() with a working dialog, such as the login dialog for Bookmark sync.
Review URL: http://codereview.chromium.org/394011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
them to sandboxed_extension_unpacker.
Added unittest files for unpacker and sandboxed unpacker.
TEST=Try loading any of the unpacker samples added in this CL. They should either pass, or show error and fail.
BUG=27362
Review URL: http://codereview.chromium.org/390019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Does not include DnD to/from menus.
No animations of drop destination yet.
BUG=http://crbug.com/17608
TEST=Do some draggin and droppin.
Confirm click still works on the marks and folders.
Confirm "other bookmarks" canNOT be moved.
Confirm NTP / detached bar also works for DnD.
Review URL: http://codereview.chromium.org/395031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
renderer only, I'll take care of plugin/worker/utility processes in a followup change. (relanding 32203)
BUG=6844
Review URL: http://codereview.chromium.org/397031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to verify we allow first-party cookies in the regular and
redirected cases.
R=abarth,eroman
BUG=25133
TEST=new browser tests are added
Review URL: http://codereview.chromium.org/401009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
block the UI thread. For now, renderer only, I'll take care of plugin/worker/utility processes in a followup change.
BUG=6844
Review URL: http://codereview.chromium.org/397002
Review URL: http://codereview.chromium.org/402033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
renderer only, I'll take care of plugin/worker/utility processes in a followup change.
BUG=6844
Review URL: http://codereview.chromium.org/397002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/400005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Implement a CreateApplicationShortcutView similar to the current Gears-based one;
- Add a few profile prefs to persist user's last checked shortcut locations
- Implement a web_app::CreateShortcut that stores icon under "<profile>/Web Applications"
in a similar layout as gears (i.e. <host>/<scheme_port>/<web_app_title>.ico) and calls
file_util code to creates shortcut on Windows;
- Add Win7 taskbar pin/unpin support function to file_util;
- Update TabContents to replace gears with new code;
Note:
- Gears dialog is modaless but this one is a modal dialog.
- Gear's icon store is not migrated because gears icons
could still be used by shortcuts created by gears and
thus we could not delete them even after migration. And we
are not using the local ico files in the dialog even if
they exists.
- New CreateApplicationShortcutView is included when
TOOLKIT_VIEW is defined. However on platforms other
than Windows, the actual CreateShortCut code is not
implemented. Right now it calls ShellIntegration's
CreateDesktopShort if OS_LINUX is defined and
NOTREACHED() for other platforms.
BUG=25528
TEST=Verify the new UI provides the same functionality as gears under XP/Vista and support pinning on Win 7.
Review URL: http://codereview.chromium.org/372012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Will revert after looking at the Linux memory bot and perf cycler.
TBR=willchan
Review URL: http://codereview.chromium.org/403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
display of pop-ups for extensions viewed through a tab-contents view.I added a new class, ExtensionPopupHost. This class implements the necessary environment for managing child popup windows from either an ExtensionHost, or an ExtensionDOMUI. Note that this class is added as a member to ExtensionHost and ExtensionDOMUI.
I decided to take this approach to prevent multiple inheritance of the NotificationObserver class: Both ExtensionPopupHost and ExtensionHost must inherit from this class, and I was uncertain of how the system would behave wrt virtual inheritance. Please comment on if I should have used the inheritance approach.
I also removed the customHandler tag (in extension_api.json) that I had added in the initial submission. The arguments in the schema are now those that users of the API see. The nodocs tags were also removed.
The api experimental.popup.getAnchorWindow() has been renamed to popup.getParentWindow, as per a suggestion from Erik K.
BUG=none
TEST=extension_popup_apitest.cc
Review URL: http://codereview.chromium.org/385061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is fixed.
BUG=16591
TEST = none
Review URL: http://codereview.chromium.org/384073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
------
Revert 31875 to see whether it fixes reliability bot.
BUG=25677
TEST=None
------
TBR=huanr
Review URL: http://codereview.chromium.org/397017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27224
Review URL: http://codereview.chromium.org/385085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25677
TEST=None
Review URL: http://codereview.chromium.org/397014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not ALL all. Make Delete and Rename enabled for folder context menu
(but disabled for "Other Bookmarks").
nib changes (related to the context menus):
- Telegate is the bookmark bar controller.
- Switched type from NSMenu to BookmarkMenu.
TEST=New window. Create folder "empty" with nothing in it. Create
folder "two" with 2 bookmarks in it. Create a final bookmark in the
top level of the bar.
Context menu (right click) over all folders.
Make sure Delete and Rename enabled for folders but not "Other Bookmarks".
Make sure "Open All" (and friends) disabled over "empty", enabled over "two".
"Open All" on "two" --> see 2 opened.
"Open All" on the bar itself --> see 3 opened.
Ditto for "Open all in new window" and "open all in incognito window".
Create a new window. In new window, make sure folders have context menus.
BUG=http://crbug.com/27522, http://crbug.com/27529
Review URL: http://codereview.chromium.org/391046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
git cl dcommit somehow committed all my local changes in cygwin
TBR=evan
BUG=none
Review URL: http://codereview.chromium.org/396006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a huge refactoring of the bookmark bar controller in this CL, so that animation-related code is in only a few places (instead of scattered all over the place).
Changes to BookmarkBar.xib: Since BookmarkBarToolbarView now inherits from AnimatableView, I had to hook up its delegate_ member to File's Owner (i.e., the BookmarkBarController).
Not yet implemented: morphing between the detached bar (on the NTP) and anything else.
BUG=25600
TEST=Go to a normal page, show/hide the bookmark bar (Shift-Cmd-B), watch it animate.
Review URL: http://codereview.chromium.org/384105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of the extensions API is not supported in content scripts for security
purposes. Instead the typical pattern is to use messaging between content
scripts and a background page which executes them on behalf of the script.
This is not immediately obvious to many extension developers, so this
change adds an error message to help them better understand what's going on.
BUG=26128
TEST=Try writing a content script that uses some of the extensions API stuff
in chrome.tabs, chrome.windows, etc. You should see errors in the console
telling you that it isn't supported in content scripts.
Review URL: http://codereview.chromium.org/366024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gesture, not arbitrary script.
Experimental fix for UI test, so checking in flaky at first to see if I have it...
BUG=27215
TEST=included
Committed as r31839... and reverted.
Review URL: http://codereview.chromium.org/387011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome periodically reads the content of a well-know file,
and parses it into name-value pairs, each representing a
Chrome OS metrics event. The events are then logged using
the normal UMA mechanism. The file is then truncated to
zero size. Chrome uses flock() to synchronize accesses
to the file.
BUG=none
TEST=compiled and run Linux and Chrome OS versions.
Verified that uploaded Chrome OS events appear in about:histograms.
Also external_metrics_unittest.cc tests the collection of metrics
messages from the well-known file.
patch written by semenzato_google.com
original code review: http://codereview.chromium.org/378013
(plus http://codereview.chromium.org/346041)
Review URL: http://codereview.chromium.org/394010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
probably have the file deleted by now.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/393013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in subtle and devious ways.
Renaming webkit.gyp -> webkit_glue.gyp changed webkit.sln to webkit_glue.sln,
which occured unbeknownst to the builders who continued to build webkit.sln
for most of the day. This wasn't an issue until we did a WebKit roll, where
the trickery was discovered and hell broke loose.
TBR=yaar
TEST=green bots
BUG=none
Review URL: http://codereview.chromium.org/385084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=25677
Review URL: http://codereview.chromium.org/372075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
response to a user gesture, not arbitrary script.
Includes UI test which verify the infobar is shown from a gesture, and not shown from raw script.
BUG=27215
TEST=included
Review URL: http://codereview.chromium.org/387011
TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/385080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gesture, not arbitrary script.
Includes UI test which verify the infobar is shown from a gesture, and not shown from raw script.
BUG=27215
TEST=included
Review URL: http://codereview.chromium.org/387011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Popups are not implemented within this change.
BUG=23881
TEST=Install a browser action extension on the mac. Observe that something actually happens in the UI.
Review URL: http://codereview.chromium.org/366029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* test for ViewID util that is not used in linux views
BUG=None
TEST=Run browser_tests --gtest_filter=ViewIDTest.* and make sure no test runs.
Review URL: http://codereview.chromium.org/388014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Will revert after looking at the Linux memory bot and perf cycler.
TBR=willchan
Review URL: http://codereview.chromium.org/386016
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/384074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Will revert after looking at the Linux memory bot and perf cycler.
TBR=willchan
Review URL: http://codereview.chromium.org/386016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
reusable.
o Adds the ability to position the arrow of the bubble on the top right as well as the top left (default).
BUG=none
TEST=Nothing should change visually. This is prep for use by browser action popups and the first run UI.
Review URL: http://codereview.chromium.org/385060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26713
TEST=still compiles
Review URL: http://codereview.chromium.org/387031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31756 0039d316-1c4b-4281-b951-d872f2087c98
|