| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Fixes http://crbug.com/8829 .
Review URL: http://codereview.chromium.org/42336
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The bookmark menu is populated dynamically with bookmarks, including
subfolders --> submenus. E.g. star something --> shows up in menu.
Menu items are disabled but always present and current.
- Always Show Bookmarks" menu now live; reads from / writes to
preference, and shows correct "toggle state".
- Bookmark bar on each tab, present if requested. (Currently an empty box).
- Random stuff; e.g. bookmark prefs init moved to a x-plat location.
This CL does not contain Cole's views.
Bried english description of the nib file changes:
- add a new view for the bookmark bar in the tab; hook it up to the controller
- Many tag sets (e.g. View-->Always Show Bookmarks Bar now 40009)
- Remove dummy bookmark menu items
Review URL: http://codereview.chromium.org/46078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
I did a lot of cleanup of the DOM UI system as part of this.
Review URL: http://codereview.chromium.org/42227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mark
Review URL: http://codereview.chromium.org/48046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
minimal dependencies to build on Linux, Windows will need more.
Make a 'test_support_base' library containing the .cc files used
in common by perf tests in both net and chrome.
Review URL: http://codereview.chromium.org/48021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ownership of a GtkWidget encapsulated (and exposed) from a C++ object.
Debugging checks help verify that the GtkWidget is not leaked, and that it was destroyed when expected.
Review URL: http://codereview.chromium.org/42226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
HistoryContentsProviderTest, and KeywordProviderTest from
chrome/browser/autocomplete.
NOTIMPLEMENTED bits where HistoryURLProviderTest and AutocompleteTest
have UI dependencies, and ExternalProtocolHandler has OS dependencies.
Review URL: http://codereview.chromium.org/43034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
developer tools windows. It's supposed to route devtoools messages. Also it will notify DevToolsClient when inspected renderer crashes or when it's changes due to cross-site navigation. Currently when inspected tab is closed it will close devtools window as well.
Devtools state moved from RenderViewHost and WebContentsView to the manager.
Please look at devtools_manager.{h,cc} in the first place.
Review URL: http://codereview.chromium.org/42076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* test_support_unit
For *_tests executables using main() from test/unit/run_all_unittests.cc.
* test_support_ui
For *_tests executables using main() from test/ui/run_all_unittests.cc,
plus supporing UI-specific code.
* test_support_common
All the stuff common to both unit and UI testing.
Ripple effects and additional changes:
* Added list of *_uitest.cc modules. Most of these aren't building on mac
or Linux, but should give the Windows gyp build a head start.
browser/locale_tests_uitest.cc, however, is self-contained enough to
actually build and work on Linux. (Bonus!)
* test/automation/automation_handle_tracker.cc moves into test_support_common.
* Added missing browser/grk/dialogs_gtk.cc.
Review URL: http://codereview.chromium.org/42186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Added entry to ResourceResponseHead so that it contains
either a base::PlatformFile (OS_WIN) or
base::FileDescriptor (OS_POSIX) for passing the file
handle from browser to renderer process.
2. Also added IPC messages for reporting download progress
and ACK message for it. ResourceLoaderBridge::Peer::OnDownloadProgress
is added so that the peer is notified of the download
progress in the renderer process.
3. Load flag to kick start the resource loading for media
files. LOAD_MEDIA_RESOURCE is added so that
ResourceDispatcherHost knows how to use a different
ResourceHandler for handling media resource request.
Review URL: http://codereview.chromium.org/27168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/46036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
cleanup in how resource dispatching happens in a future cl.
Review URL: http://codereview.chromium.org/42158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/42135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
we can share code across platforms.
See http://code.google.com/p/chromium/wiki/FindBarRefactoring for
more information about the design.
Review URL: http://codereview.chromium.org/42057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Rewrite strip controller to create and manage TabControllers instead of NSButtons.
Review URL: http://codereview.chromium.org/43137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
building parts of GTM that are needed for theming.
Review URL: http://codereview.chromium.org/42081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This required getting rid of the stubs in common/temp_scaffolding_stubs.cc
to avoid duplicate symbols, in favor of moving the stubs into a separate
module for use when porting to new platforms.
Review URL: http://codereview.chromium.org/43089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- bring the rules for grit all in align for common style/dir names.
- make the mac build net:net_resource (was win/linux only)
- ripple the mac dep upstream
- merge net_resource into the chrome repack
more work is needed on the mac side, we aren't really using the new resources
yet, but this is a clean landing point.
Review URL: http://codereview.chromium.org/45001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It looks like these were originally meant to be deleted, but instead all of their lines were removed and the empty file was left behind.
Review URL: http://codereview.chromium.org/43021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/43040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
duplicated code in scaffolding in deference to equivalent code in tab_contents.cc.
Review URL: http://codereview.chromium.org/42031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
generates .rc and .pak files, too.
Review URL: http://codereview.chromium.org/42033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Build additional files on Linux (but not yet on Mac):
browser/autocomplete/autocomplete_edit.cc
browser/autocomplete/autocomplete_popup_model.cc
browser/bookmarks/bookmark_context_menu.cc
browser/bookmarks/bookmark_drop_info.cc
browser/dom_ui/dev_tools_ui.cc
browser/dom_ui/dev_tools_ui.h
Remove duplicates from the 'browser' sources list, and sort it.
Review URL: http://codereview.chromium.org/42028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add Linux-specific files:
* third_party/xdg_user_dirs/xdg_user_dir_lookup.cc
* browser/gtk/download_item_gtk.{cc,h}
* browser/gtk/download_shelf_gtk.{cc,h}
* browser/tab_contents/render_view_context_menu_gtk.{cc,h}
* Don't exclude too many browser/download/* files on Linux.
* Remove browser/download/save_page_model.{cc,h}.
* Exclude Windows-specific browser/download/download_{exe,util}.cc.
* Make test/unit/run_all_unittests.cc part of the test_support library.
* Remove duplicate test/ui_test_utils.{cc,h} (moved to test_support).
* Exclude test/automation/window_proxy.{cc,h} on non-Windows systems,
but only exclude the rest of test/automation/*.{cc,h} on Mac.
* Remove left-over test/automation/window_proxy exclusion from the
'ui_tests' target (they're now in the 'test_support' target).
Review URL: http://codereview.chromium.org/40328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Got app and unit_tests linking with gyp under windows.
Still missing pieces (things don't run).
Review URL: http://codereview.chromium.org/39319
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Far from complete but sending early to sync with others.
Review URL: http://codereview.chromium.org/40258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Exclude .m and .mm files on non-Mac platforms.
* browser/autocomplete/edit_drop_target.{cc,h} are gone.
* browser/gtk/browser_toolbar_view_gtk.{cc,h}
=> browser/gtk/browser_toolbar_gtk.{cc,h}
* Target 'browser' needs net_resources.h to build on Linux.
* Exclude to-be-ported browser/debugger files on Linux.
* Comment out url_request_mock_http_job.cc in test_support.
(It really belongs there, but it's currently used by
production code in automation_provider.cc, so leave
it there for now, with appropriate comments.)
Review URL: http://codereview.chromium.org/39350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ExtensionsService and ExtensionErrorReporter
Review URL: http://codereview.chromium.org/39026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* RenderViewContextMenu is now cross platform. Each platform needs to implement an inheritor that fills in the virtual methods.
* RenderViewContextMenuController was deleted. Platform agnostic elements from it were added to RenderViewContextMenu, while the Menu::Delegate implemenation was moved to RenderViewContextMenuWin.
* Some more (minor) refactoring may need to be performed as the rest of the menu actions are ported.
* include clipboard_service.h on all platforms (not sure why it wasn't included before)
Review URL: http://codereview.chromium.org/40249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixes a gyp Linux build error because gyp expects all _posix files to actually
build on all posix platforms.
Review URL: http://codereview.chromium.org/39290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Added google_update and install utils.
Review URL: http://codereview.chromium.org/39204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
copy of the native os event.
Only the WebKeyboardEvent is sent over the IPC barrier, but the full structure passed to the unhandled key event handler.
BUG=4772
Review URL: http://codereview.chromium.org/40065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This adds a placeholder condition for building branded 'chrome.exe'
vs. 'chromium.exe', which can be updated to build 'chromium.exe' by
default whenever we update the infrastructure (buildbots, developer
instructions, etc.) to use -Dbranding=Chrome.
Review URL: http://codereview.chromium.org/40233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the filesystem and avoid the need for processing of Info.plist.
Dup of svn log since rietveld doesn't like A+D:
A + chrome/app/theme/chromium/app.icns
D chrome/app/theme/chromium/chromium.icns
M chrome/app/app-Info.plist
M chrome/chrome.gyp
Review URL: http://codereview.chromium.org/40238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The FileDescriptor API is clearly too hard to use. It's the only IPC
data type which is non-POD and serialising an invalid file descriptor
is fatal to Chrome on POSIX. The use of Maybe is possibly non-obvious
to non-functional programmers.
This patch merges Maybe and FileDescriptor so that serialising invalid
file descriptors is permitted and results in -1 at the other end.
(Serialising /closed/ a file descriptor is still fatal.) Also, it adds
a pointer in base/file_descriptor.h to instructions for its use with
IPC. Although it's generally bad practice to mention IPC in base, in
this case I cannot find another suitable location.
Review URL: http://codereview.chromium.org/39208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
supporting icon scaffolding.
Review URL: http://codereview.chromium.org/39132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
To brand, do a "src/tools/gyp/gyp_dogfood -Dbranding=Chrome src/build/all.gyp"
(Then build, of course.)
Review URL: http://codereview.chromium.org/40066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10866 0039d316-1c4b-4281-b951-d872f2087c98
|