summaryrefslogtreecommitdiffstats
path: root/chrome/chrome.gyp
Commit message (Collapse)AuthorAgeFilesLines
* Changes to the Browser to support Database access from Workers.ericu@google.com2010-04-021-0/+1
| | | | | | | | | | | | This changelist should have no visible effect until the V8 bindings for the Database get added to the Worker context in WebKit. BUG=none TEST=webkit layout tests Review URL: http://codereview.chromium.org/1387001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43427 0039d316-1c4b-4281-b951-d872f2087c98
* Move the Nigori classes from base to sync.albertb@chromium.org2010-04-011-1/+4
| | | | | | | | | BUG=none TEST=NigoriTest Review URL: http://codereview.chromium.org/1549012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43366 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented initial version of themes syncing (behind a flag).akalin@chromium.org2010-03-291-0/+3
| | | | | | | | | BUG=32414 TEST=manual,unittests,trybot Review URL: http://codereview.chromium.org/1399001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42984 0039d316-1c4b-4281-b951-d872f2087c98
* Don't strip main from the browser or helper app executables. This helpsmark@chromium.org2010-03-261-0/+1
| | | | | | | | | | | backtraces of stripped executables look more reasonable. BUG=39232 TEST=gdb backtrace in a stripped executable with no symbols loaded should show thread 0 beginning in main Review URL: http://codereview.chromium.org/1460001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42817 0039d316-1c4b-4281-b951-d872f2087c98
* Change how version_build_patch is computed to allow PATCH > 255mark@chromium.org2010-03-261-4/+4
| | | | | | | | | | | | | | | | | | | | version_build_patch is built as BUILD.PATCH and then used to set DYLIB_CURRENT_VERSION and DYLIB_COMPATIBILITY_VERSION on Mac OS X. These VERSION strings have the format X.Y.Z, where X cannot exceed 65535 and Y and Z cannot exceed 255 (see the ld man page). In order to allow PATCH to exceed 255, change version_build_patch to BUILD.PATCH/256.PATCH%256. BUG=39244 TEST=Set PATCH > 255 in chrome/VERSION, rebuild, and use otool -L to confirm version Patch by Jay Soffian <jaysoffian@gmail.com> Review URL: http://codereview.chromium.org/1322002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42771 0039d316-1c4b-4281-b951-d872f2087c98
* Completing Chrome Frame localization by adding the resource script ↵robertshield@chromium.org2010-03-241-0/+3
| | | | | | | | | | | containing the dialog template to Chrome's generated_resources.grd. Associated changes in CF to call _AtlBaseModule.SetResourceInstance to get it to load dialog templates from a resource dll. BUG=24305 TEST=The Find in page dialog in full tab Chrome Frame is localized. Review URL: http://codereview.chromium.org/1293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42543 0039d316-1c4b-4281-b951-d872f2087c98
* Make it clear what last_sync_timestamp actually tracks. Updatenick@chromium.org2010-03-241-0/+2
| | | | | | | | | | | | | | | | last_sync_timestamp from the new_timestamp only, never from per-entry timestamps. Use what the server sends us to know whether or not there are more updates to fetch. Eliminate some unnecessarily complicated logic having to do with the # of updates returned -- that's always a red herring; with server-side filtering, it is indeed possible for 0 updates to be returned along with a new timestamp. BUG=37373 TEST=manual testing of 2 browser sync; unit tests. Review URL: http://codereview.chromium.org/1161006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42413 0039d316-1c4b-4281-b951-d872f2087c98
* Update sync to support syncing of typed urlszork@chromium.org2010-03-181-0/+3
| | | | | | Review URL: http://codereview.chromium.org/896001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41901 0039d316-1c4b-4281-b951-d872f2087c98
* Whitespace gyp change for grdstuartmorgan@chromium.org2010-03-171-1/+0
| | | | | | TBR:thestig git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41892 0039d316-1c4b-4281-b951-d872f2087c98
* Removed auth_task.* and talk_auth_task.* (dead code)akalin@chromium.org2010-03-171-11/+1
| | | | | | | | | | | | | | | Removed GaiaAuth class. Gtalk login will now fail immediately instead of trying (in vain) to gaia-auth. Removed now-unneeded parameters. BUG=38034 TEST=manual with and without --invalidate-sync-xmpp-login Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41790 Review URL: http://codereview.chromium.org/885008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41865 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41790 - Removed auth_task.* and talk_auth_task.* (dead code) because ↵hbono@google.com2010-03-171-1/+11
| | | | | | | | | | | | | | | | | | Windows XP doesn't have inet_pton and it crashes XP bots. Removed GaiaAuth class. Gtalk login will now fail immediately instead of trying (in vain) to gaiaauth. Removed nowunneeded parameters. BUG=38034 TEST=manual with and without invalidatesyncxmpplogin Review URL: http://codereview.chromium.org/885008 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/983005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41808 0039d316-1c4b-4281-b951-d872f2087c98
* Removed auth_task.* and talk_auth_task.* (dead code)akalin@chromium.org2010-03-171-11/+1
| | | | | | | | | | | | | Removed GaiaAuth class. Gtalk login will now fail immediately instead of trying (in vain) to gaia-auth. Removed now-unneeded parameters. BUG=38034 TEST=manual with and without --invalidate-sync-xmpp-login Review URL: http://codereview.chromium.org/885008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41790 0039d316-1c4b-4281-b951-d872f2087c98
* Create a toplevel gfx/ dir and seed it with icon_util.ben@chromium.org2010-03-131-0/+1
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/915002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41528 0039d316-1c4b-4281-b951-d872f2087c98
* Move devtool resources from webkit_resources.grd to an upstream grd file.tony@chromium.org2010-03-111-0/+1
| | | | | | | | This gets rid of third_party references in webkit_resources.grd which will allow us to build this file upstream. Review URL: http://codereview.chromium.org/792005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41238 0039d316-1c4b-4281-b951-d872f2087c98
* Copy the bookmark manager to the chromium frameworks resources directory so ↵feldstein@chromium.org2010-03-111-83/+0
| | | | | | | | | | | | it can be loaded into a tab. Originally it was only copied to the build directories resources folder. The broken key issue still exists but if you manually add a good key this works fine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41098 Review URL: http://codereview.chromium.org/775001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41236 0039d316-1c4b-4281-b951-d872f2087c98
* Move wtl from chrome/third_party to third_party/. Thistony@chromium.org2010-03-091-2/+2
| | | | | | | | | | | breaks dependencies on chrome from webkit, app, views and base. BUG=37649 TEST=compiles Review URL: http://codereview.chromium.org/699001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41001 0039d316-1c4b-4281-b951-d872f2087c98
* svn prop fixes. Applied to all files not in third_party.pkasting@chromium.org2010-03-091-0/+0
| | | | | | | | | | | | * Removed eol-style, executable and mergeinfo from BMP/GIF/ICO/JPEG files, and set correct mime-type. * Removed executable and mergeinfo from .c/.cc/.cpp/.h/.m/.mm and .gyp files, and set eol-style to LF. TBR=evanm BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40991 0039d316-1c4b-4281-b951-d872f2087c98
* Move apply_locales.py from src/chrome/tools/build/ to src/build/.tony@chromium.org2010-03-091-1/+1
| | | | | | | | src/app shouldn't depend on src/chrome and I need to break these dependencies for some upstreaming work. Review URL: http://codereview.chromium.org/668249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40985 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing ARM build. command_buffer_service target does not build on ARM.apatrick@chromium.org2010-03-051-1/+5
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/669208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40789 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for opening a GPU command buffer from a renderer processes ↵apatrick@chromium.org2010-03-051-0/+5
| | | | | | | | | | | | through a GPU channel. Probably only works in windows only so far. TEST=none BUG=none Review URL: http://codereview.chromium.org/657046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40783 0039d316-1c4b-4281-b951-d872f2087c98
* Load the bookmark manager extension at Chrome startup.aa@chromium.org2010-03-041-0/+83
| | | | | | Review URL: http://codereview.chromium.org/660232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40683 0039d316-1c4b-4281-b951-d872f2087c98
* Laying down the groundwork for GPU video layers.scherkus@chromium.org2010-03-021-0/+2
| | | | | | | | | | | This gets --enable-video-layering working when using the GPU backing store. No actual visuals yet, just IPC message passing and a lot of NOTIMPLEMENTED messages. BUG=33329 TEST=try it out and see if you get lots of NOTIMPLEMENTED messages corresponding with video playback Review URL: http://codereview.chromium.org/661344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40434 0039d316-1c4b-4281-b951-d872f2087c98
* I just put the code that does not compile on ARM. Trybots will fail because ↵apatrick@chromium.org2010-02-241-1/+2
| | | | | | | | | | | | | | I had to remove these from the CL to make gcl upload properly accept it. A + base\scoped_open_process.h A + chrome\plugin\command_buffer_stub_win.cc TEST=try BUG=none Review URL: http://codereview.chromium.org/661022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39937 0039d316-1c4b-4281-b951-d872f2087c98
* Found repeated rlz.gyp ref in chrome.gypcpu@chromium.org2010-02-231-1/+0
| | | | | | | | | | | | | - Lets delete one of them. BUG=none TEST=none Review URL: http://codereview.chromium.org/650004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39674 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39530 - GPU plugin forwards repaint events to Pepper plugin.apatrick@chromium.org2010-02-201-2/+1
| | | | | | | | | | | | | | | | WM_PAINT results in a call to Pepper repaint callback. Implemented WM_ERASEBKGND to prevent flickering on repaint. Implemented PGL_NO_CONTEXT (copied from EGL spec). This is already reviewed by alokp but unfortunately got entangled with this CL. TEST=none BUG=none Review URL: http://codereview.chromium.org/571018 TBR=alokp@chromium.org Review URL: http://codereview.chromium.org/650100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39535 0039d316-1c4b-4281-b951-d872f2087c98
* GPU plugin forwards repaint events to Pepper plugin.apatrick@chromium.org2010-02-201-1/+2
| | | | | | | | | | | | | WM_PAINT results in a call to Pepper repaint callback. Implemented WM_ERASEBKGND to prevent flickering on repaint. Implemented PGL_NO_CONTEXT (copied from EGL spec). This is already reviewed by alokp but unfortunately got entangled with this CL. TEST=none BUG=none Review URL: http://codereview.chromium.org/571018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39530 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing Default User Data Directory for SxS install.huanr@chromium.org2010-02-191-0/+2
| | | | | | | | | TEST=SxS install can run together with normal install. BUG=35574 Review URL: http://codereview.chromium.org/639002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39487 0039d316-1c4b-4281-b951-d872f2087c98
* Solaris: Second set adding in Solaris as an OS optionevan@chromium.org2010-02-181-6/+6
| | | | | | | | | | TEST=compiles BUG=30101 Patch by James Choi <jchoi42@pha.jhu.edu>. Review URL: http://codereview.chromium.org/606075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39362 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gyp DEPS, and mostly revert r38366 which was fixed better in gyp.mmoss@google.com2010-02-171-0/+1
| | | | | | | | | | This properly triggers build targets that depend on "always run" actions. BUG=22044 Review URL: http://codereview.chromium.org/604061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39223 0039d316-1c4b-4281-b951-d872f2087c98
* For sync, make ProcessCommitResponseCommand handle commit entries one ↵tim@chromium.org2010-02-161-0/+2
| | | | | | | | | | | | | | | ModelSafeGroup at a time. Enforce ModelSafeGroup restrictions in the StatusController by DCHECKing if out-of-bounds. Move OrderedCommitSet to its own file. Removed some unused error counters and ResetTransientState calls that were useless. BUG=31911 TEST=ProcessCommitResponseTest, OrderedCommitSetTest Review URL: http://codereview.chromium.org/604045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39139 0039d316-1c4b-4281-b951-d872f2087c98
* For sync, add OrderedCommitSet::Projection, a helper for iterating overtim@chromium.org2010-02-111-0/+1
| | | | | | | | | | | commit IDs one ModelSafeGroup at a time. BUG=31911 TEST=SyncerTest.OrderedCommitSetProjections Review URL: http://codereview.chromium.org/603025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38803 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented new notification methods.akalin@chromium.org2010-02-111-0/+4
| | | | | | | | | | | | | | | | | Added a NotificationMethod enum, which defines NOTIFICATION_LEGACY, NOTIFICATION_TRANSITIONAL, NOTIFICATION_NEW (see bug for details). Made SendUpdateTask and SubscribeTask take a NotificationMethod and use it. Added command-line switch to override default notification method (currently NOTIFICATION_LEGACY). Added a bunch of unittests. BUG=33261 TEST=trybots, manual testing with notification client pythons scripts and browsers with different notification methods Review URL: http://codereview.chromium.org/573046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38740 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up client side of per-datatype GetUpdates.nick@chromium.org2010-02-111-0/+3
| | | | | | | | | | | Which datatypes are fetched is dictated by the ModelSafeRoutingInfo. We change the semantic of the ModelSafeRoutingInfo so that datatypes which should not be synced are not in the map. We will do GetUpdates for GROUP_PASSIVE datatypes. BUG=29905 TEST=included unit tests Review URL: http://codereview.chromium.org/594024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38726 0039d316-1c4b-4281-b951-d872f2087c98
* Include test_shell.gypi in webkit.gyp instead of maintaining a distinctmark@chromium.org2010-02-101-1/+0
| | | | | | | | | | | | | | | | | | test_shell.gyp. This allows the removal of webkit.gyp:pull_in_test_shell, eliminating the circular relationship between webkit.gyp and test_shell.gyp. The expected semantics of building all of test_shell during a webkit.gyp:All build is performed are retained. This change depends on GYP r781 (in Chromium at r38526) for GYP suffix operator path section treatment. It also depends on Chromium r38519 and r38658 for common.gypi treatment of chromium_code. BUG=33186 TEST=Xcode no longer holds stale project files in memory Review URL: http://codereview.chromium.org/602006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38664 0039d316-1c4b-4281-b951-d872f2087c98
* Fill in the preference sync TODOs using the preference specifics proto andalbertb@google.com2010-02-101-0/+5
| | | | | | | | | | | client tags. BUG=32409 TEST=none Review URL: http://codereview.chromium.org/593029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38650 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up invocations of grit and grit_info.bradnelson@google.com2010-02-101-13/+8
| | | | | | | | | | | Making webkit grd dependencies more correct. BUG=19866 TEST=None Review URL: http://codereview.chromium.org/600029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38646 0039d316-1c4b-4281-b951-d872f2087c98
* Make LASTCHANGE work properly for make build.mmoss@google.com2010-02-081-1/+0
| | | | | | | | BUG=22044 Review URL: http://codereview.chromium.org/579014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38366 0039d316-1c4b-4281-b951-d872f2087c98
* OpenBSD/FreeBSD GYP changes (most of the remaining ones)pvalchev@google.com2010-02-041-6/+6
| | | | | | Review URL: http://codereview.chromium.org/565043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38079 0039d316-1c4b-4281-b951-d872f2087c98
* Add autofill proto buffer for sync.zork@google.com2010-02-031-0/+1
| | | | | | | | | BUG=34203 TEST=none Review URL: http://codereview.chromium.org/562027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38033 0039d316-1c4b-4281-b951-d872f2087c98
* [GPU] Get GPU process running on the mackbr@google.com2010-02-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Initial port of GPU process / plugin to Mac OS X. Uses new IOSurface APIs and therefore currently runs only on 10.6. Alternate strategy will need to be devised for 10.5. Slight UI issues remain such as GPU plugins initially showing up in the wrong place on the page. These will be fixed in follow-on bugs. Minimal changes made to command buffer code to get it to compile on Mac OS X. Commented out use of nested anonymous namespaces in gles2_cmd_decoder.cc which were causing the linker to crash with a seg fault. Refactored gyp files so the OS test enabling the GPU plugin is in one place, common.gypi, and other files test only the variable enable_gpu. Slight change to gles2_demo_cc.cc to add some simple animation to verify that updates from the GPU plugin are reaching the screen. Changed Pepper test plugin to use 3D view by default and commented out use of audio context because of recent issues. TEST=none (ran Pepper Test Plugin with 3D view enabled) BUG=http://crbug.com/25988 Review URL: http://codereview.chromium.org/558035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37934 0039d316-1c4b-4281-b951-d872f2087c98
* Sync api changes to support preferences.albertb@google.com2010-02-021-0/+3
| | | | | | | | | BUG=34174 TEST=none Review URL: http://codereview.chromium.org/561010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37865 0039d316-1c4b-4281-b951-d872f2087c98
* Add an implementation for async_network_alive to Linuxzork@chromium.org2010-01-271-4/+1
| | | | | | | | | BUG=33091 TEST=none Review URL: http://codereview.chromium.org/552162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37342 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux shared lib break due to new XScreenSaver dependency.mmoss@google.com2010-01-271-0/+5
| | | | | | | | http://build.chromium.org/buildbot/waterfall.fyi/builders/Chromium%20Linux%20Builder%20(dbg-shlib)/builds/6488/steps/compile/logs/stdio Review URL: http://codereview.chromium.org/558003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37282 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for UserIdleTime to Linux.zork@chromium.org2010-01-261-0/+2
| | | | | | | | | BUG=32421 TEST=none Review URL: http://codereview.chromium.org/553051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37136 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ARM build which can't find OpenGL. This adds a new define which I usebrettw@chromium.org2010-01-261-1/+2
| | | | | | | | | | | | to detect X and GL related build options. On ARM, this means we don't compile the accelerated backing store even though its Linux. BUG=none TEST=none Review URL: http://codereview.chromium.org/546144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37091 0039d316-1c4b-4281-b951-d872f2087c98
* Create initial GPU backing store in the GPU process for X windows applications.brettw@chromium.org2010-01-261-13/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | This gets the window from the RenderWidgetHostViewGtk and just does OpenGL calls directly into it. There are a lot of bugs, especially around expose events, which aren't really processed at all, and also tab teardown and reparenting. The new backing store defaults to off. This does some refactoring of the existing Windows GPU process backing store implementation to make some of it sharable by this Linux verion. This removes some previously defunct in-process GL backing store code and moves it to the GPU process. This patch does some refactoring around how child processes are created using zygoes or not. I found there were many places where a command line would be checked with special logic to know whether to enable zygote code or not. I tried to unify this so it could be computed once for each process type. This is what most of the changed files in chrome/browser are related to. BUG=none TEST=none Review URL: http://codereview.chromium.org/548112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37088 0039d316-1c4b-4281-b951-d872f2087c98
* Split platform specific settings out from locale_settings.grd so we cantony@chromium.org2010-01-221-0/+64
| | | | | | | | | | | | | | | | | | have per platform config and overrides. This is easier to manage than the mess of <if>'s in the existing grd and xtb files. Each platform only builds its locale_settings_{win,mac,linux}.grd file. All the grd files generate the same platform_locale_settings.h header (for easy inclusion in .cc files). We use the fallback feature of grit to only specify locale specific values in xtb files if we want to override the default for the locale. BUG=28590 Review URL: http://codereview.chromium.org/545132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36849 0039d316-1c4b-4281-b951-d872f2087c98
* Support for multiple sync ModelSafeWorkers.tim@chromium.org2010-01-221-0/+1
| | | | | | | | | | | | | | | | | | - Introduce an equivalence class enum to group sync model types that live on the same chrome native model together. - Remove ModelSafeWorkerBridge as it is no longer needed. - Rename BookmarkModelWorker -> UIModelWorker, and make it use the new stuff. - Allow syncable entries belonging to an "unsynced" model type to be just processed "passively" from the SyncerThread (rather than dispatching), and allow this to change as a result of enable/disabling. - Experimenting with a way to complete issue 31909 (the CLASS_UNASSOCIATED stuff). BUG=31925,31911,31909 Review URL: http://codereview.chromium.org/553015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36835 0039d316-1c4b-4281-b951-d872f2087c98
* The renderer and plugin processes can send over raw NPObjects valid in the ↵ananta@chromium.org2010-01-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | other side's address space. Basically the way this works is if an NPObject is marshaled over to the other side, an NPObjectStub is created in the caller address space and a NPObjectProxy is created on the other side. The NPObjectProxy is passed the raw NPObject pointer which is used as a cookie. If the original NPObject needs to be passed back we pass the underlying NPObject saved in the NPObjectProxy. The receiver does not validate whether this NPObject is valid before invoking on it. While this is mostly fine, in the case of a compromised renderer invalid addresses could be passed back to the plugin which would invoke on these addresses and crash. Fix is to never pass raw object pointers across and just pass the corresponding routing id of the NPObjectStub. The receiver validates this object by invoking a new method GetNPObjectListenerForRoute on the PluginChannelBase. This method returns the corresponding NPObject listener for the routing id. We then retrieve the underlying NPObject from the listener and use it. The map of NPObjectListeners which is maintained by PluginChannelBase has been changed to hold NPObjectBase pointers instead. NPObjectStub and NPObjectProxy implement the new NPObjectBase interface which provides methods to return the underlying NPObject and the IPC::Channel::Listener pointer. Fixes bug http://code.google.com/p/chromium/issues/detail?id=31880 I verified with the steps outlined in the bug that this fix does address the underlying crash. Bug=31880 Test=We need a framework to test PluginChannel and NPObjectProxy/Stub. Will add a test case for this once we have this in place. Review URL: http://codereview.chromium.org/548046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36618 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a secondary mini_installer target for Chrome Frame. This will remove ↵robertshield@chromium.org2010-01-191-5/+1
| | | | | | | | | | | | | | the need to have different build scripts to build either Chrome or Chrome Frame. Also remove the now-unneeded gyp variables 'chrome_frame_define' and 'google_update_appid'. BUG=Both Chrome and Chrome Frame products should be buildable from a single solution file - we shouldn't need to run GYP with different settings to get a CF solution. TEST=none Review URL: http://codereview.chromium.org/542078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36546 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 07:18:37 +0000