| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/462014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes Cocoa-event plugins (e.g., Flash 10.1 preview) happier, and Carbon full-screen still gets key events.
BUG=28000
TEST=Flash 10.1 preview should play even without mouse movement. Flash 10 full screen should still accept keyboard commands (e.g., esc).
Review URL: http://codereview.chromium.org/460052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(i.e. this is a plain vanilla build used when layers like base/allocator
are getting in the way of debugging)
and make sure they use msvcrt rather than libcmt
(libcmt is used to help shim malloc/free, but it gets
in the way of valgrind doing the same thing).
Sadly, this is now a gyp-time operation rather than a Configuration
option.
Had to remove hardcoded C prototype for _set_new_mode,
as that caused link errors.
Also add variables win_{release,debug}_{Optimization,RuntimeLibrary}
to let the valgrind build override those settings.
Fix calling convention on _set_new_mode to match the
one in <new.h>
BUG=none
TEST=build with ~/.gyp/include.gypi set as described in comment in common.gypi, gclient runhooks, do release build, verify all exe's and dll's linked against msvcrt dll
Review URL: http://codereview.chromium.org/455037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also enable the task_manager_browsertest.cc (where I added the new test) on Linux.
TEST=Covered by browser_tests.
BUG=21635
Review URL: http://codereview.chromium.org/465007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
than Chromium specific, and clean up a few headers.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/449048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=gregoryd
Review URL: http://codereview.chromium.org/459011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=gregoryd
Review URL: http://codereview.chromium.org/455028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28276
TEST=dump_syms works with ToT Chrome.
Review URL: http://codereview.chromium.org/414049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WebDataService.
This is so I can start adding change notification to the autofill methods, which is need to sync this data type.
Review URL: http://codereview.chromium.org/435030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fix up the references to the mac plugin interpose lib for the proper naming from the GYP roll.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/453014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST="./out/Debug/unit_tests --gtest_filter=CookiesViewTest.\*" should actually do something
BUG=none
Review URL: http://codereview.chromium.org/457018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is the initial implementation, it is still missing:
- row focusing
- resizable columns
- autosize columns
BUG=None
TEST=Run the unit-tests, play with the TableView2 tab in the
view examples.
Review URL: http://codereview.chromium.org/434066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/449024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
added support for baselines to GridLayout.
BUG=4374
TEST=On a new profile make sure the bookmark bar has a link to import
bookmarks, click the link and make sure you can import your bookmarks.
Review URL: http://codereview.chromium.org/440029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now each Profile has a BlacklistManager that maintains a compiled Blacklist for that Profile.
The system does not yet pause user-initiated web requests until the blacklist system is ready. However, the code is not supposed to be ready, and is hidden behind a --enable-privacy-blacklists command-line flag.
TEST=Covered by browser_test.
BUG=21541
Review URL: http://codereview.chromium.org/371063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The concept of "ticket promotion" is added to the application when Keystone is
in use. Ticket promotion is used to turn a user Keystone ticket, which Chrome
normally establishes when it launches, into a system Keystone ticket, after
successful user authentication and authorization. Having a system Keystone
with a system ticket means that updates are applied with root privileges
instead of user privileges, essentially eliminating the possibility that a
user will fall off of the auto-update train because they can read and execute
but not write the application.
Two principles of promotion apply:
- An application on a user ticket NEEDS promotion if it determines that it
doesn't have permission to write to itself. Being on a user ticket, an
update attempt would fail.
- An application on a user ticket WANTS promotion if it already NEEDS
promotion. Additionally, if it is installed in a system-wide location
such as /Applications, it will WANT promotion, even if it does not NEED it.
If promotion is needed, an info bar will show up on launch requesting it.
This info bar works similarly to the default browser info bar: it has a "don't
bother me again" button, it will only show up after the first launch, it won't
disappear on navigation if the navigation happens very quickly, and it won't
show itself if another info bar is up. This means that if both the default
browser info bar and the promotion info bar have a shot at showing, only one
will win. In my experience, each wins about half of the time.
If promotion is needed, the update UI in the About window will be hidden.
Checking for updates and offering to apply them doesn't make much sense when
the update won't be able to install successfully. All of the auto-update
machinery is still working in the background, but the About window UI is
hidden.
If promotion is wanted, the About window will contain a new button allowing
the user to enter promotion. This gives access to the same promotion routine
as the promotion info bar. It can be used even from an administrative account
that is able to update the application without promotion. It's intended to be
used by the system administrator of the family without requiring them to
switch to one of the kids' accounts.
BUG=16360
TEST=Exhaustively, please.
Review URL: http://codereview.chromium.org/437053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SystemMonitor makes an assumption that through its lifetime a MessageLoop exists and stays the same. It is difficult and error-prone to satisfy that when it is a Singleton. It has caused problems in the past.
Additionally, extract HighResoltionTimerManager out of time_win.cc, eliminating yet another Singleton.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/431008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
library with upstream source code from the new vendor branch patterns
in third_party\jemalloc and third_party\tcmalloc.
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/435040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than duplicate logic in the tree, merge all of the
shared rules about patterns in filenames into one common set.
The pattern is: "if (OS != x): exclude x's files."
This is especially needed for upcoming changes that bring in a few
more platform-specific (FreeBSD, OpenBSD, Solaris(?)) files.
Review URL: http://codereview.chromium.org/443011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jparent
TEST=bots green
Review URL: http://codereview.chromium.org/444002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preferences yet, but at least adds support for looking in the right place.
R=cpu,kuchhal
TEST=unit test included
BUG=19374
Review URL: http://codereview.chromium.org/405003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Thiago Farina (thiago.farina@gmail.com)
BUG=26443
TEST=None
Review URL: http://codereview.chromium.org/414072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(sync_ui_util), per style guide.
Changed static functions into anonymous-namespace functions.
Renamed files/namespaces from sync_status_ui_helper to sync_ui_util.
Moved sync_ui_util_mac.mm functions into sync_ui_util namespace.
Updated all callers.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/414065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
default it to false. This should improve performance in
sites that use frames and elimiate confusion, since in most
cases developers *don't* expect content scripts to match
frames.
Review URL: http://codereview.chromium.org/412008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change also reworks the tcmalloc dependency to be added only to chrome and test_shell, instead of base. This is necessary since otherwise tcmalloc will be double initialized (by both the main executable and dlopen'd shared objects like the npapitestplugin.so).
Add valgrind suppressions. This are invalid reads on static initialization in the VDSOSupport module. I haven't investigated it yet, but I suspect they're benign.
BUG=http://crbug.com/28149, http://crbug.com/28385
Review URL: http://codereview.chromium.org/399081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
file with the necessary include rules.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
paths and other minor changes to make it work in the Chrome tree. Will remove copy from O3D tree shortly. Only works in Windows currently.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/436017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26342
TEST+exist
Review URL: http://codereview.chromium.org/429003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it work without a browser window being present.
Moved menu verification code into sync_status_ui_helper_mac{.h,.mm,_unittest.mm}.
BUG=27995
TEST=tested that the main menu item worked with or without a browser window. tested that the main menu item didn't show up unless --enable-sync was passed in.
Review URL: http://codereview.chromium.org/423004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This allows us to not waste time building packages/channels we don't care about. Also added option to build new 'trunk' channel packages, which are a special configuration for developer testing.
Review URL: http://codereview.chromium.org/418021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It does not create these threads, the embedder is responsible for
providing them to the appcache library by implementing the class
declared in appcache_thread.h.
Also in this CL are two implementations, one for Chrome and another for test_shell.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/409005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
process: grep for TODO(port), find cruft, clean it up
Review URL: http://codereview.chromium.org/427004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SyncerSession,
SyncerStatus, and ConflictResolutionView of duty.
Main impact is factors all status munging to 'StatusController', adds SyncSessionContext
to wrap various engine parts needed by different components, removes duplicated methods by a
factor of ~3 making it easier to reason about, and adds a 'Controller' to the session object to
give a way to delegate session-global (i.e affecting any session) occurrences such as throttling.
Also adds testing for 'HasMoreToSync' and other session related code.
BUG=25266
TEST=SyncSessionTest(added), StatusControllerTest(added)
various sync_unit_tests in this CL
Review URL: http://codereview.chromium.org/386030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This makes the man page consistent with other outputs, like 'chrome' and 'chrome.pak', which simplifies some package building logic and keeps all file renaming in one place.
Review URL: http://codereview.chromium.org/420008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17706
TEST=None
Review URL: http://codereview.chromium.org/414006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds functionality to choose between two different InfoBubbleView types: white background and gradient background.
Screenshot: http://andybons.com/chrome/news_popup.png
BUG=23881
TEST=Install a browser action extension that has a popup, click and observe the popup being shown. Initial unit test added, but disabled.
Review URL: http://codereview.chromium.org/402077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
index to store things with parent id and metahandle instead of parent id and name.
Add a template function for extracting name from proto buffers.
Refactor some unit tests to work without unique naming.
Remove path calls since they make no sense without unique names.
Remove find by parentID and names.
Remove unique name resolution from conflict resolver.
Remove syncable name class.
TEST=included unit tests
Review URL: http://codereview.chromium.org/371029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows was the only platform where they were run in-process.
Arguably running out-of-proc is more stable (a test that crashes won't
crash the entire test suite run).
I timed in-proc/out-of-proc runs, the out-of-proc is also slightly faster.
This as the added benefit that we don't need the --lib flag anymore.
This CL also adds usage and fixes the --help flag.
BUG=27677
TEST=Make sure browser tests run well on Windows. Try using the --help
flag, the --gtest_help flag and a combination of --gtest_filter and
--single-process.
Review URL: http://codereview.chromium.org/402061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25677
Review URL: http://codereview.chromium.org/395007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
higher than _ChromeMain, so that CrashReporter stacks and other symbolized
stacks aren't so confusing. Add a tool to verify that nothing violates this
ordering requirement.
BUG=28257
TEST=verify_order, which is part of the build
Review URL: http://codereview.chromium.org/414003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=mark
Review URL: http://codereview.chromium.org/402090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Splitting may cause merge pain for m4.
Will do this over again in about 2 weeks.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/409006
TBR=bradnelson@google.com
Review URL: http://codereview.chromium.org/414004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Splitting may cause merge pain for m4.
Will do this over again in about 2 weeks.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/409006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed to MainMenu.xib: Added a new menu item under the ^IDS_SHORT_PRODUCT_NAME menu with the name . This menu item has a tag of 40014 corredponsing to IDC_IMPORT_SETTINGS and is connected to the commandDispatch: action of the CrApplication (First Responder).
Changes to Toolbar.xib: Added a new menu item with the name ^IDS_IMPORT_SETTINGS in the same manner as above.
BUG=26157
TEST=Launch Chrome and inspect the current bookmarks and settings. With no browser window open and then with a browser window open choose the "Import Bookmarks and Settings..." menu option found under the "Chromium" menu. Also, with a browser window open, hoose the "Import Bookmarks and Settings..." menu option found under the page's tool menu. Select a browser from the popup, choose the items to be imported, and press OK. Then inspect the bookmarks and other settings to insure that the selected items have indeed been imported.
Review URL: http://codereview.chromium.org/378036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/399095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
little (helpeful to make it use ChildProcessLauncher). Note that the test isn't needed anymore as a unit test because since it was written, there have been a couple of tests that exercise this code path through browser_tests. They use sandboxed utility processes so it's more equivalent to what the user experiences.
Review URL: http://codereview.chromium.org/402074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32446 0039d316-1c4b-4281-b951-d872f2087c98
|