summaryrefslogtreecommitdiffstats
path: root/chrome/chrome.gyp
Commit message (Collapse)AuthorAgeFilesLines
* Localize OS X First Run Dialogsjeremy@chromium.org2009-09-081-0/+2
| | | | | | | | | | | | * Uses the awesome ChromeUILocalizer infrastructure. * Also solves the issue of hard coded prodcut names. BUG=19160,19651,19176 TEST=First run dialog + it's progress dialog should now say "Chromium" instead of "Google Chrome". Review URL: http://codereview.chromium.org/199035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25644 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] New icons for the find bar buttons.rohitrao@chromium.org2009-09-081-0/+2
| | | | | | | | BUG=http://crbug.com/14903 TEST=Findbar icons should look more like windows, be properly themed. Review URL: http://codereview.chromium.org/197040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25620 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor DOM storage to be more object oriented. All the ↵jorlow@chromium.org2009-09-081-0/+6
| | | | | | | | | | | | | DOMStorageDispatcher hosts (which are each owned by one ResourceMessageFilter) for the same profile share a WebKit context, and each one of those contexts owns a DOMStorageContext. The DOMStorageContext owns storage namespace objects which own storage area objects which wrap their WebKit counterparts. Not only is this cleaner code wise and more efficient (we're not duplicating WebStorageNamespaces and Areas for each DOMStorageDispatcherHost) but this is necessary for events and locking. TEST=none BUG=none Review URL: http://codereview.chromium.org/192003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25609 0039d316-1c4b-4281-b951-d872f2087c98
* Make ui_tests (and any renderer-based PE) use tcmalloc.mbelshe@google.com2009-09-071-0/+65
| | | | | | | | | | | This paves the way for some upcoming allocator improvements BUG=none TEST=none Review URL: http://codereview.chromium.org/199041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25603 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some gcc 4.4 issues when compiling with toolkit_views.craig.schlenter@chromium.org2009-09-071-2/+5
| | | | | | | | | | | | | | | | | | | | | Most of these squash harmless compiler warnings but the custom_button.cc change fixes a real problem with the accelerator key bitmask calculation (+ preceeds << in terms of operator precedence) The change to tab_strip.cc is ugly but it fixes the following error: chrome/browser/views/tabs/tab_strip.cc: In member function ‘void TabStrip::StartRemoveTabAnimation(int, TabContents*)’: chrome/browser/views/tabs/tab_strip.cc:201: error: assuming signed overflow does not occur when assuming that (X - c) > X is always false As an added bonus, this makes the Linux shared build of toolkit_views work too. Review URL: http://codereview.chromium.org/199025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25602 0039d316-1c4b-4281-b951-d872f2087c98
* Added USE_GDK, set when either TOOLKIT_GTK or TOOLKIT_VIEWS is set butbenl@chromium.org2009-09-071-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | not OS_WIN. Added USE_X11. Set when OS_LINUX or OS_FREEBSD is set. Added USE_BASE_DATA_PACK for base::DataPack usage, set for OS_MACOSX, OS_LINUX or OS_FREEBSD. Added USE_NSS for ... nss (for crypto). Windows and MacOS use platform-specific libraries. All of the above cause slightly odd formulations like: #if defined(OS_WIN) ... #elif defined(USE_BASE_DATA_PACK) ... #endif Possibly should also define USE_DLL_FOR_DATA, etc? Or something? Wrapped various references to struct stat64 and stat64() to use struct stat and stat() for FreeBSD - but a "man stat64" on Linux suggests that we could do the same thing for at least Linux, too, and perhaps eliminate the wrapper? git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25599 0039d316-1c4b-4281-b951-d872f2087c98
* Rename X-Force-TLS to Strict-Transport-Security.abarth@chromium.org2009-09-051-2/+2
| | | | | | | | | | | Also, remove StrictTransportSecurity code from SSLPolicy because that code doesn't work. R=agl Review URL: http://codereview.chromium.org/198035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25577 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add testing code to expose an NSColor memory leak.shess@chromium.org2009-09-051-0/+1
| | | | | | | | | | | | | | | | | | | AutocompleteTextFieldCell calls -keyboardFocusIndicatorColor when drawing the focus ring, which valgrind considers a leak. While we were testing drawing when not focussed, unit tests could not test drawing when focussed without the window being made key, which is bad for many reasons. This change adds some code to allow faking the key window, then adds tests for drawing when focussed which exposes the memory leak, then adds a suppression for that memory leak. http://crbug.com/21137 TEST=valgrind AutocompleteTextFieldCellTest.Display Review URL: http://codereview.chromium.org/192031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25567 0039d316-1c4b-4281-b951-d872f2087c98
* Delete all precompiled support. It is causing more harm than good, ↵maruel@chromium.org2009-09-041-112/+0
| | | | | | | | | | | | especially when define changes. TEST=none BUG=20889 Review URL: http://codereview.chromium.org/171118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25511 0039d316-1c4b-4281-b951-d872f2087c98
* Altering grit so that it clobbers all outputs even on windows.bradnelson@chromium.org2009-09-041-23/+51
| | | | | | | | | | | | | | | | | | | | Previously headers were handled differently only as an optimization. This thwarts vstudio + gyp. Adding a grit_info python stub so that gyp can get an accurate list of inputs and outputs from a grd file. Currently only using it for the inputs, because there's no good way in gyp to have rules invoke a !@( expansion once per rule instance. This change will over-specify dependencies for these modules, but it will at least not under-specify them anymore. BUG=24836 TEST=None Review URL: http://codereview.chromium.org/197007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25499 0039d316-1c4b-4281-b951-d872f2087c98
* Intercept HTTP requests for documents that GView is capable of displaying (suchdavemoore@chromium.org2009-09-041-0/+3
| | | | | | | | | | | as pdf) and redirect the user to the appropriate URL for viewing. Original patch by skrulx@gmail.com http://codereview.chromium.org/174016 Review URL: http://codereview.chromium.org/199019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25496 0039d316-1c4b-4281-b951-d872f2087c98
* ForceTLS: persist to diskagl@chromium.org2009-09-041-0/+2
| | | | | | | | | | | | | | | With this patch, we'll persist ForceTLS state to disk. It's saved as a JSON file (ForceTLSState) in the profile directory for the moment. You still need the --force-https flag in order to trigger any ForceTLS behaviour. For the moment, this state isn't cleared when the rest of the browser state it. That's ok because it's still behind a flag. http://codereview.chromium.org/186014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25459 0039d316-1c4b-4281-b951-d872f2087c98
* Hung Renderer dialog:thomasvl@chromium.org2009-09-041-2/+1
| | | | | | | | | | | | | | | | | | | | Resize to fit the graphic. Fetch the hung from ResourceBundle since it looks like it should be under theme control. Swap the kill and wait buttons. Add in localization objects. Resize message and window to find localized content. Bookmark Bubble: Right align labels to fields. Make window resize to fit labels. Switch to small controls per Cole. Stop bringing the frozen tab graphic into the bundle so we avoid the extra copy. BUG=20525 BUG=20533 TEST=Hung renderer localized and fits content. Bookmark bubble fits labels in all languages. Review URL: http://codereview.chromium.org/193020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25452 0039d316-1c4b-4281-b951-d872f2087c98
* Delete some empty files.viettrungluu@chromium.org2009-09-041-1/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/174190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25414 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r25382: blame Windowsagl@chromium.org2009-09-031-2/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25386 0039d316-1c4b-4281-b951-d872f2087c98
* Add "loading..." message to theme install to counter jank.mirandac@chromium.org2009-09-031-0/+2
| | | | | | | | | BUG= http://crbug.com/17696 TEST= Install a theme. Note that a "loading" message appears to notify you that a theme is loading. Review URL: http://codereview.chromium.org/191011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25383 0039d316-1c4b-4281-b951-d872f2087c98
* ForceTLS: persist to diskagl@chromium.org2009-09-031-0/+2
| | | | | | | | | | | | | | | With this patch, we'll persist ForceTLS state to disk. It's saved as a JSON file (ForceTLSState) in the user data directory for the moment. You still need the --force-https flag in order to trigger any ForceTLS behaviour, however. For the moment, this state isn't cleared when the rest of the browser state it. That's ok because it's still behind a flag. http://codereview.chromium.org/186014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25382 0039d316-1c4b-4281-b951-d872f2087c98
* Add external protocol dialog for Linux.estade@chromium.org2009-09-031-0/+2
| | | | | | | | | | This exposes a bug where \n in a string resource is rendered literally when it is displayed. I don't know at what point on Windows the '\' + 'n' is translated to a line return, I have filed crbug.com/20943 BUG=20731 Review URL: http://codereview.chromium.org/194002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25373 0039d316-1c4b-4281-b951-d872f2087c98
* (Mac) Make the Page/Wrench buttons place their menu in the right place.viettrungluu@chromium.org2009-09-031-0/+3
| | | | | | | | | | | | | | | | | | | | | | Also makes the buttons drag-able -- you can drag or click and wait to open their menu. Lucky for me, I wrote reusable code. To do (not now): The "off-the-end" button on the bookmark bar needs the same fix. Bug (not to be fixed now): The menu doesn't do the right thing when the window is moved off the left edge to the screen -- it doesn't open to the right in the correct fashion. Nor does it do the proper thing when you move the window off the bottom edge of the screen -- it doesn't open upwards entirely correctly. <shrug> BUG=18572 TEST=Click on the Page and Wrench menu buttons and observe. Also test \ dragging to open. Review URL: http://codereview.chromium.org/174556 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25362 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Add basic unit tests for gtk themes.erg@google.com2009-09-031-0/+1
| | | | | | Review URL: http://codereview.chromium.org/186019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25317 0039d316-1c4b-4281-b951-d872f2087c98
* Move status area view to the chromeos directory.brettw@chromium.org2009-09-031-8/+2
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/192001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25279 0039d316-1c4b-4281-b951-d872f2087c98
* Adding in memory log of history visit database. Thishuanr@chromium.org2009-09-021-0/+3
| | | | | | | | | | | | log will be saved in crash dump (to be done in next CL) to help debug the corruption in history thread. TEST=Added unit test. BUG=16591 Review URL: http://codereview.chromium.org/187004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25276 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude specific browser_tests that don't yet work on Mac.paul@chromium.org2009-09-021-0/+1
| | | | | | | | | BUG=16322 (http://crbug.com/16322) TEST=Covered by browser_tests. Review URL: http://codereview.chromium.org/189007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25265 0039d316-1c4b-4281-b951-d872f2087c98
* Even though the Finder's Get Info shows the language correctly when you use ↵thomasvl@chromium.org2009-09-021-2/+4
| | | | | | | | | | | | | lproj folders with '-' instead of '_', Cocoa fails to load things at runtime from within them. Map the names when writing lproj folders to use underscore. Put an option on the helper script to control dash/underscore mapping since we need support for both. TEST=try chinese and traditional chinese, they work now. BUG=20441 Review URL: http://codereview.chromium.org/187011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25243 0039d316-1c4b-4281-b951-d872f2087c98
* Add all locales to the grit output list.thestig@chromium.org2009-09-021-10/+8
| | | | | | | | BUG=none TEST=Linux make build no longer fails complaining about foo_ar.pak. Review URL: http://codereview.chromium.org/188003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25213 0039d316-1c4b-4281-b951-d872f2087c98
* A new string for the mac file type label in the save as dialog.thomasvl@chromium.org2009-09-021-1/+3
| | | | | | | | | | | Localize the save page as dialog. Localize the clear browser data dialog. TEST=The file saves as won't show up localized until it's been through translation. The Clear browser data should show up in all languages now. BUG=205280,20537 Review URL: http://codereview.chromium.org/176059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25164 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude pack_extension_job.cc from non windows builds.craig.schlenter@chromium.org2009-09-021-0/+1
| | | | | | | | | This code relies on extension_creator.cc which is also currently excluded. This fixes the Linux shared build. Review URL: http://codereview.chromium.org/175044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25155 0039d316-1c4b-4281-b951-d872f2087c98
* Split ExtraRequestInfo out of ResourceDispatcherHost so it isn't cluttering upbrettw@chromium.org2009-09-021-0/+2
| | | | | | | | | | | that header file. I added documentation and split out the accessors according to Google-style. BUG=none TEST=none Review URL: http://codereview.chromium.org/179046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25133 0039d316-1c4b-4281-b951-d872f2087c98
* The FocusManager stores/restores focus when the top window becomes ↵jcampan@chromium.org2009-09-011-1/+2
| | | | | | | | | | | | inactive/active. BUG=None TEST=Run the focus manager unit-tests. Review URL: http://codereview.chromium.org/164448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25108 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb request interception into the appcache library for both chrome and ↵michaeln@google.com2009-09-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | test_shell. AppCache library: * Added AppCacheInterceptor, which is derived from URLRequest::Interceptor. Chrome: * Each UserProfile instantiates a ChromeAppCacheService, which is derived from an appcache library class. * Each ChromeURLRequestContext associated with that profile has a reference to that instance. * ResourceDispatcherHost pokes AppCacheInterceptor when initiating URLRequests and when returning the response head. TestShell: * Added SimpleAppCacheSystem which bundles together appcache lib components for use in a single process with an UI and IO thread. * TestShellWebKit instantiates and initializes an instance of the above, aimed at at temp directory that will get cleaned up when the test run is over. * SimpleResourceLoaderBridge pokes the system when initiating URLRequests and when returning the response head. TEST=none, although many existing tests exercise this stuff BUG=none Review URL: http://codereview.chromium.org/173406 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25099 0039d316-1c4b-4281-b951-d872f2087c98
* (Mac) Added unit tests for ClickHoldButtonCell and DelayedMenuButton.viettrungluu@chromium.org2009-09-011-0/+2
| | | | | | | | | | | | Also added some comments and cleaned up some code. BUG=20693 TEST=Run unit tests. Also make sure back/forward buttons (and menus) \ work correctly. Review URL: http://codereview.chromium.org/179043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25088 0039d316-1c4b-4281-b951-d872f2087c98
* Parameterize the Google Update appid at build time instead of hard coding it ↵robertshield@chromium.org2009-09-011-0/+1
| | | | | | | | in the source. Review URL: http://codereview.chromium.org/178011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25072 0039d316-1c4b-4281-b951-d872f2087c98
* Porting textfield to toolkit_views Gtk.jcampan@chromium.org2009-09-011-0/+2
| | | | | | | | | | | BUG=None TEST=Run the view unit-tests. See original review: http://codereview.chromium.org/165512/show Review URL: http://codereview.chromium.org/180061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25063 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: The Theme Installed Infobar's "Undo" button should work with GTK ↵erg@google.com2009-09-011-0/+2
| | | | | | | | | | Themes. http://crbug.com/20629 Review URL: http://codereview.chromium.org/181022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25050 0039d316-1c4b-4281-b951-d872f2087c98
* When running on chrome OS about:version now shows OS version.sky@chromium.org2009-09-011-0/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/179063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25045 0039d316-1c4b-4281-b951-d872f2087c98
* Put a proper info.plist into the framework so we can codesign it.thomasvl@chromium.org2009-09-011-3/+28
| | | | | | | | | | | Update the tweak info.plist script to work on frameworks as well as apps. Remove the bundle version since the script manages that. BUG=20503 TEST=The framework should now have an valid info.plist file in it's resources folder. Review URL: http://codereview.chromium.org/178055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25027 0039d316-1c4b-4281-b951-d872f2087c98
* A few more fixes to chrome://extensions/.aa@chromium.org2009-09-011-0/+2
| | | | | | | | | | | | | | | * Pull PackExtensionJob out into its own file so that it could more easily be reused in the future. * Disable OK button while PackExtnesionJob is running to give a bit of feedback that something is happening. * Fix title-casing. Apparently sentence-casing is Google UX stanard. Review URL: http://codereview.chromium.org/176047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25013 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser tests for extensions tab API.asargent@chromium.org2009-09-011-0/+1
| | | | | | | | | BUG=18442 TEST=none Review URL: http://codereview.chromium.org/174633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25006 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: about:memoryagl@chromium.org2009-09-011-1/+2
| | | | | | | | | | | | | (based on http://code.google.com/p/chromium/issues/detail?id=16251) Add about:memory support to Linux. Rather than try and copy the Windows output, we use a couple of metrics which make more sense on Linux: USS and PSS. http://codereview.chromium.org/177024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24979 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk confirm form resubmission dialog.mattm@chromium.org2009-08-311-1/+2
| | | | | | | | | | | Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog BUG=19761 TEST=see bug Review URL: http://codereview.chromium.org/174294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24930 0039d316-1c4b-4281-b951-d872f2087c98
* Replace the RenderProcessHost.PID function that returns the OS-generatedbrettw@chromium.org2009-08-311-0/+2
| | | | | | | | | | | | | | | | | | | | process ID with an internally-generated id() function. This allows us the guarantee that the IDs are unique over the entire run of the application. This also cleans up some code associated with managing the PID. The main potentially interesting change is now the PID is set uniquely for every creation of RenderProcessHost. It used to be set cleared if the process went away, and re-set if the process was re-created. The ID generation is in ChildProcesInfo so it is also unique between workers and plugins. I had to change some significant things in resource_dispatcher_host_unittest to take into account this new generation of IDs. BUG=17828 TEST=none Review URL: http://codereview.chromium.org/160203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24899 0039d316-1c4b-4281-b951-d872f2087c98
* share extension API test frameworkerikkay@chromium.org2009-08-311-0/+1
| | | | | | | | | BUG=18442 TEST=ExtensionApiTest.* Review URL: http://codereview.chromium.org/173622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24892 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a button to chrome://extensions/ that allows easy packingaa@chromium.org2009-08-311-0/+1
| | | | | | | | | | | of extensions into crx files. BUG=20578 TEST=Create a sample extension, pack it, then try to install it. Review URL: http://codereview.chromium.org/181020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24877 0039d316-1c4b-4281-b951-d872f2087c98
* Disable incremental linking for ui_tests on 32 bits OS.maruel@chromium.org2009-08-291-0/+5
| | | | | | | | | | ui_tests needs to be considered as a "large module" now otherwise linking failure may happen. TEST=none BUG=none Review URL: http://codereview.chromium.org/182016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24855 0039d316-1c4b-4281-b951-d872f2087c98
* Force databases and localstorage to be enabled extensions.aa@chromium.org2009-08-291-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | We were already doing this, this change modifies the mechanism. Before we were relying on the presence of the --enable-extensions flag, but as we are getting ready to remove that on dev, we needed something else. This forces local storage and database to be enabled on chrome-extension:// pages. Also, change the way database enabling works in general to be more like the way local storage works, just for consistency. Will remove old, unnecessary WebKit API in an upstream change. erikkay: extensions stuff dumi: database stuff jorlow: local storage stuff BUG=19511 Review URL: http://codereview.chromium.org/173306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24841 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Refactoring and rounds the "Search site for:" hint.erg@google.com2009-08-281-0/+2
| | | | | | | | | | | | | Factor out common window rounding code from two places where it was used, generalize it, and use it to round the "Search site for:" hint in the location bar. Theoretically, people should be able to use this anywhere they need a window to have rounded corners. http://crbug.com/18310 Review URL: http://codereview.chromium.org/179026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24828 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Gtk confirm form resubmission dialog." Broke linux views build.mattm@chromium.org2009-08-281-2/+1
| | | | | | | | | | This reverts commit e6ab23c81e56c6b9fbb062bbb090a648e6ebef12. TBR=beng Review URL: http://codereview.chromium.org/183006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24827 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk confirm form resubmission dialog.mattm@chromium.org2009-08-281-1/+2
| | | | | | | | | | | Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog BUG=19761 TEST=see bug Review URL: http://codereview.chromium.org/174294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24826 0039d316-1c4b-4281-b951-d872f2087c98
* Make the views bookmark bubble work on GTK.brettw@chromium.org2009-08-281-0/+2
| | | | | | | | | | | The combobox still isn't implemented, but this makes TextBox work, and also does some changes around the info_bubble to make sure it get created properly. TEST=none BUG=none. Review URL: http://codereview.chromium.org/177026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24821 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a FaviconService class tied to the profile.arv@google.com2009-08-281-0/+2
| | | | | | | | | | | | | | | | | | | Original issue: http://codereview.chromium.org/115212/show The favicons service is the entry point to getting favicons. Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages are never added to the history. BUG=5840 TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in this window. Then close the window and open the NTP. The recently closed windows/tabs should show the favicons for the hsitroy and downloads page. Review URL: http://codereview.chromium.org/178001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24806 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 19:38:02 +0000