summaryrefslogtreecommitdiffstats
path: root/chrome/chrome.gyp
Commit message (Collapse)AuthorAgeFilesLines
* This CL adds an infobar instructing users they can do search directly from ↵jcampan@chromium.org2009-07-231-0/+2
| | | | | | | | the location bar when they navigate to their default search engine.The infobar is dismissed and not shown again if the user does a search from the omnibox or dismiss the infobar.This is part of a UX experiment and is behind a switch.BUG=NoneTEST=Start Chrome with a fresh profile. Navigate to www.google.com. An info bar should be shown. Click the 'show me' button, the location bar should display a message explaining search can be made from it. Review URL: http://codereview.chromium.org/159242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21438 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a couple gyp configuration issues with ipc_tests.agl@chromium.org2009-07-231-3/+1
| | | | | | | | | | | | | | | | | Adds ipc/ipc.gyp:* to the windows-only 'pull_in_all' target in chrome.gyp so that it's built on the windows builders and removes the dependency from unit_tests onto ipc/ipc.gyp:ipc_tests. Renames file_descriptor_set_unittest.cc to file_descriptor_set_posix_unittest.cc to match the .h/.cc files and so that it gets picked up by the exclusion filter properly. (Patch from James Robinson) http://codereview.chromium.org/159272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21399 0039d316-1c4b-4281-b951-d872f2087c98
* back out CLs 21367, 21366 - no idea why these keep breakingdpranke@google.com2009-07-231-0/+12
| | | | | | Review URL: http://codereview.chromium.org/155983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21371 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: ipc_tests.exe is not getting built for Windows release.agl@chromium.org2009-07-231-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | (Broke in r21342) <jamesr> agl: chromium XP release builder builds chrome.sln and then tries to run ipc_tests.exe. nothing in chrome.gyp depends on ipc_tests now so the executable doesn't exist on that builder <jamesr> agl/jrg: adding a dependency on ../ipc/ipc.gyp:ipc_tests to the 'coverage' target would solve both issues <jrg> jamesr: agl's change will only impact the coverage bots. Sounds like that't not what you want, right? <jamesr> jrg: i think it's correct but won't resolve the chromium XP issue. coverage should run for those tests either way <agl> jamesr: how about I tie it to unit_tests? <agl> jamesr: there's a long term solution and then there's getting the builder green. <jamesr> agl: yeah. trying to check super fast if getting that builder to not run ipc_tests.exe is easy http://codereview.chromium.org/155977 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21369 0039d316-1c4b-4281-b951-d872f2087c98
* re-do CL 21252 - move image_diff to tools, add deps to test_shelldpranke@google.com2009-07-231-12/+0
| | | | | | | | | | | | | | | CL 21252 seems to have had some svn brokenness (not sure why). I've recreated it and resubmitted it. The changes are to move image_diff from chrome/tools/test to tools/, and to make test_shell depend on image_diff and npapi_layout_test_plugin (and test_worker, where applicable) R=nsylvain@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/155959 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21366 0039d316-1c4b-4281-b951-d872f2087c98
* Split the IPC code into ipc/agl@chromium.org2009-07-221-56/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This splits the ipc code from the common project. The 'common' project pulls in all of webkit, the v8 bindings, skia, googleurl, and a number of other projects which makes it very difficult to deal with especially for external projects wanting just to use some of Chromium's infrastructure. This puts the ipc code into its top-level ipc/ directory with a dependency only on base. The common project depends on the new ipc/ipc.gyp:ipc target so that all projects currently pulling common in to get the IPC code still have it available. This mostly follows agl's pre-gyp attempt to do this which was r13062. Known issues: - Currently a number of projects depend on chrome/chrome.gyp:common in order to use the IPC infrastructure. Rather than fixing all of these dependencies I have made common depend on ipc/ipc.gyp:ipc and added "ipc" to the include_rules section of DEPS so that checkdeps.py doesn't complain. Over time projects that need IPC should depend on the IPC project themselves and dependencies on common removed, although I don't think many projects that need IPC will be able to get away without common currently. - ipc/ipc_message_macros.h still has #include "chrome/common/..." inside of a ipc/ should not refer to files in chrome/... now. I'm not sure how to resolve this since it's really an IDE bug - the named pipe name (windows+linux) and the logging event name (all) + env variable (posix) refer explicitly to 'Chrome' which somewhat hurts the illusion of ipc/ being an independent library. I think this should be examined in a subsequent, much smaller patch. - I've eliminated the IPC.SendMsgCount counter since it was implemented in a way to create a dependency from ipc/ to chrome/common/chrome_counters. This is the same approach that r13062 took. http://codereview.chromium.org/155905 (Patch from James Robinson) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21342 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to provide asynchronous read in data source:hclam@chromium.org2009-07-221-2/+0
| | | | | | | | | | | | | 1. FFmpegGlue now taks a FFmpegProtocol instead of DataSource as input 2. FFmpegDemuxr implements FFmpegProtocol and does the blocking read and submit asynchronous read request to DataSource (with unit tests) 3. Changed SimpleDataSource to work with asynchronous read (with unit tests) 4. Reimplemented BufferedDataSource to work with asynchronous read (with unit tests) 5. Moved BufferedDataSource from chrome/renderer/media to webkit/glue/media (for faster build/debug and better coverage in automated testing) TEST=BufferedDataSourceTest.*, SimpleDataSourceTest.*, FFmpegDemuxerTest.* Review URL: http://codereview.chromium.org/149567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21326 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk cookie manager part 1.mattm@chromium.org2009-07-221-0/+4
| | | | | | | | | | | | (Doesn't display cookie details, otherwise working.) BUG=11507 TEST=All cookie manager functions should work as expected, other than viewing the cookie details. Review URL: http://codereview.chromium.org/159187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21307 0039d316-1c4b-4281-b951-d872f2087c98
* linux: generate a manpageevan@chromium.org2009-07-221-0/+34
| | | | | | | | This is not intended to be complete; hopefully we can iterate from here. Review URL: http://codereview.chromium.org/159198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21298 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark Bar Add Folder / Rename Folder dialog and controller.jrg@chromium.org2009-07-221-0/+4
| | | | | | | | | | | | TEST=Right click on bar --> Add Folder... Type a name and it shows up as a folder in the bookmark bar. (You can't do anything with it yet; sorry). Right click on folder name --> Edit... Make sure you can rename the folder. Review URL: http://codereview.chromium.org/159183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21293 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure installer_util_string is always built beforensylvain@chromium.org2009-07-221-6/+15
| | | | | | | | | | | | | installer_util. It was triggering a bug in Incredibuild. By making one of the dependent of install_util a dummy_executable, and making this dummy_executable depends on installer_utils_strings, the odds that it triggers a bug is a lot smaller. I tried 6 clobber builds so far and none of them failed. Review URL: http://codereview.chromium.org/155923 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21283 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: generate a manpage"evan@chromium.org2009-07-221-30/+0
| | | | | | | This reverts commit r21277, since it failed on the scons build for reasons totally opaque to me. :~( git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21278 0039d316-1c4b-4281-b951-d872f2087c98
* linux: generate a manpageevan@chromium.org2009-07-221-0/+30
| | | | | | | | This is not intended to be complete; hopefully we can iterate from here. Review URL: http://codereview.chromium.org/159198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21277 0039d316-1c4b-4281-b951-d872f2087c98
* Starting mac l10n:thomasvl@chromium.org2009-07-221-10/+24
| | | | | | | | | | | | | | | | | | | Added a script to process a xib file and generate a localizer out of the resource constants it finds in the xib. Update the MainMenu.xib to use a generated localizer. Kill off the menu_localizer in favor of a generated one. ui_localizer is a helper so each "localizer" is as small as possible. Build some menus out of base strings and the product name like windows. Added the dir generated for the localizers so we can load the header to directly create them (menubar one). Enable the other 3 languages we were building to help test. Made the context menu code use the new code for handling window's accelerators and ellipsis. Added unittest for ui_localizer. Opened http://crbug.com/17380 to track the problem with the menu titles so I can move on to other parts of the UI for now. TEST=The main menu will have some items localized now (and more will be localizable in the TC). BUG=16764 Review URL: http://codereview.chromium.org/155774 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21272 0039d316-1c4b-4281-b951-d872f2087c98
* Submit the second part of the revert.nsylvain@chromium.org2009-07-221-1/+0
| | | | | | Review URL: http://codereview.chromium.org/155907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21264 0039d316-1c4b-4281-b951-d872f2087c98
* revert change 21252, which broke the mac build for some reasondpranke@google.com2009-07-221-0/+12
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21262 0039d316-1c4b-4281-b951-d872f2087c98
* Add a unit test for ProcessWatcher::EnsureProcessTerminated().thestig@chromium.org2009-07-221-0/+1
| | | | | | Review URL: http://codereview.chromium.org/155799 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21259 0039d316-1c4b-4281-b951-d872f2087c98
* make 'test_shell' target depend on everything needed to pass layout_testsdpranke@google.com2009-07-221-12/+0
| | | | | | | | | | | | | | | | | This adds project dependencies to test_shell so that all (and only?) the targets needed for the layout_tests to run cleanly are built. On most platforms this is test_shell, npapi_test_plugin, and test_worker, and on the Mac this adds the layout_test_helper binary as well also, this moves image_diff from chrome/tools/test to tools/ R=mmentovai@google.com, darin@google.com BUG=none TEST=none Review URL: http://codereview.chromium.org/149714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21252 0039d316-1c4b-4281-b951-d872f2087c98
* Split NSSDecryptor out into platform specific files.willchan@chromium.org2009-07-221-0/+7
| | | | | | | | | | This lets Linux not bother to initialize NSS in the same way as the rest, but instead use the NSS symbols linked into the library, thereby preventing the NSS_Shutdown related bugs. BUG=http://crbug.com/13929 TEST=Case 1: Start chrome. Use firefox import utility. Browse to some https site. Shouldn't crash. Case 2: Start chrome. Browse to some https site. Use firefox import utility. Continue browsing https sites. Shouldn't crash. Review URL: http://codereview.chromium.org/159165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21251 0039d316-1c4b-4281-b951-d872f2087c98
* Implement bookmark editor. No tree display or hierarchy movement, butjrg@chromium.org2009-07-211-1/+5
| | | | | | | | | | | | | | | | | | name/url editing works. Get to the edotir from a context menu (Edit, Add Page). Also Implement Open All Bookmarks menu item. BUG=http://crbug.com/8381, http://crbug.com/17006 TEST=Add some bookmarks. Right-click on a bookmark and pick Edit. Test editing the name and URL. Make sure you can't add a bogus URL. Right-click on a bookmark or the bar and Add Page. Fill in name and URL fields to add a new bookmark. Right-click Open All Bookmarks and make sure it hoses your machine. Review URL: http://codereview.chromium.org/155874 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21241 0039d316-1c4b-4281-b951-d872f2087c98
* Use a real download item.thakis@chromium.org2009-07-211-0/+2
| | | | | | | | | BUG=14659,17100 TEST=Download multiple things. Items should now be inserted from the left. When a download is in progress, the time to completion should be displayed, when it's done the time should fade out and the filename should move down. Download items should appear in a sweep animation. Clicking the download directly should open it; clicking the arrow on the right of the download item should show the correct context menu. If a download filename is long, it should be elided in the middle. Review URL: http://codereview.chromium.org/159060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21201 0039d316-1c4b-4281-b951-d872f2087c98
* Resurrect toolkit_views build.ben@chromium.org2009-07-211-5/+1
| | | | | | Review URL: http://codereview.chromium.org/155797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21132 0039d316-1c4b-4281-b951-d872f2087c98
* Infobar UI cleanup on Mac. Adds the yellow background gradient androhitrao@chromium.org2009-07-201-0/+3
| | | | | | | | | | | | | | | centers all of the buttons. Also adds the ok/cancel buttons to the xib file. Infobars that do not need the buttons can remove them from the view before displaying. BUG=http://crbug.com/14462 BUG=http://crbug.com/17195 TEST=Infobars should have yellow background, look less ugly. Review URL: http://codereview.chromium.org/155788 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21128 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Strip newlines from paste.shess@chromium.org2009-07-201-0/+1
| | | | | | | | | | | | | | http://crbug.com/11817 TEST=Copy an URL somewhere and break it apart with newlines at random places. Copy/paste it into omnibox and the newlines should be gone. Try this one: http://dev.chro mium.org/develo pers/how-tos/ge t-the-code Review URL: http://codereview.chromium.org/159018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21125 0039d316-1c4b-4281-b951-d872f2087c98
* Move all the xib files out of the en.lproj in prep for starting to land real ↵thomasvl@chromium.org2009-07-201-61/+89
| | | | | | | | | | | | l10n support. Cleanup some tabs/indents in chrome.gyp BUG=16764 TEST=All UI still works Review URL: http://codereview.chromium.org/155800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21109 0039d316-1c4b-4281-b951-d872f2087c98
* Add a simple "sidebar"-like panel container that will scroll.brettw@chromium.org2009-07-201-0/+27
| | | | | | | | This doesn't actually hold any panels at the moment, just dummy content. Review URL: http://codereview.chromium.org/155593 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21092 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the the refactoring the page info to have a model.jcampan@chromium.org2009-07-191-4/+3
| | | | | | | | | BUG=None TEST=Make sure clicking the lock/warning icon when visiting a HTTPS page brings the page info and that it reports the correct info. Also check that the "Page/Frame info" right click menu works as well. TBR=ben Review URL: http://codereview.chromium.org/155753 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21065 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux shared build of page_cycler_tests.craig.schlenter@chromium.org2009-07-181-0/+1
| | | | | | | | Reported by fta. Review URL: http://codereview.chromium.org/159055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21058 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 21032.jcampan@chromium.org2009-07-181-3/+4
| | | | | | | | | It breaks the release build on Windows. TBR=ben Review URL: http://codereview.chromium.org/155736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21035 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring the page info to have a model.BUG=NoneTEST=Make sure clicking ↵jcampan@chromium.org2009-07-181-4/+3
| | | | | | | | the lock/warning icon when visiting a HTTPS page brings the page info and that it reports the correct info. Also check that the "Page/Frame info" right click menu works as well. Review URL: http://codereview.chromium.org/155336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21032 0039d316-1c4b-4281-b951-d872f2087c98
* Begin work on extension shelf for Linux.phajdan.jr@chromium.org2009-07-171-0/+2
| | | | | | | | | | | For now it displays only a placeholder text, but knows when to display (it's connected to the ExtensionShelfModel). TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/159019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21014 0039d316-1c4b-4281-b951-d872f2087c98
* Move into browser/cocoa from browser/pinkerton@chromium.org2009-07-171-1/+1
| | | | | | | | BUG=15475 TEST=none Review URL: http://codereview.chromium.org/155690 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20958 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at infobars on Mac. These are not expected to berohitrao@chromium.org2009-07-171-0/+13
| | | | | | | | | | | | | | pretty. Animations and aesthetic appeal will come in a future CL. BUG=http://crbug.com/14462 BUG=http://crbug.com/14937 BUG=http://crbug.com/15839 BUG=http://crbug.com/16487 TEST=Infobars should show up when expected. Review URL: http://codereview.chromium.org/155494 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20930 0039d316-1c4b-4281-b951-d872f2087c98
* Print only the focused frame. This makes more sense than trying to print ↵sverrir@chromium.org2009-07-161-2/+0
| | | | | | | | | | | | | | all frames since most of the time you end up with ugly clipping and scroll bars on the printed page. This also fixes printing issue with print selection since we don't pick up the currently selected text if's not in the main frame. Also did some refactoring of the printing test in render_view_unittest. Mainly to reuse the new Image class. BUG=http://crbug.com/15250 TEST=Print pages with frames. Print selection when using multiple frames (one example in bug). Review URL: http://codereview.chromium.org/149644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20876 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactor location-bar autocomplete cell classes.shess@chromium.org2009-07-161-4/+9
| | | | | | | | | | | LocationBarCell -> AutocompleteTextFieldCell. LocationBarFieldEditor -> AutocompleteTextFieldEditor. AutocompleteTextField added as placeholder for future work (hints and keyword search). Review URL: http://codereview.chromium.org/149717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20853 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the default for what to do on startup be restore last session onsky@chromium.org2009-07-161-0/+2
| | | | | | | | | | | | | | chrome os as well as changing autocomplete edit/popup font sizes on chrome os. As suggested by Evan I've moved these options into chrome/browser/defaults.h so that we don't have a ton of #ifdefs every where. BUG=none TEST=none Review URL: http://codereview.chromium.org/155576 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20852 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move hardcoded paths to GYP variables.agl@chromium.org2009-07-151-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch removes the hardcoded paths for the sandbox binary location and the chrome binary location for the sandbox. Instead, you can now set GYP variables for these things. Indeed, you have to set a GYP variable in order to use the sandbox now. GYP variables can be set on the command line, if you run gyp.py directly, with -D key=value. Or you can export GYP_DEFINES="key=value key2=value2". Now, in order to use the sandbox you should set: linux_sandbox_path=/opt/google/chrome/chrome-sandbox linux_sandbox_chrome_path=/opt/google/chrome/chrome (changing the paths as needed, of course). See the comments in build/common.gypi For development see http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment Because developers need to setup a special sandbox binary. http://codereview.chromium.org/149689 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20801 0039d316-1c4b-4281-b951-d872f2087c98
* This makes the unit-tests pass with toolkit_views on Linux.jcampan@chromium.org2009-07-151-12/+25
| | | | | | | | | | It also make them run the view tests. BUG=None TEST=Run the unit-tests on Linux with toolkit_views=1 Review URL: http://codereview.chromium.org/149649 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20794 0039d316-1c4b-4281-b951-d872f2087c98
* Adds browser tests instead of the old flaky UI tests.klink@chromium.org2009-07-151-18/+1
| | | | | | Review URL: http://codereview.chromium.org/155487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20757 0039d316-1c4b-4281-b951-d872f2087c98
* Implement drops on web view.pinkerton@chromium.org2009-07-151-0/+3
| | | | | | | | BUG=13155, 15657 TEST=Dragging from other applications to web view should load urls or drop text depending on where in the view the drop occurs. Same with drags from the desktop. Drags within text fields on a webpage should work. Review URL: http://codereview.chromium.org/149626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20737 0039d316-1c4b-4281-b951-d872f2087c98
* Privacy Blacklist IOImplemented parsing of input (text) blacklists. This is ↵idanan@chromium.org2009-07-151-0/+5
| | | | | | | | | | the format in which we will download privacy blacklist.Implemented storing and reading of aggregated blacklists in a binary format. This is the repository which Chromium will read on startup which is more efficient to load than the downloaded blacklists.Added concept of providers to blacklist entries so that we can determine the source of a pattern match, for future display in the UI.Unit tests added for the new IO classes. Privacy Blacklist conversion tool implemented to a single text blacklist into the binary format. Still needs options for storing multiple blacklists (TODO). BUG=none TEST=Blacklist* Review URL: http://codereview.chromium.org/155298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20734 0039d316-1c4b-4281-b951-d872f2087c98
* Various minor fixes:aa@chromium.org2009-07-151-1/+0
| | | | | | | | | | | | | | | | * --load-extension no longer requires --enable-extensions * No longer support chrome:// URLs for user scripts * Remove old unused Greasemonkey test * Enable Greasemonkey API emulation in linux/mac BUG=16720,16007,4476 TEST=Added several unit tests Original review: http://codereview.chromium.org/149619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20719 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a message box to confirm if the user really wants to delete all storedhclam@chromium.org2009-07-141-0/+2
| | | | | | | | | | | passwords. Original CL: http://codereview.chromium.org/155291 Patch contributed by: thiago.farina@gmail.com Review URL: http://codereview.chromium.org/155513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20658 0039d316-1c4b-4281-b951-d872f2087c98
* Make workers functional on OSX and Linux.levin@chromium.org2009-07-141-41/+35
| | | | | | | | | | BUG=http://crbug.com/16664 TEST=The same tests run for Web Workers on Windows should be run on Linux and OSX. Review URL: http://codereview.chromium.org/155015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20653 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155508 for cmasone:sky@chromium.org2009-07-141-0/+2
| | | | | | | | | | | Fixes build breakage. BUG=none TEST=none Review URL: http://codereview.chromium.org/149629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20648 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add first run search bubble.kuchhal@chromium.org2009-07-141-0/+2
| | | | | | Review URL: http://codereview.chromium.org/149501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20625 0039d316-1c4b-4281-b951-d872f2087c98
* Finishes fixing adding protobuf dependency.sky@chromium.org2009-07-141-3/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149612 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20622 0039d316-1c4b-4281-b951-d872f2087c98
* Allow dragging text/url content out of the browser. Dragging back in not yet ↵pinkerton@chromium.org2009-07-141-0/+6
| | | | | | | | | | implemented. BUG=13155 TEST=dragging urls and selected text to other apps, the desktop, or the Dock should work. Review URL: http://codereview.chromium.org/149565 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20619 0039d316-1c4b-4281-b951-d872f2087c98
* Copy codec Mac build stage (branded and unbranded)jrg@chromium.org2009-07-141-0/+16
| | | | | | Review URL: http://codereview.chromium.org/149593 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20596 0039d316-1c4b-4281-b951-d872f2087c98
* More bookmark bar changes.jrg@chromium.org2009-07-141-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Applied memory cleanliness fix in unit test; follow-up from http://codereview.chromium.org/149308. * Move bookmark bar into it's own nib; minor code refactor to accomodate. * The toolbar STAR button somehow lost it's action; added it back in. * Implemented delete bookmark notification callback so we behave (remove button from the screen) when a bookmark is deleted. * Added context menus for the bookmark bar and bookmark buttons. * Hooked up a handful of these menu items. E.g. - open in new tab, window, incog window - delete bookmark (finally) - bookmark manager (which then hits a NOTIMPLEMENTED()) - always show bookmark bar * Truncate bookmark button text on end, not on middle. Experimental to look more like Windows. It looks cleaner but is less Mac-like. * Add "draws border when mouse goes over" for bookmark buttons. Need to do it by hand since we have a custom button drawing method. BUG=crbug.com/8381 TEST=Here's a list: - Make sure the bookmark buttons don't have a border unless the mouse is over them - Toolbar "STAR" should now add bookmarks when clicked - Test context menus on bookmark buttons, and the bar itself - Confirm a few of the behaviors as listed in the 'what I hooked up'; e.g. Right click on bookmark --> delete menu item should delete button Review URL: http://codereview.chromium.org/155358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20591 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 07:08:08 +0000