| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Signed-off-by: Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The /prefetch:# argument that is currently added to the command line of
processes launched with content::StartSandboxedProcess is ignored by
Windows because # doesn't respect the [1, 8] constraint.
This CL ensures that a valid /prefetch:# argument is used for every
process launch (except when the feature is disabled by the PreRead
field trial).
BUG=577698
Review URL: https://codereview.chromium.org/1612663002
Cr-Commit-Position: refs/heads/master@{#373241}
(cherry picked from commit 343068c41c299e65a87d935654f0b81a9935250f)
Conflicts:
chrome/service/DEPS
TBR=gab@chromium.org
Review URL: https://codereview.chromium.org/1727983002 .
Cr-Commit-Position: refs/branch-heads/2623@{#484}
Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is dedicated to implement newly designed sign in related histograms (Signin.SigninStartedAccessPoint, Signin.SigninCompletedAccessPoint, Signin.SigninReason) for Android. Please refer https://docs.google.com/a/google.com/document/d/1-gXYAMXXgsJhk6jxO55RuYJ00JBGermevJZ0sIlk6ko/edit?usp=sharing for details.
BUG=532557
Review URL: https://codereview.chromium.org/1578433002
Cr-Commit-Position: refs/heads/master@{#373577}
(cherry picked from commit 5a9e2b34d01056dfdc1a60ce418f5e9f884c9967)
Review URL: https://codereview.chromium.org/1699633002 .
Cr-Commit-Position: refs/branch-heads/2623@{#392}
Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}
|
|
|
|
|
|
|
|
|
| |
Android."
This reverts commit 596c11f66d536c4230c9e37ff044cffc7a3029a7.
Cr-Commit-Position: refs/branch-heads/2623@{#376}
Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is dedicated to implement newly designed sign in related histograms (Signin.SigninStartedAccessPoint, Signin.SigninCompletedAccessPoint, Signin.SigninReason) for Android. Please refer https://docs.google.com/a/google.com/document/d/1-gXYAMXXgsJhk6jxO55RuYJ00JBGermevJZ0sIlk6ko/edit?usp=sharing for details.
BUG=532557
Review URL: https://codereview.chromium.org/1578433002
Cr-Commit-Position: refs/heads/master@{#373577}
(cherry picked from commit 5a9e2b34d01056dfdc1a60ce418f5e9f884c9967)
Review URL: https://codereview.chromium.org/1693603002 .
Cr-Commit-Position: refs/branch-heads/2623@{#366}
Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
settings
BUG=565566
Review URL: https://codereview.chromium.org/1580233002
Cr-Commit-Position: refs/heads/master@{#370299}
(cherry picked from commit 33ced7a1ea60824e88c132d727dd864b37b0e6e2)
Review URL: https://codereview.chromium.org/1631083002 .
Cr-Commit-Position: refs/branch-heads/2623@{#127}
Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal was to start by removing base/win/metro.{cc|h}, but this
ended up touching a number of places. So, also removed are:
chrome/browser/metro_utils/
chrome/browser/ui/apps/apps_metro_handler_win.{cc|h}
chrome/browser/ui/metro_pin_tab_helper_win.{cc|h}
chrome/browser/ui/views/frame/browser_frame_ashwin.{cc|h}
In order for the CL to not get even larger, there are some added TODOs
pointing at the associated bug where calls to the above were removed,
but the surrounding code is not yet simplified.
BUG=558054
Review URL: https://codereview.chromium.org/1581473002
Cr-Commit-Position: refs/heads/master@{#368971}
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a component, the SecurityStateModel logic can be reused on iOS, so
that we use consistent logic and definitions to describe a page's
overall security status for UI on all platforms.
BUG=515071
Review URL: https://codereview.chromium.org/1539043002
Cr-Commit-Position: refs/heads/master@{#368636}
|
|
|
|
|
|
|
|
|
|
| |
Moved gyp build to third_party/kasko
Also fixed some build issues that came with rebasing to tip of tree.
Review URL: https://codereview.chromium.org/1526213002
Cr-Commit-Position: refs/heads/master@{#368212}
|
|
|
|
|
|
|
|
| |
When adding the GN build to kasko, the location of kasko.dll changed.
Review URL: https://codereview.chromium.org/1568943002
Cr-Commit-Position: refs/heads/master@{#368129}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This resubmits https://codereview.chromium.org/1452603002/ which
was reverted by https://codereview.chromium.org/1539653002/
The previous version of SupervisedUserContentProviderUnitTest was
using Java Thread objects, which seems to confuse Robolectric. I
have now removed this, which slightly reduces the coverage of the
tests (it no longer tests that the threading is correct) but allows
them to run.
TBR=jochen@chromium.org
BUG=570768
Review URL: https://codereview.chromium.org/1552333002
Cr-Commit-Position: refs/heads/master@{#367512}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:220001 of https://codereview.chromium.org/1452603002/ )
Reason for revert:
The new test is failing on CQ
BUG=570768
Original issue's description:
> Supervised user web restrictions content provider
>
> The web restrictions content provider lets other apps query
> web restrictions. In particular it lets apps using WebView
> query Chrome's supervised user web restrictions.
>
> BUG=569879
>
> Committed: https://crrev.com/d501894251559fe547bda9381bdeb98d229f6e7c
> Cr-Commit-Position: refs/heads/master@{#365834}
TBR=jochen@chromium.org,bauerb@chromium.org,knn@chromium.org,aberent@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=569879
Review URL: https://codereview.chromium.org/1539653002
Cr-Commit-Position: refs/heads/master@{#365870}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The web restrictions content provider lets other apps query
web restrictions. In particular it lets apps using WebView
query Chrome's supervised user web restrictions.
BUG=569879
Review URL: https://codereview.chromium.org/1452603002
Cr-Commit-Position: refs/heads/master@{#365834}
|
|
|
|
|
|
|
|
| |
BUG=548645
Review URL: https://codereview.chromium.org/1494213002
Cr-Commit-Position: refs/heads/master@{#363763}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a chrome crash_service target that matches the target arch, and a *_win64 version when compiling 32-bit targets.
Previosly we had a crash_service.exe target that was actually the content_shell one with the wrong name. Various code referred to this target when some meant the chrome one, and some meant the content one. This patch fixes the naming and updates the references to use the correct one.
Fixes cross-compiling of generated buildflag headers. It was computing the output directory incorrectly.
BUG=537009
Review URL: https://codereview.chromium.org/1491363002
Cr-Commit-Position: refs/heads/master@{#362826}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Reland of https://codereview.chromium.org/1475513006/
Reland of https://codereview.chromium.org/1458653002/
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/1469383005
Cr-Commit-Position: refs/heads/master@{#361854}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:20001 of https://codereview.chromium.org/1475513006/ )
Reason for revert:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/69779/steps/compile/logs/stdio
Original issue's description:
> New build flag system, convert Google Now flag
>
> This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
>
> Converts Google Now to use this and remove the global google now define and grit define.
>
> Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
>
> Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
>
> Reland of https://codereview.chromium.org/1458653002/
> TBR=mark@chromium.org
>
> Committed: https://crrev.com/cbc1cd295bc85219ad89326457cd7f5cf003d41c
> Cr-Commit-Position: refs/heads/master@{#361741}
TBR=mark@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1480693003
Cr-Commit-Position: refs/heads/master@{#361749}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Reland of https://codereview.chromium.org/1458653002/
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/1475513006
Cr-Commit-Position: refs/heads/master@{#361741}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:260001 of https://codereview.chromium.org/1458653002/ )
Reason for revert:
This seems to have broken webkit builders: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/94668
Original issue's description:
> New build flag system, convert Google Now flag
>
> This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
>
> Converts Google Now to use this and remove the global google now define and grit define.
>
> Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
>
> Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
>
> Committed: https://crrev.com/3118dde528359280fa0cb3c6fc5b6323e834c514
> Cr-Commit-Position: refs/heads/master@{#361527}
TBR=mark@chromium.org,spang@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1475883002
Cr-Commit-Position: refs/heads/master@{#361541}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Review URL: https://codereview.chromium.org/1458653002
Cr-Commit-Position: refs/heads/master@{#361527}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch Chrome to dlopen() the Google Chrome Framework.framework,
instead of relying on the linker. This is necessary to opt into the
restrict flag, because the restrict flag will not allow relative search
paths to be used for linking libraries.
BUG=523041
Review URL: https://codereview.chromium.org/1412803002
Cr-Commit-Position: refs/heads/master@{#358110}
|
|
|
|
|
|
|
|
| |
BUG=546038
Review URL: https://codereview.chromium.org/1411913005
Cr-Commit-Position: refs/heads/master@{#357774}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Auto-generates the enum values for java autocomplete types. (Gets rid
of java enum overhead as a bonus).
Removes OPEN_HISTORY_PAGE suggestion type which looks like dead
code.
Replaces some switch statements with isUrlSuggestion, which seems to have
identical logic.
BUG=373520
Review URL: https://codereview.chromium.org/1413773006
Cr-Commit-Position: refs/heads/master@{#357515}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts https://codereview.chromium.org/1225393002.
Android Support design library is large and currently is only used in one place
where we already have an existing similar class. This will reduce our method
limit by 1409
BUG=272790
Review URL: https://codereview.chromium.org/1419553003
Cr-Commit-Position: refs/heads/master@{#356982}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename "version.h" to "chrome/common/chrome_version.h"
Update #include and GYP/GN references
Generate on all platforms
Remove redundant generated chrome/common/chrome_version.cc.version
Fix DEPS include_rules
BUG=542807
Committed: https://crrev.com/59647ecac9524d954010d3d10b539ee4a340bf94
Cr-Commit-Position: refs/heads/master@{#355196}
Committed: https://crrev.com/31f086c2013853749cac45522eb950b9d0ab0302
Cr-Commit-Position: refs/heads/master@{#355377}
Review URL: https://codereview.chromium.org/1405633002
Cr-Commit-Position: refs/heads/master@{#355434}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1405633002/ )
Reason for revert:
Causing failures on the GN build (not gyp) for Mac:
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/23191
Original issue's description:
> Cleanup chrome/common/chrome_version.h handling
>
> Rename "version.h" to "chrome/common/chrome_version.h"
> Update #include and GYP/GN references
> Generate on all platforms
> Remove redundant generated chrome/common/chrome_version.cc.version
> Fix DEPS include_rules
>
> BUG=542807
>
> Committed: https://crrev.com/59647ecac9524d954010d3d10b539ee4a340bf94
> Cr-Commit-Position: refs/heads/master@{#355196}
>
> Committed: https://crrev.com/31f086c2013853749cac45522eb950b9d0ab0302
> Cr-Commit-Position: refs/heads/master@{#355377}
TBR=brettw@chromium.org,mdempsky@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=542807
Review URL: https://codereview.chromium.org/1418933002
Cr-Commit-Position: refs/heads/master@{#355393}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename "version.h" to "chrome/common/chrome_version.h"
Update #include and GYP/GN references
Generate on all platforms
Remove redundant generated chrome/common/chrome_version.cc.version
Fix DEPS include_rules
BUG=542807
Committed: https://crrev.com/59647ecac9524d954010d3d10b539ee4a340bf94
Cr-Commit-Position: refs/heads/master@{#355196}
Review URL: https://codereview.chromium.org/1405633002
Cr-Commit-Position: refs/heads/master@{#355377}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1405633002/ )
Reason for revert:
Appears to be breaking at least Mac GN build
Example failure: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/23114
Original issue's description:
> Cleanup chrome/common/chrome_version.h handling
>
> Rename "version.h" to "chrome/common/chrome_version.h"
> Update #include and GYP/GN references
> Generate on all platforms
> Remove redundant generated chrome/common/chrome_version.cc.version
> Fix DEPS include_rules
>
> BUG=542807
>
> Committed: https://crrev.com/59647ecac9524d954010d3d10b539ee4a340bf94
> Cr-Commit-Position: refs/heads/master@{#355196}
TBR=brettw@chromium.org,mdempsky@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=542807
Review URL: https://codereview.chromium.org/1411173003
Cr-Commit-Position: refs/heads/master@{#355231}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename "version.h" to "chrome/common/chrome_version.h"
Update #include and GYP/GN references
Generate on all platforms
Remove redundant generated chrome/common/chrome_version.cc.version
Fix DEPS include_rules
BUG=542807
Review URL: https://codereview.chromium.org/1405633002
Cr-Commit-Position: refs/heads/master@{#355196}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1376913005
Cr-Commit-Position: refs/heads/master@{#352747}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds two new histograms (with suffixes):
NewTabPage.TileType.<source> - Records the type of each most visited
tile that's shown on the NTP. Valid values are IconReal, IconColor,
IconDefault, ThumbnailLocal, ThumbnailServer, ThumbnailDefault.
NewTabPage.TileTypeClicked.<source> - Records the type of each most
visited tile that the user clicks on. Same values as above.
In both cases <source> can be one of "client", "server8", "popular", or
another value indicating the source of the most visited suggestions.
This CL also refactors a fair amount to support this change:
- There's a new C++/Java shared enum called MostVisitedTileType, with
the same values as the new histograms.
- Each MostVisitedItem in Java stores its tile type.
- NewTabPage.IconsGray and related histograms are now recorded in
most_visited_sites.cc alongside NewTabPage.NumberOfGrayTiles, since
these histograms are equivalent (one is for the icon NTP; one for the
thumbnail NTP)
BUG=536294
Review URL: https://codereview.chromium.org/1373983003
Cr-Commit-Position: refs/heads/master@{#351869}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL enables chrome on Android to show GIF-powered doogle in NTP. To
accomplish this goal, this CL:
1. Ports GifPlayer library from googlesource to chromium third_party
folder.
2. Creates AnimatedLogoTracker to download the gif url specified by the
parsed logo.
3. Copies the downloaded gif as byte array to java side, and in NTP,
GifPlayer is used to decode the raw byte array and draw it as an Android
drawable.
BUG=414528
Review URL: https://codereview.chromium.org/1343913002
Cr-Commit-Position: refs/heads/master@{#350907}
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is no longer clear if we will be adding more helper variants in the
near future. This change removes any additional dead code related to the
helper apps.
BUG=520680
Review URL: https://codereview.chromium.org/1354703002
Cr-Commit-Position: refs/heads/master@{#349970}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of https://codereview.chromium.org/1314843007/
Compared to the original commit, this reland caches the relevant parts
of the visible navigation entry in the SecurityStateModel, so that the
model doesn't have to be notified on navigation changes. This fixes bugs
in the original commit caused by not notifying the model properly on
navigation state changes. I've removed now-unnecessary changes in
WebContentsDelegates, and added additional SecurityStateModel tests.
BUG=528034,529872,529664
TBR=avi@chromium.org,sky@chromium.org,tedchoc@chromium.org,dzhioev@chromium.org
Review URL: https://codereview.chromium.org/1310833006
Cr-Commit-Position: refs/heads/master@{#349181}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Running gyp in chromium with configuration_policy set to 0 fails as
multiple targets that are behind condition of configuration_policy==1
are referenced without corresponding conditionals
BUG=530579
Review URL: https://codereview.chromium.org/1334253002
Cr-Commit-Position: refs/heads/master@{#348903}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:360001 of https://codereview.chromium.org/1314843007/ )
Reason for revert:
We need to call SecurityStateChanged() in a few more places to avoid a crash and some UI bugs. See bugs 529664 and 529872.
Original issue's description:
> Refactor connection_security into SecurityStateModel
>
> This CL refactors the connection_security namespace (a namespace of
> statics) into SecurityStateModel, a class attached to a WebContents that
> drives the security UI for that WebContents. The SecurityStateModel
> provides high-level security information about a page or request, with
> the goal of reducing code duplication across various security UI
> elements.
>
> In this first CL, I've introduced the SecurityStateModel and am using it
> to drive the omnibox/lock icon, but have not yet adapted WebsiteSettings
> to use a SecurityStateModel.
>
> BUG=528034
> TBR=sky@chromium.org
>
> Committed: https://crrev.com/83a81afbef8f265815cb6c6a48690511825a1ce5
> Cr-Commit-Position: refs/heads/master@{#347775}
TBR=palmer@chromium.org,lgarron@chromium.org,pkasting@chromium.org,tedchoc@chromium.org,avi@chromium.org,sky@chromium.org,dzhioev@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=528034
Review URL: https://codereview.chromium.org/1324293003
Cr-Commit-Position: refs/heads/master@{#347980}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL refactors the connection_security namespace (a namespace of
statics) into SecurityStateModel, a class attached to a WebContents that
drives the security UI for that WebContents. The SecurityStateModel
provides high-level security information about a page or request, with
the goal of reducing code duplication across various security UI
elements.
In this first CL, I've introduced the SecurityStateModel and am using it
to drive the omnibox/lock icon, but have not yet adapted WebsiteSettings
to use a SecurityStateModel.
BUG=528034
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/1314843007
Cr-Commit-Position: refs/heads/master@{#347775}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This deletes the no-longer-used ChromeShell. Its raison d'être has been
supplanted by ChromePublic (the chrome_public_apk build target).
Goodbye, ChromeShell!
BUG=510220
Review URL: https://codereview.chromium.org/1314413004
Cr-Commit-Position: refs/heads/master@{#347454}
|
|
|
|
|
|
|
|
|
|
| |
This brings it in sync with GYP.
BUG=521048
Review URL: https://codereview.chromium.org/1319043002
Cr-Commit-Position: refs/heads/master@{#345980}
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/1306573003
Cr-Commit-Position: refs/heads/master@{#345358}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only RenderViewContextMenu uses it and the function is tiny and self
contained, no reason to have a separate file just for it.
BUG=None
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1297553002
Cr-Commit-Position: refs/heads/master@{#343939}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The chrome_java target includes several resources that are specific to a
Chromium-branded build (e.g. the Chromium icon and app name). It's now
possible to set a value for the GYP/GN variable
android_branding_res_dirs to override the directory in which these
branding resources live. This enables easy swapping of the resources
when building, e.g., a Google Chrome-branded build.
R=yfriedman@chromium.org
TBR=thestig@chromium.org
BUG=520794,474747
Review URL: https://codereview.chromium.org/1301613002 .
Cr-Commit-Position: refs/heads/master@{#343746}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
1) Added the logic in EnhancedBookmarksModel to wait for OfflinePagesBridge being loaded if it is enabled
2) Supported adding a new offline page. To do this, a new asynchronous method addBookmarkAsync is added to EnhancedBookmarksModel.
3) Supported launching an offline page. getBookmarkLaunchUrl, that returns the launch url, is added to EnhancedBookmarksModel.
BUG=491352
TEST=tests added and updated
Review URL: https://codereview.chromium.org/1285313003
Cr-Commit-Position: refs/heads/master@{#343531}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://crrev.com/1247853007 for where the new ModelType was added.
- ModelType is now just represented by an integer.
- ModelType is now located in org.chromium.sync.
- Many of the constants were singular and are now plural to match
the ones in model_type.h.
- ModelTypeSet is removed and a jintArray is used for JNI.
BUG=509788
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1262413006
Cr-Commit-Position: refs/heads/master@{#343051}
|
|
|
|
|
|
|
|
|
|
|
| |
CRD app now bundles PNaCl version of the plugin so it doesn't need to
be built in chrome anymore.
BUG=510271
Review URL: https://codereview.chromium.org/1271523003
Cr-Commit-Position: refs/heads/master@{#341804}
|
|
|
|
|
|
|
|
|
|
|
|
| |
AccountManager.
Based on http://crrev.com/1224643007
BUG=508054
Review URL: https://codereview.chromium.org/1231653007
Cr-Commit-Position: refs/heads/master@{#340774}
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Moves cloud print IPC message handling from ServiceIPCServer to CloudPrintMessageHandler
* Removes the last 4 uses of g_service_process from ServiceIPCServer.
* Add unit test for ServiceIPCServer
BUG=402456
Review URL: https://codereview.chromium.org/1249513003
Cr-Commit-Position: refs/heads/master@{#340664}
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds UMA for when Bookmark Navigator and Bookmark Shortcut widgets get added.
- Adds new EXTRA_SOURCE types for Bookmark Navigator and Bookmark Shortcut
widgets.
BUG=447706
Review URL: https://codereview.chromium.org/1241823002
Cr-Commit-Position: refs/heads/master@{#339147}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want several new widgets from the design library:
1. TextInputLayout
2. NavigationView
3. AppBarLayout
This CL adds the gyp target to chrome_java and roll DEPS for the
third_party folder.
BUG=498585
Review URL: https://codereview.chromium.org/1225393002
Cr-Commit-Position: refs/heads/master@{#339073}
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Android, the JSON sanitizer parses the untrusted JSON in Java and checks it for wellformedness before serializing it again. On desktop platforms it uses SafeJsonParser to parse the JSON out of process, then serializes it again.
Also, on Android (where JsonSanitizer is not implemented in terms of the SafeJsonParser) the SafeJsonParser now uses the JsonSanitizer to sanitize its input before parsing it directly in process, instead of starting a new process, which is very costly on Android.
BUG=501333
Review URL: https://codereview.chromium.org/1203083002
Cr-Commit-Position: refs/heads/master@{#338495}
|