| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These classes were simple wrappers that didn't actually do a whole lot.
They added an unnecessary layer of indirection and required us to write
several lines of boilerplate every time we wanted to access the
directory.
The DirectoryManager did manage some locks, but it is believe that these
are no longer necessary. The directory management functions (ie. open,
close, save changes, etc.) are only invoked from the syncer thread and
all other operations require a transaction. Directory operations should
be safe even without these locks.
The DirectoryManager was responsible for taking the input directory path
argument, appending a constant filename, and passing the result on to
the Directory. The constant value has been moved to a static member of
syncable::Directory and it is now the responsibility of the caller of
Directory::Open() to assemble the full file path.
Deleting the DirectoryManager left the Cryptographer without a home. It
was moved into the syncable::Directory for now. This allows us to
perform more thorough runtime verification of the locking assertions
around this class.
These changes had some reprecussions for the unit test base classes.
The TestDirectorySetterUpper underwent significant modifications.
Hopefully these will make it easier to read and reduce duplication of
test boilerplate code.
This change also wound up affecting the SyncerCommandTest class. The
template-based conditional instantiation of a Directory or a
MockDirectory was making it hard to use the TestDirectorySetterUpper, so
the class hierarchy was refactored to allow for greater code reuse.
BUG=115560
TEST=
Review URL: http://codereview.chromium.org/9442031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fill out all HTTP status codes from RFC 2616.
Clean up sync deps.
BUG=113723
TEST=
Review URL: https://chromiumcodereview.appspot.com/9447046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove --enable-sync-oauth switch.
Clean up some headers.
BUG=113723
TEST=
Review URL: http://codereview.chromium.org/9455005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SYNC_DATATYPE_HISTOGRAM can now be used with any arbitrary histogram to
have a unique name based on the datatype. This is the start of cleaning
up the boilerplate histogram code in the datatype controllers.
BUG=114031
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/9388025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Conflict sets were intended to help us deal with updates that could
corrupt the directory tree if applied. This could happen, for example,
when the server sends us a new item in a directory that has been deleted
locally.
Due to a bug, the code to deal with conflict sets was never run. It
seems that the consequences of this weren't as bad as one would expect.
By this point, it's not worth fixing, since we are a few weeks away from
adding code to handle conflict sets entirely on the server side.
Over a series of commits, we have removed lots of dead code related to
conflict set handling. The only remaining function of conflict sets
code was to prevent items that were in both a "conflict set" and a
"simple conflict" state from being processed as simple conflicts. If
those items had been processed as simple conflicts, there is a small
chance we could accidentally apply them, or do other bad things.
The code that detects conflict sets is overkill for our current needs,
because it was built with the idea that we had to gather information
about these conflict sets in order to resolve them. Now that this
requirement has been removed, I have been able to greatly simplify the
implementation of conflict set detection by moving it to the update
application code. Since this was the last remaining purpose of the
conflict set processing code, it is now safe to entirely remove the
concept of conflict sets.
Other changes:
- Removed ConflictProgress::EraseNonBlockingConflictingItemById(); the
function was never used.
- Added some unit tests for the new functionality.
BUG=107816
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/9305001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for the components build.
BUG=90078
TEST=none
Review URL: http://codereview.chromium.org/9426021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce new ReportUnrecoverableErrorFunction type.
Move the breakpad-uploading code into ChromeReportUnrecoverableError.
Plumb that function pointer all the way down to the Directory.
BUG=113723
TEST=
Review URL: http://codereview.chromium.org/9415023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: http://codereview.chromium.org/9395024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By removing pull_in_all, this removes many circular dependencies in the generated project files. Unfortunately, this also removes many unit tests from being available in chrome/chrome.sln.
Developers are encouraged to modify build/some.gyp to their local workflow, which will ensure circular dependencies are not accidentally introduced. Alternatively, chrome/chrome_all.gyp is provided to offer equivalent functionality to the current chrome/chrome.sln, at the cost of the same performance penalty.
This reduces the number of dependent projects loaded by chrome.sln from 768 to 650, which improves overall .sln load times.
BUG=94622
Review URL: http://codereview.chromium.org/9369047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add code to locate the Chrome bundle + unit tests.
* Refactor app_mode_app to use the new code, also now we can use stuff from base, remove hacks from the code.
BUG=None
TEST=Unit tests should pass.
Review URL: http://codereview.chromium.org/9351014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notifier framework for sessions use.
The ChromeSyncNotificationBridge listens to notifications from chrome events that should
trigger a sync notification. It is a thread-safe class that will post the
notifications to the thread the SyncNotifierObserver is on, thereby allowing,
for example, events on the UI thread to trigger notifications on the Sync
thread. At the moment the only such event is NOTIFICATION_SYNC_REFRESH, which
is only triggered by the sessions datatype.
TBR=zea
BUG=103469
TEST=manually going to chrome://newtab#opentabs and ensuring a sync cycle
occurs.
Review URL: http://codereview.chromium.org/9079002
Review URL: https://chromiumcodereview.appspot.com/9310046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeSyncNotificationBridge class to sync notifier framework for sessions use.
The ChromeSyncNotificationBridge listens to notifications from chrome events that should
trigger a sync notification. It is a thread-safe class that will post the
notifications to the thread the SyncNotifierObserver is on, thereby allowing,
for example, events on the UI thread to trigger notifications on the Sync
thread. At the moment the only such event is NOTIFICATION_SYNC_REFRESH, which
is only triggered by the sessions datatype.
BUG=103469
TEST=manually going to chrome://newtab#opentabs and ensuring a sync cycle
occurs.
Review URL: http://codereview.chromium.org/9079002
TBR=zea@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9316054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sessions use.
The ChromeSyncNotificationBridge listens to notifications from chrome events that should
trigger a sync notification. It is a thread-safe class that will post the
notifications to the thread the SyncNotifierObserver is on, thereby allowing,
for example, events on the UI thread to trigger notifications on the Sync
thread. At the moment the only such event is NOTIFICATION_SYNC_REFRESH, which
is only triggered by the sessions datatype.
BUG=103469
TEST=manually going to chrome://newtab#opentabs and ensuring a sync cycle
occurs.
Review URL: http://codereview.chromium.org/9079002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dependencies.
During gclient runhooks, update LASTCHANGE so that it will be updated at least as often as runhooks is run (i.e. for every sync).
LASTCHANGE moved to build/util rather than SHARED_INTERMEDIATE_DIR because that directory isn't known to runhooks.
BUG=111731
Review URL: https://chromiumcodereview.appspot.com/9169105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Refactor app mode app into a static library + executable target.
* Add a test target + main test runner file (no tests for now).
* Make app mode app depend on base so we can use logging and DCHECKs, etc.
In the interests of keeping this CL small, no tests are added and app_mode_loader_mac.mm isn't changed to use base/ functionality.
TEST=NONE
BUG=NONE
Review URL: http://codereview.chromium.org/9274003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=77634
R=tfarina@chromium.org
Review URL: http://codereview.chromium.org/9186042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=62079
TEST=none
Review URL: http://codereview.chromium.org/9211007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=62079
TEST=compiles
Review URL: http://codereview.chromium.org/9113011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part 1 of 3 in a series of patches to remove the unnecessary
SYNC_CYCLE_CONTINUATION sync cycle that follows every sync commit.
In this patch, we add a return value to all SyncerCommands. This will
make it easier for us to tell when a command has failed, and why.
Currently, the error detection does not work very well. We don't have
much support for errors that occur on worker threads. Many commands will
return an error only in case of directory lookup failure, but return
NO_ERROR otherwise.
This is OK because we're not aiming to fully implement error detection
in this commit. This provides a base we can build on in future commits.
BUG=94670,109422
TEST=
Review URL: http://codereview.chromium.org/9113024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This affects some stats displayed in about:sync.
Due to a logic error, syncing was defined as 'unsynced_handles > 0 &&
!throttled'. This seems sort of reasonable, until you notice that the
unsynced_handles value is zero at the beginning of the sync cycle and is
not updated for successful commits that occur during the sync cycle.
And that's just the tip of the iceberg.
This change makes it so that 'syncing' is an edge-triggered value. When
a sync cycle starts or ends, it will send a SYNC_CYCLE_BEGIN or
SYNC_CYCLE_END event to AllStatus, which will update the flag
accordingly.
This results in a different definition of 'syncing' than the previous
system. Whereas the old system tried to infer what the SyncScheduler
was doing and remain in the syncing state until it had fully completed
its job, this one will report the 'syncing' state only if a call to
SyncShare() is currently in progress. One of the implications of this
is that it will now toggle in and out of the syncing state when
committing more than 25 items, because the loop to commit all unsynced
items in batches of 25 currently occurs outside SyncShare. The new
system will also bounce in an out of the syncing state as we handle the
SYNC_CYCLE_CONTINUATION cycle that follows every cycle that commits an
item.
How does this look in about:sync? The biggest change is that it will
now be almost impossible to see the status summary of "SYNCING". This
is because the ProfileSyncService does not receive notification of the
beginning of a sync cycle, only the end. So it doesn't bother to update
the state of about:sync until the syncing is already completed. Prior
to this change, about:sync did show the "SYNCING" summary sometimes, but
this was only during the *second* sync cycle, which we enter only because
of the SYNC_CYCLE_CONTINUATION bug (issue 94670).
Also in this commit are changes to remove the infrastructure used to
set the 'syncing' variable in the SyncSessionSnapshot. This had the
side-effect of removing the mechanism by which we're guaranteed to kick
AllStatus with a STATUS_CHANGED event, so I replaced it with a
SYNC_CYCLE_BEGIN event sent from the SYNCER_BEGIN step. I also removed
SyncerEndCommand, because the mechanims used to send the
SYNC_CYCLE_BEGIN event could be used to send the SYNC_CYCLE_ENDED
event, too.
BUG=98346
TEST=
Review URL: http://codereview.chromium.org/8873058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/renderer/nacl_desc_wrapper_chrome.cc (indirectly via
native_client/src/include/nacl_base.h) depends on NACL_BUILD_ARCH being
defined. Before http://codereview.chromium.org/8973002 (native_client
r7458) the code failed to notice the missing definition and defaulted
to x86 by happenstance. Now the (Linux) compile fails unless all the
right macros are defined.
Define them for the chrome compilation so we won't have this problem next
time nacl_revision gets updated. It also makes the affected native_client
code actually use the right code in a non-x86 (i.e. ARM) build.
BUG= none
TEST= fixes Linux build of chrome with native_client tip of tree
R=mseaborn@chromium.org
Review URL: http://codereview.chromium.org/8964022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8931018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is intended to make it easier to test Breakpad crash dumping on
the buildbots. Crash dumping will be disabled in Chromium by default
at run time unless CHROME_HEADLESS is set.
The bots set CHROME_HEADLESS, but we don't really want the bots to be
uploading crash dumps that are useless without symbols, so uploading
is disabled except for official builds and when building with
mac_breakpad_uploads=1.
This should not affect stack backtraces that occur in tests (such as
browser_tests) via StackDumpSignalHandler(). Although Breakpad would
normally take priority over this signal handler, Breakpad does not get
enabled in these test suites because is_browser is false inside
InitCrashReporter().
This change leaves the Gyp option "mac_breakpad" for enabling the
creation of Breakpad files. This remains off by default for Chromium
builds, because the symbol dumping is slow and because it has problems
in the makefile-based Mac builds.
BUG=105778
TEST=run Chromium with --crash-test and CHROME_HEADLESS=1; a *.dmp file
should appear in ~/Library/Application Support/Chromium/Crash Reports
Review URL: http://codereview.chromium.org/8824003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first patch to get remove CHECK stmts from syncable layer.
BUG=100444
TEST=
Review URL: http://codereview.chromium.org/8804026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will eventually replace ModelType{Bit,}Set.
BUG=79970
TEST=
Review URL: http://codereview.chromium.org/8772073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
it through composition. This cleans up the code and makes it easier to understand (as well as more closely conform to the Google C++ style guide). It also makes it possible to add an interface around ChildProcessHost in a future change.
BUG=98716
Review URL: http://codereview.chromium.org/8774040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Moved task to get the session name and its dependencies from chrome/browser/sync/glue/session_model_associator to chrome/browser/sync/util/get_session_name_task
BUG=103970
TEST=SessionModelAssociatorTest.*,GetSessionNameTaskTest.*
Review URL: http://codereview.chromium.org/8698004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105076
TEST=
Review URL: http://codereview.chromium.org/8636020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DevTools remote debugging protocol supersedes the legacy protocol and old implementation should be removed.
BUG=104625
TEST=Existing tests
Review URL: http://codereview.chromium.org/8635005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=robertshield@chromium.org,rogerm@chromium.org
Review URL: http://codereview.chromium.org/8685001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove dependencies from automation on testing libraries that pull in gtest / gmock directly or indirectly. Do this by pulling ASSERTs out of chrome code and putting them into test code instead. Also delete some unused code.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8584013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make PassiveModelWorker class.
Make FakeModelWorker class and make tests use it. Also make some tests
use realistic groups instead of shunting everything to GROUP_PASSIVE.
Rename MockModelSafeWorkerRegistrar to FakeModelSafeWorkerRegistrar.
This will make it easier to test an upcoming change that makes
ModelChangingSyncerCommand post on only the threads it needs to.
BUG=97832
TEST=
Review URL: http://codereview.chromium.org/8625005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turn on -Wexit-time-destructors for (most of) the chrome target.
BUG=101600,94925
TEST=none
TBR=stevenjb
Review URL: http://codereview.chromium.org/8547005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also get rid of flushed_metahandles since it serves exactly zero purpose :)
BUG=87122
TEST=none
Review URL: http://codereview.chromium.org/8565035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8372084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107967
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108466
Review URL: http://codereview.chromium.org/8425002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resource generation
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107967
Review URL: http://codereview.chromium.org/8425002
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8448001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107967
Review URL: http://codereview.chromium.org/8425002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resource generation
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Review URL: http://codereview.chromium.org/8425002
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8430011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Review URL: http://codereview.chromium.org/8425002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
print proxy issues.Split proxy code from cloud_print_proxy_backend to a separate pieces: - auth code goes to cloud_print_auth.h/cc - connector logic goes to cloud_print_connector.h/cc (printer enumeration, registration and deletion) - wiring backend/frontend threads, notifications with other parts will stay in cloud_print_backend.h/ccMade proxy logic more straightforward.
Review URL: http://codereview.chromium.org/8387011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unrecoverable error info class which is plumbed up all ModelSafeWorker subclasses.
The subclasses of ModelChangingSyncer command would be converted to return an unrecoverable error info in another CL.
BUG=100374
TEST=
Review URL: http://codereview.chromium.org/8366030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
class called DebugInfoEventListener which implements 2 interfaces. one being the syncmanager::observer to observe events from syncmanager.
The other being DebugInfoGetter so that syncer can call this class to give the debug information in protobuf format.
The implementation of this class uses a queue. And it limits the number of events to 6. if more than 6 events are in the queue we delete the oldest event.
Also we send this information to the server only once per sync cycle during the first getudpdates command.
also includes the unit test.
TBR=cmp@chromium.org for the SI relaxation.
BUG=100058
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105667
Review URL: http://codereview.chromium.org/8189003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We create a class called DebugInfoEventListener which implements 2 interfaces. one being the syncmanager::observer to observe events from syncmanager.
The other being DebugInfoGetter so that syncer can call this class to give the debug information in protobuf format.
The implementation of this class uses a queue. And it limits the number of events to 6. if more than 6 events are in the queue we delete the oldest event.
Also we send this information to the server only once per sync cycle during the first getudpdates command.
also includes the unit test.
BUG=100058
TEST=
Review URL: http://codereview.chromium.org/8189003
TBR=lipalani@chromium.org
Review URL: http://codereview.chromium.org/8313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
class called DebugInfoEventListener which implements 2 interfaces. one being the syncmanager::observer to observe events from syncmanager.
The other being DebugInfoGetter so that syncer can call this class to give the debug information in protobuf format.
The implementation of this class uses a queue. And it limits the number of events to 6. if more than 6 events are in the queue we delete the oldest event.
Also we send this information to the server only once per sync cycle during the first getudpdates command.
also includes the unit test.
BUG=100058
TEST=
Review URL: http://codereview.chromium.org/8189003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The plugin_carbon_interpose_mac.cc which intercepts system API's in plugin processes on the Mac has been moved to
content\plugin. The plugin_carbon_interpose shared library target which lives in chrome.gyp refers to this file.
This is a short term workaround while we look into switching the interposing mechanism on the mac.
Changes as part of creating a Content API
BUG=98716
Review URL: http://codereview.chromium.org/8224021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Define InvalidationVersionTracker interface and make SyncPrefs
inherit from it.
Pass down SyncPrefs (as InvalidationVersionTracker) all the way
down to ChromeInvalidationClient and call it when there is a new
max invalidation version.
Pass SyncBackendHost a WeakPtr instead of a raw pointer to SyncPrefs.
Made sync_listen_notifications work again.
BUG=85286
TEST=
Review URL: http://codereview.chromium.org/8188006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
utility process like the rest of our tasks that we want to run outside the browser. When that code was first written, we didn't have the utility process.
Review URL: http://codereview.chromium.org/8108001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
anything from content.
I also moved ChromeContentPluginClient to chrome\plugin where it really belongs (i.e. to match what we do with the utility client).
Review URL: http://codereview.chromium.org/8095011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the build/installer output.
This change undoes the revert of 99878. This change was originally reverted
because it was decided to push this change to M16.
BUG=94920
TEST=Do an Official build in mac, linux and win. Ensure that after installing
the app, you can find the default apps under the install's directory
structure. For win, this is under a default_apps directory, for mac, this is
under a "Default Apps" directory.
Review URL: http://codereview.chromium.org/8041033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103078 0039d316-1c4b-4281-b951-d872f2087c98
|