| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
files as opposed to being statically linked to the binary.
This is not currently supported on any architecture.
BUG=421063
Review URL: https://codereview.chromium.org/594603003
Cr-Commit-Position: refs/heads/master@{#301595}
|
|
|
|
|
|
|
|
|
|
|
| |
wow_helper.exe is needed by the sandbox.
BUG=414808
TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/667513002
Cr-Commit-Position: refs/heads/master@{#300185}
|
|
|
|
|
|
|
|
| |
BUG=421288
Review URL: https://codereview.chromium.org/639503005
Cr-Commit-Position: refs/heads/master@{#298954}
|
|
|
|
|
|
|
|
|
|
|
| |
We need nacl_irt_x86_32.nexe
BUG=414808
TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/637433002
Cr-Commit-Position: refs/heads/master@{#298318}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Merges the lists when relevant. This simplify the management significantly.
Remove the .isolate from the '*_run' target 'includes' section.
TBR=vadimsh@chromium.org
BUG=swarming:148
Review URL: https://codereview.chromium.org/614923005
Cr-Commit-Position: refs/heads/master@{#297633}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed recently with the change to query the device scale factor to see if it needs to be scaled back to 1.0 for
display scales equal to or under 125%. user32/gdi32 API's crash or fail with the Win32K lockdown process mitigation.
Fix is to ensure that the device scale factor is queried from the one set via the command line. The other change is to move
the code in ContentMainRunner::Initialize which sets the global device scale factor for the process to before the content client
initialization. This is because the ShellContentRendererClient in its ctor calls the ShouldUseDirectWrite function which relies on
the GetDPIScale function to decide whether or not directwrite should be enabled. This causes a DCHECK in content_browsertests.
To ensure that the win32k lockdown does not regress I added a simple content browsertest RendererWin32KLockdownNavigationTest which runs
this on Windows 8+.
The accessibility fixes are to get the browser tests to run
on Windows 8. There were special cases to always enable
accessibility on Windows 8 for historical reasons. These are
no longer necessary as we don't rely on accessibility to display the virtual keyboard.
BUG=417147
Review URL: https://codereview.chromium.org/600263002
Cr-Commit-Position: refs/heads/master@{#296859}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
don't have it.
This is breaking after r295514 which enforces that every file listed in an isolate file exists.
BUG=414808
R=erg@chromium.org
Review URL: https://codereview.chromium.org/584553006
Cr-Commit-Position: refs/heads/master@{#295548}
|
|
|
|
|
|
|
|
|
|
| |
This might have been useful before while trying to get the system running. But now we have swarming running on Linux/Mac/Windows trybots, so it's not so useful. It's also confusing when tests fail on swarming machines because an isolate file referred to a binary that wasn't in the dependencies.
BUG=414808
Review URL: https://codereview.chromium.org/575363002
Cr-Commit-Position: refs/heads/master@{#295514}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change links the trusted plugin into the renderer, making it easier for
the trusted plugin to use libraries in Chromium. This removes the
ppGoogleNaClPlugin loadable module file on various platforms.
This is part of a larger effort to remove the "trusted plugin" used to
bootstrap NaCl plugins.
It introduces an "internal_module" interface for setting the value returned by
pp::Module::Get(). This is so that both the trusted plugin and the remoting
plugin can be linked into the renderer. However, I believe this is safe because
the trusted plugin runs in-process and the remoting plugin runs out-of-process.
BUG=394497
R=dmichael@chromium.org, mseaborn@chromium.org, phajdan.jr@chromium.org, thestig@chromium.org, wez@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287071
Review URL: https://codereview.chromium.org/397243004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The reverted change broke the ChromeOS builder, which depends on the loadable
module file existing. Argh.
This reverts commit b0b91c06bc2ed6afc0611f00d68f72b19dd06d26.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change links the trusted plugin into the renderer, making it easier for
the trusted plugin to use libraries in Chromium. This removes the
ppGoogleNaClPlugin loadable module file on various platforms.
This is part of a larger effort to remove the "trusted plugin" used to
bootstrap NaCl plugins.
It introduces an "internal_module" interface for setting the value returned by
pp::Module::Get(). This is so that both the trusted plugin and the remoting
plugin can be linked into the renderer. However, I believe this is safe because
the trusted plugin runs in-process and the remoting plugin runs out-of-process.
BUG=394497
R=dmichael@chromium.org, mseaborn@chromium.org, phajdan.jr@chromium.org, thestig@chromium.org, wez@chromium.org
Review URL: https://codereview.chromium.org/397243004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Deduplicate chrome.isolate items found in angle.isolate. Move comment about
D3DCompiler_43.dll to 32bits build. If it is going to be mapped, it is only for
32 bits builds and not 64 bits builds since this DLL doesn't seem to exist in 64
bits.
R=scheib@chromium.org,kbr@chromium.org
BUG=
Review URL: https://codereview.chromium.org/379843004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=scheib@chromium.org
BUG=
Review URL: https://codereview.chromium.org/340313005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to get this dll from third_party/directxsdk but that's not
longer true. For some reason, this started to break bots recently.
BUG=none
TBR=maruel@chromium.org,kbr@chromium.org
Review URL: https://codereview.chromium.org/311063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Tested on Windows, Mac and Linux with the GPU bots' recipe.
BUG=378021
R=maruel@chromium.org,vadimsh@chromium.org,csharp@chromium.org
Review URL: https://codereview.chromium.org/303473007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch:
https://codereview.chromium.org/191583002
This takes the original patch and changes libexif from a load-time 'shared_library' to a runtime-loaded 'loadable_module'. This is based on rsesek's reasoning that it would reduce overall performance impact as well as not require a sandbox hole for Mac 10.6.
TBR=
BUG=318450
Review URL: https://codereview.chromium.org/226643007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/216443005/)
Reason for revert:
Breaking Mac 10.6 release testers. (no idea why, but it is)
Original issue's description:
> Reapply "Media Galleries API Metadata: Image metadata"
>
> Original patch (also PS1) https://codereview.chromium.org/191583002
>
> CQ can't catch the breakages of this patch.
>
> TBR=
> BUG=318450
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261864
TBR=ccameron@chromium.org,thestig@chromium.org,grt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=318450
Review URL: https://codereview.chromium.org/225023014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch (also PS1) https://codereview.chromium.org/191583002
CQ can't catch the breakages of this patch.
TBR=
BUG=318450
Review URL: https://codereview.chromium.org/216443005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Media Galleries API Metadata: Image metadata
>
> Enables libexif and uses it to parse some image tags into the GetMetadata call.
>
> BUG=318450
>
> Review URL: https://codereview.chromium.org/191583002
TBR=tommycli@chromium.org
Review URL: https://codereview.chromium.org/217233005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Enables libexif and uses it to parse some image tags into the GetMetadata call.
BUG=318450
Review URL: https://codereview.chromium.org/191583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We've figured out a way to make things work without a shared library, so libmojo_system is no more.
BUG=none
TEST=none
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/215153007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sky is about to check something in that will interact poorly with this
and it'll be easier to apply the necessary changes after that.
> Fixup mojo dylibs to support mojo in content
>
> Second try after revert of
> https://codereview.chromium.org/211503005/
>
> The isolates failed because libmojo_system.dylib wasn't getting copied.
>
> BUG=
> TBR=mark@chromium.org
>
> Review URL: https://codereview.chromium.org/217003003
TBR=davemoore@chromium.org
Review URL: https://codereview.chromium.org/216793008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Second try after revert of
https://codereview.chromium.org/211503005/
The isolates failed because libmojo_system.dylib wasn't getting copied.
BUG=
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/217003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=353602
TEST=none
R=csharp@chromium.org, mmoss@google.com, thestig@chromium.org, mmoss@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258062
Review URL: https://codereview.chromium.org/203963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=353602
TEST=none
R=bradnelson@chromium.org, csharp@chromium.org, grt@chromium.org
Review URL: https://codereview.chromium.org/204023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Turns on use_mojo=1 for linux.
>
> BUG=353602
> TEST=none
> R=csharp@chromium.org, mmoss@google.com, thestig@chromium.org, mmoss@chromium.org
>
> Review URL: https://codereview.chromium.org/203963003
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/200033005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=353602
TEST=none
R=csharp@chromium.org, mmoss@google.com, thestig@chromium.org, mmoss@chromium.org
Review URL: https://codereview.chromium.org/203963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) To match the gyp dependencies, move clearkeycdmadapter binaries, plugins/,
lib32/ and lib64/ from chrome.isolate to browser_tests.isolate.
2) On Windows, include <(version_full).manifest in chrome.isolate to be able
to execute chrome.exe. Add needed chrome_child.dll and chrome_elf.dll.
3) Add libEGL.dll and libGLESv2.dll dependencies to gpu.gyp:gl_tests and a
new angle.isolate; refer to it from gl_tests.isolate and
gles2_conform_test.isolate.
4) Copy run_gpu_test to run_gpu_test.py, and invoke that instead in
telemetry_gpu_test.isolate, to make this isolate work on Windows.
BUG=321878,334539
Review URL: https://codereview.chromium.org/140263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
icu.isolate file added in https://codereview.chromium.org/99073008/
is used where icudt.dll is directly listed for
'isolate_dependency_tracked'.
icu.isolate includes either icudtl.dat or icudt.dll depending on
'OS' and 'icu_use_data_file_flag'.
Besides, 'icu_use_data_file_flag' is added to build/isolate.gypi as a
config-variable.
Once the above icu-side CL is checked in, this CL will also includes
icu DEPS roll.
This is a prerequisite for the following CLs to use icudtl.dat :
Windows : https://codereview.chromium.org/99473012
Linux : https://codereview.chromium.org/102413007
Mac : https://codereview.chromium.org/109013004
BUG=72633
TEST=All tests utilizing isolate pass on bots.
Review URL: https://codereview.chromium.org/124143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Complete chrome.isolate to work on all platforms by extracting relevant data
from browser_tests.isolate. Then make browser_tests.isolate 'includes'
chrome.isolate and remove the duplicate entries.
The story for bundling lib32 and lib64 NaCl libraries will have to cleared up
since it depends on the OS running the test and on the build itself.
Note: interactive_ui_tests.isolate doesn't actually start the chrome executable
so it is not bundled.
R=csharp@chromium.org
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/106823003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert r241063 "Remove stale 'lib64' entries in browser_tests.isolate and chrome.isolate on linux"
These directories get created on a clobber build.
R=szym@chromium.org, yoz@chromium.org
BUG=
Review URL: https://codereview.chromium.org/115953005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux
'lib32' was removed in r240867 because it was not being generated on OSX
anymore. These directories were likely generated by NaCl and stopped being
generated at some moment in the past days.
R=szym@chromium.org
BUG=
Review URL: https://codereview.chromium.org/113773005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=324911
NOTRY=true
Review URL: https://codereview.chromium.org/99893005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This puts resources that used to be in chrome.pak and/or compiled in to
chrome.dll into resources.pak. resources.pak is already loaded at startup
on all platforms so having some resources in a separate pak file isn't
beneficial.
This previously landed as https://codereview.chromium.org/22339020 and
was reverted due to various scripts/etc still referencing chrome.pak. This
patch still builds chrome.pak, but with only the (tiny) net_resources in
it. After this lands I'll go remove references to chrome.pak and then remove
it completely once all references are gone.
BUG=52609
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218956
R=phajdan.jr@chromium.org, sky@chromium.org, tony@chromium.org
Review URL: https://codereview.chromium.org/23205023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seemes to have broken the mac buildbot.
I'll post more info here soon, crbug.com does not seem to be working at the moment.
> Remove chrome.pak references, build resources into resources.pak (try 2)
>
> This puts resources that used to be in chrome.pak and/or compiled in to
> chrome.dll into resources.pak. resources.pak is already loaded at startup
> on all platforms so having some resources in a separate pak file isn't
> beneficial.
>
> This previously landed as https://codereview.chromium.org/22339020 and
> was reverted due to various scripts/etc still referencing chrome.pak. This
> patch still builds chrome.pak, but with only the (tiny) net_resources in
> it. After this lands I'll go remove references to chrome.pak and then remove
> it completely once all references are gone.
>
> BUG=52609
> TBR=phajdan.jr@chromium.org for chrome/installer/linux
>
> Review URL: https://chromiumcodereview.appspot.com/23205023
TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/22807012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This puts resources that used to be in chrome.pak and/or compiled in to
chrome.dll into resources.pak. resources.pak is already loaded at startup
on all platforms so having some resources in a separate pak file isn't
beneficial.
This previously landed as https://codereview.chromium.org/22339020 and
was reverted due to various scripts/etc still referencing chrome.pak. This
patch still builds chrome.pak, but with only the (tiny) net_resources in
it. After this lands I'll go remove references to chrome.pak and then remove
it completely once all references are gone.
BUG=52609
TBR=phajdan.jr@chromium.org for chrome/installer/linux
Review URL: https://chromiumcodereview.appspot.com/23205023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Compile failures on main builders, not seen on try bots.
> Remove chrome.pak references, build resources into resources.pak
>
> This puts resources that used to be in chrome.pak and/or compiled in to
> chrome.dll into resources.pak. resources.pak is already loaded at startup
> on all platforms so having some resources in a separate pak file isn't
> beneficial.
>
> TBR=tony@chromium.org
>
> BUG=52609
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216822
>
> Review URL: https://codereview.chromium.org/22339020
TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/22794013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This puts resources that used to be in chrome.pak and/or compiled in to
chrome.dll into resources.pak. resources.pak is already loaded at startup
on all platforms so having some resources in a separate pak file isn't
beneficial.
TBR=tony@chromium.org
BUG=52609
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216822
Review URL: https://codereview.chromium.org/22339020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke a variety of Linux, CrOS, and Android bots:
ninja: error: 'gen/repack/chrome.pak', needed by 'chrome.pak', missing and no
known rule to make it
> Remove chrome.pak references, build resources into resources.pak
>
> This puts resources that used to be in chrome.pak and/or compiled in to
> chrome.dll into resources.pak. resources.pak is already loaded at startup
> on all platforms so having some resources in a separate pak file isn't
> beneficial.
>
> R=tony
> TBR=sky
>
> BUG=52609
>
> Review URL: https://chromiumcodereview.appspot.com/22339020
TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/22557005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This puts resources that used to be in chrome.pak and/or compiled in to
chrome.dll into resources.pak. resources.pak is already loaded at startup
on all platforms so having some resources in a separate pak file isn't
beneficial.
R=tony
TBR=sky
BUG=52609
Review URL: https://chromiumcodereview.appspot.com/22339020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Reland 198495 for Windows.
>
> > Build libpeerconnection as a loadable module for win, mac and linux by default. Also remove the allocator shim variable since it's no longer needed.
> >
> > This requires updating .isolate files for some try bots.
> > In practice, I've only seen failures in interactive_ui_tests because of this change, but I'm being a bit proactive here and making sure that libpeerconnection.so exists with test hosts that have tests that depend on it.
> >
> > BUG=238207
> > R=csharp@chromium.org, ronghuawu@chromium.org
> >
> > Review URL: https://codereview.chromium.org/14907003
>
> TBR=tommi@chromium.org
>
> Review URL: https://codereview.chromium.org/14767016
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/14615011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Build libpeerconnection as a loadable module for win, mac and linux by default. Also remove the allocator shim variable since it's no longer needed.
>
> This requires updating .isolate files for some try bots.
> In practice, I've only seen failures in interactive_ui_tests because of this change, but I'm being a bit proactive here and making sure that libpeerconnection.so exists with test hosts that have tests that depend on it.
>
> BUG=238207
> R=csharp@chromium.org, ronghuawu@chromium.org
>
> Review URL: https://codereview.chromium.org/14907003
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/14767016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Perf bots broke due to not being able to find libpeerconnection.so
> Revert 198503 "Revert 198495 "Build libpeerconnection as a loada..."
> (was a false positive revert)
>
> > Revert 198495 "Build libpeerconnection as a loadable module for ..."
> >
> > > Build libpeerconnection as a loadable module for win, mac and linux by default. Also remove the allocator shim variable since it's no longer needed.
> > >
> > > This requires updating .isolate files for some try bots.
> > > In practice, I've only seen failures in interactive_ui_tests because of this change, but I'm being a bit proactive here and making sure that libpeerconnection.so exists with test hosts that have tests that depend on it.
> > >
> > > BUG=238207
> > > R=csharp@chromium.org, ronghuawu@chromium.org
> > >
> > > Review URL: https://codereview.chromium.org/14907003
> >
> > TBR=tommi@chromium.org
> >
> > Review URL: https://codereview.chromium.org/15005004
>
> TBR=tommi@chromium.org
>
> Review URL: https://codereview.chromium.org/14919005
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/14670014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(was a false positive revert)
> Revert 198495 "Build libpeerconnection as a loadable module for ..."
>
> > Build libpeerconnection as a loadable module for win, mac and linux by default. Also remove the allocator shim variable since it's no longer needed.
> >
> > This requires updating .isolate files for some try bots.
> > In practice, I've only seen failures in interactive_ui_tests because of this change, but I'm being a bit proactive here and making sure that libpeerconnection.so exists with test hosts that have tests that depend on it.
> >
> > BUG=238207
> > R=csharp@chromium.org, ronghuawu@chromium.org
> >
> > Review URL: https://codereview.chromium.org/14907003
>
> TBR=tommi@chromium.org
>
> Review URL: https://codereview.chromium.org/15005004
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/14919005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Build libpeerconnection as a loadable module for win, mac and linux by default. Also remove the allocator shim variable since it's no longer needed.
>
> This requires updating .isolate files for some try bots.
> In practice, I've only seen failures in interactive_ui_tests because of this change, but I'm being a bit proactive here and making sure that libpeerconnection.so exists with test hosts that have tests that depend on it.
>
> BUG=238207
> R=csharp@chromium.org, ronghuawu@chromium.org
>
> Review URL: https://codereview.chromium.org/14907003
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/15005004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default. Also remove the allocator shim variable since it's no longer needed.
This requires updating .isolate files for some try bots.
In practice, I've only seen failures in interactive_ui_tests because of this change, but I'm being a bit proactive here and making sure that libpeerconnection.so exists with test hosts that have tests that depend on it.
BUG=238207
R=csharp@chromium.org, ronghuawu@chromium.org
Review URL: https://codereview.chromium.org/14907003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All the necessary files, like resources.pak and ffmpegsumo.so, are already
mapping deep inside Chromium.app/. Mapping the ones in PRODUCT_DIR is useless.
Technically, Chromium.dmg could be used but it's harder to start from the
command line, and mapping each individual files permits caching modules that
haven't changed, like the resource files.
TBR=csharp@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/14109022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add 'command' on linux too. OSX will come next.
TBR=csharp@chromium.org
BUG=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/13956022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This permits a user to archive a working chrome build on isolateserver for
downloading it elsewhere. Note that the actual list of files listed
chrome.isolate hasn't been verified but I prefer to commit it as-is and check
each OS afterward. In particular, this new chrome_run target is not included in
chromium_swarm_tests.
Command to archive is:
ninja -C out/Release chrome_run
python tools/swarm_client/isolate.py hashtable \
-s out/Release/chrome.isolated \
-o https://isolateserver-dev.appspot.com/
sha1sum out/Release/chrome.isolated
Command to download is:
python tools/swarm_client/run_isolated.py \
-r https://isolateserver-dev.appspot.com/content/retrieve/default-gzip/ \
-H <hash got from sha1sum command above>/ \
--download <path to download files>
Note that the same command can be used on all OSes, except for sha1sum on
Windows.
R=csharp@chromium.org
BUG=98636
Review URL: https://chromiumcodereview.appspot.com/13913025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194010 0039d316-1c4b-4281-b951-d872f2087c98
|