| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Fix our heuristics to not be terribly wrong, while discouraging their use. If the theme author doesn't specify colors in the form of ChromeGtkFrame::frame-color, use the old MetaFrames/selection color fallback (tinting slightly darker).
2) Give the ChromeGtkFrame several optional widget style properties allowing theme authors to explicitly specify colors for the frame and scrollbars, and control the gradient on top of the chrome frame.
TODO: Do we want to let theme authors override the close/min/max button images?
BUG=62377, 35317
TEST=for now, compiles, as the needed data hasn't been added by theme authors.
Review URL: http://codereview.chromium.org/4715005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Welcome screen uses different style of buttons.
BUG=chromium-os:8468
TEST=none
Review URL: http://codereview.chromium.org/4402001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise they hit a base::ThreadRestrictions::AssertIOAllowed() assertion.
Introduced MimeRegistryDispatcherHost for code sharing among renderer_host and worker_host.
BUG=62601
TEST=none
Review URL: http://codereview.chromium.org/4857001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* CopyBackground that copies the background from other view.
* Updated NewUserView to use CopyBackground.
I couldn't use this for existing_user_view as surrounding area is rendered by another window.
BUG=chromium-os:8101
TEST=Check username/password fields on new user pods and password field on screen locker have the same background as surrounding area.
Review URL: http://codereview.chromium.org/4882003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
blocked plugins, which it hasn't done since r62146, and there are no firm plans to do so in the future.
This is important because http://codereview.chromium.org/4767001/ is going to make calling RemoveInfoBar() with a non-showing delegate an error, and it seems better to just remove all this code if it's not doing anything than to neuter parts of it.
BUG=62154
TEST=none
Review URL: http://codereview.chromium.org/4863001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves SecurityStyle and PageType into chrome/common/ and removes the
chrome_frame dependency on chrome/browser/tab_contents/. This undoes the
temporary DEPS hack on chrome/common/.
BUG=51409
TEST=compiles
Review URL: http://codereview.chromium.org/4697005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to communicate dynamic information to its update server if needed.
BUG=none
TEST=Make sure that existing extensions that do no set any extra data are
not adversely affected.
Review URL: http://codereview.chromium.org/4725002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...instead of relying on file modification time.
Also in this release:
- updated unit tests. They now use the production code path in PersistPolicyTask for writing policies, instead of duplicating that functionality.
- fixed nit: "#include <string>" in device_management_policy_cache_unittest.cc
BUG=62489
TEST=unit tests: DeviceManagementPolicyCacheTest* (in particular, these should no longer be flaky on Windows)
Review URL: http://codereview.chromium.org/4752004
Patch from Jakob Kummerow <jkummerow@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notifications from that extension.
This change also refactors the balloon collection code to remove duplication between chrome and chromeos.
Removes some gross removal code which was using fake notifications just to get the right ID.
BUG=58266
TEST=open notifications from extension, uninstall extensions
Review URL: http://codereview.chromium.org/4635007
TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/4855002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension.
This change also refactors the balloon collection code to remove duplication between chrome and chromeos.
Removes some gross removal code which was using fake notifications just to get the right ID.
BUG=58266
TEST=open notifications from extension, uninstall extensions
Review URL: http://codereview.chromium.org/4635007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class is responsible for talking to the client-side detection
servers and to fetch the machine learning model.
BUG=none
TEST=ClientSideDetectionServiceTest
Review URL: http://codereview.chromium.org/3815014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a simple device management server implementation written in python that's useful for unit tests and local testing.
BUG=62318
TEST=Compiles and browser tests in device_management_backend_browsertest succeed
Review URL: http://codereview.chromium.org/4659002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
are a number of parts of this patch that need work, but it should be
good enough for us to decide if we want to pursue it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4385001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the automation message files from chrome/test/automation to
chrome/common/. This requires a temporary override to chrome/common/DEPS until
Part 3 lands.
BUG=51409
TEST=compiles
Review URL: http://codereview.chromium.org/4758001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7217
TEST=None. Test until some constrained DOMUI is submitted.
Review URL: http://codereview.chromium.org/4662003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
quite simple and just sets up the PPAPI dispatcher and loads the library.
There is a new command line switch --ppapi-out-of-process which runs PPAPI
plugins out of process using the new code path. There is some logic in
RenderView and PepperPluginModule for setting up this connection, but it should
be straightforward.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3915002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toolbar.
Side effect: Changed all instances of IDC_REPORT_BUG to IDC_FEEDBACK to correctly indicate the message
BUG=chromium-os:5361
TEST=Verified visually that the status bar icon is gone and the toolbar icon
is there; tested the toolbar icon to verify functionality.
Review URL: http://codereview.chromium.org/4546002
TBR=rkc@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Side effect: Changed all instances of IDC_REPORT_BUG to IDC_FEEDBACK to correctly indicate the message
BUG=chromium-os:5361
TEST=Verified visually that the status bar icon is gone and the toolbar icon
is there; tested the toolbar icon to verify functionality.
Review URL: http://codereview.chromium.org/4546002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
views / chrome OS. This is necessary because linux views is already using GTK ConstrainedWindow.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4416002
TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/4711003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary because linux views is already using GTK ConstrainedWindow.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4416002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62462
TEST=DeviceManagementPolicyProviderTest*
Review URL: http://codereview.chromium.org/4382001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since r65508 does not move the files in "browser/chromeos/views", this change use the original ones to fix the build break on the "Chrome OS" bots. (I'm not sure if this is a correct fix, though.)
TBR=beng
BUG=none
TEST=fix build
Review URL: http://codereview.chromium.org/4739001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4694005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is upstreaming a Gentoo Linux patch.
BUG=13322
TEST=none
Review URL: http://codereview.chromium.org/4691001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renamed FileSystemQuota to FileSystemQuotaManager.
Removed PlatFormErrorToFileError in simple_file_system.cc (in favor of webkit_flue::PlatformErrorToFileError)
BUG=60243
TEST=none
Review URL: http://codereview.chromium.org/4017007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4720002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch extends the existing Status Icon support to include
Background Application launch entries. This is implemented by
introducing the BackgroundApplicationListModel class. The
BackgroundModeManager creates and observes an instance of this class
which calls back into the BackgroundModeManager using
OnApplicationAdded, OnApplicationRemoved, and
OnApplicationDataChanged.
BUG=59223
TEST=None
Review URL: http://codereview.chromium.org/3822003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4694002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I originally added this in r60123 but over time it turned out that being a regular installed app will work out better.
BUG=none
TEST=chat manager should no longer be a component extension on Chrome OS builds
Review URL: http://codereview.chromium.org/4652002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--enable-video-layering flags. With the introduction of accelerated
compositing to Chromium this code is now obsolete, and it is causing
problems and bug reports when users experiment with these flags.
Tested on Linux in the following configurations:
- Compositor on, CSS 3D content
- Compositor on, HTML5 video content
- Compositor off, HTML5 video content
Also ran patch successfully through the try bots.
BUG=54932
TEST=none
Review URL: http://codereview.chromium.org/4399003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
process.
BUG=http://crbug.com/51105, http://crbug.com/57239
TEST=Unit tests included.
Review URL: http://codereview.chromium.org/4524002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This decodes the device management policy information and keeps a local cache of the policy information on disk.
BUG=62036
TEST=unit tests
Review URL: http://codereview.chromium.org/4338004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently this command will fail when is touchui=1, because one file that should have been excluded from the gtk related code had been missed. This code is thus missing some of the symbols that it needs during the linking stage. Since this code is not used in chrome when this flag is set the build system is able to successfully build the browser, but since the unit tests exercise the code it fails when building unit tests. This fix explicitly excludes this code and related unit tests.
BUG=
TEST=Setup a build enviroment with touchui=1 and issue 'make unit_tests'
Review URL: http://codereview.chromium.org/3517014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58937
TEST=manual
Review URL: http://codereview.chromium.org/4427001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting because this causes problems on valgrind (for ChromeOS only).
Turns out that TabStripModel is not thread safe, and I'm calling from
another thread.
Review URL: http://codereview.chromium.org/4446002
TBR=gspencer@chromium.org
Review URL: http://codereview.chromium.org/4417006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separate the parts of ExternalPrefExtensionProvider that store the list of external extensions and the parts that parse the preference file. This makes it possible for other providers to reuse the storage code.
Also make it possible to have external extensions from update URLs with locations other than Extension::EXTERNAL_PREF_DOWNLOAD, by making it a parameter of OnExternalExtensionUpdateUrlFound.
Add new provider (ExternalPolicyExtensionProvider) to provide external extensions from policies.
BUG=59782
TEST=ExtensionsServiceTest.ExternalPrefProvider,ExternalPolicyExtensionProvider.*
Review URL: http://codereview.chromium.org/3826008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a URL chrome://keyboardoverlay/ for keyboard overlay.
BUG=chromium-os:6268
TEST=manually on the net book
Review URL: http://codereview.chromium.org/4226001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[I actually did this two months ago, and though I had committed it, but
due to the "git cl push" vs "git cl dcommit" craziness, it was never
in the tree.]
It was previously reviewed and LGTM'd here:
http://codereview.chromium.org/3235007/show
BUG=none
TEST=Tested on device, both using large numbers of tabs, and
small tabs that used lots of memory.
Review URL: http://codereview.chromium.org/4446002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27786,60591
TEST=Enable 'Confirm to Quit' in about:flags. When you press Cmd+Q, it brings up the floaty panel telling you to hold the key combo. When you do, it quits after 1.5 seconds.
Review URL: http://codereview.chromium.org/4220005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a device management backend implementation running over HTTP.
BUG=None
TEST=unit tests in device_management_backend_impl_unittest.cc
Review URL: http://codereview.chromium.org/4098004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/8458
TEST=Manual
Review URL: http://codereview.chromium.org/4324001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I wrote much of the cross-platform policy-providing mechanism for Chrome. Much of the policy code is cross platform, so I would like to apply for a Linux C++ readability review. However, my submitted CLs also contain Windows-specific code, so I'm unsure if Windows readability is more appropriate.
* Implementation of managed policy abstraction on top of a preference store. This is the CL that is the initial preparation for implementing platform-specific policy - http://codereview.chromium.org/1692011
* Implement core mechanism to honor Windows Group Policy on top of initial CL - http://codereview.chromium.org/2119005
* Dynamic refresh of policy without restarting Chrome including Windows-specific code - http://codereview.chromium.org/2858060
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3774003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in pure HTML into the extension-based web apps used internally
by Chrome.
BUG=49233
TEST=unit_tests --gtest_filter=ExtensionFromWebApp.*
Review URL: http://codereview.chromium.org/4139008
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/4326002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in pure HTML into the extension-based web apps used internally
by Chrome.
BUG=49233
TEST=unit_tests --gtest_filter=ExtensionFromWebApp.*
Review URL: http://codereview.chromium.org/4139008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57892
TEST=none
Review URL: http://codereview.chromium.org/4150007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/4093006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit c1c1fed998ee4d839bfe256150e5e59220ebc0ef (r64637).
TBR=nirnimesh@
BUG=51409
TEST=none
Review URL: http://codereview.chromium.org/4194007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
automation_messages used to live in chrome/test/automation, when it's needed by
browser and chrome_frame. When I started lifting code out of headers and into
implementation files, I was getting link errors and temporarily solved the
problem by compiling the cc files manually into libbrowser.a. Now this is part
of chrome/common/ which is included by all targets needed.
While doing this, discover that automation IPC redefines the ContextMenuParams struct. Rename it to MiniContextMenuParams.
BUG=51409
TEST=none
Review URL: http://codereview.chromium.org/4200007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64637 0039d316-1c4b-4281-b951-d872f2087c98
|