summaryrefslogtreecommitdiffstats
path: root/chrome/chrome_browser.gypi
Commit message (Collapse)AuthorAgeFilesLines
* views: Rename JavaScriptMessageBoxDialog to JSModalDialogViews so it matches ↵tfarina@chromium.org2010-09-291-4/+4
| | | | | | | | | | | | | with cocoa and gtk. In the refactor in http://codereview.chromium.org/3398015 it seems that was missed. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3384036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60906 0039d316-1c4b-4281-b951-d872f2087c98
* Create a TabHandler object to decouple Browser from TabStripModel API.ben@chromium.org2010-09-281-0/+3
| | | | | | | | | | Currently it's just a pass-through so everything still works while I begin to move stuff out of Browser down into it. BUG=none TEST=existing unittests. Review URL: http://codereview.chromium.org/3412041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60860 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60845 (check perms failure) - Added UI for clearing Chrome Sync datawillchan@chromium.org2010-09-281-6/+0
| | | | | | | | | | | | | | | | | | | | | | | - Created 2 tabs, one for for clearing local browsing data, one for clearing server data - Refactored the old local browsing code to use a grid layout rather than less-wieldy math - Controls on all tabs block while, closing dialog is disabled, new throbber is going while clear is in progress - Clear server tab will be behind a flag until I deploy the server endpoint - Retained old clearing behavior: dialog closes on successful lear - Clear server UI only visible if user is syncing Outstanding issues: - Clearing currently causes an account to become unusable. The cause of the issue is a known problem with auth; currently investigating a fix - Unlike local clearing, clearing server data is more likely to error out. For now I just show a label next to the clear button that says Error, allowing the user to try again BUG=54349 TEST=Clear from UI, or run sync backend tests checked in for issue 54280 Review URL: http://codereview.chromium.org/3412032 TBR=raz@chromium.org Review URL: http://codereview.chromium.org/3552001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60857 0039d316-1c4b-4281-b951-d872f2087c98
* Added UI for clearing Chrome Sync dataraz@chromium.org2010-09-281-0/+6
| | | | | | | | | | | | | | | | | | | | - Created 2 tabs, one for for clearing local browsing data, one for clearing server data - Refactored the old local browsing code to use a grid layout rather than less-wieldy math - Controls on all tabs block while, closing dialog is disabled, new throbber is going while clear is in progress - Clear server tab will be behind a flag until I deploy the server endpoint - Retained old clearing behavior: dialog closes on successful lear - Clear server UI only visible if user is syncing Outstanding issues: - Clearing currently causes an account to become unusable. The cause of the issue is a known problem with auth; currently investigating a fix - Unlike local clearing, clearing server data is more likely to error out. For now I just show a label next to the clear button that says Error, allowing the user to try again BUG=54349 TEST=Clear from UI, or run sync backend tests checked in for issue 54280 Review URL: http://codereview.chromium.org/3412032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60845 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60821 (build break) - Create a TabHandler object to decouple Browser ↵willchan@chromium.org2010-09-281-3/+0
| | | | | | | | | | | | | | | | from TabStripModel API. Currently it's just a pass-through so everything still works while I begin to move stuff out of Browser down into it. BUG=none TEST=existing unittests. Review URL: http://codereview.chromium.org/3447033 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/3423028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60824 0039d316-1c4b-4281-b951-d872f2087c98
* Create a TabHandler object to decouple Browser from TabStripModel API.ben@chromium.org2010-09-281-0/+3
| | | | | | | | | | | Currently it's just a pass-through so everything still works while I begin to move stuff out of Browser down into it. BUG=none TEST=existing unittests. Review URL: http://codereview.chromium.org/3447033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60821 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AppModalDialog to more clearly isolate platform specific UI pieces ↵ben@chromium.org2010-09-281-6/+7
| | | | | | | | | | | and eliminate the dependency on individual frontends from cross platform code. BUG=none TEST=none Review URL: http://codereview.chromium.org/3398015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60785 0039d316-1c4b-4281-b951-d872f2087c98
* [Chrome OS] Refactor Canonicalize() method into base class to prepare for ↵cmasone@chromium.org2010-09-281-1/+2
| | | | | | | | | | | new Authenticator subclass BUG=chromium-os:4929 TEST=unit tests Review URL: http://codereview.chromium.org/3436031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60752 0039d316-1c4b-4281-b951-d872f2087c98
* Landing http://codereview.chromium.org/3387008 for sadrul:tfarina@chromium.org2010-09-281-0/+1
| | | | | | | | | | | | | | | | linux: Add support for undo in the omnibox. GtkTextView does not support undo. So borrow the relevant code from GtkSourceView. BUG=18210 TEST=None Patch from sadrul <sadrul@chromium.org> Review URL: http://codereview.chromium.org/3429025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60744 0039d316-1c4b-4281-b951-d872f2087c98
* Add search engine selection dialog for Mac, do new-style first-run.avi@chromium.org2010-09-271-0/+3
| | | | | | | | | | | | SearchEngineDialog.xib: creation FirstRunDialog.xib: removal of import and cancel UI elements BUG=47651 TEST=reset profile, run. Make sure goto/chromefirstrun is satisfied. Review URL: http://codereview.chromium.org/3223010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60699 0039d316-1c4b-4281-b951-d872f2087c98
* Cloud print proxy management UI.scottbyer@chromium.org2010-09-271-0/+4
| | | | | | | | | | | Based in the Under-the-Hood section of options, this UI allows mere mortals to turn on and off the cloud print proxy. Currently working on Windows only, behind a flag. BUG=none TEST=Open up the options, turn CPP on and off. Review URL: http://codereview.chromium.org/3450021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60684 0039d316-1c4b-4281-b951-d872f2087c98
* Create DownloadStatusUpdater to keep track of download progressphajdan.jr@chromium.org2010-09-271-0/+3
| | | | | | | | | | | | | | | and update the application icon. We can't do that in DownloadManager because there are multiple DownloadManagers (one per Profile) and they would overwrite each other's updates. BUG=none TEST=none Review URL: http://codereview.chromium.org/3454018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60625 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60556 (broke chrome, at least on linux) - Refactor, rename and ↵thakis@chromium.org2010-09-251-2/+0
| | | | | | | | | | | | | | | | | relocate ProfileSyncServiceTestHarness. ProfileSyncServiceTestHarness needs to support a specialization that can use a WaitableEvent instead of starting and stopping the UI Message loop. Required for automation provider support for sync. The class also needs to live in chrome/browser, instead of chrome/test, and could do with a rename. BUG=56460 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3492005 TBR=rsimha@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60584 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this patch with the compile fix for Visual studio 2005. The ↵ananta@chromium.org2010-09-251-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | compiler gets confused between the two Delegate classes URLRequest::Delegate and the PluginDownloadHelper::Delegate class. Renaming the latter seems to work Fix a regression introduced in the chrome plugin installer on Windows in revision 54316 which was to remove usages of GetTempDir. However the change failed to take into account that the file name which is used to perform the download eventually is shell executed on windows. In this case the download was performed on a temporary file which causes ShellExecute to put up a confirmation dialog asking the user to select the application for opening the file. Fix is to rename the temp file path to the desired file path on success. Fixes bug http://code.google.com/p/chromium/issues/detail?id=56746 Bug=56746 Test=Covered by plugin installer plugin test. TBR=jam Review URL: http://codereview.chromium.org/3453025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60577 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60574 - Fix a regression introduced in the chrome plugin installer on ↵ananta@chromium.org2010-09-251-2/+0
| | | | | | | | | | | | | | | | | | | | | | | Windows in revision 54316 which was to remove usages of GetTempDir. However the change failed to take into account that the file name which is used to perform the download eventually is shell executed on windows. In this case the download was performed on a temporary file which causes ShellExecute to put up a confirmation dialog asking the user to select the application for opening the file. Fix is to rename the temp file path to the desired file path on success. Fixes bug http://code.google.com/p/chromium/issues/detail?id=56746 Bug=56746 Test=Covered by plugin installer plugin test. Review URL: http://codereview.chromium.org/3432028 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/3461029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60575 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression introduced in the chrome plugin installer on Windows in ↵ananta@chromium.org2010-09-251-0/+2
| | | | | | | | | | | | | | | | | | | | revision 54316 which was to remove usages of GetTempDir. However the change failed to take into account that the file name which is used to perform the download eventually is shell executed on windows. In this case the download was performed on a temporary file which causes ShellExecute to put up a confirmation dialog asking the user to select the application for opening the file. Fix is to rename the temp file path to the desired file path on success. Fixes bug http://code.google.com/p/chromium/issues/detail?id=56746 Bug=56746 Test=Covered by plugin installer plugin test. Review URL: http://codereview.chromium.org/3432028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60574 0039d316-1c4b-4281-b951-d872f2087c98
* Skeleton for mobile device activation UI.zelidrag@chromium.org2010-09-251-2/+4
| | | | | | | | | BUG=chromium-os:6868 TEST=none Review URL: http://codereview.chromium.org/3448018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60568 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor, rename and relocate ProfileSyncServiceTestHarness.rsimha@chromium.org2010-09-251-0/+2
| | | | | | | | | | | | | ProfileSyncServiceTestHarness needs to support a specialization that can use a WaitableEvent instead of starting and stopping the UI Message loop. Required for automation provider support for sync. The class also needs to live in chrome/browser, instead of chrome/test, and could do with a rename. BUG=56460 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3492005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60556 0039d316-1c4b-4281-b951-d872f2087c98
* Add IndexedDB to cookie tree.bauerb@chromium.org2010-09-241-0/+2
| | | | | | | | | | | XIB changes: Add another view with IndexedDB details to CookieDetailsView.xib. BUG=56248 TEST=CookiesTreeModelTest.*:CookiesDetailsTest.*:CookiesViewTest.*: Review URL: http://codereview.chromium.org/3429020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60470 0039d316-1c4b-4281-b951-d872f2087c98
* Windows Gateway Data Provider.allanwoj@chromium.org2010-09-241-0/+2
| | | | | | | | | | | Provides the MAC address of any routers connected via Ethernet. Also added in a command line flag to enable it. BUG=None TEST=None Review URL: http://codereview.chromium.org/3368014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60463 0039d316-1c4b-4281-b951-d872f2087c98
* Move task manager code into a subdirectory.evan@chromium.org2010-09-231-4/+4
| | | | | | | | | BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3454028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60325 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up indexed databases to content settings.jochen@chromium.org2010-09-231-0/+2
| | | | | | | | | | | Step 2: add a browsing data helper for indexed databases. BUG=56248 TEST=CannedBrowsingDataIndexedDBHelperTest.*,BrowsingDataIndexedDBHelperTest.* Review URL: http://codereview.chromium.org/3468007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60270 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move a bunch of code to the headers and remove includes.erg@google.com2010-09-221-0/+2
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3412016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60208 0039d316-1c4b-4281-b951-d872f2087c98
* [Chrome OS] Infrastucture for doing offline/online login simultaneouslycmasone@google.com2010-09-221-6/+16
| | | | | | | | | | | | | | | | | | | | | | These are meant to wrap and replace large chunks of code in GoogleAuthenticator, once I rewrite that code to do offline and online login at the same time. That's why there's some code that's still in GoogleAuthenticator that's refactored into some of these classes. Essentially, one creates an AuthAttemptState object, which will only allow its mutable contents to be read/written on the IO thread. Then, you pass it to an OnlineAttempt which, when done, stores results in the AuthAttemptState. You can do the same thing with the various CryptohomeOp classes. They call out over DBus to asynchronously do stuff with the user's cryptohome and then, when the callbacks come in, these object post a call over to the IO thread to update the contents of the AuthAttemptState instance they're holding on to. BUG=chromium-os:4929 TEST=unit testss Review URL: http://codereview.chromium.org/3407008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60190 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor some file_system classes to use chromium types instead ofdumi@chromium.org2010-09-221-2/+2
| | | | | | | | | | | WebKit API types. BUG=none TEST=none Review URL: http://codereview.chromium.org/3406008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60152 0039d316-1c4b-4281-b951-d872f2087c98
* Enable and disable Chat Manager component extension based on labs preference ↵scherkus@chromium.org2010-09-211-0/+27
| | | | | | | | | | | setting. BUG=56429 TEST=unit_tests --gtest_filter=ExtensionsServiceTest.* Review URL: http://codereview.chromium.org/3120029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60123 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Explicitly set Space when existing full screen rohitrao@chromium.org2010-09-211-0/+2
| | | | | | | | | | | | | | | | | | | | If a user moves the full screen window to a different space they get snapped back to the original space when they exit full screen. The problem is that internally the full screen window is a different window than the normal browser window. This means that any changes the user makes to the full screen window aren't reflected on the normal browser window. The correct fix for this bug is to create a new browser window when the user exits full screen. This new window would then be on the correct space. This would require a fairly large architectural change to the BrowserWindowController class. My proposed fix is much simpler. When exiting full screen we simply move the normal browser window to the Space that the full screen window is on. Original review at: http://codereview.chromium.org/3345005/show Patch by Sailesh Agrawal <fnepal@gmail.com>. BUG=41693 TEST=Moved the full screen window to a different Space. Verified that exiting full screen didn't change the active Space. Review URL: http://codereview.chromium.org/3386015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60063 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of bugreport fixes. Also, moved about:system page to chrome:system.zelidrag@chromium.org2010-09-171-0/+2
| | | | | | | | | BUG=chromium-os:6737,chromium-os:6739,chromium-os:6547,chromium-os:6108 TEST=test the bugs above Review URL: http://codereview.chromium.org/3417008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59876 0039d316-1c4b-4281-b951-d872f2087c98
* Remove vestigial cookie/web app permissions prompting UI now that the async ↵ben@chromium.org2010-09-171-16/+0
| | | | | | | | | | UI has been approved for M7.This allows me to more easily change the way the appmodal dialog system works. http://crbug.com/55121 TEST=existing tests Review URL: http://codereview.chromium.org/3299020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59838 0039d316-1c4b-4281-b951-d872f2087c98
* Added missing headers.dilmah@chromium.org2010-09-171-0/+2
| | | | | | | | BUG=None TEST=Manual Review URL: http://codereview.chromium.org/3413017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59783 0039d316-1c4b-4281-b951-d872f2087c98
* Implement SearchProviderInstallData.levin@chromium.org2010-09-171-0/+1
| | | | | | | | | | | Support for Google base URL will be in another patch. BUG=38475 TEST=unit_tests --gtest_filter=SearchProviderInstallDataTest* Review URL: http://codereview.chromium.org/3403008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59765 0039d316-1c4b-4281-b951-d872f2087c98
* Moves TabStripModelObserver/Delegate into their own headers.sky@chromium.org2010-09-161-0/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3425009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
* Add a placeholder, overridable DOMUI keyboard.bryeung@chromium.org2010-09-161-1/+4
| | | | | | | | | | | This change does not add support for displaying the keyboard. That will be provided (along with a more useful keyboard) in follow-up changes. BUG=none TEST=added new override test Review URL: http://codereview.chromium.org/3362019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59712 0039d316-1c4b-4281-b951-d872f2087c98
* Test shell impl for WebKit's File System API:BUG=52799TEST=nonekkanetkar@chromium.org2010-09-161-3/+3
| | | | | | | | | | | Also refactored a bunch of code from chrome/browser to webkit/fileapi for reuse. Added class hierarchy. Test shell and browser operations now inherit from common webkit/fileapi/file_system_operation. Review URL: http://codereview.chromium.org/3186009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59616 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make compile-time dependency on gnome-keyring optional.phajdan.jr@chromium.org2010-09-161-1/+7
| | | | | | | | | | | This is upstreaming a Gentoo Linux patch. BUG=none TEST=none Review URL: http://codereview.chromium.org/3380004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59587 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for speak properties such as rate to platform specific TTS.dtseng@chromium.org2010-09-151-0/+2
| | | | | | | | | BUG=none. TEST=Use extension to drive the tts engines on Windows and Mac. Had key bindings so that verification of: decrease rate, increase rate, decrease pitch, increase pitch, decrease volume, and increase volume worked. Verified that the limits, when reached, did not have any adverse effects. Review URL: http://codereview.chromium.org/3325021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59572 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add per-plugin exceptions to content settings.bauerb@chromium.org2010-09-151-0/+2
| | | | | | | | | | | | | | | Screenshot: http://www.dropmocks.com/mXMd I'm adding a subclass of NSArrayController, TableModelArrayController, that binds to a RemoveRowsTableModel that can use groups and displays them using group rows in an NSTableView. This cleans up SimpleContentExceptionsWindowController a lot, and the class could also be used for other table models that use groups (keyword editor and autofill). XIB changes: In SimpleContentExceptionsWindow.xib, bind table view to TableModelArrayController instead of using the dataSource outlet. Buttons call actions on TableModelArrayController, and table view delegate also points to it. BUG=39252 TEST=SimpleContentExceptionsWindowControllerTest.*:TableModelArrayControllerTest.*:PluginExceptionsTableModelTest.* Review URL: http://codereview.chromium.org/3327016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59501 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui options: Migrate two alerts to shared AlertOverlay.csilv@chromium.org2010-09-141-4/+0
| | | | | | | | BUG=none TEST=Verify that 'stop sync' and 'remove all password' alerts display correctly. Review URL: http://codereview.chromium.org/3409001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59436 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of match preview tweaks:sky@chromium.org2010-09-141-0/+5
| | | | | | | | | | | | | | | | . Makes MatchPreview owned by Browser rather than each TabContents. . Makes MatchPreview dismiss when the omnibox closes. . Supports the ability to send script to the page rather than reloading on every keystroke. . Supports receiving results from the page that drives the suggest text in the omnbox. BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3332022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59428 0039d316-1c4b-4281-b951-d872f2087c98
* Add a helper class to use with SignedSettings.xiyuan@chromium.org2010-09-141-0/+2
| | | | | | | | | | | | | | | - Add a SignedSettingsHelper that serializes all SignedSettings ops, provides a unified callback interface and allows canceling callback of requested ops; - Move MockOwnershipService into a header file; - Add a unit test for SignedSettingsHelper; BUG=chromium-os:968 TEST=none. This is still plumbing work required users options ui. Review URL: http://codereview.chromium.org/3373008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59380 0039d316-1c4b-4281-b951-d872f2087c98
* Enumerate layered service providers and namespace providers under Windows ↵mmenke@chromium.org2010-09-141-0/+2
| | | | | | | | | | | and display them on a new net-internals tab. On other OSes, the new tab is always hidden. BUG=53474 TEST=manual Review URL: http://codereview.chromium.org/3329016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59364 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SessionStoragejorlow@chromium.org2010-09-141-0/+2
| | | | | | | | | | | | | | | Apparently the session storage code was pretty horribly broken. It didn't correctly handle tabs being restored, didn't have the proper lifetime (this was the issue exposed in the bug), and had many leaks. To fix this, things had to be plumbed fairly differently. We need to pass session storage in on TabContents creation to ensure that the first RenderView will have the correct session storage id. When closing a tab, we need to save the session storage with the restoration service. When restoring a tab, we pass it back into the tab contents class. When duplicating a tab, we clone the storage. Lifetimes are now handled by standard reference counting code. A SessionStorageNamespace object wraps an ID. When it's instantiated, it allocates an ID. When it's destroyed, it deletes the ID. IDs make this process very lightweight (the heavyweight stuff is allocated on first use of SessionStorage) and it seperates the more complex lifetimes of SessionStorage namespaces (where less deterministic shutdown is more tollerable) from the LocalStorage namespace which needs to shutdown very precisely. BUG=52393 TEST=Set some variable on session storage; close the tab; re-open the tab; the variable should still be set. You can also run through the repro steps in the bug. Review URL: http://codereview.chromium.org/3325012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59350 0039d316-1c4b-4281-b951-d872f2087c98
* Create a DefaultPrefStore to hold registered application-default preference ↵pam@chromium.org2010-09-141-0/+2
| | | | | | | | | | | | | | | values. Also rework preference notifications so they're not sent when a pref store rewrites the same value it already had, to avoid infinite recursion in places that set a pref in response to a notification that that pref has changed. This allows notifications to be sent properly when another PrefStore takes control from a default value. BUG=52719, 54950 TEST=covered by unit tests (PrefValueStoreTest.*, PrefNotifierTest.*, and ExtensionPrefStoreTest.*) Review URL: http://codereview.chromium.org/3323022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59345 0039d316-1c4b-4281-b951-d872f2087c98
* Replace network combobox with network dropdown buttondpolukhin@chromium.org2010-09-141-0/+4
| | | | | | | | | BUG=chromium-os:4023, chromium-os:4117, chromium-os:4117 TEST=Manual test first OOBE screen Review URL: http://codereview.chromium.org/3166028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59343 0039d316-1c4b-4281-b951-d872f2087c98
* This is a second attempt of http://codereview.chromium.org/3175038davemoore@chromium.org2010-09-131-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It failed the Vista Perf UI tests. This is because those tests close the browser upon an error. And they always get an error when the session is closed in the middle of the test. The new changes are in chrome/browser/automation/testing_automation_provider.cc BUG=50006 TEST=Run chrome under nested window manager using Xephyr (see http://code.google.com/p/chromium/wiki/LayoutTestsLinux) use --enable-logging=stderr --log-level=0 kill xephyr examine log. You should see X IO Error detected followed (not necessarily immediately) by successfully saved /tmp/tx/Default/Preferences successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Default/Preferences along with no crash. BUG= TEST= Review URL: http://codereview.chromium.org/3364019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59269 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move ctors/dtors into cc files.erg@google.com2010-09-131-1/+4
| | | | | | | | | | | | | This cleanup patch isn't as impactful; this only shrinks our .a files by 304k. This patch also renames chrome/browser/history/download_type.h to download_create_info.h because there are then two download_type.cc files and MSVS will have the .obj from one of those overwrite the other. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3351005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59264 0039d316-1c4b-4281-b951-d872f2087c98
* Add CoreLocation support to Chrome.allanwoj@chromium.org2010-09-131-0/+4
| | | | | | | | | | | | | | | | | | | | | Patch from Jorge Villatoro <jorge@tomatocannon.com> This add core location support to the Geolocation code. Included are the base location provider class, a data provider class that allows CoreLocation to run on the UI thread, and an Objective C wrapper for CoreLocation. Hints were taken from the CoreWLAN Api class in the same directory for dynamically loading the framework, since CoreLocation is only available on Snow Leopard (Mac OS X 10.6) This new provider has also been added to the location arbitrator in the same way that the libgps provider was added. BUG=45548 TEST=Open the browser with the --enable-geolocation argument on 10.6 and visit http://maps.google.com/maps/m Review URL: http://codereview.chromium.org/3092015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59213 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r54723. Implement the webNavigation.onCommitted event.jochen@chromium.org2010-09-131-0/+2
| | | | | | | | | BUG=50943 TEST=ExtensionApiTest.WebNavigationEvents Review URL: http://codereview.chromium.org/3310025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59212 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 59147 - Allow overriding of X error functionsdavemoore@chromium.org2010-09-101-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | BUG=50006 (and various other reports) TEST=Run chrome under nested window manager using Xephyr (see http://code.google.com/p/chromium/wiki/LayoutTestsLinux) use --enable-logging=stderr --log-level=0 kill xephyr examine log. You should see X IO Error detected followed (not necessarily immediately) by successfully saved /tmp/tx/Default/Preferences successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Default/Preferences along with no crash. There is a high ranking crash report on both linux and chromeos that happens whenever X sends an error to chrome. This change causes us to log and continue when we get a regular error from X. When we get an IO error, indicating X is gone, we attempt to shut down gracefully. Review URL: http://codereview.chromium.org/3175038 TBR=davemoore@chromium.org Review URL: http://codereview.chromium.org/3332019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59175 0039d316-1c4b-4281-b951-d872f2087c98
* Allow overriding of X error functionsdavemoore@chromium.org2010-09-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | BUG=50006 (and various other reports) TEST=Run chrome under nested window manager using Xephyr (see http://code.google.com/p/chromium/wiki/LayoutTestsLinux) use --enable-logging=stderr --log-level=0 kill xephyr examine log. You should see X IO Error detected followed (not necessarily immediately) by successfully saved /tmp/tx/Default/Preferences successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Default/Preferences along with no crash. There is a high ranking crash report on both linux and chromeos that happens whenever X sends an error to chrome. This change causes us to log and continue when we get a regular error from X. When we get an IO error, indicating X is gone, we attempt to shut down gracefully. Review URL: http://codereview.chromium.org/3175038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59147 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-27 09:29:34 +0000