| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
non-incognito normal browser, in which case, the window also cannot be closed. if the last normal browser is closeable and user closes it or the last tab in it, if it's a incognito browser, a new non-incognito browser will be opened, else the browser stays opened with all tabs closed and a NTP opened. before-unload-handlers are also taken care of.
BUG=chromium-os:2711,chromium-os:3479,chromium-os:2568
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/2069002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/3178, crosbug.com/2884
TEST=out/Debug/browser_tests --gtest_filter=WizardControllerFlowTest.*
Review URL: http://codereview.chromium.org/2920001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is more like a boilerplate place holder.
Will add the contents in a separate change.
BUG=chromiumo-os:4573
TEST=manually
Review URL: http://codereview.chromium.org/2958003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This dialog cannot be opend from UI yet.
The execution path will be added once "Languages and Input" dialog is ready.
TEST=manually check on the netbook by uncommenting TODO lines.
BUG=chromium-os:4806
Review URL: http://codereview.chromium.org/2853032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44620 46634
TEST=Make sure the auto fill dialogs work correctly.
Review URL: http://codereview.chromium.org/2975003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromiumOS login into Sync.
This is just initial groundlaying for replacing the internal sync auth stack. IssueAuthToken is not yet used in this CL.
TEST=Run chromium OS. Login using your credentials. Verify that sync works in about:sync.
BUG=47093
Review URL: http://codereview.chromium.org/2872034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:1178 1610 2033
TEST=UpdateBrowserTest.Notifications
Review URL: http://codereview.chromium.org/2859043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The views implementation of the little things floating around in the
Omnibox uses nested views which are manually laid out by the
location-bar code. The Mac code has a variety of different
implementations for these items, with the layout distributed across
many files. This change creates something called a "decoration" which
is similar (different name because Mac has a strong sense of what a
"view" is). Decorations are kind of like a C++ NSCell, which the
AutocompleteTextFieldCell handles generically and the
LocationBarViewMac::Layout() code will lay out. The overall goal is
to loosely parallel the views code for decorations and Layout(), so
that future coders can do the right thing more easily.
This CL converts the left-hand items, namely:
- the location icon
- the search-keyword bubble
- the ev security bubble (new)
The Layout() function does not yet deal with trimming things to fit
when space is tight.
location_bar_view_mac_unittest.mm was always a sham, so I'm going to
stop pretending.
BUG=41998
TEST=EV bubble for secure sites.
TEST=location icon can be clicked (page info panel) and dragged.
TEST=EV bubble can be clicked (page info panel) and dragged.
TEST=keyword-search mode shows appropriately.
Review URL: http://codereview.chromium.org/2805070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Always mark HTML/CSS as "flattenhtml" unless not possible
* Remove resources not needed due to flattening
* Simplify dom_ui code now that most resources won't be loaded that route
The change to index.html is needed to make the flattener do the right thing (otherwise the stylesheet doesn't get inlined).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2907009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47428
TEST=none
Review URL: http://codereview.chromium.org/2965007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Missing pieces:
- Add the other tabs besides the first two.
- The tab switching mechanism might need some work (it definitely needs to look better, and perhaps should also work with the back/forward buttons).
- none of the <button>s work
- I added the Content Settings page as one of the main options pages for now, but in the end it should show up when a user clicks the "Content Settings..." button in Under the Hood.
There is a bit of extra code because content settings don't use prefs, so I had to sort of replicate the pref_ui code.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/2804039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prefs, to manage preferences set by extensions.
Update various callers of the PrefValueStore constructor accordingly.
The initial user will be the proxy extension API.
BUG=266
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/2823037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
UI only, not integrated into OOBE yet.
BUG= http://crosbug.com/4645
TEST=--login-screen=register should show wizard screen with about: page.
Review URL: http://codereview.chromium.org/2924010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 52054 - Refactor json automation interface for pyauto hooks.
Reduces the number of lines you need to add per new automation hook. Shaves
off several lines of code.
Refactor pyauto.py to obviate raising exception in case the json interfaces produces an error string.
Review URL: http://codereview.chromium.org/2898001
TBR=nirnimesh@chromium.org
Review URL: http://codereview.chromium.org/2977001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reduces the number of lines you need to add per new automation hook. Shaves
off several lines of code.
Refactor pyauto.py to obviate raising exception in case the json interfaces produces an error string.
Review URL: http://codereview.chromium.org/2898001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used to implement 3605. I created separate notification as we're planning to port to other platfrom.
BUG=chromium-os:3605
TEST=added browser test
Review URL: http://codereview.chromium.org/2913001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2812043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/48114
TEST=none (depends on bug 47428)
Review URL: http://codereview.chromium.org/2949002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in order to fully support Windows screenreaders.
Note: it makes sense to check these files into third_party
directly (rather than pull from Mozilla's repository) because
(1) they're very small (under 500 lines total), and
(2) they're stable and unlikely to change frequently.
BUG=48185
TEST=none
Review URL: http://codereview.chromium.org/2802031
TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/2873043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This abstracts away the platform-specific certificate viewer behind a common
function call.
R=wtc,mattm
BUG=none
TEST=Viewing the certificate information on an SSL session continues to work
Review URL: http://codereview.chromium.org/2815024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A new ClipboardDispatcher interface has been added to handle the IPC calls. The new methods don't really belong on the existing Clipboard class, since that class deals with only copy and paste. On Windows and Mac, ClipboardDispatcher will share logic for copy/paste and drag/drop. GTK will have to use two separate code paths.
BUG=31037
TEST=none
Review URL: http://codereview.chromium.org/2842016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hold the reload button state change from stop to reload until the
mouse exits. Also short-circuit the stop message when the real state
should be reload. Also prevent multi-clicks from sending multiple
actions.
Toolbar.xib: reload button made kind of ReloadButton.
BUG=47184
TEST=Browse to a slow page, mouse over stop button. Should not go to reload button when throbber (in tab) stops.
TEST=After page loaded, click stop. Should not crash.
TEST=Hover over reload button. Command-r should start a reload and change the button to stop button.
Review URL: http://codereview.chromium.org/2847051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Right now the accessibility tree is shipped over at page load, so this doesn't account for any changes to the html, or scrolling/resizing.
BUG=27112
TEST=Use accessibility inspector to inspect various elements of the webpage.
Review URL: http://codereview.chromium.org/2642001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- All checkboxes are functional, partial functionality for buttons.
- Download path controls TBD.
- Security SSL checkboxes on non-Mac platform TBD.
- Added placeholder files for Browser and Personal option panels.
- Moved placeholder CSS into a new options_page.css file.
- Unit testing TBD.
BUG=48482
TEST=Launch browser with --enable-tabbed-options and bring up options window.
Review URL: http://codereview.chromium.org/2830036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none (or is there?)
TEST=trybots and tests
Review URL: http://codereview.chromium.org/2234006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change will move all the audio device methods calls to
AudioController so we can move all the audio related methods calls off the IO
thread. This change will let AudioRendererHost to use the AudioController API.
This involves rewriting the whole AudioRendererHost.
After this patch we can implement proper pause operations that is only possible
if they are hosted on a separated thread due to their blocking nature.
Normal latency mode is fully covered by unit tests, including audio control
operations and data conversation.
Low latency mode using SyncSocket is tested only for stream creation and still
need to handle cases during shutdown when we want SyncSocket to return
immediately.
TEST=unit_tests --gtest_filter=AudioRendererTest.*
BUG=39885
Review URL: http://codereview.chromium.org/2850016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2800035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=open New Tab page, see thumbnails. Same with chrome --top-sites.
Review URL: http://codereview.chromium.org/2815045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in order to fully support Windows screenreaders.
Note: it makes sense to check these files into third_party
directly (rather than pull from Mozilla's repository) because
(1) they're very small (under 500 lines total), and
(2) they're stable and unlikely to change frequently.
BUG=48185
TEST=none
Review URL: http://codereview.chromium.org/2802031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43423
TEST=box_layout_unittest.cc, manual UI tests.
Review URL: http://codereview.chromium.org/2738002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/323
TEST=Manual. Change password for the account that was previously logged on the device. Observe dialog box.
Review URL: http://codereview.chromium.org/2834041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserChildProcessHost with browser-specific implementation. This is in preparation of creating a ServiceChildProcessHost.
BUG=None
TEST=Test for regressions .
Review URL: http://codereview.chromium.org/2885017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This about page was only being enabled for non-official windows builds as its UI wasn't cross platform.
Its functionality is now superceded by about:net-internals (which works cross platform and is enabled for all builds).
In fact at some point we might consider renaming about:net-internals to about:network.
BUG=25557
Review URL: http://codereview.chromium.org/2814047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will enable chrome to display all cookies used/blocked on the current site to the user instead of just the information that something was blocked. The cookies are collected in data structures suitable for displaying them using the cookies tree model.
BUG=45230
TEST=none
Review URL: http://codereview.chromium.org/2370001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16932
TEST=compiles
Review URL: http://codereview.chromium.org/2862041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-landing patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910,47858
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups. Also, if the internal PDF plugin is enabled, it should stay enabled after a restart.
Review URL: http://codereview.chromium.org/2811037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also allow for editing them...
The XIB change adds a column at the end of the table with a NSCheckboxCell in it and the title IDS_EXCEPTIONS_OTR_HEADER
BUG=44480
TEST=manual
Review URL: http://codereview.chromium.org/2858032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of leftover references to "merge and sync."
BUG=48125
TEST=Start up sync, change data types, stop sync, etc, nothing should break.
Review URL: http://codereview.chromium.org/2843019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switching to the new TranslateManager code (renaming TranslateManager2 to TranslateManager and similarly for all similar classes).
Original review:
http://codereview.chromium.org/2825032/show
BUG=40828
TEST=Make sure translate still works as expected on all platforms.
Review URL: http://codereview.chromium.org/2885015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
radius of the close button hover state circle a bit.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2833050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Methods stubbed out for now, and not used anywhere yet.
BUG=45547
TEST=none
Review URL: http://codereview.chromium.org/2847041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=--bookmark-menu no longer does anything
Review URL: http://codereview.chromium.org/2853024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically,
geolocation_exceptions_window_controller => simple_content_exceptions_window_controller (mac)
geolocation_exceptions_view => simple_content_exceptions_view (win)
geolocation_content_exceptions_window => simple_content_exceptions_window (linux)
It's now easy to use it to show desktop notification exceptions as well.
No functionality change.
BUG=45547
TEST=geolocation exceptions dialog still works
Review URL: http://codereview.chromium.org/2835031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2850038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
derive from it.
No functionality change.
This will be used to share the content settings exceptions dialog code between geolocation and notifications.
BUG=45547
Review URL: http://codereview.chromium.org/2838037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the download shelf and other places. Delete the original pdfs. This is in line with the new top chrome refresh.
BUG=44574
TEST=none
Review URL: http://codereview.chromium.org/2805055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for RLZ chrome extension api.
BUG=None
TEST=See unit tests as part of this CL.
Review URL: http://codereview.chromium.org/2864024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remnants of shipping address and CVV.
BUG=47426,47423
TEST=PersonalDataManager.*
Review URL: http://codereview.chromium.org/2818033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(instead of a preference) to save the timezone.
BUG=chromium-os:1025
TEST=ClockMenuButtonTest
Review URL: http://codereview.chromium.org/2828024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=build and ran with chromeos-wm
BUG=chromium-os:2866, chromium-os:2867
Review URL: http://codereview.chromium.org/2857005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51305 0039d316-1c4b-4281-b951-d872f2087c98
|