| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=521
TEST=none
Review URL: http://codereview.chromium.org/1079007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Functionality protected behind --in-chrome-auth flag.
TEST=unittests, also run on Chromium OS with --in-chrome-auth flag. Log in should work.
Review URL: http://codereview.chromium.org/1026001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HostContentSettingsMap.
This was originally written by bulach and posted at http://codereview.chromium.org/1033004 ; modified and landed by me.
BUG=37206
TEST=Tested by unittests
TBR=bulach,joth
Review URL: http://codereview.chromium.org/1084005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I also sorted the files alphabetically.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1145002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Known issues:
o The ordering of the Browser Actions is not consistent within the menu.
o Icons for the actions within the menu are not implemented yet.
o It is a standard NSMenu, so drag and drop will not work and right click does not work for now.
TEST=none
BUG=32101
Review URL: http://codereview.chromium.org/1083001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, cross-platform: eschew RenderViewHostDelegate:BookmarkDrag::DragData type in favor of BookmarkDragData.
BUG=37702
TEST=manual
Review URL: http://codereview.chromium.org/1029004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
restore.
BUG=23613
TEST=turn off session restore, pin a tab, restart chrome and make sure
you get back the pinned tab.
Review URL: http://codereview.chromium.org/1026005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored code so that the class that encapsulates cookies details
is shared between the cookie tree and cookie prompt on the mac.
xib changes: Fixed the bindings in all of the subviews in the details view to use the new shared details class. Also added a currently hidden popup menu for selecting the cookie expiration time in the prompt details view--this needs to be wired up in a separate CL.
BUG=http://crbug.com/38348
TEST=added unit tests for the new class, manual testing of cookie tree and cookie prompt dialog
Review URL: http://codereview.chromium.org/1025003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=AutoFillQueryXmlParserTest
Review URL: http://codereview.chromium.org/1014008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/896001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Actions container.
TEST=none
BUG=32101
Review URL: http://codereview.chromium.org/1037007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Original review: http://codereview.chromium.org/882003
Review URL: http://codereview.chromium.org/1042004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the "mystery target" solution from the last CL, move everything into
chrome_browser.gypi and have the browser target dependent on
component_extensions.
Fixes the confusion introduced in http://codereview.chromium.org/775001/show
Review URL: http://codereview.chromium.org/985005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The primary change in this CL is a refactor which makes ExtensionPopup a bit more self-contained WRT its clients. It adds the ability to specify an "inspect_with_devtools" flag to its Show() method which will cause the popup to remain open regardless of losing focus and to focus a devtools window on the popup's render view host.
This CL also pulls apart some aspects of the extension_popup_api from ExtensionFunctionDispatcher and ExtensionHost.
Still remaining to be done are:
1) Also the popup to stay open when the host window drags (it current closes)
2) Support for GTK
3) Support for Mac
BUG=24477
Review URL: http://codereview.chromium.org/1001002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally described here:
http://code.google.com/p/chromium/wiki/InfoBarExtensionAPI
The API is simple:
chrome.experimental.infoBar.show(
{"htmlPath": "infobar.html"}, function(window) {
// |window| is where the infobar was shown.
});
To close it, you can simply call window.close() from within the InfoBar (infoBar.hide is not provided).
The api is privileged (not available to content scripts directly).
The minimum height for the infobar is regular height for our infobars (32 pixels), maximum is twice that and the actual size is determined by the content (within these constraints mentioned).
See screenshot in bug. The icon on the far left is an extension icon with a dropdown menu showing the menu that shows when you right-click on the extension icon in the Omnibox/browser action container.
BUG=26463
TEST=None (for now).
Review URL: http://codereview.chromium.org/1049001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added AddSystemNotification to add system notification
and UpdateNotification to update a notification.
* refactored NotificationObjectProxy and added NotificationDelegate class.
* Added notification_browser.cc.
BUG=33306
TEST=added notification_browser.cc with minimal test. I'll add more in next step.
Review URL: http://codereview.chromium.org/1013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now it is bound to the temporary URL "chrome://net2", since the frontend is under construction.
(Loading this page right now just shows a dummy HTML page.)
This change is a first step to transitioning the about:net-internals / about:network pages from C++ to javascript.
Note that the network stuff needs to run on the IO thread, however the DOMUI infrastructure is all set up to run on the UI thread.
I work around this by proxying things back and forth through the IO thread. Hopefully in subsequent iterations this overhead can be removed, by exposing a sort of "IO thread DOMUI".
BUG=37421
Review URL: http://codereview.chromium.org/1036001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
IBus IME engines send some strings written in English (e.g. IME names and IME property names) to its language bar module (i.e. Chrome). This change adds a function that converts the english string into a Chrome's resource ID, then converts the ID into a localized string, and returns it.
BUG=crosbug.com/1699
TEST=run the unittest
Review URL: http://codereview.chromium.org/948001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
event stream (NetLog).
This makes it possible to associate a single NetLog with a URLRequestContext, and then attach observers to that log to watch the stream of events.
This changelist attempts to do the most direct translation, so there will be subsequent iterations to clean up.
The user-visible behavior should remain unchanged.
BUG=37421
Review URL: http://codereview.chromium.org/848006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Tests=ExtensionApiTest.Idle
Bug=one
Review URL: http://codereview.chromium.org/845005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We'll have a separate dialog for each input method that has settings.
Review URL: http://codereview.chromium.org/889002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
it from using MessageLoop to post tasks to using
ChromeThread::PostTask, which is safer.
Review URL: http://codereview.chromium.org/864001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
defualt and hidden behind a switch.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/906001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Purely cleanup, no functional changes.
Review URL: http://codereview.chromium.org/855003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NetworkManager
NOTE: Adds a new build dependency on dbus-glib, on ubuntu you can meet this with:
$ sudo aptitude install dbus-glib-1-dev
BUG=http://crbug.com/37199
TEST=use browser with --enable-geolocation
Review URL: http://codereview.chromium.org/787003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added two new xibs. The first is a cookie info view that is shared between the tree that shows browser data and the cookie modal prompt to block accepting cookies. The second is a window to replace the NSAlert modal dialog for the cookie prompt. Modified cookie tree code and added cookie prompt code to use new xibs.
Changed "hidden" handling of cookie detail view to use bindings rather than explicit code.
TODOs for http://crbug.com/36948 not in this CL:
- changing the expiration for cookies isn't implemented
TEST=manually testing of modal cookie prompt, new unit tests
BUG=http://crbug.com/36948
Review URL: http://codereview.chromium.org/669127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
was including files from chrome and only used in
chrome/browser/renderer_host, so it should live in src/chrome/.
TEST=compiles
Review URL: http://codereview.chromium.org/852001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mainichi.jp (from an English profile).
BUG=36714,37528
TEST=Open up a page that's not in your current language. You should be presented with a toolbar offering to apply Google Translate to the page.
Review URL: http://codereview.chromium.org/830005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TODO: persist the size of the browser actions container to the profile.
TODO: implement the overflow menu.
BUG=32101
TEST=manual
Review URL: http://codereview.chromium.org/800003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
handle offline login.
TEST=Unittests, and also run on chromium OS device with --in-chrome-auth
Review URL: http://codereview.chromium.org/822006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. background window containing the status and visual background.
. WizardController creates it's own window for showing the various
wizard dialogs.
I needed to separate these two out as if you have logged in once I
still want the background, and may end up showing the
wizardcontrollers later.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/832002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
if the user selects a file via the filebrowser.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/749001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change integrates the custom AeroPeek implementation into Chromium, which shows the thumbnail list of all tabs and the preview image of the tab selected from the thumbnail list. It uses the AeroPeekManager object, which is a proxy between TabStripModel and Windows to translate events from TabStripModel for Windows, and vice versa. To listen events from TabStripModel without changing the existing part of Chromium, this AeroPeekManager class implements the TabStripModelObserver interface.
Even though this change doesn't include any automated tests for AeroPeek, I would like to send its automated UI test as a separate change. Nevertheless, it just creates/deletes a tab and see this AeroPeekManager can create its thumbnail window correctly.
BUG=6337
TEST=base_unittests.exe --gtest_filter=ScopedNativeLibrary.Basic
Review URL: http://codereview.chromium.org/303033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also refactor FirstRunTabs to use GURL instead of wstring.
BUG=none
TEST=Add master_preferences file to directory containing the chrome binary and
execute chrome with the --first-run option.
Original patch by bgmerrell@gmail.com at
http://codereview.chromium.org/551160
Review URL: http://codereview.chromium.org/796001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Changes to add basic automation proxy support to chromeos login wizard
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/783003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2. Adjust transparency of background tabs a little.
3. Implement loading animation for side tabs.
4. Deeper shadow for side tabstrip between browser view and side tabstrip.
http://crbug.com/34509
TEST=none
Review URL: http://codereview.chromium.org/610002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implements Mac Address Book "me" card integration with AutoFill feature. When the kAutoFillAuxiliaryProfilesEnabled preference is enabled, via the AutoFill preferences dialog, the active user's designated "me" card becomes available to AutoFill. That is, forms become aware of any name, address, email, and telephone number information residing in the user's "me" card. Small change to AutoFillDialog.xib to resize the preference check-box label width to accommodate new string.
BUG=36496
TEST=PersonalDataManagerTest
Review URL: http://codereview.chromium.org/668247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/668075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Just move the code. No logic is changed.
This is the first step towards implmenting the input language settings.
TEST=manually
BUG=none
Review URL: http://codereview.chromium.org/668061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
breaks dependencies on chrome from webkit, app, views
and base.
BUG=37649
TEST=compiles
Review URL: http://codereview.chromium.org/699001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18119
TEST=Export some certs, compare files with exports from firefox.
Review URL: http://codereview.chromium.org/669137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=greens the tree
TBR=tony
Review URL: http://codereview.chromium.org/689003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Similar to the previous patch for CustomButtons.
BUG=36760
TEST=manual
Review URL: http://codereview.chromium.org/676001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Errors:
out/Release/obj.target/chrome/libbrowser.so: undefined reference to
`BalloonCollectionImpl::Layout::InterBalloonMargin() const'
out/Release/obj.target/chrome/libbrowser.so: undefined reference to
`BalloonCollectionImpl::Layout::VerticalEdgeMargin() const'
out/Release/obj.target/chrome/libbrowser.so: undefined reference to
`BalloonCollectionImpl::MakeBalloon(Notification const&, Profile*)'
out/Release/obj.target/chrome/libbrowser.so: undefined reference to
`BalloonCollectionImpl::Layout::HorizontalEdgeMargin() const'
BUG=None
TEST=compile and out/Debug/chrome
Patch by Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/668218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37198
TEST=Run browser with --enable-geolocation on OSX 10.6, open maps.google.com
Review URL: http://codereview.chromium.org/669083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enabled with the --enable-user-stylesheet flag which
causes chrome to read
<user-data-dir>/<profile>/User StyleSheet/Custom.css
at startup and set it as the user style sheet.
This version never reloads the user style sheet, I'll
have to bring back FileWatcher for that. I also put the user
stylesheet in a subdir because the implementation of
FileWatcher will watch the parent dir (this is what the OS
apis give me) and watching the profile dir will cause
lots of activity.
BUG=2393
Review URL: http://codereview.chromium.org/660349
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/660139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added Mac implementation of StatusIcon, and added a simple click callback that
displays the "extensions" tab when clicked on, to allow us to dogfood long-lived
extensions.
BUG=37375
Review URL: http://codereview.chromium.org/661454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved OOBE views classes to the chromeos namespace.
BUG=35249
TEST=run out/Debug/chrome --login-manager --login-screen=update
TBR=denisromanov
(Checking in patch for Denis Romanov, previously reviewed here:
http://codereview.chromium.org/669089/show)
Review URL: http://codereview.chromium.org/669241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40842 0039d316-1c4b-4281-b951-d872f2087c98
|