| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
classes defined within.
BUG=None
TEST=existing unit_tests.
Review URL: http://codereview.chromium.org/6612008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the XIB in favor of doing programmatic drawing.
As a side effect of not having a titlebar, the window will no longer be eligible
to take key status (fixing crbug.com/74813).
BUG=74813
TEST=Visual
Review URL: http://codereview.chromium.org/6612019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for multi-profile UI before back end is hooked in.
BUG=74731
TEST=none
Review URL: http://codereview.chromium.org/6610015
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/6610028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
multi-profile UI before back end is hooked in.
BUG=74731
TEST=none
Review URL: http://codereview.chromium.org/6610015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I will be doing some refactoring that will change the way pending extension records for a single extension ID are merged. This change will make PendingExtensionInfo a class with nontrivial member functions. As a first step, this change moves PendingExtensionInfo into its own file.
Fixing crbug.com/61000 by merging pending requests is an example of the changes that will add members to class PendingExtensionInfo.
I changed the type ShouldInstallExtensionPredicate to PendingExtensionInfo::ShouldAllowInstallPredicate. I wanted to get the type defined inside the class, and changing the name avoids some ugly 80-colunm gymnastics because it is slightly shorter.
BUG=None
TEST=ExtensionServiceTest.*
Review URL: http://codereview.chromium.org/6579005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
defined within, so that each piece is shorter and clearer.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6598057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move this function to importer_progress_dialog.h
- Rename it ShowImportProgressDialog.
- Put it under the importer namespace (so the callers can know where it comes from).
- Reorder the parameters to be more easy to read.
- Remove some using declarations.
BUG=None
TEST=importer unit tests and importing works as before.
Review URL: http://codereview.chromium.org/6597095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
logic when the user tries to launch the app. This also adds a chrome://extension-icon endpoint that provides easy access to extension and app icons.
BUG=61270
TEST=ExtensionIconSourceTest.IconsLoaded
Review URL: http://codereview.chromium.org/6495002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the WATCHDOG thread that monitors browser threads for their
responsiveness using ping-pong messaging. WACTHDOG thread also
collects statistics for response time for each thread via histograms.
This CL was approved http://codereview.chromium.org/6588039
BUG=71378, 73915, 73844, 73975
TEST=performance tests
TBR=jar
Review URL: http://codereview.chromium.org/6591091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=71378,73915,73844,73975
TEST=performance tests
Review URL: http://codereview.chromium.org/6588039
TBR=rtenneti@chromium.org
Review URL: http://codereview.chromium.org/6597088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71378,73915,73844,73975
TEST=performance tests
Review URL: http://codereview.chromium.org/6588039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/ui/views/bookmarks/ directory.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6594067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Lay out ConfirmInfoBar as per current UI guidelines (bug 39102)
* Remove now-unnecessary dedicated autofill infobar, which implemented correct infobar layout only for autofill, since the default ConfirmInfoBar is now correct
* ConfirmInfoBar: Don't create OK/Cancel buttons or link at all when not needed (bug 27832)
* Add child views when the infobar is first made part of the view hierarchy rather than at construction (simplifies ownership, matches standard implementation pattern)
* Translate infobars: Create language menus at construction rather than on demand (simpler code)
* Elide text elements as infobar width shrinks
* ...but, stop layout changes for infobar content when the infobar reaches a minimum width (i.e. don't drop buttons atop each other)
* Remove now-unnecessary hardcoded 30 px. space on the right side of the ExtensionInfoBar in favor of the new and more-accurate InfoBarView::EndX()
* Make ExtensionInfoBar menu animate down properly during infobar creation by calling OffsetY() instead of hardcoding a division by 2
* Remove erroneous -1s when setting ExtensionView bounds
* Fix calls to InfoBarAnimated() always getting |completed| reversed
BUG=27832, 39102
TEST=ConfirmInfoBars should put buttons on left by text and link on right by close button
Review URL: http://codereview.chromium.org/6596058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes no logic changes.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6596040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73903
TEST=tests for proxy and webrequest API should still work
Review URL: http://codereview.chromium.org/6598002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/ui/gtk/bookmarks/ directory.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6598026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is going to be used for MHTML support.
BUG=30863
TEST=Run the unit-tests.
Review URL: http://codereview.chromium.org/6542069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
situation happens if you focus the omnibox and press the down
arrow. As part of this I consolidated the code for upading instant to
the LocationBar. I didn't want to put this in the instant code as I'm
trying to make instant know as little as possible about autocomplete.
BUG=73407
TEST=see bug
Review URL: http://codereview.chromium.org/6597023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/6592041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
dialog is opened.
BUG=56846
TEST=Verify that the font lists load properly in the font settings window.
Review URL: http://codereview.chromium.org/6575015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles with chromeos=1 library=shared_library
Review URL: http://codereview.chromium.org/6596046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
printing_message_filter.
Created a new BrowserMessageFilter to handle print related IPC messages.
Associated review at: http://codereview.chromium.org/6546051/
BUG=none
TEST=printing works after code changes.
Review URL: http://codereview.chromium.org/6592018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
carving in some places. i.e. geolocation_permission_context.h needs to split into the interface part and the implementation part. access_token_store.h needs to drop the chrome factory function. arbitrator_dependency_factory.h needs to be split up into the interface and the default implementation. I've left all this to future changes per the other file moves, and since this is already pretty large.TBR=joth
Review URL: http://codereview.chromium.org/6591034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change list is same as CL 6588039.
BUG=73915
Review URL: http://codereview.chromium.org/6602004
TBR=rtenneti@chromium.org
Review URL: http://codereview.chromium.org/6591035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change list is same as CL 6588039.
Will back out immediately.
BUG=73915
Review URL: http://codereview.chromium.org/6602004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/ui/webui. Final Part.
BUG=59946
TEST=trybots
Review URL: http://codereview.chromium.org/6594035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm moving the files I have found with:
$ ls chrome/browser/webui | grep _ui
BUG=59946
TEST=trybots
Review URL: http://codereview.chromium.org/6599024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change list is same as CL 6588039.
Will back out immediately.
http://codereview.chromium.org/6588039/
Review URL: http://codereview.chromium.org/6594032
TBR=rtenneti@chromium.org
Review URL: http://codereview.chromium.org/6588041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change list is same as CL 6588039.
Will back out immediately.
http://codereview.chromium.org/6588039/
Review URL: http://codereview.chromium.org/6594032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=satish
Review URL: http://codereview.chromium.org/6591024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59946
TEST=trybots
Review URL: http://codereview.chromium.org/6588037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
will revert the changes right away. trying to test
impact on memory on mac.
BUG=73915
TEST=performance tests
Review URL: http://codereview.chromium.org/6598021
TBR=rtenneti@chromium.org
Review URL: http://codereview.chromium.org/6598022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
will revert the changes right away. trying to test
impact on memory on mac.
BUG=73915
TEST=performance tests
Review URL: http://codereview.chromium.org/6598021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reverting the revert.
will revert the changes right away. trying to test
impact on memory on mac.
BUG=73915
TEST=performance tests
Review URL: http://codereview.chromium.org/6594011
TBR=rtenneti@chromium.org
Review URL: http://codereview.chromium.org/6588038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reverting the revert.
will revert the changes right away. trying to test
impact on memory on mac.
BUG=73915
TEST=performance tests
Review URL: http://codereview.chromium.org/6594011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allows us to blacklist bad GPU/drivers as soon as we discover them.
Note that this patch does not turn the auto update on. We will turn it on in a separate CL.
Reland this patch after fixing a bug causing a XP test failure.
BUG=68802
TEST=bots green
TBR=kbr
Review URL: http://codereview.chromium.org/6588035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead move the methods into browser_dialogs.h and rename them.
ShowForTabContents -> ShowHungRendererDialog
HideForTabContents -> HideHungRendererDialog.
BUG=None
TEST=compiled locally and trybots
Review URL: http://codereview.chromium.org/6588002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The whole thing is still behind a flag.
The download_file_manager will start a url check with safebrowsing. It goes parallel with file creation operation. When url is checked to be dangerous, the UI dialog will show the dialog.
TEST=download_manager_unittest
BUG=60822
Review URL: http://codereview.chromium.org/6410050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UITestCanLaunchWithOSMesa. Will unrevert if proven innocent.]
Revert 76075 - With this CL, GPU blacklist auto update from the web (before it ships together with chrome) is implemented. This allows us to blacklist bad GPU/drivers as soon as we discover them.
Note that this patch does not turn the auto update on. We will turn it on in a separate CL.
BUG=68802
TEST=build bots all green
Review URL: http://codereview.chromium.org/6469094
TBR=zmo@google.com
Review URL: http://codereview.chromium.org/6599020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
country.
* Changes the country field to a <select> field.
* Restricts the possible values for the "country" field to a set of known values
* Moves the country field to the top of the Autofill dialog
* Changes the field labels according to the selected country
BUG=56599,56602,56604
TEST=
Review URL: http://codereview.chromium.org/6484022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IPC messages.
Move print related IPC message handlers from render_message_filter to printing_message_filter.
BUG=none
TEST=printing works after code changes.
Review URL: http://codereview.chromium.org/6546051
TBR=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/6588015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
together with chrome) is implemented. This allows us to blacklist bad GPU/drivers as soon as we discover them.
Note that this patch does not turn the auto update on. We will turn it on in a separate CL.
BUG=68802
TEST=build bots all green
Review URL: http://codereview.chromium.org/6469094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move print related IPC message handlers from render_message_filter to printing_message_filter.
BUG=none
TEST=printing works after code changes.
Review URL: http://codereview.chromium.org/6546051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function was implemented for mac and win in the chrome_main_xxx files because it was used only by the UserDataDir policy until now. However we need this in the DownloadDirectory policy too so I extracted in in a more
global way in the policy::path_parser namespace.
BUG=None
TEST=unit_tests:PolicyPathParser.*
Review URL: http://codereview.chromium.org/6469081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content/browser/webui.
BUG=59946
TEST=trybots
Review URL: http://codereview.chromium.org/6575054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
defined within, so that each piece is shorter and clearer.
BUG=None
TEST=compiled locally and trybots
Review URL: http://codereview.chromium.org/6541045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73915
TEST=performance tests
Review URL: http://codereview.chromium.org/6578033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/ui/views/importer/ directory.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6580023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
to content\browser.
TBR=avi
Review URL: http://codereview.chromium.org/6586001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on Views accessibility for everything.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6501003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75922 0039d316-1c4b-4281-b951-d872f2087c98
|