| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/656011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional.
BUG=34894
TEST=Go to Preferences->under the hood->content settings->cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39756
Review URL: http://codereview.chromium.org/650206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36512
TEST=drag a file out of the downloads page
Review URL: http://codereview.chromium.org/657026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional.
BUG=34894
TEST=Go to Preferences>under the hood>content settings>cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim.
Review URL: http://codereview.chromium.org/650206
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/652150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional.
BUG=34894
TEST=Go to Preferences->under the hood->content settings->cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim.
Review URL: http://codereview.chromium.org/650206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes compilation errors on Karmic, where dlopen() and friends were undefined:
http://chrome-buildbot.corp.google.com:8016/builders/Chromium%20Linux%20Builder%20(dbg-shlib)/builds/7777/steps/compile/logs/stdio
The missing '-ldl' is papered over on Hardy because pretty much everything
depends on gtk, which brings that in through pkg-config, but pkg-config gtk
no longer includes '-ldl' on Karmic.
Review URL: http://codereview.chromium.org/656014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
bar/status bubble in unthemed incognito mode.
BUG=http://crbug.com/35554 ; http://crbug.com/29845
TEST=no visible change in normal mode; themed incognito windows should look ugly still but in a different way
Review URL: http://codereview.chromium.org/650092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to further reduce bad dependencies on chrome/browser.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/652051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Introduced NormalBrowserFrameView, which can place OTR avatar icon in the right place.
- This is based on OpaqueBrowserFrameView, but a lot of stuff that are unnecessary in ChromeOS has been removed.
- Moved OTR Avatar icon view to BrowserView for now as this is much simpler to implement the above change. I'll revisit the possibility to refactor layout code to GetBoundsForXXX later.
* removed most of browser extender stuff.
BUG=chromium-os:1007
TEST=open incognito window and switch to compact navigation mode (ctrl-shift-c). incognito icon should be placed between
tabstrip and status area.
Review URL: http://codereview.chromium.org/593098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/650097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/572020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WmIpc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/646079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles on bots
Review URL: http://codereview.chromium.org/619008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also introduce scaffolding for the actual content settings dialog.
xib changes:
+ Personal stuff
* Move "Clear browsing data" button to under the hood tab
* Move themes stuff up a bit to cover hole left by missing button
+ under the hood:
* Created "Content Settings..." button
* Got rid of cookie settings
* Moved stuff around
+ clear data:
* Added horizontal rule and flash player settings link, linked its action to
new method.
+ content settings:
* Added mostly empty window that contains "This is not implemented yet" label and a button that shows cookies (since I removed that from the prefs, so that it's still available). This window will be fleshed out very soon (in my next CL).
* The window _is_ set up for l10n
+ bubble xibs:
* Enable "Manage" links now that they open a window
Four screenshots at http://imgur.com/axGiR&78O8g&wgk3p&6oOHj
BUG=34656,34894
TEST="Clear data" button has moved from "Personal Stuff" to "Under the hood" in prefs. There's a "Content Settings" button next to it that opens a mostly empty window. The "Clear data" dialog now has a link to flash's privacy settings (which hang if one has the AdThwart extension installed, heh).
Review URL: http://codereview.chromium.org/650124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two screenshots at http://imgur.com/5NDoC&pJJwP .
xib changes: All 5 xibs contain a window of type InfoBubbleWindow with a custom InfoBubbleView. The view is connected to the controller's |bubble_| outlet. The controller is the window's |delegate|, and the window is the controller's |window|. The window is not visible at launch. It autorecalculates its key view loop. For the non-cookie xibs, the two buttons at the bottom are in GTMWidthBasedTweakers.
Issues:
* Clicking "blocked" icon with open bubble doesn't close the bubble
BUG=35594,34894
TEST=Go to popuptest.com, start test. Click "Popups blocked" icon in omnibox. Bubble should appear. It should look sane in multiple locales (I tried English and German). The left button and the radio buttons are disabled at the moment, but the close button and the popup links should be functional.
Review URL: http://codereview.chromium.org/650073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35178
TEST=none
Review URL: http://codereview.chromium.org/646060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=39374
Initial Geolocation implementation
Adds IPC plumbing.
Adds Infobar buttons for requesting permission
This change specifically:
ui_test_utils::WaitForAppModalDialog registers for listening to notifications too late, i.e., after the dialog had been triggered.
Exposes AppModalDialogObserver so that we can register, trigger the dialog, then wait for it.
Review URL: http://codereview.chromium.org/647048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to chrome/browser.
This is a part of an effort to remove bad dependency of chrome/common
on chrome/browser.
TEST=unit_tests and ui_tests, just moving code
BUG=none
Review URL: http://codereview.chromium.org/621004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This includes sending an existing identity cert, and asking the user which cert to use. Doesn't yet handle SSL renegotiation, or key-gen.
BUG=16831
TEST=none
Review URL: http://codereview.chromium.org/604067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds IPC plumbing.
Adds Infobar buttons for requesting permission
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/548188
TBR=bulach@chromium.org
Review URL: http://codereview.chromium.org/646027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds IPC plumbing.
Adds Infobar buttons for requesting permission
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/548188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First we have to allow the regular initialization to happen.
This will permit the login wizard screens to use the network
and rendering capabilities of chrome safely. Once a user logs in
and cros mounts their encrypted directory as a profile, we
change the default profile to that one and create a new browser
window with it as well. This ought to make launching the
first browser window even faster.
Review URL: http://codereview.chromium.org/604052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
token store (as it integrates with browser singletons)
Fixes a few bugs discovered along the way, and make large-ish redesign of the access token API in order to allow sane use with threading restrictions.
BUG=None
TEST=unit_tests.exe --gtest_filter=Geol* --gtest_repeat=10000 --gtest_break_on_failure
Review URL: http://codereview.chromium.org/600141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for local storage.
BUG=34628
TEST=none
Review URL: http://codereview.chromium.org/605028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/608016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where the form is embedded within an NSScrollView. Also, when a disclosure view closes, its "content" should be disabled from the point-of-view of receiving tabbing focus.
Nib file changes add the new |detailsView_| outlet to disclosure views. Also changed text fields to AutoFillTextFields to pick up auto-scrolling behavior.
BUG=33029
TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.*
Review URL: http://codereview.chromium.org/606067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/593111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes a bunch of NOTIMPLEMENTEDs and stub files,
moving them to a different place.
TEST=it compiles
Review URL: http://codereview.chromium.org/594057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
persistence (via local state prefs)
BUG=11246
TEST=unit_tests.exe --gtest_filer=Geoloc*
Review URL: http://codereview.chromium.org/603040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35016
TEST=With --login-manager=network screen should be shown. Ethernet and Wifi networks are shown and could be selected.
Review URL: http://codereview.chromium.org/597046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The demise of temp scaffolding has left the shared build in
an unhappy state where the compiler complains about vtable
issues with PrintJob because only half the class is implemented.
Fix this by compiling some more printing files on linux and
stubbing out AskUserForSettings.
BUG=none
TEST=linux shared build compiles. Other builds still ok too.
Review URL: http://codereview.chromium.org/598066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Not actually hooked up to the options dialog since it doesn't do anything useful yet.
BUG=19991
TEST=none
Review URL: http://codereview.chromium.org/593076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Made Init in BrowserFrameGtk virtual so that chromeos can use it's own frame view.
- Introduced BrowserFrameChromeos (which is currently empty)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/606014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a page and are navigating to a new page in the same language by
clicking a link, the new page is automatically translated.
In order to do that I moved the language state from the navigation
entry to some dedicated class that each TabContents owns.
Also added some basic unit-testing for good measure.
BUG=35477
TEST=See bug steps. Run unit-tests.
Review URL: http://codereview.chromium.org/596092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
exceptions page.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/597051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
actual key and value. Unfortunately, we're going to have to abuse cookie strings for 4.1 Once this goes in, I'll add new strings for the actual fields.
This also cleans up the code some.
TEST=Instead of size/modified information you'll see "name" and "content" in the dialog that comes up when asking whether to allow local storage.
BUG=none
Review URL: http://codereview.chromium.org/597061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- DEPS roll to pick up new GTM without GTMTheme
- GTMTheme within chrome until someone gets the cycles to completely remove it and use the core chrome theme objects
- Update all the includes of GTMTheme for the new copy.
BUG=35554
TEST=everything still builds/works
Review URL: http://codereview.chromium.org/596095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=35543
TEST=everything still builds and works
Review URL: http://codereview.chromium.org/606002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hooked up to the back end yet. The UI demonstrates manipulation of one address and one credit card record. Eventually buttons will be added to add and remove additional records. The additions in this CL are:
- Preferences dialog has a new "Change autofill settings" button that triggers an autofill settings dialog.
- The autofill settings dialog now exists and allows the user to manipulate form autofill data. Specifically address information and credit card information.
- Each address or credit card record is presented in a disclosure view to allow for summary or detailed views of each record.
- The autofill dialog is layed out dynamically in a vertical list (ordered by y) using the VerticalLayoutView.
- Sections are delimited visually with the SectionSeparatorView. There are currently two sections, one for addresses and one for credit cards.
- Unit tests are present that exercise the invocation of the dialog and check basic functionality. Checks are performed to see that data is flowing from core profile and credit card data structures into Cocoa model data structures used for bindings internally by the UI.
- There are three .xib files (AutoFillDialog.xib, AutoFillAddressFormView.xib, and AutoFillCreditCardFormView.xib) that partition the dialog UI into distinct views, controllers, and model objects.
- Cocoa databinding is utilized to syncronize dependent parts of the UI.
- All strings are stored in internationalized form in .grd files and .xib files (with one small TODO execption, see below).
The things remaining to do are:
- Hook the UI up to the backend model, specifically the PersonalDataManager data.
- Add support for arbitrary number of address and credit card records. I.e. Add and Delete buttons.
- Scroll-to-Point support for autoscrolling when tabbing between fields.
- Billing and shipping address popups in the credit card section.
- Any validation of input (need to circle back with UI folks on this).
- Input validation unit tests.
- String concatenation of the summary label needs to be internationalized.
BUG=33029
TEST=none
Review URL: http://codereview.chromium.org/558066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/566023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also includes a small valgrind error fix.
Review URL: http://codereview.chromium.org/598046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/572001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=34573
TEST=none
Review URL: http://codereview.chromium.org/603005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a NotificationMethod enum, which defines NOTIFICATION_LEGACY, NOTIFICATION_TRANSITIONAL, NOTIFICATION_NEW (see bug for details).
Made SendUpdateTask and SubscribeTask take a NotificationMethod and use it.
Added command-line switch to override default notification method (currently NOTIFICATION_LEGACY).
Added a bunch of unittests.
BUG=33261
TEST=trybots, manual testing with notification client pythons scripts and browsers with different notification methods
Review URL: http://codereview.chromium.org/573046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=279 (Chromium OS) (Not Complete)
TEST=none
Review URL: http://codereview.chromium.org/587006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=estade
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When codereviewing my r36867, evmar suggested that I implement our trying to
match WM frames in terms of gtk_rc_get_style_by_paths(). This worked... on the
version of gtk+ included with hardy. It notably doesn't work under the version
included with Karmic. This is the original patch from CL 552092 with some
cleanup, before I rewrote it.
BUG=32173
TEST=New Wave has a dark border color under GNOME on Karmic.
Review URL: http://codereview.chromium.org/564048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/views/tab_contents/render_view_context_menu_win.cc appears to
be a views file, not a Windows file, so why is it named with _win.cc? This is
a speculative change.
BUG=none
TEST=Linux Builder (Views dbg) and Linux Builder (ChromiumOS) compile steps
turn green
Review URL: http://codereview.chromium.org/600049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/views/tab_contents/render_view_context_menu_win.cc appears to
be a views file, not a Windows file, so why is it named with _win.cc? This is
a speculative change.
BUG=none
TEST=Linux Builder (Views dbg) and Linux Builder (ChromiumOS) compile steps
turn green
Review URL: http://codereview.chromium.org/596040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/views/tab_contents/render_view_context_menu_win.cc appears to
be a views file, not a Windows file, so why is it named with _win.cc?
This is a speculative change. It may not work, in which case the file will
need to be renamed.
BUG=none
TEST=Linux Builder (Views dbg) and Linux Builder (ChromiumOS) compile steps
turn green
Review URL: http://codereview.chromium.org/598042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38667 0039d316-1c4b-4281-b951-d872f2087c98
|