| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
classes.
Adds basic support to Chrome for using the wifi API, and basic test.
Does not yet provide concrete implementation of the underlying methods, this will be in follow-up CLs once I have ChromeOS device.
BUG=45671
TEST=GeolocationChromeOsWifiDataProviderTest.*
Review URL: http://codereview.chromium.org/2769007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=trybots; make -j8 chrome unit_tests browser_tests
BUG=chromium-os:4063
Review URL: http://codereview.chromium.org/2875001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I'll be adding a map of FilePath to resource id to this class soon.
For example, FilePath("bookmark_manager/main.html") -> id.
Review URL: http://codereview.chromium.org/2870001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If --restore-background-contents flag is passed, stores the URLs of running
BackgroundContents in preferences so they can be re-launched when the browser
restarts.
Moved logic to shutdown background contents into BackgroundContentsService so
we can use this to coordinate when to keep the browser process running.
BUG=43382
TEST=new tests
Review URL: http://codereview.chromium.org/2104018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Porting the infobars on Linux to the new TranslateInfobarDelegate2 (relanding)
Each translate infobar is now its own class and most of the logic is in the delegate.
Original review:
http://codereview.chromium.org/2836006/show
BUG=40828
TEST=Thoroughly test the translate feature on Linux.
Review URL: http://codereview.chromium.org/2817015
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2863011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Each translate infobar is now its own class and most of the logic is in the delegate.
Original review:
http://codereview.chromium.org/2836006/show
BUG=40828
TEST=Thoroughly test the translate feature on Linux.
Review URL: http://codereview.chromium.org/2817015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cherrypicked from
tony's CL 2814009 that tell make about the net_internals_resources_map.{cc,h}
files.
Load net-internals from the newly created resources.pak file.
This patch also forces the loading of the optional DataPack for const correctness reasons
Original Review: http://codereview.chromium.org/2855003
BUG=35793,42770
TEST=none
TBR=tony
Review URL: http://codereview.chromium.org/2800014
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2811016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tony's CL 2814009 that tell make about the net_internals_resources_map.{cc,h}
files.
Load net-internals from the newly created resources.pak file.
This patch also forces the loading of the optional DataPack for const correctness reasons
Original Review: http://codereview.chromium.org/2855003
BUG=35793,42770
TEST=none
TBR=tony
Review URL: http://codereview.chromium.org/2800014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Moved all functions in language_menu_l10n_util.h to the new file.
- Moved static methods in language_library.h and language_config_model.h to the file.
BUG=none
TEST=try bot passed
Review URL: http://codereview.chromium.org/2810008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It causes the unit-test, ui-tests and more to fail with a not found symbol.
- Porting the infobars on Linux to the new TranslateInfobarDelegate2.
Each translate infobar is now its own class and most of the logic is in the delegate.
BUG=40828
TEST=Thoroughly test the translate feature on Linux.
Review URL: http://codereview.chromium.org/2836006
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2805016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Each translate infobar is now its own class and most of the logic is in the delegate.
BUG=40828
TEST=Thoroughly test the translate feature on Linux.
Review URL: http://codereview.chromium.org/2836006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the initial implementation of System page in ChromeOS options.
BUG=chromium-os:
TEST=none yet, work in progress
Review URL: http://codereview.chromium.org/2781005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2809016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No change in the logic. Just move the code around.
- Add language_config_model.cc, .h, _test.cc
- Sort function definitions and declarations so the order match in .cc and .h files.
Search for OCD in http://www.chromium.org/developers/coding-style
TEST=manually
BUG=chromium-os:4063
Review URL: http://codereview.chromium.org/2856005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch also forces the loading of the optional DataPack for const correctness reasons
BUG=35793,42770
TEST=none
Review URL: http://codereview.chromium.org/2855003
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2852011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch also forces the loading of the optional DataPack for const correctness reasons
BUG=35793,42770
TEST=none
Review URL: http://codereview.chromium.org/2855003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2831010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
from the default store, and add unit tests. Still disabled.
BUG=12351, 25404
TEST=unit tests work
Review URL: http://codereview.chromium.org/2806002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Created new UserView that shows the user's photo.
* Moved common constants to helper.h with login namespace to avoid
conflict.
BUG=none
TEST=none. CL does not change the behavior. All tests should still pass.
Review URL: http://codereview.chromium.org/2831007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/525
TEST=none
Review URL: http://codereview.chromium.org/2790012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor ImageDownloader/ImageDecoder into a separate classes.
Resources submitted in http://codereview.chromium.org/2856003
BUG= http://crosbug.com/3486
TEST=Select "New User" screen, enter new account for this device. Enter incorrect password 3 times. After captcha is presented and entered login should succeed.
Review URL: http://codereview.chromium.org/2729020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser_accessibility_manager, to make it more clear that these are
Windows-only source files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2830005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Augment ProxyConfig to fetch its configuration from preferences that are initialized by settings and policy (rather than getting its config directly from settings). Add policies for everything that is needed to configure a ProxyConfig and wire the policies up to the corresponding preferences.
Also remove CookieMode policy, it's harder to get right than we naively thought.
BUG=43458
TEST=ChromeUrlRequestContextTest*:ConfigurationPolicyPrefStoreTest*
Review URL: http://codereview.chromium.org/2459001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/2860001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
net::HttpNetworkDelegate is an interface for providing hooks into http network activity. ChromeNetworkDelgate implements this interface in chrome/ code. In the future, it might also implement other interfaces. My only current intended consumer for this would be extensions. There's no actual behavior change, this is all just plumbing for now.
BUG=29314
Review URL: http://codereview.chromium.org/2749015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Call SetKeyboardLayoutPerWindow(false) in LanguageMenuButton::LanguageMenuButton().
- Mock Keyboard APIs so LanguageMenuButton::LanguageMenuButton() can call the function even in browser_tests.
In browser_tests, code like "if (CrosLibrary::Get()->EnsureLoaded()) SetKeyboardLayoutPerWindow(false);" does not work since the EnsureLoaded() function is replaced so it always returns true without loading libcros.so (i.e. the function pointer |SetKeyboardLayoutPerWindow| is NULL). We could fix this by either of the following:
1) Add NULL check: if (CrosLibrary::Get()->EnsureLoaded() && (SetKeyboardLayoutPerWindow != NULL)) SetKeyboardLayoutPerWindow(false);
2) Mock keyboard APIs and just call: CrosLibrary::Get()->GetKeyboardLibrary()->SetKeyboardLayoutPerWindow(false);
I'd choose 2), since 1) looks a bit error-prone and inconsistent with other libcros libraries (e.g. power, language, ...)
FYI, we can use the new cros/keyboard_library.h interface to implement the "swap ctrl/caps" feature in a clean way.
BUG=chromium-os:2433
TEST=manually
Review URL: http://codereview.chromium.org/2781006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/7147
TEST=unit tested; not integrated yet
Review URL: http://codereview.chromium.org/2605002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32413
TEST=unit tests, trybots, manual
Review URL: http://codereview.chromium.org/2752007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
platform.
BUG=46134
TEST=none
Review URL: http://codereview.chromium.org/2321003
Patch from Markus Heintz <markusheintz@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Views and Gtk.
BUG=None
TEST=manually
Review URL: http://codereview.chromium.org/2673005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We don't use this yet, but the plan is to move everything in the resources directory into here.
BUG=42770
Review URL: http://codereview.chromium.org/2667001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This does the basic surgery on all three OSes without trying to fix up the visual appearance. As a result, things look pretty ugly. My intent is to at least put endcaps on the omnibox in a subsequent patch.
BUG=45745,45762,45763
TEST=Reload and stop should be combined; go should be gone.
Review URL: http://codereview.chromium.org/2677003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Requested by Ben. Never worked on linux or OSX and apparently broken on Windows. Removal of the multiprofile code will make switching out the old AppMenuModel with the new WrenchMenuModel trivial.
BUG=27177
TEST=none
Review URL: http://codereview.chromium.org/2736001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to pass the check dependency step in the build, I added rlz to
the include_rules in DEPS. However, I am not sure this is the best solution.
TEST=Make sure that the RLZ pings from chrome are the sameas they were with
the old RLZ dll
BUG=none
Review URL: http://codereview.chromium.org/2755002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
integration. It's still unused.
BUG=12351,25404
TEST=GNOME Keyring and KWallet get compiled, but add no new library dependencies
Review URL: http://codereview.chromium.org/2774002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I got it to a point where we show HTML content from the extension within an infobar, but there are a few things missing.
Missing pieces:
- Infobar does not size based on the height of its content (between 36px and 72px).
- Infobar content always has a fixed width, but needs to fill out into the available infobar area.
- I've put in code to asynchronously fetch the image for the Infobar, but it needs to be shown and hooked up to the ExtensionAction context menu (same context menu we use for the browser action container icons).
- The background for HTML content should have a gradient, but is just solid blue at the moment.
BUG=39916
TEST=Infobars should show up on GTK.
Review URL: http://codereview.chromium.org/2753005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since some work is needed on Linux and Mac to use the new translate infobar delegate, I created a new version of the refactored classes instead of replacing them. Once Linux and Mac use the new classes, we can make the swicth.
The TranslateInfoBarDelegate now contains all states, so there is no more logic on the infobar classes.
I broke down the single infobar class into multiple ones (there is now an infobar for each state: before translate, translating, after translate, error): it makes the code simpler.
I had to fix ReplaceInfoBar on Windows as it was not working properly.
BUG=40828
TEST=Test thoroughly the translate feature.
Review URL: http://codereview.chromium.org/2602003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New mocks are attached to bug 44622. These changes replace the in-place editing of address and credit card records with a table of records and separate sheets for manipulating the record data. Changes to the layout of fields on the sheets has been done also.
AutoFillDialog.xib changes: Replaced disclosure based list of address and credit cards with an NSTableView of the same data. Added buttons for "Add", "Edit", and "Remove".
Replaced AutoFillAddressViewController.xib with sheet-based AutoFillAddressSheetController.xib.
Replaced AutoFillCreditCardViewController.xib with sheet-based AutoFillCreditCardSheetController.xib.
BUG=44621
TEST=AutoFillAddressModelTest,AutoFillAddressSheetControllerTest,AutoFillCreditCardModelTest,AutoFillCreditCardSheetControllerTest,AutoFillDialogControllerTest
Review URL: http://codereview.chromium.org/2673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is a clone of
http://codereview.chromium.org/2607001/show
which was reviewd and LGTM'ed by Jeremy Orlow.
Review URL: http://codereview.chromium.org/2740003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use it for "Can't access your account" link.
BUG= http://crosbug.com/3179
TEST=Open "Can't access your account" link from "New User" view.
Review URL: http://codereview.chromium.org/2675007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43423
TEST=Unit test in managed_prefs_banner_base_unittest.cc, manual UI tests
Review URL: http://codereview.chromium.org/2425006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
integration. Some of the bots (memory, ARM) didn't get the new package installed yet.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2763001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
unused.
BUG=12351,25404
TEST=GNOME Keyring and KWallet get compiled, but add no new library dependencies
Review URL: http://codereview.chromium.org/2718001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Does not contain Cole's unified edit menu / zoom controls. This is just
scaffolding that should allow all the rest of the unified menu to exist, while
letting each platform implement the native-only portions in their platform
specific ways.
Only modifies the linux implementation to actually use the new model, though the command line flag and the new model should be shared between platforms.
BUG=45734,45757
TEST=Run with --new-wrench-menu on linux. Notice how long the unified menu is.
Review URL: http://codereview.chromium.org/2677006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Patch by davej@chromium.org:
http://codereview.chromium.org/2285004/show
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add interface for multi_pref_store_manager.
BUG=40259
TEST=Unittests in pref_service_unittest.cc, pref_value_store_unittest.cc
Review URL: http://codereview.chromium.org/1957005
Patch from Markus Heintz <markusheintz@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
about:plugins and show update link for out-of-date ones.
Patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>.
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.
Review URL: http://codereview.chromium.org/2686001
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/2652002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>.
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.
Review URL: http://codereview.chromium.org/2686001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the side.
xib changes:
* Set NSTabView's style to "Tabless" (but kept panes in an NSTabView, since it's a convenient method to handle multiple overlapping views in IB)
* Put NSTabView into a split view, put a table view in the other split pane of the split view, gave it class TabViewSwitcherTable
* changed autosize flags of all child views of the tab view items
* Made the NSTabView the tabView_ of the table view
BUG=45546
TEST=Content settings window should still work. If it's opened through an omnibox bubble, the right section should still be autoselected.
Review URL: http://codereview.chromium.org/2534001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Snow Leopard deprecated -[NSImage setFlipped:] for good reasons. This
implements a method similar to the new
-[NSImage drawInRect:*:respectFlipped:] method, which allows images to
be drawn so that they always look right visually regardless of the
-isFlipped status of the view being drawn.
BUG=38943
TEST=Autocomplete, download, and reload button look right.
Review URL: http://codereview.chromium.org/2587003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48954 0039d316-1c4b-4281-b951-d872f2087c98
|