summaryrefslogtreecommitdiffstats
path: root/chrome/chrome_browser.gypi
Commit message (Collapse)AuthorAgeFilesLines
* Move the files in resources/shared/ into resources.pakerg@chromium.org2010-06-241-72/+4
| | | | | | | | | BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2817026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50761 0039d316-1c4b-4281-b951-d872f2087c98
* Move the bookmark manager into resources.pak.tony@chromium.org2010-06-241-38/+1
| | | | | | | | | | | | This allows for the bookmark manager to work after upgrading in the background on Linux. BUG=42770 TEST=Bookmark manager still works Review URL: http://codereview.chromium.org/2814009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50683 0039d316-1c4b-4281-b951-d872f2087c98
* Add RemotingUI class to handle chrome://remoting URLs.garykac@google.com2010-06-231-0/+2
| | | | | | | | | | | | These URLs are handled by a plugin that is registered to the chrome-internal-plugin/remoting MIME type. BUG=none TEST=verify plugin is loaded when navigating to chrome://remoting Review URL: http://codereview.chromium.org/2812017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50655 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the translate infobars on mac to match the new windows code.feldstein@chromium.org2010-06-231-2/+8
| | | | | | | | | | | | Breaks it up into 4 different classes instead of 1 class full of switches and if statements. BUG=none TEST=unit_tests.TranslationInfoBarTest Review URL: http://codereview.chromium.org/2815013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50641 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing the following. This differs from the first insky@chromium.org2010-06-231-0/+4
| | | | | | | | | | | | | | | | that I wasn't setting a field in a default: of a switch where I have a NOTREACHED. Moves cut/copy/paste and increment/descrement/fullscreen into buttons on views. BUG=45734 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2868029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50613 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50604 - Moves cut/copy/paste and increment/descrement/fullscreen into ↵mrossetti@chromium.org2010-06-231-4/+0
| | | | | | | | | | | | | | | | buttons on views. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2803013 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/2829021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50608 0039d316-1c4b-4281-b951-d872f2087c98
* Implement side tab view and controller and hook up their creation. ↵pinkerton@chromium.org2010-06-231-0/+4
| | | | | | | | | | | Parameterize tab strip layout so it can be vertical in addition to horizontal without breaking up the code too much. Abstracted some of the side tab knowledge into TabWindowController with overrides in BrowserWindowController. Nib change: added a SideTabStripView custom view to BrowserWindow and hooked it to an outlet. Renamed the outlets to better reflect both views. BUG=44773 TEST=Tab layout, full screen, dragging tabs within and to other windows to make sure they reflow and draw correctly. Side tabs themselves are still behind a flag, but this cl touches many normal codepaths. Review URL: http://codereview.chromium.org/2846028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50606 0039d316-1c4b-4281-b951-d872f2087c98
* Moves cut/copy/paste and increment/descrement/fullscreen into buttonssky@chromium.org2010-06-231-0/+4
| | | | | | | | | | | on views. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2803013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50604 0039d316-1c4b-4281-b951-d872f2087c98
* Fix files with svn:executable permissions.thestig@chromium.org2010-06-231-0/+0
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50566 0039d316-1c4b-4281-b951-d872f2087c98
* Do speculative preconnection based on network traffic (not just DNS)jar@chromium.org2010-06-231-0/+2
| | | | | | | | | | | | This rev also handles the triple of scheme/host/port for recording both referrers and speculative connections, so that we can soon support SSL warming as well as "mere" TCP/IP preconnection. r=mbelshe Review URL: http://codereview.chromium.org/2563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50563 0039d316-1c4b-4281-b951-d872f2087c98
* TTF: Rename jumplist.cc/h to jumplist_win.cc/h as it's a win-onlyjhawkins@chromium.org2010-06-231-3/+2
| | | | | | | | | | | file. BUG=none TEST=none Review URL: http://codereview.chromium.org/2836020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50559 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50465 - Porting the infobars on Linux to the new ↵robertshield@chromium.org2010-06-221-13/+8
| | | | | | | | | | | | | | | | TranslateInfobarDelegate2. Each translate infobar is now its own class and most of the logic is in the delegate. BUG=40828 TEST=Thoroughly test the translate feature on Linux. Review URL: http://codereview.chromium.org/2867017 TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2870019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50468 0039d316-1c4b-4281-b951-d872f2087c98
* Porting the infobars on Linux to the new TranslateInfobarDelegate2.jcivelli@chromium.org2010-06-221-8/+13
| | | | | | | | | | | Each translate infobar is now its own class and most of the logic is in the delegate. BUG=40828 TEST=Thoroughly test the translate feature on Linux. Review URL: http://codereview.chromium.org/2867017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50465 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Give the Wrench menu keyboard shortcuts.rsesek@chromium.org2010-06-221-0/+2
| | | | | | | | | | | Note that these key equivalents are for display only and do not get fired. Commands are routed through the main menu/CommandUpdater. BUG=45098 TEST=Open Wrench menu, see keyboard shortcuts. Review URL: http://codereview.chromium.org/2800019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50452 0039d316-1c4b-4281-b951-d872f2087c98
* Remove traces of a toolbar controller and xib specific to side-tabs, that ↵pinkerton@chromium.org2010-06-221-3/+0
| | | | | | | | | | mock died on the vine. Toolbar is now indented along with the rest of the window content. BUG=44773 TEST=hidden behind flag, nothing to test. Review URL: http://codereview.chromium.org/2824021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50450 0039d316-1c4b-4281-b951-d872f2087c98
* Managed preferences warning banner for Mac preferences dialogmnissler@chromium.org2010-06-221-0/+2
| | | | | | | | | | | | | Add a new view to the preferences dialog in Preferences.xib that holds the alert image and the warning message label. Update the visibility of the warning banner when switching preference views in PreferencesWindowController. BUG=43423 TEST=none Review URL: http://codereview.chromium.org/2831004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50444 0039d316-1c4b-4281-b951-d872f2087c98
* Load net-internals resources from resources.pak.tony@chromium.org2010-06-221-35/+2
| | | | | | | | | | | | | | | This is the same as r50257 with 2 fixes: 1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will work for things tests. 2) Add back the check in chrome_paths.cc to see if we're in a mac bundle or not. BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2865010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50433 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the slideshow application. First revision only allows you to go ↵dhg@chromium.org2010-06-211-0/+2
| | | | | | | | | | through the list of files. Have not wired this into the filebrowser yet either. BUG=chromium-os:3837 TEST=none Review URL: http://codereview.chromium.org/2801004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50405 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix duplicate definition of two symbols.thakis@chromium.org2010-06-211-0/+1
| | | | | | | | | | ar -tv ../clang/sym/Release/libbrowser.a | grep login_database shows that both login_database_mac.cc and login_database_posix.cc end up being included in the build. That seems wrong. Review URL: http://codereview.chromium.org/2859012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50400 0039d316-1c4b-4281-b951-d872f2087c98
* Speculatively revert 50374 (miniinstaller breakage) - Load netinternals ↵willchan@chromium.org2010-06-211-2/+35
| | | | | | | | | | | | | | | | | | | | resources from resources.pak. This is the same as r50257 with 2 fixes: 1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will work for things tests. 2) Add back the check in chrome_paths.cc to see if we're in a mac bundle or not. BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2865010 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2799022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50392 0039d316-1c4b-4281-b951-d872f2087c98
* Load net-internals resources from resources.pak.erg@chromium.org2010-06-211-35/+2
| | | | | | | | | | | | | | | This is the same as r50257 with 2 fixes: 1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will work for things tests. 2) Add back the check in chrome_paths.cc to see if we're in a mac bundle or not. BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2865010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50374 0039d316-1c4b-4281-b951-d872f2087c98
* Fork chrome://history/ for development of a new UI, currently calledpam@chromium.org2010-06-211-0/+2
| | | | | | | | | | | chrome://history2/. BUG=2093 TEST=launch browser, navigate to chrome://history2/ Review URL: http://codereview.chromium.org/2852015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50371 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmarks/DOMUI JS: Refactor the list to use a data model.arv@chromium.org2010-06-211-0/+1
| | | | | | | | | | | | | | | | | | | | This refactors the cr.ui.List to be backed by a data model. The data model is like an array, but it dispatches events when it changes. When the data model changes the view is updated. The view is smart enough to only draw what is in the viewport which allows large data sets to be displayed. There are a lot of TODOs after this to make the list more reusable but this is already getting big so I'd rather get this in before moving on. TODOs: 1. Create a *real* data model for the bookmark list. 2. Move the edit behavior from bmm.BookmarkListItem to cr.ui.ListItem and make it work better with scrolling. 3. Refactor the drag and drop code so that it can be reused. 4. Refactor the selectionModel so that it does not handle the user input events. BUG=39528 TEST=The bookmarks manager should still work. Review URL: http://codereview.chromium.org/2842001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50369 0039d316-1c4b-4281-b951-d872f2087c98
* Adds wifi mac addresses and cell IDs to the corresponding network library ↵joth@chromium.org2010-06-211-0/+2
| | | | | | | | | | | | | | classes. Adds basic support to Chrome for using the wifi API, and basic test. Does not yet provide concrete implementation of the underlying methods, this will be in follow-up CLs once I have ChromeOS device. BUG=45671 TEST=GeolocationChromeOsWifiDataProviderTest.* Review URL: http://codereview.chromium.org/2769007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50345 0039d316-1c4b-4281-b951-d872f2087c98
* Rename *language_library* to *input_method_library*.satorux@chromium.org2010-06-211-2/+2
| | | | | | | | | TEST=trybots; make -j8 chrome unit_tests browser_tests BUG=chromium-os:4063 Review URL: http://codereview.chromium.org/2875001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50341 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ThemeResourcesUtil to ResourcesUtil.tony@chromium.org2010-06-211-2/+2
| | | | | | | | | I'll be adding a map of FilePath to resource id to this class soon. For example, FilePath("bookmark_manager/main.html") -> id. Review URL: http://codereview.chromium.org/2870001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50336 0039d316-1c4b-4281-b951-d872f2087c98
* Added BackgroundContentsService to manage lifecycle of BackgroundContents.atwilson@chromium.org2010-06-211-0/+2
| | | | | | | | | | | | | | | | If --restore-background-contents flag is passed, stores the URLs of running BackgroundContents in preferences so they can be re-launched when the browser restarts. Moved logic to shutdown background contents into BackgroundContentsService so we can use this to coordinate when to keep the browser process running. BUG=43382 TEST=new tests Review URL: http://codereview.chromium.org/2104018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50329 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50308: still failing on Linux sh-lib testsjcivelli@chromium.org2010-06-191-11/+6
| | | | | | | | | | | | | | | | | | Porting the infobars on Linux to the new TranslateInfobarDelegate2 (relanding) Each translate infobar is now its own class and most of the logic is in the delegate. Original review: http://codereview.chromium.org/2836006/show BUG=40828 TEST=Thoroughly test the translate feature on Linux. Review URL: http://codereview.chromium.org/2817015 TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2863011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50310 0039d316-1c4b-4281-b951-d872f2087c98
* Porting the infobars on Linux to the new TranslateInfobarDelegate2 (relanding)jcivelli@chromium.org2010-06-191-6/+11
| | | | | | | | | | | | | | Each translate infobar is now its own class and most of the logic is in the delegate. Original review: http://codereview.chromium.org/2836006/show BUG=40828 TEST=Thoroughly test the translate feature on Linux. Review URL: http://codereview.chromium.org/2817015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50308 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50257 - Reland r50057. This is exactly the same except with two lines ↵erg@chromium.org2010-06-181-2/+35
| | | | | | | | | | | | | | | | | | | | | | | | cherrypicked from tony's CL 2814009 that tell make about the net_internals_resources_map.{cc,h} files. Load net-internals from the newly created resources.pak file. This patch also forces the loading of the optional DataPack for const correctness reasons Original Review: http://codereview.chromium.org/2855003 BUG=35793,42770 TEST=none TBR=tony Review URL: http://codereview.chromium.org/2800014 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2811016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50260 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r50057. This is exactly the same except with two lines cherrypicked fromerg@chromium.org2010-06-181-35/+2
| | | | | | | | | | | | | | | | | | | tony's CL 2814009 that tell make about the net_internals_resources_map.{cc,h} files. Load net-internals from the newly created resources.pak file. This patch also forces the loading of the optional DataPack for const correctness reasons Original Review: http://codereview.chromium.org/2855003 BUG=35793,42770 TEST=none TBR=tony Review URL: http://codereview.chromium.org/2800014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50257 0039d316-1c4b-4281-b951-d872f2087c98
* Added input_method_util.h.yusukes@google.com2010-06-181-3/+3
| | | | | | | | | | | | - Moved all functions in language_menu_l10n_util.h to the new file. - Moved static methods in language_library.h and language_config_model.h to the file. BUG=none TEST=try bot passed Review URL: http://codereview.chromium.org/2810008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50223 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50148:jcivelli@chromium.org2010-06-171-8/+4
| | | | | | | | | | | | | | | | | It causes the unit-test, ui-tests and more to fail with a not found symbol. - Porting the infobars on Linux to the new TranslateInfobarDelegate2. Each translate infobar is now its own class and most of the logic is in the delegate. BUG=40828 TEST=Thoroughly test the translate feature on Linux. Review URL: http://codereview.chromium.org/2836006 TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2805016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50157 0039d316-1c4b-4281-b951-d872f2087c98
* Porting the infobars on Linux to the new TranslateInfobarDelegate2.jcivelli@chromium.org2010-06-171-4/+8
| | | | | | | | | | | Each translate infobar is now its own class and most of the logic is in the delegate. BUG=40828 TEST=Thoroughly test the translate feature on Linux. Review URL: http://codereview.chromium.org/2836006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50148 0039d316-1c4b-4281-b951-d872f2087c98
* Basic code structures for rewritten options dialogs as DOM UI. Also includes ↵zelidrag@chromium.org2010-06-171-1/+7
| | | | | | | | | | | the initial implementation of System page in ChromeOS options. BUG=chromium-os: TEST=none yet, work in progress Review URL: http://codereview.chromium.org/2781005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50117 0039d316-1c4b-4281-b951-d872f2087c98
* s/LanguageSwitchModel/LanguageSwitchMenu/glotov@chromium.org2010-06-171-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2809016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50100 0039d316-1c4b-4281-b951-d872f2087c98
* The second step of refactoring LanguageConfigView.satorux@chromium.org2010-06-171-0/+2
| | | | | | | | | | | | | | | No change in the logic. Just move the code around. - Add language_config_model.cc, .h, _test.cc - Sort function definitions and declarations so the order match in .cc and .h files. Search for OCD in http://www.chromium.org/developers/coding-style TEST=manually BUG=chromium-os:4063 Review URL: http://codereview.chromium.org/2856005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50069 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50057 - Load net-internals from the newly created resources.pak file.erg@chromium.org2010-06-171-2/+35
| | | | | | | | | | | | | | This patch also forces the loading of the optional DataPack for const correctness reasons BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2855003 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2852011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50059 0039d316-1c4b-4281-b951-d872f2087c98
* Load net-internals from the newly created resources.pak file.erg@chromium.org2010-06-171-35/+2
| | | | | | | | | | | This patch also forces the loading of the optional DataPack for const correctness reasons BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2855003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50057 0039d316-1c4b-4281-b951-d872f2087c98
* Chromeos: fix broken build.mdm@chromium.org2010-06-161-4/+4
| | | | | | Review URL: http://codereview.chromium.org/2831010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50039 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor GNOME Keyring and KWallet integration to allow migration ↵mdm@chromium.org2010-06-161-24/+16
| | | | | | | | | | from the default store, and add unit tests. Still disabled. BUG=12351, 25404 TEST=unit tests work Review URL: http://codereview.chromium.org/2806002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50034 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor login/screen locker to use the same UserView to show user's image.oshima@chromium.org2010-06-161-0/+2
| | | | | | | | | | | | | * Created new UserView that shows the user's photo. * Moved common constants to helper.h with login namespace to avoid conflict. BUG=none TEST=none. CL does not change the behavior. All tests should still pass. Review URL: http://codereview.chromium.org/2831007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50032 0039d316-1c4b-4281-b951-d872f2087c98
* Volume bubble added for ChromeOS.glotov@chromium.org2010-06-161-0/+4
| | | | | | | | | BUG=crosbug.com/525 TEST=none Review URL: http://codereview.chromium.org/2790012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49970 0039d316-1c4b-4281-b951-d872f2087c98
* Show Captcha dialog.nkostylev@google.com2010-06-161-1/+7
| | | | | | | | | | | | | Refactor ImageDownloader/ImageDecoder into a separate classes. Resources submitted in http://codereview.chromium.org/2856003 BUG= http://crosbug.com/3486 TEST=Select "New User" screen, enter new account for this device. Enter incorrect password 3 times. After captcha is presented and entered login should succeed. Review URL: http://codereview.chromium.org/2729020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49965 0039d316-1c4b-4281-b951-d872f2087c98
* Rename browser_accessibility to browser_accessibility_win, and same fordmazzoni@chromium.org2010-06-161-6/+6
| | | | | | | | | | | | browser_accessibility_manager, to make it more clear that these are Windows-only source files. BUG=none TEST=none Review URL: http://codereview.chromium.org/2830005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49947 0039d316-1c4b-4281-b951-d872f2087c98
* Add policy code for proxy configurationdanno@chromium.org2010-06-161-0/+2
| | | | | | | | | | | | | Augment ProxyConfig to fetch its configuration from preferences that are initialized by settings and policy (rather than getting its config directly from settings). Add policies for everything that is needed to configure a ProxyConfig and wire the policies up to the corresponding preferences. Also remove CookieMode policy, it's harder to get right than we naively thought. BUG=43458 TEST=ChromeUrlRequestContextTest*:ConfigurationPolicyPrefStoreTest* Review URL: http://codereview.chromium.org/2459001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49924 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up of chrome_browser.gypi/nacl_host files.estade@chromium.org2010-06-161-13/+8
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/2860001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49895 0039d316-1c4b-4281-b951-d872f2087c98
* Add a net::HttpNetworkDelegate and a ChromeNetworkDelegate.willchan@chromium.org2010-06-151-0/+2
| | | | | | | | | net::HttpNetworkDelegate is an interface for providing hooks into http network activity. ChromeNetworkDelgate implements this interface in chrome/ code. In the future, it might also implement other interfaces. My only current intended consumer for this would be extensions. There's no actual behavior change, this is all just plumbing for now. BUG=29314 Review URL: http://codereview.chromium.org/2749015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49804 0039d316-1c4b-4281-b951-d872f2087c98
* Share the same keyboard layout among all windows.yusukes@google.com2010-06-151-0/+2
| | | | | | | | | | | | | | | | | | | | - Call SetKeyboardLayoutPerWindow(false) in LanguageMenuButton::LanguageMenuButton(). - Mock Keyboard APIs so LanguageMenuButton::LanguageMenuButton() can call the function even in browser_tests. In browser_tests, code like "if (CrosLibrary::Get()->EnsureLoaded()) SetKeyboardLayoutPerWindow(false);" does not work since the EnsureLoaded() function is replaced so it always returns true without loading libcros.so (i.e. the function pointer |SetKeyboardLayoutPerWindow| is NULL). We could fix this by either of the following: 1) Add NULL check: if (CrosLibrary::Get()->EnsureLoaded() && (SetKeyboardLayoutPerWindow != NULL)) SetKeyboardLayoutPerWindow(false); 2) Mock keyboard APIs and just call: CrosLibrary::Get()->GetKeyboardLibrary()->SetKeyboardLayoutPerWindow(false); I'd choose 2), since 1) looks a bit error-prone and inconsistent with other libcros libraries (e.g. power, language, ...) FYI, we can use the new cros/keyboard_library.h interface to implement the "swap ctrl/caps" feature in a clean way. BUG=chromium-os:2433 TEST=manually Review URL: http://codereview.chromium.org/2781006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49754 0039d316-1c4b-4281-b951-d872f2087c98
* Policy provider for the Mac.avi@chromium.org2010-06-141-3/+6
| | | | | | | | | BUG=http://crbug.com/7147 TEST=unit tested; not integrated yet Review URL: http://codereview.chromium.org/2605002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49715 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 06:47:51 +0000