| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HistoryQuickProvider) part 1. (Transactions will be introduced in the next submission.) Fixed a problem in the caching of search results as the user types each character in a search term. Updated the unit test associated with that code.
Added (temporary) flag which can be used to turn on the HQP (enable-history-quick-provider); also added it to about:flags.
Previously reviewed as http://codereview.chromium.org/6286029/.
BUG=19736,60107
TEST=Added unit tests.
Review URL: http://codereview.chromium.org/6581024
TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/6575032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. (Transactions will be introduced in the next submission.) Fixed a problem in the caching of search results as the user types each character in a search term. Updated the unit test associated with that code.
Added (temporary) flag which can be used to turn on the HQP (enable-history-quick-provider); also added it to about:flags.
Previously reviewed as http://codereview.chromium.org/6286029/.
BUG=19736,60107
TEST=Added unit tests.
Review URL: http://codereview.chromium.org/6581024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a Preference class to the extension APIs that can be used for access to other preferences in the future.
BUG=71067
TEST=ExtensionApiTest.ContentSettings:ExtensionApiTest.IncognitoContentSettings
Review URL: http://codereview.chromium.org/6480033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12095
TEST=trybots
Review URL: http://codereview.chromium.org/6569003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove InfoBarTextButton and just use a normal views::TextButton. The custom things InfoBarTextButton wanted to do (like fixing some button sizing issues) are now part of the base TextButton.
* Restore the "needs elevation" badge for the "set default browser" infobar, which was lost in http://src.chromium.org/viewvc/chrome?view=rev&revision=70913 .
* Factor out common code for creating buttons, labels, and links into static methods on InfoBarView.
* Remove the ability of LinkInfoBar to draw links right-aligned, which was unused.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6574011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/ui/gtk/importer/ directory.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6568008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Implementation of ExtensionEventRouterForwarder, a class that allows forwarding events from contexts without a profile (e.g. system URL request context) and from the IO thread to extensions.
BUG=73903
TEST=unit_tests --gtest_filter='ExtensionEventRouterForwarderTest.*'
Review URL: http://codereview.chromium.org/6538093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=carnitas
TEST=compiles
Review URL: http://codereview.chromium.org/6575004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no visible change
Review URL: http://codereview.chromium.org/6573008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This continues the work of http://codereview.chromium.org/6312121/. Description of that CL:
This refactors the cloud policy-related code to support device policy
that gets associated with the whole browser session. Device policy
information will show up in g_browser_process->local_state(). Also,
start supporting recommended policy from the cloud.
BUG=chromium-os:11259, chromium-os:11257, chromium-os:11256
TEST=Enable device policy by passing --device-policy-cache-dir, claim a device and verify that policy gets downloaded.
Review URL: http://codereview.chromium.org/6520008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
responsiveness by sending a ping message to them. Watched Threads
respond by sending a pong message to WATCHDOG thread.
WACTHDOG thread collects statistics for response time.
BUG=71378
TEST=browser_thread_unit_test and thread_watcher_unittest. Starting
and stopping of browser.
Review URL: http://codereview.chromium.org/6392018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/6538111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reworked version of r74451 that makes the following changes:
* Removed function to convert an about: string to a URL. We don't need this in the autocomplete side because the "about:" URLs will be correctly handled when the user hits enter; and removing it means we don't need to ensure that the data provider is initialized, because that will also be done automatically.
* Clean up the about:about HTML construction to be shorter and produce slightly more readable source code
* Remove about:vaporware (cleared with thakis, who added it)
(Obviously, the last two changes are "while I'm here, ..." cleanups.)
BUG=6870
TEST=Typing "about:s" into the omnibox should result in a couple of "about:s..." URL entries in the dropdown even if you've never visited them.
Review URL: http://codereview.chromium.org/6474019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11359
TEST=None at the moment
Review URL: http://codereview.chromium.org/6410115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This speeds up chromeos builds by a little bit because then we don't need to compile gtest/gmock and makes for faster iterations because we don't need to relink the views tests all the time.
BUG=none
TEST=touch a file in base, make chrome, check that views_unittests doesn't get build
Review URL: http://codereview.chromium.org/6542073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To reduce the size of this change I've left stub header files in chrome/browser/dom_ui/.
I'll updated the references and delete the stub files later.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6538075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
rest in another cl.
TBR=avi
Review URL: http://codereview.chromium.org/6538100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73268
TEST=look at the memory bots this time
Review URL: http://codereview.chromium.org/6469036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6542027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
which isn't moving. I incorrectly moved it.
Review URL: http://codereview.chromium.org/6538095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11662
TEST=Check that user pictures are always consistent on both Personal and Accounts pages.
Review URL: http://codereview.chromium.org/6532089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6392045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The last references to chrome/browser/dom_ui/options/* have been updated so it's
safe to delete the stub headers.
BUG=59945, 59946
TEST=compiled locally and trybots
Review URL: http://codereview.chromium.org/6542033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To reduce the size of this change I've left stub header files in chrome/browser/dom_ui/options.
I'll updated the references and delete the stub files later.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6469067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/6532073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/webui. Part 5."
This reverts commit 1088003ee7026f2b830d2451f79ce772c44a7cea.
BUG=59945, 59946
TEST=trybots
TBR=avi@chromium.org
Original Review: http://codereview.chromium.org/6538053/
Review URL: http://codereview.chromium.org/6532069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/webui. Part 5.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6538053
TBR=tfarina@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 5.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6538053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Creates a new internal page for listing recent reported crashes, to make it easier for users to report crashes, or get crash IDs when asked in bug reports.
Won't yet display any crashes on Windows, since the breakpad side is not yet done on Windows.
BUG=41106
TEST=Visit chrome://crashes; depending on the build type, platform, and metric pref state, it should display crashes or an informative message.
Review URL: http://codereview.chromium.org/6545001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/6286092/
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6349101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
promo-related code into a new PromoResourceService class that inherits WebResourceService.
This refactoring will allow us to re-use WebResourceService class for GPU Blacklist updates purpose.
This CL tries to minimize the code change and adds no new logic.
BUG=68802
TEST=unittest,promo functions working fine as before.
Review URL: http://codereview.chromium.org/6542003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 4.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6532045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
starting with tab_contents directory.In future changes the headers that include these files will be updated. Once all the files are moved (i.e. renderer_host, rest of browser, renderer etc), then refactoring can begin so that content\DEPS doesn't have chrome in it.
Review URL: http://codereview.chromium.org/6537015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 3.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6541006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 2.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6531028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Simpler! -=150 lines :)
Need this to be able to use SyncerThread2.
BUG=26339
TEST=DataTypeManagerImpl2Test
Review URL: http://codereview.chromium.org/6528042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the client-side phishing detection classifies a page as phishing it will
send back a ping to Google to verify whether or not the page is really phishing.
If the server also classifies the site as phishing we may show a phishing
interstitial if it is enabled.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6014003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Third attempt to land http://codereview.chromium.org/6409040/ -- now without memory leaks)
- cloud_policy.proto autogenerated from policy_templates.json
- C++ method decoding the protobuf also autogenerated from policy_templates.json
- changed policy fetching mechanism to fetch new-style policy protobufs
BUG=68309, chromium-os:11253, chromium-os:11255
TEST=CloudPolicyCacheTest.*; also manual test against python testserver
Review URL: http://codereview.chromium.org/6532019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/webui.
BUG=59946, 59945
TEST=trybots
Review URL: http://codereview.chromium.org/6539004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
'protected' and 'unlimited' storage rights to chrome extensions and applications.
BUG=52357
TEST=extension_special_storage_policy_unittest.cc
Review URL: http://codereview.chromium.org/6299012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Merge HomeAddress into Address, since there are no other subclasses.
* Eliminate unhelpful wrapper functions
* Get rid of Apartment Number code, since we always store that as generic line 2 data.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6533011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
PasswordManager... for now.) Also, just pre-create them up-front. It saves us effort, as they're all going to be eventually created anyway, so being lazy saves us nothing and creates headaches since the rules about what can be lazy differ from feature to feature.
BUG=71097
TEST=zero visible change
Review URL: http://codereview.chromium.org/6480117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Merged correctly this time.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6523067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
popup for touch. There are mainly two refactoring tasks in this CL:
1. Move class definitions from .cc file to .h file so they can be used elsewhere
2. Refactor out some code parts of AutocompletePopupContentView that deal with
drawing individual autocomplete results.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6286092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bug was that the ProfilePolicyContext was getting initialized before the ProfileImplIOData::Handle was initialized.
BUG=67237
TEST=none
Review URL: http://codereview.chromium.org/6526029
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/6480120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The bug was that the ProfilePolicyContext was getting initialized before the ProfileImplIOData::Handle was initialized.
BUG=67237
TEST=none
Review URL: http://codereview.chromium.org/6526029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
addition to the notification. The notification is now only sent out
when done. Also makes the editmodel own the controller.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6519014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Second attempt to land http://codereview.chromium.org/6409040/)
- cloud_policy.proto autogenerated from policy_templats.json
- C++ method decoding the protobuf also autogenerated from policy_templates.json
- changed policy fetching mechanism to fetch new-style policy protobufs
BUG=68309, chromium-os:11253, chromium-os:11255
TEST=CloudPolicyCacheTest.*; also manual test against python testserver
Review URL: http://codereview.chromium.org/6523058
TBR=jkummerow@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Second attempt to land http://codereview.chromium.org/6409040/)
- cloud_policy.proto autogenerated from policy_templats.json
- C++ method decoding the protobuf also autogenerated from policy_templates.json
- changed policy fetching mechanism to fetch new-style policy protobufs
BUG=68309, chromium-os:11253, chromium-os:11255
TEST=CloudPolicyCacheTest.*; also manual test against python testserver
Review URL: http://codereview.chromium.org/6523058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
scheme.
BUG=63656
TEST=none
Review URL: http://codereview.chromium.org/6526044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75094 0039d316-1c4b-4281-b951-d872f2087c98
|