summaryrefslogtreecommitdiffstats
path: root/chrome/chrome_browser_ui.gypi
Commit message (Collapse)AuthorAgeFilesLines
* Delete most web intents code.thakis@chromium.org2013-02-111-36/+0
| | | | | | | | | | | | | | | | | It's already disabled, so this should have no observable effect. The database code stays around until I've written a migration to delete the webintents table. The apps schema code stays around so that 'intent' blocks in apps are silently ignored instead of causing an error. BUG=173194 TBR=piman Review URL: https://codereview.chromium.org/12225076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181702 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 181499 - Allow Terms of Service to be specified for Public Accountsbartfab@chromium.org2013-02-101-0/+2
| | | | | | | | | | | | | | | | | This CL allows Terms of Service to be specified for a Public Account. The terms are set by specifying a URL through policy. Chrome downloads the terms and presents them to the user. Only if the user accepts the terms can the Public Account be entered. This CL also fixes the regression described in issue 174314. TEST=Manual BUG=chromium-os:32780, 174314 TBR=nkostylev,mnissler Review URL: https://codereview.chromium.org/12221097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181656 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 181499 - Allow Terms of Service to be specified for Public Accountsbartfab@chromium.org2013-02-081-2/+0
| | | | | | | | | | | | | | | | | | | | This CL allows Terms of Service to be specified for a Public Account. The terms are set by specifying a URL through policy. Chrome downloads the terms and presents them to the user. Only if the user accepts the terms can the Public Account be entered. This CL also fixes the regression described in issue 174314. TEST=Manual BUG=chromium-os:32780,174314 Review URL: https://codereview.chromium.org/12218014 TBR=bartfab@chromium.org Review URL: https://codereview.chromium.org/12213087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181512 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Terms of Service to be specified for Public Accountsbartfab@chromium.org2013-02-081-0/+2
| | | | | | | | | | | | | | | | This CL allows Terms of Service to be specified for a Public Account. The terms are set by specifying a URL through policy. Chrome downloads the terms and presents them to the user. Only if the user accepts the terms can the Public Account be entered. This CL also fixes the regression described in issue 174314. TEST=Manual BUG=chromium-os:32780,174314 Review URL: https://codereview.chromium.org/12218014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181499 0039d316-1c4b-4281-b951-d872f2087c98
* Adding infobar for reloading page if mediastream (camera, mic) settings have ↵grunell@chromium.org2013-02-071-0/+2
| | | | | | | | | | | | | | changed. This is the same behavior as currently for other content settings, though it will likely change soon (see discussion in bug). Strings are in https://codereview.chromium.org/12218033/ BUG=172778 Review URL: https://codereview.chromium.org/12207011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181303 0039d316-1c4b-4281-b951-d872f2087c98
* Implement user consent InfoBar for screen capturing.sergeyu@chromium.org2013-02-071-0/+2
| | | | | | | | | | | | | | | Support for screen capturing using getUserMedia() was added in r180502 (behind a flag), but there were no notifications to let the user know that the screen is being captured. This CL dds InfoBar that is shown whenever a page requests screen capturing and lets the user approve or deny the request. BUG=134249 TBR=brettw@chromium.org (gypi changes) Review URL: https://chromiumcodereview.appspot.com/12022024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181112 0039d316-1c4b-4281-b951-d872f2087c98
* Introduces new display overscan calibration UI.mukai@chromium.org2013-02-071-0/+2
| | | | | | | | | BUG=161115 Review URL: https://chromiumcodereview.appspot.com/12090127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181107 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: One click signin dialogsail@chromium.org2013-02-061-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the Mac version of this Views CL: https://codereview.chromium.org/11896021/ Currently the one click signin confirmation UI is implemented as a bubble. This CL adds a tab modal dialog version of that UI. Code common to the dialog and bubble has been moved to a new OneClickSigninViewController class. XIB Changes: OneClickSigninBubble.xib: * aligned the baseline of the text in the advanced link with the text in the OK button. * changed the file owner to be OneClickSigninViewController OneClickSigninDialog.xib * same as OneClickSigninBubble.xib except it uses constrained window sytle controls Screenshots: Bubble: http://i.imgur.com/HmJqoQk.png Dialog: http://i.imgur.com/gaY2cym.png BUG=171330 TEST= To show the bubble I performed the following steps; - ran chrome with --use-client-login-signin-flow - signed into gmail - clicked "Ok Sync" in the infobar Testing the dialog requires access to server side stuff that's not public yet. I asked rogerta@ for instructions. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181056 Review URL: https://codereview.chromium.org/12082088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181071 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 181056sail@chromium.org2013-02-061-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Mac: One click signin dialog > > This is the Mac version of this Views CL: > https://codereview.chromium.org/11896021/ > > Currently the one click signin confirmation UI is implemented as a > bubble. This CL adds a tab modal dialog version of that UI. > > Code common to the dialog and bubble has been moved to a new OneClickSigninViewController class. > > XIB Changes: > OneClickSigninBubble.xib: > * aligned the baseline of the text in the advanced link with the > text in the OK button. > * changed the file owner to be OneClickSigninViewController > OneClickSigninDialog.xib > * same as OneClickSigninBubble.xib except it uses constrained > window sytle controls > > Screenshots: > Bubble: http://i.imgur.com/HmJqoQk.png > Dialog: http://i.imgur.com/gaY2cym.png > > BUG=171330 > TEST= > To show the bubble I performed the following steps; > - ran chrome with --use-client-login-signin-flow > - signed into gmail > - clicked "Ok Sync" in the infobar > Testing the dialog requires access to server side stuff that's not public yet. I asked rogerta@ for instructions. > > Review URL: https://codereview.chromium.org/12082088 TBR=sail@chromium.org Review URL: https://codereview.chromium.org/12213050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181061 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: One click signin dialogsail@chromium.org2013-02-061-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the Mac version of this Views CL: https://codereview.chromium.org/11896021/ Currently the one click signin confirmation UI is implemented as a bubble. This CL adds a tab modal dialog version of that UI. Code common to the dialog and bubble has been moved to a new OneClickSigninViewController class. XIB Changes: OneClickSigninBubble.xib: * aligned the baseline of the text in the advanced link with the text in the OK button. * changed the file owner to be OneClickSigninViewController OneClickSigninDialog.xib * same as OneClickSigninBubble.xib except it uses constrained window sytle controls Screenshots: Bubble: http://i.imgur.com/HmJqoQk.png Dialog: http://i.imgur.com/gaY2cym.png BUG=171330 TEST= To show the bubble I performed the following steps; - ran chrome with --use-client-login-signin-flow - signed into gmail - clicked "Ok Sync" in the infobar Testing the dialog requires access to server side stuff that's not public yet. I asked rogerta@ for instructions. Review URL: https://codereview.chromium.org/12082088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181056 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors code for finding HWND associated with a Widget/NativeWindowsky@chromium.org2013-02-061-0/+5
| | | | | | | | | | | | | to a common place to avoid ifdefs. BUG=none TEST=none R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/12211044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181048 0039d316-1c4b-4281-b951-d872f2087c98
* When the Autofill server hints that the current page is the start of an ↵ahutter@chromium.org2013-02-061-0/+4
| | | | | | | | | | | Autocheckout flow, the browser should prompt the user with a bubble asking if they want to use Autocheckout. BUG=172123 Review URL: https://chromiumcodereview.appspot.com/12091094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181042 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor modality-specific behavior from ConstrainedWindowViews to ↵wittman@chromium.org2013-02-061-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | WebContentsModalDialogManager This CL moves the Views web contents modal dialog code towards the interface described in the associated bug. Similar changes for Gtk and Cocoa will be made in follow-on CLs. To that end, this CL contains the following detailed changes: - Introduce NativeWebContentsModalDialogManager for providing platform-specific UI functionality within WebContentsModalDialogManager, and implement NativeWebContentsModalDialogManagerViews. - Under Views, move to a model where WebContentsModalDialogManager listens for closing events rather than requiring notifications from the widget. Continue using the existing model on Gtk and Cocoa, pending refactoring there. - Provide a mechanism for disabling mouse-driven dialog movement on Widget. - Remove NativeConstrainedWindowDelegate and subclasses as they're no longer necessary due to the above two items. - Update tests to account for closing notification to WebContentsModalDialogManager being done from the event loop, rather than synchronously. - Add temporary ConstrainedWindowViews factory function to minimize code churn at construction sites during this refactoring. The next planned steps in this work are: - Refactor ConstrainedWindow subclasses under Gtk and Cocoa to listen for closing events rather than requiring notifications from the widget. - Refactor uses of WebContentsModalDialog interface to use platform-specific equivalents in platform-specific code and, in platform-independent code, invoke functionality via some other mechanism: platform_utils, WebContentsModalDialogManager, ???. Remove WebContentsModalDialog interface. - Generalize WebContentsModalDialogManagerDelegate positioning interface and write WebContentsModalDialogManager::ShowDialog using the new interface. BUG=157161 Review URL: https://chromiumcodereview.appspot.com/12045037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180904 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Remove chromeos ifdefs from caps_lock_handler.tfarina@chromium.org2013-02-061-4/+8
| | | | | | | | | R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/12079017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180894 0039d316-1c4b-4281-b951-d872f2087c98
* Gets desktop win-aura to use non-win aura assets. There are likelysky@chromium.org2013-02-051-0/+5
| | | | | | | | | | | | | | more places that need to be converted from USE_ASH/USE_AURA to HostDesktopType, but this covers all the images. BUG=171859 TEST=none R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/12093117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180633 0039d316-1c4b-4281-b951-d872f2087c98
* Added app install UI for kiosk runtime.zelidrag@chromium.org2013-02-041-0/+3
| | | | | | | | | BUG=173010 TEST=pass following switches to chrome: --install-from-webstore=<app_id> --app-id=<app_id> --force-app-mode Review URL: https://codereview.chromium.org/12086076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180535 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 180282 (doesn't build without reverting r180071 too, so let's justthakis@chromium.org2013-02-031-4/+0
| | | | | | | | | | | | | | | | | | disable the test for now.) > Revert 180055: Very likely caused http://crbug.com/173885 > > Moving chrome://tracing to content. > > > > BUG=169170 > > Review URL: https://codereview.chromium.org/12088099 > > TBR=jam@chromium.org > Review URL: https://codereview.chromium.org/12194007 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/12197003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180285 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 180055: Very likely caused http://crbug.com/173885thakis@chromium.org2013-02-031-0/+4
| | | | | | | | | | | | > Moving chrome://tracing to content. > > BUG=169170 > Review URL: https://codereview.chromium.org/12088099 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/12194007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180282 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 179608sky@chromium.org2013-02-021-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | > views: Remove simple_message_box_win.cc in favor of simple_message_box_views.cc > > simple_message_box_win.cc is not be needed nor compatible with the desktop-aura > transition. It also uses the win32 appearance not the new Chrome style > appearance currently in development. So it's bad twice ;) > > Just kill it and that eases the work that will need to be done later. > > By enabling simple_message_box_views on Windows means that it will be used for all > ShowMessageBox() dialogs instead of current Windows MessageBox. > > BUG=166075,54988 > R=ben@chromium.org > > Review URL: https://codereview.chromium.org/12042083 Reverting as causes crashes on windows. Specifically this code is not necessarily executed on the UI thread and views is not designed to be used on anything but the UI thread. TBR=tfarina@chromium.org BUG=173751 Review URL: https://codereview.chromium.org/12173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180208 0039d316-1c4b-4281-b951-d872f2087c98
* Rename JavaScriptDialogCreator to JavaScriptDialogManager.kkania@chromium.org2013-02-011-2/+2
| | | | | | | | | | It has taken on some responsibility besides just creating dialogs. I'm also planning on adding an additional method soon for accepting/dismissing an open dialog. BUG=none TBR=joth Review URL: https://codereview.chromium.org/12082123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180194 0039d316-1c4b-4281-b951-d872f2087c98
* Make most code on mac compile with enable_web_intents=0thakis@chromium.org2013-02-011-0/+10
| | | | | | | | | | | | | | | | | Once everything builds with that set, I'll switch the default of that to off, then merge that into webkit and delete the webkit pieces, and then I'll delete the chromium bits. Since enable_web_intents is still 1, this change has no observable effect. BUG=173194 TEST=build with GYP_DEFINES=enable_web_intents=0. No compile errors, fewer linker errors. TBR=jschuh Review URL: https://codereview.chromium.org/12089102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180186 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Remove RatingsView. It's unused.thakis@chromium.org2013-02-011-2/+0
| | | | | | | | | | | Looks like this wasn't deleted when the mac webintents UI went away in r173274. BUG=173194 Review URL: https://codereview.chromium.org/12094096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180076 0039d316-1c4b-4281-b951-d872f2087c98
* Moving chrome://tracing to content.jam@chromium.org2013-02-011-4/+0
| | | | | | | BUG=169170 Review URL: https://codereview.chromium.org/12088099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180055 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome://media-internals to content. This allows us to hide ↵jam@chromium.org2013-02-011-6/+0
| | | | | | | | | implementation details from the public API. BUG=169170 Review URL: https://codereview.chromium.org/12153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180040 0039d316-1c4b-4281-b951-d872f2087c98
* [sync] Componentize sync: Part Final: Target 'sync' is now its own componentrsimha@chromium.org2013-02-011-6/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One of the long term goals of the sync team has been to pull sync out of chrome_dll and into its own component. This should result in faster link times for component builds, and cleaner demarcation between sync code and the rest of chrome. This patch does the following: - Splits off sync.gyp into gypi files for sync_core, sync_api, sync_internal_api, sync_notifier and sync_proto. - Audits the dependencies of various targets in sync.gyp, sync_tests.gyp, and other chrome gyp files, and makes sure all dependencies are explicitly declared. - Makes targets declared in gyp files outside sync.gyp directly depend on sync.gyp:sync instead of inner sync targets. - Implements two versions of the target 'sync.gyp:sync': 1) In static mode, the public 'sync' target has a target type of 'none', and is composed of the static library targets 'sync_api', 'sync_core', 'sync_internal_api', 'sync_notifier', and 'sync_proto'. 2) In component mode, we build the public 'sync' target into a single shared library, which includes the contents of sync_api.gypi, sync_core.gypi, sync_internal_api.gypi, sync_notifier.gypi, and sync_proto.gypi. TBR=akalin,robertshield,thakis BUG=136928 TEST=Set GYP_DEFINES="component=shared_library" and build the 'all' target on all platforms. Review URL: https://codereview.chromium.org/11412211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180034 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at UI for saving net_logs data into a temporary file onrtenneti@chromium.org2013-02-011-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mobile (Android and iOS). Added a new page chrome://net-export to start/stop/send the net_log for mobile platforms. net_log entries are saved in "chrome-net-export-log.json" file created in temporary directory. Button "Start Saving (after deleting old data)" will start saving to a temporary file in "NetLog" directory in Temp directory. It deletes all the old temporary files that were in that directory before creating a new temporty file. It is a no-op if we are already saving data into a file. Button "Stop Saving Data" closes the temporary file so that it could be mailed. It is a no-op if we haven't started saving data into a file. Button "Send Data" emails the data file if a temporary file exists in "NetLog" directory. It is a no-op if there is no file. There is only a single temporary file into which we log the data. NetLog data is saved in the browser process. Logging of net_log data behaves similar to the command line option --log-net-log. If chrome://net-export is accessed in multiple tabs, action in first tab wins. If Stop is clicked in any tab, logging stops. If start is clicked in any tab, net logging starts. about:about lists chrome://net-export as one of the links. unit tests create a temporary file for each test run and they delete the file at the end of the test run. mmenke@ and/or eroman@ for chrome\browser\resources and webui changes. jar@ for net_log_temp_file changes. jhawkins@chromium.org for chrome\browser\ui\webui and chrome\browser\resources OWNERS stamp. R=jar@chromium.org, mmenke@chromium.org BUG=151212 TEST=chrome://net-export Review URL: https://chromiumcodereview.appspot.com/11828036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180026 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome://gpu to content.jam@chromium.org2013-01-311-2/+0
| | | | | | | BUG=169170 Review URL: https://codereview.chromium.org/12086079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179908 0039d316-1c4b-4281-b951-d872f2087c98
* Alternate NTP: Add search token to omniboxsail@chromium.org2013-01-311-0/+4
| | | | | | | | | | | | | | | | | | | | | | | This is the Mac verison of this Views CL: https://chromiumcodereview.appspot.com/11418229/ This CL adds a search token decoration to the omnibox. The search token is displayed when the user does a search from the omnibox. The search token appears on the right with a separtor between it and other decorations. Screenshot: no separator: http://i.imgur.com/TXCixtn.png with separator 1x: http://imgur.com/xtxv9hG with separator 2x: http://imgur.com/2Pzi7dN BUG=163190 TBR=thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/12042002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179818 0039d316-1c4b-4281-b951-d872f2087c98
* Implement message center on Windows.dewittj@chromium.org2013-01-311-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | This takes the existing message center code for Ash, and refactors it into two layers - a system-specific layer (WebNotificationTray) and a platform-independent (modulo Views) layer (MessageCenterTray). The WebNotificationTray is responsible for rendering the tray icon and noticing system changes that cause differences in rendering. The MessageCenterTray delegates responsibility for rendering the message center and notification bubbles to the WebNotificationTray. This patch also adds a Windows port of MessageCenterTray - MessageCenterTrayWin. BUG=168605 TEST: message_center_unittests browser_tests (WebNotificationTrayWinTest.*) ash_unittests (WebNotificationTrayTest.*) Review URL: https://chromiumcodereview.appspot.com/11819048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179807 0039d316-1c4b-4281-b951-d872f2087c98
* Add TabStripObserver interfacedavemoore@chromium.org2013-01-311-0/+2
| | | | | | | | | BUG=124830 TEST=New tests Review URL: https://codereview.chromium.org/12089078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179743 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce BrowserIterator.gab@chromium.org2013-01-301-0/+3
| | | | | | | | | | | | | | | | An iterator meant to iterate over all the browsers in BrowserListImpls across multiple desktops (i.e. multiple HostDesktopTypes). As a first step, used it in TabContentsIterator (pretty much bringing back the implementation to the one that was there prior to https://codereview.chromium.org/11316340/ -- except that the iterator is now aware of multiple desktops). Another CL will follow in which all BrowserList::const_iterator, etc. methods will be replaced by BrowserIterator. The interface of BrowserIterator is derived from the interface of TabContentsIterator for consistency (which is being slightly tweaked in parallel in https://codereview.chromium.org/12049038/). BUG=129187 Review URL: https://chromiumcodereview.appspot.com/12038053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179695 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 179615 - didn't help by itself. (May need another revert for r179399)kinuko@chromium.org2013-01-301-0/+2
| | | | | | | | | | | | | | | | | | | | | | > Revert 179554 - suspected to break browser_tests on Mac 10.6 > > > Refactor FullscreenController removing TogglePresentationMode & adding ToggleFullscreenWithChrome. > > > > Part of a series of refactoring changes that will enable simpler code in FullscreenController as well as correcting behavior there. This change attempts to make the minimal modifications required in order to have FullscreenController::ToggleFullscreenMode consistently mean fullscreen with no browser chrome on all platforms. > > > > Depends on https://codereview.chromium.org/12018007/ > > > > BUG=169138 > > > > Review URL: https://chromiumcodereview.appspot.com/11896104 > > TBR=scheib@chromium.org > Review URL: https://codereview.chromium.org/12089068 TBR=kinuko@chromium.org Review URL: https://codereview.chromium.org/12096059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179626 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 179554 - suspected to break browser_tests on Mac 10.6kinuko@chromium.org2013-01-301-2/+0
| | | | | | | | | | | | | | | | | > Refactor FullscreenController removing TogglePresentationMode & adding ToggleFullscreenWithChrome. > > Part of a series of refactoring changes that will enable simpler code in FullscreenController as well as correcting behavior there. This change attempts to make the minimal modifications required in order to have FullscreenController::ToggleFullscreenMode consistently mean fullscreen with no browser chrome on all platforms. > > Depends on https://codereview.chromium.org/12018007/ > > BUG=169138 > > Review URL: https://chromiumcodereview.appspot.com/11896104 TBR=scheib@chromium.org Review URL: https://codereview.chromium.org/12089068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179615 0039d316-1c4b-4281-b951-d872f2087c98
* views: Remove simple_message_box_win.cc in favor of simple_message_box_views.cctfarina@chromium.org2013-01-301-3/+0
| | | | | | | | | | | | | | | | | | simple_message_box_win.cc is not be needed nor compatible with the desktop-aura transition. It also uses the win32 appearance not the new Chrome style appearance currently in development. So it's bad twice ;) Just kill it and that eases the work that will need to be done later. By enabling simple_message_box_views on Windows means that it will be used for all ShowMessageBox() dialogs instead of current Windows MessageBox. BUG=166075,54988 R=ben@chromium.org Review URL: https://codereview.chromium.org/12042083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179608 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor external protocol handler dialog for linuxcalamity@chromium.org2013-01-301-2/+6
| | | | | | | | | | | | This is in preparation for adding chrome-app link handlers which will also require this popup. BUG= Review URL: https://chromiumcodereview.appspot.com/12051033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179558 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor FullscreenController removing TogglePresentationMode & adding ↵scheib@chromium.org2013-01-301-0/+2
| | | | | | | | | | | | | | ToggleFullscreenWithChrome. Part of a series of refactoring changes that will enable simpler code in FullscreenController as well as correcting behavior there. This change attempts to make the minimal modifications required in order to have FullscreenController::ToggleFullscreenMode consistently mean fullscreen with no browser chrome on all platforms. Depends on https://codereview.chromium.org/12018007/ BUG=169138 Review URL: https://chromiumcodereview.appspot.com/11896104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179554 0039d316-1c4b-4281-b951-d872f2087c98
* Drag URL onto Home Button to set homepagetom.cassiotis@gmail.com2013-01-301-0/+2
| | | | | | | | | | | | | | | | | | | Implemented drop hander for the Home toolbar button that accepts links and informs the user with a bubble with the option to undo. Contributed by: tom.cassiotis@gmail.com BUG=152210 TEST=Manually tested various links and other sources and followed through all confirmation permutations (Undo, clicking on bubble, focus loss/application switching, navigating off page). Also the special case where the setting that the undo is resetting to is the NTP. Tested RTL alignment to ensure that the Undo link is to the left of the message in this situation. Review URL: https://chromiumcodereview.appspot.com/11742003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179526 0039d316-1c4b-4281-b951-d872f2087c98
* [win] Enable app list signinbenwells@chromium.org2013-01-291-0/+2
| | | | | | | | | | | This relands r179307 with the app_list_unittests target updated on chromeos. TBR=sky@chromium.org, atwilson@chromium.org, rogerta@chromium.org, xiyuan@chromium.org BUG=159733 Review URL: https://chromiumcodereview.appspot.com/12093040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179453 0039d316-1c4b-4281-b951-d872f2087c98
* Add a WebUIControllerFactory in content and move chrome://webrtc-internals ↵jam@chromium.org2013-01-291-4/+0
| | | | | | | | | to content. BUG=169170 Review URL: https://codereview.chromium.org/12089034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179425 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 179347 can't repro this.jam@chromium.org2013-01-291-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Revert 179271 > > Simplify how TestChromeWebUIControllerFactory is registered now that multiple WebUIControllerFactory instances are supported. Instead of compiling the test code into the shipping product, have tests which use it unregister the default one and register the test one. This also makes the non-test version used for the majority of the test, which keeps the browser_tests more like the shipping product. > > > > I've also moved the test harness code to chrome\test\base, which is where test harnesses live. > > > > BUG=169170 > > Review URL: https://codereview.chromium.org/12084029 > > This seems cause a few webui test crashes on Linux ChromiumOS Tests > (dbg)(2) since http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/6808 > > I can reproduce the crash on my local machine with CookiesViewWebUITest.* > (Note: not all failing tests can be reproduced but this one has a reliable > reproduce of the crash). > And after I revert this, the crash gone. I am not sure why chromeos try > bots have a green run. > > The crash is: > [17690:17690:0128/215636:6223762366:FATAL:web_ui_impl.cc(84)] Check failed: false. Blocked unauthorized use of WebUIBindings. > [0x7f4eb3da52f0] base::debug::StackTrace::StackTrace() > [0x7f4eb3dda2a3] logging::LogMessage::~LogMessage() > [0x7f4eaf52c45b] content::WebUIImpl::OnWebUISend() > [0x7f4eaf52deaa] DispatchToMethod<>() > [0x7f4eaf52d823] ViewHostMsg_WebUISend::Dispatch<>() > [0x7f4eaf52c28c] content::WebUIImpl::OnMessageReceived() > [0x7f4eaf4fe6e8] content::WebContentsImpl::OnMessageReceived() > [0x7f4eaf444489] content::RenderViewHostImpl::OnMessageReceived() > [0x7f4eaf42f031] content::RenderProcessHostImpl::OnMessageReceived() > [0x7f4eb40109c0] IPC::ChannelProxy::Context::OnDispatchMessage() > [0x7f4eb4014a8b] base::internal::RunnableAdapter<>::Run() > [0x7f4eb4014553] base::internal::InvokeHelper<>::MakeItSo() > [0x7f4eb4013df3] base::internal::Invoker<>::Run() > [0x7f4eb3d9a0cd] base::Callback<>::Run() > [0x7f4eb3de0d21] MessageLoop::RunTask() > [0x7f4eb3de0e3c] MessageLoop::DeferOrRunPendingTask() > [0x7f4eb3de16cd] MessageLoop::DoWork() > [0x7f4eb3d7aee7] base::MessagePumpGlib::HandleDispatch() > [0x7f4eb3d7a557] (anonymous namespace)::WorkSourceDispatch() > [0x7f4ea3adb9d2] g_main_context_dispatch > [0x7f4ea3adf858] <unknown> > [0x7f4ea3adfa0c] g_main_context_iteration > [0x7f4eb3d7aaf4] base::MessagePumpGlib::RunWithDispatcher() > [0x7f4eb3d7afc4] base::MessagePumpGlib::Run() > [0x7f4eb3de0911] MessageLoop::RunInternal() > [0x7f4eb3de07cc] MessageLoop::RunHandler() > [0x7f4eb3e197c6] base::RunLoop::Run() > [0x000003101379] content::RunThisRunLoop() > [0x000003101306] content::RunMessageLoop() > [0x000001b66d64] InProcessBrowserTest::QuitBrowsers() > [0x000001b66c58] InProcessBrowserTest::RunTestOnMainThreadLoop() > [0x0000030bd6dd] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > [0x0000030bdb5b] base::internal::RunnableAdapter<>::Run() > [0x0000030bdaf1] base::internal::InvokeHelper<>::MakeItSo() > [0x0000030bdaa9] base::internal::Invoker<>::Run() > [0x000000775215] base::Callback<>::Run() > [0x00000333188c] ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > [0x00000332fe46] ChromeBrowserMainParts::PreMainMessageLoopRun() > [0x000002c50658] chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > [0x7f4eaf197cba] content::BrowserMainLoop::CreateThreads() > [0x7f4eaf19b57e] content::BrowserMainRunnerImpl::Initialize() > [0x7f4eaf1959f7] content::BrowserMain() > [0x0000030bd662] content::BrowserTestBase::SetUp() > [0x000001b65e1a] InProcessBrowserTest::SetUp() > [0x000001c8072b] testing::internal::HandleSehExceptionsInMethodIfSupported<>() > [0x000001c7de76] testing::internal::HandleExceptionsInMethodIfSupported<>() > [0x000001c7305d] testing::Test::Run() > [0x000001c738d6] testing::TestInfo::Run() > [0x000001c74004] testing::TestCase::Run() > [0x000001c78faf] testing::internal::UnitTestImpl::RunAllTests() > [0x000001c81557] testing::internal::HandleSehExceptionsInMethodIfSupported<>() > [0x000001c7e67d] testing::internal::HandleExceptionsInMethodIfSupported<>() > [0x000001c77a7e] testing::UnitTest::Run() > [0x000001b8183c] base::TestSuite::Run() > [0x000000e6b473] ChromeTestLauncherDelegate::RunTestSuite() > [0x0000030fd3fc] content::LaunchTests() > [0x000000e6b315] main > [0x7f4ea2d7fc4d] __libc_start_main > [0x00000072fc29] <unknown> > > TBR=jam@chromium.org > Review URL: https://codereview.chromium.org/12089051 TBR=bshe@chromium.org Review URL: https://codereview.chromium.org/12093047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179352 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 179271bshe@chromium.org2013-01-291-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Simplify how TestChromeWebUIControllerFactory is registered now that multiple WebUIControllerFactory instances are supported. Instead of compiling the test code into the shipping product, have tests which use it unregister the default one and register the test one. This also makes the non-test version used for the majority of the test, which keeps the browser_tests more like the shipping product. > > I've also moved the test harness code to chrome\test\base, which is where test harnesses live. > > BUG=169170 > Review URL: https://codereview.chromium.org/12084029 This seems cause a few webui test crashes on Linux ChromiumOS Tests (dbg)(2) since http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/6808 I can reproduce the crash on my local machine with CookiesViewWebUITest.* (Note: not all failing tests can be reproduced but this one has a reliable reproduce of the crash). And after I revert this, the crash gone. I am not sure why chromeos try bots have a green run. The crash is: [17690:17690:0128/215636:6223762366:FATAL:web_ui_impl.cc(84)] Check failed: false. Blocked unauthorized use of WebUIBindings. [0x7f4eb3da52f0] base::debug::StackTrace::StackTrace() [0x7f4eb3dda2a3] logging::LogMessage::~LogMessage() [0x7f4eaf52c45b] content::WebUIImpl::OnWebUISend() [0x7f4eaf52deaa] DispatchToMethod<>() [0x7f4eaf52d823] ViewHostMsg_WebUISend::Dispatch<>() [0x7f4eaf52c28c] content::WebUIImpl::OnMessageReceived() [0x7f4eaf4fe6e8] content::WebContentsImpl::OnMessageReceived() [0x7f4eaf444489] content::RenderViewHostImpl::OnMessageReceived() [0x7f4eaf42f031] content::RenderProcessHostImpl::OnMessageReceived() [0x7f4eb40109c0] IPC::ChannelProxy::Context::OnDispatchMessage() [0x7f4eb4014a8b] base::internal::RunnableAdapter<>::Run() [0x7f4eb4014553] base::internal::InvokeHelper<>::MakeItSo() [0x7f4eb4013df3] base::internal::Invoker<>::Run() [0x7f4eb3d9a0cd] base::Callback<>::Run() [0x7f4eb3de0d21] MessageLoop::RunTask() [0x7f4eb3de0e3c] MessageLoop::DeferOrRunPendingTask() [0x7f4eb3de16cd] MessageLoop::DoWork() [0x7f4eb3d7aee7] base::MessagePumpGlib::HandleDispatch() [0x7f4eb3d7a557] (anonymous namespace)::WorkSourceDispatch() [0x7f4ea3adb9d2] g_main_context_dispatch [0x7f4ea3adf858] <unknown> [0x7f4ea3adfa0c] g_main_context_iteration [0x7f4eb3d7aaf4] base::MessagePumpGlib::RunWithDispatcher() [0x7f4eb3d7afc4] base::MessagePumpGlib::Run() [0x7f4eb3de0911] MessageLoop::RunInternal() [0x7f4eb3de07cc] MessageLoop::RunHandler() [0x7f4eb3e197c6] base::RunLoop::Run() [0x000003101379] content::RunThisRunLoop() [0x000003101306] content::RunMessageLoop() [0x000001b66d64] InProcessBrowserTest::QuitBrowsers() [0x000001b66c58] InProcessBrowserTest::RunTestOnMainThreadLoop() [0x0000030bd6dd] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() [0x0000030bdb5b] base::internal::RunnableAdapter<>::Run() [0x0000030bdaf1] base::internal::InvokeHelper<>::MakeItSo() [0x0000030bdaa9] base::internal::Invoker<>::Run() [0x000000775215] base::Callback<>::Run() [0x00000333188c] ChromeBrowserMainParts::PreMainMessageLoopRunImpl() [0x00000332fe46] ChromeBrowserMainParts::PreMainMessageLoopRun() [0x000002c50658] chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() [0x7f4eaf197cba] content::BrowserMainLoop::CreateThreads() [0x7f4eaf19b57e] content::BrowserMainRunnerImpl::Initialize() [0x7f4eaf1959f7] content::BrowserMain() [0x0000030bd662] content::BrowserTestBase::SetUp() [0x000001b65e1a] InProcessBrowserTest::SetUp() [0x000001c8072b] testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x000001c7de76] testing::internal::HandleExceptionsInMethodIfSupported<>() [0x000001c7305d] testing::Test::Run() [0x000001c738d6] testing::TestInfo::Run() [0x000001c74004] testing::TestCase::Run() [0x000001c78faf] testing::internal::UnitTestImpl::RunAllTests() [0x000001c81557] testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x000001c7e67d] testing::internal::HandleExceptionsInMethodIfSupported<>() [0x000001c77a7e] testing::UnitTest::Run() [0x000001b8183c] base::TestSuite::Run() [0x000000e6b473] ChromeTestLauncherDelegate::RunTestSuite() [0x0000030fd3fc] content::LaunchTests() [0x000000e6b315] main [0x7f4ea2d7fc4d] __libc_start_main [0x00000072fc29] <unknown> TBR=jam@chromium.org Review URL: https://codereview.chromium.org/12089051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179347 0039d316-1c4b-4281-b951-d872f2087c98
* Add empty chrome://memory-internals pagejochen@chromium.org2013-01-291-0/+2
| | | | | | | | | | | It's currently behind the --enable-memory-internals-ui command-line flag BUG=168642 R=jhawkins@chromium.org,marja@chromium.org Review URL: https://codereview.chromium.org/11896108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179319 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 179302jochen@chromium.org2013-01-291-2/+0
| | | | | | | | | | | | | | | | | | | | Breaks linking on app_list_unittest on Linux: symbol lookup error: libcontent.so: undefined symbol: _ZN15MallocExtension32GetBytesAllocatedOnCurrentThreadEv > [win] Add signin support for the app launcher. > > This relands r178795, with the navigation to the sign in screen deferred until > the app list is shown and sign in is needed. > > TBR=sky@chromium.org, atwilson@chromium.org, rogerta@chromium.org, xiyuan@chromium.org > BUG=159733 > > Review URL: https://codereview.chromium.org/12095027 TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/12088037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179307 0039d316-1c4b-4281-b951-d872f2087c98
* [win] Add signin support for the app launcher.benwells@chromium.org2013-01-291-0/+2
| | | | | | | | | | | | This relands r178795, with the navigation to the sign in screen deferred until the app list is shown and sign in is needed. TBR=sky@chromium.org, atwilson@chromium.org, rogerta@chromium.org, xiyuan@chromium.org BUG=159733 Review URL: https://codereview.chromium.org/12095027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179302 0039d316-1c4b-4281-b951-d872f2087c98
* Move generic_handler.* to content\browser\webui since it's needed by all ↵jam@chromium.org2013-01-291-2/+0
| | | | | | | | | webui pages. BUG=169170 Review URL: https://codereview.chromium.org/12087040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179290 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify how TestChromeWebUIControllerFactory is registered now that ↵jam@chromium.org2013-01-291-2/+0
| | | | | | | | | | | multiple WebUIControllerFactory instances are supported. Instead of compiling the test code into the shipping product, have tests which use it unregister the default one and register the test one. This also makes the non-test version used for the majority of the test, which keeps the browser_tests more like the shipping product. I've also moved the test harness code to chrome\test\base, which is where test harnesses live. BUG=169170 Review URL: https://codereview.chromium.org/12084029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179271 0039d316-1c4b-4281-b951-d872f2087c98
* Android implementation of WebsiteSettingsUiyfriedman@chromium.org2013-01-261-0/+2
| | | | | | | | | BUG=172013 Review URL: https://chromiumcodereview.appspot.com/12045081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179027 0039d316-1c4b-4281-b951-d872f2087c98
* Implements drawing of focus ring for toolbar buttons and bookmark buttons.dvh@google.com2013-01-261-0/+2
| | | | | | | | | | | | | | | | | | | Here's how the change set makes it look like: A glow on the bookmarks has also been added per suggestion of sail@. http://i.imgur.com/oJ5Mv.png http://i.imgur.com/1Y2XA.png http://i.imgur.com/NtXeA.png http://i.imgur.com/AMeFi.png http://i.imgur.com/YOYnb.png BUG=168858 TBR=thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/11916004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178983 0039d316-1c4b-4281-b951-d872f2087c98
* Moves LauncherAppIconLoader to ui/ash directly.mukai@chromium.org2013-01-251-4/+5
| | | | | | | | | | | Now the new AppIconLoader is shared between launcher and message center settings. BUG=161094 Review URL: https://chromiumcodereview.appspot.com/12033069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178910 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 178795jochen@chromium.org2013-01-251-2/+0
| | | | | | | | | | | | | | | | | | | | | Speculative revert to see whether this is responsible for CaptivePortalBrowserTest failures. Tests are failing because there are more navigations happening than expected. > Added signin support for the app launcher. > > This prompts the user to sign in if the app launcher is shown and there is no authenticated user in the Chrome profile. This does not happen on ChromeOS. > > BUG=159733 > > > Review URL: https://chromiumcodereview.appspot.com/12044002 TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/12052077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178816 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-03 17:59:51 +0000