| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
left-facing arrows, as well as the Mac versions for now (since we're up-in-the-air on how Mac icons will work going forward).
BUG=57748
TEST=none
TBR=glen
Review URL: http://codereview.chromium.org/9190035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
indicate that it's possible to toggle between normal and keyword mode on a particular row.
BUG=57748
TEST=none
Review URL: http://codereview.chromium.org/9110012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL does the following things,
.) Removes user-facing categories from the UI completely.
.) Changes categories that are still used (Autofill for example) use category tags instead of the category enum (which has been deprecated)
.) Updates the protocol buffers
.) Refactors the code to change bug report to feedback and re-organizes the file naming/layout
.) Cleans up the unused feedback strings, files and code
.) Cleans up the code at a few places
.) Makes a few UI changes to get closer to the mock given in chromium:98738
This seems like a really huge CL but in reality it just just a couple of hundred lines of 'code' changes; a lot of this is just code being deleted
BUG=chromium:98738
TEST=Tested sending reports.
Review URL: http://codereview.chromium.org/9006003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[Relanding revert 114954 with fix to be compatible
wit new re-linking strategy. Better care was needed
in bracketing the callbacks that were used, to be
sure the new linker left all items located together.]
This code should only have much of an impact on the XP
platform, where thread teardown notification are not
currently made.
Provide an automatic fallback scan of the linker
list of notification callbacks via DllMain.
This fallback is ONLY used if there are no notifications
coming via the linker list. This allows all existing
code to continue working as it does today, and provides
thread teardown notification on XP even though we use
the LoadLibrary call.
It is a minimal change, suitable for pushing to other
channels (beta? stable?).
r=siggi
bug=107974,103209
Review URL: http://codereview.chromium.org/9024015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of thread termination
[This revert (removing XP notification) is being mode because
version .794.0 is crashing on startup (see bug 107974). This
might be due to other optimizations, but until we understand,
I'll revert, as it is better to leak, than to crash :-/ .]
This code should only have much of an impact on the XP
platform, where thread teardown notification are not
currently made.
Provide an automatic fallback scan of the linker
list of notifcation callbacks via DllMain.
This fallback is ONLY used if there are no notifications
coming via the linker list. This allows all existing
code to continue working as it does today, and provides
thread teardown notifcatino on XP even though we use
the LoadLibrary call.
It is a minimal change, suitable for pushing to other
channels (beta? stable?).
r=cpu
BUG=103209
Review URL: http://codereview.chromium.org/8836003
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8934006
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8964002
TBR=jar@chromium.org
BUG=107974
Review URL: http://codereview.chromium.org/8995001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
termination
[This change was shipping to dev/canary over the past
weekend, and had no impact on buildability. I'm landing
this yet again since the bug has a large impact on XP
users, and we need it tested in the field if we are
going to push it to M16 in the new year]
This code should only have much of an impact on the XP
platform, where thread teardown notification are not
currently made.
Provide an automatic fallback scan of the linker
list of notifcation callbacks via DllMain.
This fallback is ONLY used if there are no notifications
coming via the linker list. This allows all existing
code to continue working as it does today, and provides
thread teardown notifcatino on XP even though we use
the LoadLibrary call.
It is a minimal change, suitable for pushing to other
channels (beta? stable?).
r=cpu
BUG=103209
Review URL: http://codereview.chromium.org/8836003
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8934006
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8964002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is intended to make it easier to test Breakpad crash dumping on
the buildbots. Crash dumping will be disabled in Chromium by default
at run time unless CHROME_HEADLESS is set.
The bots set CHROME_HEADLESS, but we don't really want the bots to be
uploading crash dumps that are useless without symbols, so uploading
is disabled except for official builds and when building with
mac_breakpad_uploads=1.
This should not affect stack backtraces that occur in tests (such as
browser_tests) via StackDumpSignalHandler(). Although Breakpad would
normally take priority over this signal handler, Breakpad does not get
enabled in these test suites because is_browser is false inside
InitCrashReporter().
This change leaves the Gyp option "mac_breakpad" for enabling the
creation of Breakpad files. This remains off by default for Chromium
builds, because the symbol dumping is slow and because it has problems
in the makefile-based Mac builds.
BUG=105778
TEST=run Chromium with --crash-test and CHROME_HEADLESS=1; a *.dmp file
should appear in ~/Library/Application Support/Chromium/Crash Reports
Review URL: http://codereview.chromium.org/8824003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[Karen Grunberg requested a speculative revert, because
we are currently unable to complete a link of the canary.
This change is working fine on the Dev branch, and did
not impact the link over the weekend, but for lack of
other items, this change is being reverted]
This code should only have much of an impact on the XP
platform, where thread teardown notification are not
currently made.
Provide an automatic fallback scan of the linker
list of notifcation callbacks via DllMain.
This fallback is ONLY used if there are no notifications
coming via the linker list. This allows all existing
code to continue working as it does today, and provides
thread teardown notifcatino on XP even though we use
the LoadLibrary call.
It is a minimal change, suitable for pushing to other
channels (beta? stable?).
r=cpu
BUG=103209
Review URL: http://codereview.chromium.org/8836003
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8934006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes tests either use mock compositor or mock
WebGraphicsContext3D depending upon which compositor we're
running. This is needed to enable ui tests on the bots.
Attempt 2 failed because of last minute changes to chrome_tests.gypi
that I didn't merge properly with. TBRing again.
BUG=104360
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8890050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code should only have much of an impact on the XP
platform, where thread teardown notification are not
currently made.
Provide an automatic fallback scan of the linker
list of notifcation callbacks via DllMain.
This fallback is ONLY used if there are no notifications
coming via the linker list. This allows all existing
code to continue working as it does today, and provides
thread teardown notifcatino on XP even though we use
the LoadLibrary call.
It is a minimal change, suitable for pushing to other
channels (beta? stable?).
r=cpu
BUG=103209
Review URL: http://codereview.chromium.org/8836003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebGraphicsContext3D depending upon which compositor we're
running. This is needed to enable ui tests on the bots.
I reverted first attempt as it broke some browser_tests. I've
straightened that out in another patch, so this should be good go
again. TBR since it's the same patch as before.
BUG=104360
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8889022
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8873037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebGraphicsContext3D depending upon which compositor we're
running. This is needed to enable ui tests on the bots.
I reverted first attempt as it broke some browser_tests. I've
straightened that out in another patch, so this should be good go
again. TBR since it's the same patch as before.
BUG=104360
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8889022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebGraphicsContext3D depending upon which compositor we're running. This is needed to enable ui tests on the bots.
BUG=104360
TEST=none
Review URL: http://codereview.chromium.org/8805033
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8873001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
depending upon which compositor we're running. This is needed to enable ui tests on the bots.
BUG=104360
TEST=none
Review URL: http://codereview.chromium.org/8805033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
other problems)
- Provide windows notifictaion of thread termination
Provide an automatic fallback scan of the linker
list of notifcation callbacks via DllMain.
This fallback is ONLY used if there are no notifications
coming via the linker list. This allows all existing
code to continue working as it does today, and provides
thread teardown notifcatino on XP even though we use
the LoadLibrary call.
It is a minimal change, suitable for pushing to other
channels (beta? stable?).
r=cpu
BUG=103209
Review URL: http://codereview.chromium.org/8550009
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8839001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provide an automatic fallback scan of the linker
list of notifcation callbacks via DllMain.
This fallback is ONLY used if there are no notifications
coming via the linker list. This allows all existing
code to continue working as it does today, and provides
thread teardown notifcatino on XP even though we use
the LoadLibrary call.
It is a minimal change, suitable for pushing to other
channels (beta? stable?).
r=cpu
BUG=103209
Review URL: http://codereview.chromium.org/8550009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8770010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=robertshield@chromium.org,rogerm@chromium.org
Review URL: http://codereview.chromium.org/8685001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turn on -Wexit-time-destructors for (most of) the chrome target.
BUG=101600,94925
TEST=none
TBR=stevenjb
Review URL: http://codereview.chromium.org/8547005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Due to how Mac applications are bundled we require the application target itself to be responsible for copying FFmpeg.
BUG=23602
TBR=mark,tony
Review URL: http://codereview.chromium.org/8588063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
backing buffer to the browser process for presentation.
Implemented ImageTransportSurface for Linux (without texture sharing), XP, Vista and 7. XP. The non-texture sharing Linux and XP paths just present directly to the compositing child window owned by the browser process as before.
PassThroughImageTransportSurface still needs a proper name. I will move it into its own file once that is decided.
I moved AcceleratedSurfaceBuffersSwapped outside of the platform specific ifdefs and made the signature the same on all platforms for greater consistency.
I removed the code related to sharing surfaces between processes and synchronizing resize and swapping out of GpuCommandBufferStub. It is all now in ImageTransportSurface implementations.
Review URL: http://codereview.chromium.org/8060045
TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/8587012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser process for presentation.
Implemented ImageTransportSurface for Linux (without texture sharing), XP, Vista and 7. XP. The non-texture sharing Linux and XP paths just present directly to the compositing child window owned by the browser process as before.
PassThroughImageTransportSurface still needs a proper name. I will move it into its own file once that is decided.
I moved AcceleratedSurfaceBuffersSwapped outside of the platform specific ifdefs and made the signature the same on all platforms for greater consistency.
I removed the code related to sharing surfaces between processes and synchronizing resize and swapping out of GpuCommandBufferStub. It is all now in ImageTransportSurface implementations.
Review URL: http://codereview.chromium.org/8060045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107967
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108466
Review URL: http://codereview.chromium.org/8425002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resource generation
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107967
Review URL: http://codereview.chromium.org/8425002
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8448001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107967
Review URL: http://codereview.chromium.org/8425002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=102045
TEST=None
Review URL: http://codereview.chromium.org/8418016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resource generation
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Review URL: http://codereview.chromium.org/8425002
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8430011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Review URL: http://codereview.chromium.org/8425002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=87173
TEST=none
Review URL: http://codereview.chromium.org/8394047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because other binaries, besides chrome.dll need this, or else they will fail
to load on vista or xp, once we remove the manual binding to win7-only apis.
BUG=none
TEST= waterfall is not red
Review URL: http://codereview.chromium.org/8370019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
api bind code of the formGetModuleHandle / GetProcAddress for user32 calls.BUG=noneTEST= chrome works on xp
Review URL: http://codereview.chromium.org/8360016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB Changes:
* Moved custom views for the wrench menu items from Toolbar.xib to WrenchMenu.xib.
BUG=96608
TEST=Wrench menu works the same as before.
Review URL: http://codereview.chromium.org/8289014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows will follow very soon, just proceeding in small steps.
Previously Linux browser_tests were launching chrome binary,
and Windows called PathService::Override for no reason.
Mac is going to be _much_ harder.
BUG=none
Review URL: http://codereview.chromium.org/8178004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts, with minor rebasing, the following commits:
r95609 - "[Mac] Replace the custom bookmark menus with native NSMenus."
r95901 - "[Mac] Delete more bookmark bar folder code. This removes things that were missed last time."
r99312 - "[Mac] Remove the Open All items from the bottom of bookmark bar folder menus."
r99423 - "[Mac] Fix the off-the-side chevron menu."
BUG=93674
TEST=Visual and covered by unit_tests
Review URL: http://codereview.chromium.org/8141003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the build/installer output.
This change undoes the revert of 99878. This change was originally reverted
because it was decided to push this change to M16.
BUG=94920
TEST=Do an Official build in mac, linux and win. Ensure that after installing
the app, you can find the default apps under the install's directory
structure. For win, this is under a default_apps directory, for mac, this is
under a "Default Apps" directory.
Review URL: http://codereview.chromium.org/8041033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fullscreen mode via webkitRequestFullScreen(), telling the user how to exit
fullscreen.
This is implemented as an NSView rather than an NSWindow because the floating
chrome that appears in presentation mode should overlap the bubble.
Content-initiated fullscreen mode makes use of 'presentation mode' on the Mac:
the mode in which the UI is hidden, accessible by moving the cursor to the top
of the screen. On Snow Leopard, this mode is synonymous with fullscreen mode.
On Lion, however, fullscreen mode does not imply presentation mode: in
non-presentation fullscreen mode, the chrome is permanently shown. It is
possible to switch between presentation mode and fullscreen mode using the
presentation mode UI control.
When a tab initiates fullscreen mode on Lion, we enter presentation mode if not
in presentation mode already. When the user exits fullscreen mode using Chrome
UI (i.e. keyboard shortcuts, menu items, buttons, switching tabs, etc.) we
return the user to the mode they were in before the tab entered fullscreen.
BUG=14471
TEST=Enter fullscreen mode using webkitRequestFullScreen. You should see a bubble pop down from the top of the screen.
Need to test the Lion logic somehow, with no Lion trybots.
BUG=96883
Original review http://codereview.chromium.org/7890056/
TBR=thakis
Review URL: http://codereview.chromium.org/7920024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
targets are very simple and used little code from chrome targets. However their dependency on chrome targets was problematic because a lot of code wasn't being built for 64 bit on Windows, and so there were a lot of "dummy" files being added with stub functions and code was also being compiled out in random places for NACL_WIN64.
I've made the NaCl 64 bit windows targets self contained. They do use a few files from common, but those files are self-contained. In the future, we could move these to be in the same 64 bit target as the constants from common. However that won't make a maintenance difference since someone could still introduce link dependencies to other files in common.
Additionally, since we're not using chrome code anymore, we can avoid having both nacl.exe and nacl.dll. nacl.exe is sufficient, and this saves 1.4MB of uncompresed binaries in the installer.
BUG=86322
Review URL: http://codereview.chromium.org/7863024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a bubble view to show global errors on the Mac. Tests comming in a separate CL.
BUG=95146
TEST=
Review URL: http://codereview.chromium.org/7859022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
grit/format/data_pack class.
Marked tools/data_pack directory for removal when the dependency in third_party file WebKit.gyp has been updated to point to grit.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/7795057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the last set of strings out of autofill_resources.grd into C++ string
literals. Delete autofill_resources.grd and remove it from gyp.
BUG=None
TEST=Covered by unittests.
Review URL: http://codereview.chromium.org/7782037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
all embedders of content. I've based the refactoring on the existing BrowserMainParts. This is the first step; I didn't want to do it all at the same time because it would be too big. Remaining tasks:-rename the browser_main files in chrome to chrome_browser_main-move the OS specific implementations of BrowserMainParts that are needed for content-finish splitting the remaining BrowserMain function (now that's in TemporaryContinue())BUG=90445
Review URL: http://codereview.chromium.org/7779040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default app CRXs in the build/installer output.
BUG=94920
TEST=Do an Official build in mac and win. Ensure that after installing the app, you can find the default apps under the install's directory structure. For win, this is under a default_apps directory, for mac, this is under a "Default Apps" directory.
Review URL: http://codereview.chromium.org/7827021
TBR=stevet@chromium.org
Review URL: http://codereview.chromium.org/7795038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
removed from them. I just kept the Mac one since we need a file that can include objective c files.
Review URL: http://codereview.chromium.org/7779018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This required a new .xib (ExtensionInstallPromptInline) that shows store data
(star rating, number of reviews, number of users). Current .xibs
(ExtensionInstallPrompt and ExtensionInstallPromptNoWarnings) were rearranged
slightly to have the icon on the right and use a bulleted list for the list
of permissions (instead of a box) per Cole's mock.
This is the Cocoa side of r99407 (views) and r99205 (GTK).
BUG=93380
TEST=no
Review URL: http://codereview.chromium.org/7835039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the build/installer output.
BUG=94920
TEST=Do an Official build in mac and win. Ensure that after installing the app, you can find the default apps under the install's directory structure. For win, this is under a default_apps directory, for mac, this is under a "Default Apps" directory.
Review URL: http://codereview.chromium.org/7827021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
embedders. I've only moved a little bit of the code for now, and will do the rest in followup changes.
BUG=90445
Review URL: http://codereview.chromium.org/7817015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hardlink from different dir for chrome.exe caused annoyance when running from
Visual Studio because $(TargetPath) the default in the .user file is not the
correct path. So, instead do the hardlink on the dll. To avoid the possible
expense on non-NTFS, and to enable a trybot in the future, do this hardlink
based on a gyp define.
BUG=92528, 92685
TEST=No link problems
Review URL: http://codereview.chromium.org/7670031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I considered merging these into ui.dll, but the respective GYP files are pretty
customized, and merging all of the special casing into ui.gyp seemed like it
would just make things messy. Plus, some components only need to link to
surface and not all of ui.
One thing that I'm not entirely sure about is the naming convention. In this
case the modules are named gl, compositor and surface instead of ui_gfx_gl, and
so on. I thought about declaring UI_GFX_GL_EXPORT, but I opted for the shorter
GL_EXPORT instead. I think Ben has been thinking about moving these
directories out of ui/gfx/ anyways since it is a bit odd for them to live there.
R=rvargas
Originally reviewed at http://codereview.chromium.org/7645004
Review URL: http://codereview.chromium.org/7659017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This issue was originally http://codereview.chromium.org/7584007/
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7663001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I considered merging these into ui.dll, but the respective GYP files are pretty
customized, and merging all of the special casing into ui.gyp seemed like it
would just make things messy. Plus, some components only need to link to
surface and not all of ui.
One thing that I'm not entirely sure about is the naming convention. In this
case the modules are named gl, compositor and surface instead of ui_gfx_gl, and
so on. I thought about declaring UI_GFX_GL_EXPORT, but I opted for the shorter
GL_EXPORT instead. I think Ben has been thinking about moving these
directories out of ui/gfx/ anyways since it is a bit odd for them to live there.
R=rvargas
Review URL: http://codereview.chromium.org/7645004
TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/7659015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96997 0039d316-1c4b-4281-b951-d872f2087c98
|