| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The setup API and tools such as expand.exe and makecab.exe all use the cabinet API.
However, the setup API has additional dependencies that we don't need or want
in the mini installer. So, this is a part of a pet pieve effort of mine to
remove these dependencies and hopefully reduce the number of installation failures.
TEST=Run accompanied unit test and also make sure that the mini installer works as before.
BUG=none
Review URL: http://codereview.chromium.org/6693015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Installation failures due to out-of-disk-space seem to be getting more
and more frequent and upon inspection, I found that we can in some cases
do a terrible job and leave cruft behind. Worst of all we can do this if
an installation fails due to low free disk space, thus only adding to the
problem. I suspect there maybe users stuck on a specific revision of
Chrome because of this.
I'm also implementing Robert's idea of supporting for a --cleanup command
line arg that can be passed to the mini installer to only do the cleanup
and not the installation.
BUG=74777
TEST=This should reduce the number of crashes we're getting due to out of disk space.
Review URL: http://codereview.chromium.org/6670023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=3486114
TEST=Install chrome with a non-organic brand code. Start it and wait for
the RLZ registry values to be written to HKCU\software\google\common\rlz.
Uninstall chrome and make sure that the registry values are gone. Note
that only the registry keys and value that start with the letter 'C' relate
to chrome; any other that may exist after uninstall are OK.
Review URL: http://codereview.chromium.org/6597089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
substrings of others (IDS_INSTALL_HIGHER_VERSION and IDS_INSTALL_HIGHER_VERSION_CF, for example) were being sorted incorrectly. Now they aren't.
As a bonus, installer_util_strings now depends on create_string_py, so changes to the scipt no longer require a clobber. Yay
BUG=73884
TEST=build installer_util_strings then look at the generated .h and .rc files and notice that they are sorted properly
Review URL: http://codereview.chromium.org/6594108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=new test added to installer_util_unittests.exe
Review URL: http://codereview.chromium.org/6598065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and/or %SystemRoot%. We now do temp work on the same volume as the eventual install. In the case of system-level installs, this has the nice side-effect of allowing us to move the install into place rather than copy it, which should also speed up system-level installs.
BUG=70368
TEST=Set TMP and TEMP env vars to some volume other than the one holding %USERPROFILE% (for user-level installs) or %SystemRoot% (for system-level installs), then see if in-use updates work.
Review URL: http://codereview.chromium.org/6538091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
contains the third and final part of the validator: helper functions to cause the firing of nonfatal test failures for violations. These are to be used by other tests that mutate the machine state.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6499010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
contains the first two parts of the validator:
1. installer::InstallationValidator class, used by setup.exe to confirm that all is well following an installer operation. Violations are logged at ERROR level.
2. validate_installation.exe, used by humans to check the overall state of a machine.
The third part, in which violations fire nonfatal test failures for use in other tests, will follow in a subsequent CL.
BUG=none
TEST=Run validate_installation.exe on machine(s) containing all conceivable permutations of Chrome and Chrome Frame, and see if it reports any violations.
Review URL: http://codereview.chromium.org/6490024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6519001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After installing chrome with multi-install, you can run setup from the Installer folder with --quick-enable-cf to install Chrome Frame from the same location (using the same binaries). The operation is quick since all the shared binaries are already there and only need to be registered.
NOTE: The switch needs to be coupled with --system-level for system installs and always requires --multi-install.
TEST=After installing Chrome with --multi-install, run setup from the Installer folder with --quick-enable-cf --multi-install. For system installations also remember to include --system-level. Chrome Frame should then be installed as well from the same folder in multi mode.
BUG=none
Review URL: http://codereview.chromium.org/6349098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Run unit test. Verify that there's an elevation policy registered after install and that it gets properly removed on uninstall (ping me for more details).
BUG=none
Review URL: http://codereview.chromium.org/6368043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
repository. Removing chrome_frame -> ceee dependency.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6386025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
things up:
- Introduced ProductOperations: an interface implemented for each product that takes care of product-specific functions. Each Product owns an instance and delegates certain operations to it.
- Removed the use of MasterPreferences by BrowserDistribution so that the former isn't needed outside of the installer.
- Replaced PackageProperties with a new BrowserDistribution type (CHROME_BINARIES)
- Plumbed the concept of InstallerState more thoroughly through installer
- Removed ProductPackageMapping and Package
- Moved more registry read ops into ProductState
- Validation of products to be installed is now done in CheckPreInstallConditions
- Ignore --chrome-frame --ready-mode if chrome is also being installed/updated and a SxS GCF is found (chrome is updated).
- Migrates existing single-install Chrome to multi-install where appropriate.
- Fixes update to Chrome's uninstallation arguments when Chrome Frame is uninstalled.
- Removed dead code from install.cc.
- Added code to update products' "ap" values when ready-mode is accepted.
- Skip post-install things such as launching the browser when Chrome was implicitly added to the install/upgrade process by virtue of being part of a multi-install.
BUG=61609
TEST=run the installer, see it work. existing tests in installer_util_unittests have been updated; new tests are included for ProductState, ChannelInfo, etc.
Review URL: http://codereview.chromium.org/6288009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows me to change one of the callers to not parse the
"REVISION=1234" output, which will allow me to change that output
in a future change.
BUG=41264
Review URL: http://codereview.chromium.org/6265021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
list for better testability.
Write preliminary test framework for testing these functions.
BUG=61609
TEST=setup_unittests.exe
Review URL: http://codereview.chromium.org/6153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
prompts are displayed when the user browses to GCF-enabled sites, allowing the user to permanently activate, permanently decline, or temporarily decline Chrome Frame.
BUG=None
TEST=chrome_frame_unittests --gtest_filter=Ready* && chrome_frame_unittests --gtest_filter=Infobar* && setup.exe --chrome-frame --ready-mode --multi-install --system--level --chrome
Review URL: http://codereview.chromium.org/6040003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where it is needed
- WriteInstallerResult is no longer called on uninstall (Google Update doesn't check it on uninstall)
- Introduced the poorly named InstallationState (state of the system based on registry inspection) and InstallerState (state of the current operation) classes
- Product::GetInstalledVersion and Product::IsInstalled are gone; use InstallationState instead
- A few cleanups to make the code comply with the style guide
- UpdateDiffInstallStatus has been renamed to UpdateInstallStatus
- Chromium builds noop in UpdateInstallStatus (this was always the case for the browser, but now also is for GCF and the multi-installer package).
- The -multifail suffixes is now added to/removed from the Google Update "ap" value by UpdateInstallStatus on the basis of multi-install success/failure.
- Added code to update the Google Update "ap" value based on the set up products/options installed
- ChannelInfo is now an ordered list of modifiers and suffixes. We're careful to keep -full at the end since that was an operating assumption previously.
- ActivePackageProperties is a typedef to either the Chrome or Chromium PackageProperties class
TEST=Some existing unit tests updated; more new unit tests to follow.
BUG=61609
Review URL: http://codereview.chromium.org/5988007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
involves connecting
to the crash service which would take dumps on request.
BUG=61609
TEST=none
Review URL: http://codereview.chromium.org/6045005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1] Remove installer::version and use base::version in installer
2] Use file_util::FileEnumerator instead of calling FindFirstFile directly
BUG=none
TEST=covered by existing tests
Review URL: http://codereview.chromium.org/5687004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for each of the products.
Also removing the system_level() property out of the Product class and into the Package class as system_level can't be different for products that share the same package.
TEST=Run installer and unit tests.
BUG=61609
Review URL: http://codereview.chromium.org/5744001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ClientState value.
BUG=61609
TEST=added to and modified chrome/installer_util_unittests.exe appropriately
Review URL: http://codereview.chromium.org/5656002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The installer now does its work based on distributions and target installation paths.
Each distribution has exactly one target installation path but each installation path can have more than one distribution.
In the absense of the --multi-install switch, the installer should continue to work as before.
The biggest difference here is that we don't rely on a single global distribution object that controls the entire installation flow and we have a few classes for the new abstractions instead of global functions.
It's far from perfect, but it's a step towards separating the core file package required for all distributions from the distributions themselves.
Additionally, there are tons of little changes here such as consistant usage of FilePath and CommandLine instead of mixing them with std::wstring.
TEST=Install, uninstall, upgrade, etc. Everything install related.
BUG=61609
Review URL: http://codereview.chromium.org/5172011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Windows. (Also fixed some unrelated lint errors.) With this change, l10n_util::GetApplicationLocale first checks for an override of the "configured locale" (in base::i18n) containing the list of preferred Windows UI languages. The browser triggers an override early in startup before the ApplicationLocale is determined. In effect, the browser no longer uses ICU on Windows for language detection. (This locale override mechanism is borrowed from the OS X port.)
Changes in Chrome Frame are largely a refactor, as some Win32 code in there has been moved into base/win.
Also cleaned up language selection in installer_util so that the proper language is chosen for the EULA, installer messages, and shortcuts. In so doing, replaced hand-crafted lists of supported languages with either auto-generated lists (static consts) or logic so that the addition of translations in the future doesn't require code motion (that being said, there may be reason to update the alias and/or wildcard tables in language_selector.cc). In so doing, this change unlocks Amharic, Farsi, and Swahili translations for installer messages and shortcuts.
BUG=39986,40496,26470
TEST=New MUI/Win32 calls are tested in base/win/i18n_unittest.cc. To test the overall functionality, uninstall Chrome, remove intl.app_locale user pref, switch to a supported display language (via the "Keyboards and Languages" tab of Win7's "Regional and Language" control panel, and install with { "distribution": { "require_eula": true } } in master_preferences (via -installerdata arg to setup.exe). If all goes well, both EULA and outer frame are in the same language as Windows. Also, from gwilson: "Install system-level Chrome in audit mode on a new machine, then go through the out-of-box-experience, select a language, and the in -product EULA (triggered by "require_eula" : true) and Chrome's UI should be in the language that the user selected."
Review URL: http://codereview.chromium.org/4139010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=it compiles, 'ceee' root folder is seen in Visual Studio projects tree
BUG=none
Review URL: http://codereview.chromium.org/4287001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when running in Chrome Frame mode.
Also fix the installer_util_strings target that had a broken dependency on a file that has since been moved.
BUG=46013
TEST=Google Chrome Frame is correctly displayed when the installer is run in Chrome Frame mode.
Review URL: http://codereview.chromium.org/3968005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
only place where it's used.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3696001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gclient runhooks --force will return error:
KeyError: 'Undefined variable deb_arch in src/chrome/chrome.gyp while loading dependencies of src/chrome/browser/sync/tools/sync_tools.gyp while loading dependencies of src/build/all.gyp while trying to load src/build/all.gyp'
Error: /usr/bin/python src/build/gyp_chromium in /usr/local/google/proj/chrome_arm returned 1
BUG=NONE
TEST=GCLIENT runhooks succeed.
Review URL: http://codereview.chromium.org/3420010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mini_installer_tests.exe.
Also do some miscellaneous cleanup and rejiggering such as removing test-only constants from chrome\common, adding more useful prints when tests fail, properly waiting for child processes to terminate and moving a timeout value to test_timeouts.cc in test_support_common.
BUG=53127
TEST=Chrome Frame user level installs are tested.
Review URL: http://codereview.chromium.org/3297026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
selection on KDE 4.
This should probably wait until after we branch for M7 this week.
BUG=18106,33842
TEST=default browser selection works in KDE 4 on distributions shipping CVS xdg-mime
Review URL: http://codereview.chromium.org/3258009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
base test files dependent on test_support_base.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of header file
dependencies) from the multiprocess test and the test_suite headers to .cc
files. Moves multiprocess_test to the test directory, and all of this stuff to
the existing base_test_support project. I also used the base namespace.
Previously other projects included this functionality just by #include because
it was all inline, so I had to add dependencies on base_test_support in a few
places.
Moves and renames the command line switch this was using to base_switches. Move
the base switch for process type to chrome switches.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3026055
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/3035062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dependencies) from the multiprocess test and the test_suite headers to .cc
files. Moves multiprocess_test to the test directory, and all of this stuff to
the existing base_test_support project. I also used the base namespace.
Previously other projects included this functionality just by #include because
it was all inline, so I had to add dependencies on base_test_support in a few
places.
Moves and renames the command line switch this was using to base_switches. Move
the base switch for process type to chrome switches.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3026055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3017014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
now missing chrome_frame.release, it should be looking for chrome.release. This fixes a breakage introduced with r51729.
BUG=46818
TEST=none
TBR=pkasting
Review URL: http://codereview.chromium.org/2877013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=47199
TEST=none
Review URL: http://codereview.chromium.org/2805024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/2841003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2799006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
disk images.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2761006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
directory.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2791007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to be signed independently of the outer browser application bundle.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2749014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
installer-related files from chrome/tools/build/mac to chrome/installer/mac.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2755007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=everything still builds, new-style DRM-protected content plays
Review URL: http://codereview.chromium.org/2630001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builder will have everything for packaging so the final signing/dmg creation is self contained instead of having to live in both places.
- Move all the installer related bits into the installer folder
- Add the collection of these bits into a specific target
- Collect the internal bits also during the installer target
BUG=42635
TEST=none
Review URL: http://codereview.chromium.org/2417007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This was probably broken in r48007, but not noticed until a
clobber build.
Review URL: http://codereview.chromium.org/2163001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mark
Review URL: http://codereview.chromium.org/2124018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
The cycle is between installer.gyp and chrome.gyp. The fix is to switch installer.gyp into installer.gypi and include it into chrome.gyp
BUG=35308
Review URL: http://codereview.chromium.org/2067018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48007 0039d316-1c4b-4281-b951-d872f2087c98
|