| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Mac version of this Views CL:
https://codereview.chromium.org/11896021/
Currently the one click signin confirmation UI is implemented as a
bubble. This CL adds a tab modal dialog version of that UI.
Code common to the dialog and bubble has been moved to a new OneClickSigninViewController class.
XIB Changes:
OneClickSigninBubble.xib:
* aligned the baseline of the text in the advanced link with the
text in the OK button.
* changed the file owner to be OneClickSigninViewController
OneClickSigninDialog.xib
* same as OneClickSigninBubble.xib except it uses constrained
window sytle controls
Screenshots:
Bubble: http://i.imgur.com/HmJqoQk.png
Dialog: http://i.imgur.com/gaY2cym.png
BUG=171330
TEST=
To show the bubble I performed the following steps;
- ran chrome with --use-client-login-signin-flow
- signed into gmail
- clicked "Ok Sync" in the infobar
Testing the dialog requires access to server side stuff that's not public yet. I asked rogerta@ for instructions.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181056
Review URL: https://codereview.chromium.org/12082088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Mac: One click signin dialog
>
> This is the Mac version of this Views CL:
> https://codereview.chromium.org/11896021/
>
> Currently the one click signin confirmation UI is implemented as a
> bubble. This CL adds a tab modal dialog version of that UI.
>
> Code common to the dialog and bubble has been moved to a new OneClickSigninViewController class.
>
> XIB Changes:
> OneClickSigninBubble.xib:
> * aligned the baseline of the text in the advanced link with the
> text in the OK button.
> * changed the file owner to be OneClickSigninViewController
> OneClickSigninDialog.xib
> * same as OneClickSigninBubble.xib except it uses constrained
> window sytle controls
>
> Screenshots:
> Bubble: http://i.imgur.com/HmJqoQk.png
> Dialog: http://i.imgur.com/gaY2cym.png
>
> BUG=171330
> TEST=
> To show the bubble I performed the following steps;
> - ran chrome with --use-client-login-signin-flow
> - signed into gmail
> - clicked "Ok Sync" in the infobar
> Testing the dialog requires access to server side stuff that's not public yet. I asked rogerta@ for instructions.
>
> Review URL: https://codereview.chromium.org/12082088
TBR=sail@chromium.org
Review URL: https://codereview.chromium.org/12213050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Mac version of this Views CL:
https://codereview.chromium.org/11896021/
Currently the one click signin confirmation UI is implemented as a
bubble. This CL adds a tab modal dialog version of that UI.
Code common to the dialog and bubble has been moved to a new OneClickSigninViewController class.
XIB Changes:
OneClickSigninBubble.xib:
* aligned the baseline of the text in the advanced link with the
text in the OK button.
* changed the file owner to be OneClickSigninViewController
OneClickSigninDialog.xib
* same as OneClickSigninBubble.xib except it uses constrained
window sytle controls
Screenshots:
Bubble: http://i.imgur.com/HmJqoQk.png
Dialog: http://i.imgur.com/gaY2cym.png
BUG=171330
TEST=
To show the bubble I performed the following steps;
- ran chrome with --use-client-login-signin-flow
- signed into gmail
- clicked "Ok Sync" in the infobar
Testing the dialog requires access to server side stuff that's not public yet. I asked rogerta@ for instructions.
Review URL: https://codereview.chromium.org/12082088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=164772
R=pkasting@chromium.org,sail@chromium.org
TBR=ben@chromium.org # for file additions to gyp files
Review URL: https://codereview.chromium.org/11773025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes:
* change the window and button classes to the constrained window variant
* updated margins to match spec
* updated font sizes to match spec
Screenshots:
* New: http://i.imgur.com/wquUv.png
* Old: http://i.imgur.com/EWmd1.png
* Spec: http://i.imgur.com/JXjzg.png
BUG=140550
TEST=Verified that all LoginPromptBrowserTest.* test passed.
Manually navigated to http://www.pagetutor.com/keeper/mystash/secretstuff.html. Verified that the dialog still worked.
Review URL: https://chromiumcodereview.appspot.com/11421045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes:
* Made all windows 468 pixels wide
* Moved controls to match mocks
* Added an outlet for the store link button
Mock: http://i.imgur.com/ruUmn.png
Screenshots of new UI:
Warnings: http://i.imgur.com/5urhd.png
No Warnings: http://i.imgur.com/UrHif.png
Inline: http://i.imgur.com/nrHWQ.png
Inline No Warnings: http://i.imgur.com/Mgbgs.png
Bundle: http://i.imgur.com/mexGe.png
Screenshots old original UI:
Warnings: http://i.imgur.com/nVqgA.png
No Warnings: http://i.imgur.com/fSkGb.png
Inline: http://i.imgur.com/S7gBE.png
Inline No Warnings: http://i.imgur.com/pJJdx.png
Bundle: http://i.imgur.com/7h7QO.png
BUG=155803
TBR=sky@chromium.org
TEST=
Warnings: Install extension from: https://chrome.google.com/webstore/detail/google-mail-checker/mihcahmgecmbnbcchbopgniflfhgnkff
No Warnings: https://chrome.google.com/webstore/detail/seo-analysis-with-seoptim/pplbjgemahdghhnelnlihpflpdkkmmgj
Inline: Navigate to https://www.google.com/chrome/intl/en/p/google-plus.html and add Google+ Notifications
Inline No Warnings: Same as above but instead add Google+ App
Bundle: Run Chrome with --apps-gallery-url="http://www.corp.google.com/" and navigate to http://www.corp.google.com/~jstritar/bundle.html
Review URL: https://chromiumcodereview.appspot.com/11275269
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=138118
Review URL: https://chromiumcodereview.appspot.com/11103042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes the following changes to the extension install prompt:
- the dialog is now displayed in a constrained window
- the UI has been updated to use the new constrained window UI
- the main UI is now a view that can be embedded in any window. This will be used by the web intents picker to embed the extension install prompt in the picker UI.
XIB changes:
- change all the xibs to use a view controller instead of a window controller
- change the buttons to use the new constrained window look
Screenshot: http://i.imgur.com/V0kKF.png
BUG=152010, 95455
TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11014012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also adds a PRESUBMIT check to enforce the policy described here:
http://dev.chromium.org/developers/design-documents/mac-xib-files
BUG=149763
TEST=Build chrome target on 10.6 with Xcode 3.2. Chromium.app launches and works.
TBR=mark@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10950010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This creates lists of XIB files that Chromium has. It also lays the groundwork
for editing XIB files on Xcode 4.4 by creating a fake project for working in
Xcode.
BUG=149763
TEST=No changes in build output.
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/10918254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157199 0039d316-1c4b-4281-b951-d872f2087c98
|