| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This go into $(OutDir)/syzygy/instrumented to avoid it to be picked by the installer.
BUG=
Review URL: https://codereview.chromium.org/213123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=chrisha@chromium.org, pkasting@chromium.org
BUG=
Review URL: https://codereview.chromium.org/199633004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We're bringing the regular Clang-based ASan to Windows and will put it behind
asan==1 like on all other platforms.
BUG=343960
Review URL: https://codereview.chromium.org/167773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builds.
This is my second attempt to do this, the first time https://codereview.chromium.org/23460023/ has been reverted (https://codereview.chromium.org/23858006) because the new target 'copy_syzyasan_binaries' was not build, so the SyzyASan binaries were missing from the syzygy dir...
Currently the syzygy_optimize script was taking care of copying asan_rtl.[dll|pdb] to the syzygy directory, this was causing 2 warnings when building a SyzyASan splitted build with ninja:
- ninja: warning: multiple rules generate syzygy\asan_rtl.dll. builds involving this target will not be correct; continuing anyway
- ninja: warning: multiple rules generate syzygy\asan_rtl.dll.pdb. builds involving this target will not be correct; continuing anyway
The multiple rules come from the fact that both syzygy\chrome.dll and syzygy\chrome_child.dll were trying to generate those artifacts.
I've also added agent_logger.exe to the syzygy directory, with this it'll be easier for the person grabing a SyzyASan build from the LKGR builder to use it.
I've also removed all the "--agent-dll" logic from syzygy_instrument.py as it was only copying the asan binaries to the syzygy directory, it's now done directly in the 'copy_syzyasan_binaries' gyp target.
R=chrisha@chromium.org
BUG=
Review URL: https://codereview.chromium.org/25890006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change breaks the official ASAN Canaries.
BUG=290090
NOTRY=true
> Copy asan_rtl.* and agent_logger.exe to the syzygy directory for the ASan builds.
>
> Currently the syzygy_optimize script was taking care of copying asan_rtl.[dll|pdb] to the syzygy directory, this was causing 2 warnings when building a SyzyASan splitted build with ninja:
>
> - ninja: warning: multiple rules generate syzygy\asan_rtl.dll. builds involving this target will not be correct; continuing anyway
> - ninja: warning: multiple rules generate syzygy\asan_rtl.dll.pdb. builds involving this target will not be correct; continuing anyway
>
> The multiple rules come from the fact that both syzygy\chrome.dll and syzygy\chrome_child.dll were trying to generate those artifacts.
>
> I've also added agent_logger.exe to the syzygy directory, with this it'll be easier for the person grabing a SyzyASan build from the LKGR builder to use it.
>
> I've also removed all the "--agent-dll" logic from syzygy_instrument.py as it was only copying the asan binaries to the syzygy directory, it's now done directly in the 'copy_syzyasan_binaries' gyp target.
>
> R=chrisha@chromium.org
> BUG=
>
> Review URL: https://chromiumcodereview.appspot.com/23460023
TBR=sebmarchand@chromium.org
Review URL: https://codereview.chromium.org/23858006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builds.
Currently the syzygy_optimize script was taking care of copying asan_rtl.[dll|pdb] to the syzygy directory, this was causing 2 warnings when building a SyzyASan splitted build with ninja:
- ninja: warning: multiple rules generate syzygy\asan_rtl.dll. builds involving this target will not be correct; continuing anyway
- ninja: warning: multiple rules generate syzygy\asan_rtl.dll.pdb. builds involving this target will not be correct; continuing anyway
The multiple rules come from the fact that both syzygy\chrome.dll and syzygy\chrome_child.dll were trying to generate those artifacts.
I've also added agent_logger.exe to the syzygy directory, with this it'll be easier for the person grabing a SyzyASan build from the LKGR builder to use it.
I've also removed all the "--agent-dll" logic from syzygy_instrument.py as it was only copying the asan binaries to the syzygy directory, it's now done directly in the 'copy_syzyasan_binaries' gyp target.
R=chrisha@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/23460023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builds.
It allows us to run an experiment where only chrome.dll is instrumented.
TBR=chrisha@chromium.org, gab@chromium.org
CC=laforge@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/23719017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds optional build steps to do syzygy steps on chrome_child.dll. gyp
refactor to make the chrome_syzygy.gyp be reusable twice.
mini_installer_syzygy fiddled a little to use a list of binaries.
TBR=chrisha@chromium.org, robertshield@chromium.org
BUG=237249
Review URL: https://chromiumcodereview.appspot.com/21093004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL here: https://codereview.chromium.org/17619005/
Changed since previous landing is diff between ps1 and ps2.
Diff since previous landing is a bit noisy, but in those files
against original is relatively small. The conditions for the
defines were incorrect and are simpler (and correct) now.
Previously:
Create top-level separate targets for browser and child dlls
The general idea is that there's top level targets chrome and chrome_child,
and corresponding content_app and content_app_child that depend on only
the subtargets that should be included in the appropriate dll.
Currently (probably) Windows-only and requires setting chrome_multiple_dll=1
for gyp.
Links, but Blink is still included in browser.
Single-process mode is currently disabled when chrome_multiple_dll is set.
Current graph is at:
http://commondatastorage.googleapis.com/chromelinkgraph/deps.html generated by
"python tools\win\split_link\graph_dependencies.py deps.html"
Remove the previous hacky-er attempt at this that was named "split dll".
TBR=jam@chromium.org
BUG=237249, 256965
Review URL: https://codereview.chromium.org/19572013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused Linux x64 sizes to fail for reasons unclear.
> Create top-level separate targets for browser and child dlls
>
> The general idea is that there's top level targets chrome and chrome_child,
> and corresponding content_app and content_app_child that depend on only
> the subtargets that should be included in the appropriate dll.
>
> Pull bluetooth_utils from bluetooth_device into separate common target
> as it's referenced from chrome/common/extensions.
>
> Currently (probably) Windows-only and requires setting chrome_multiple_dll=1
> for gyp.
>
> Links, but Blink is still included in browser.
>
> Single-process mode is currently disabled when chrome_multiple_dll is set.
>
> Current graph is at: http://commondatastorage.googleapis.com/chromelinkgraph/deps.html
> generated by "python tools\win\split_link\graph_dependencies.py deps.html"
>
> Remove the previous hacky-er attempt at this that was named "split dll".
>
> TBR=jam@chromium.org
>
> BUG=237249,256965
>
> Review URL: https://codereview.chromium.org/17619005
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/19572012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The general idea is that there's top level targets chrome and chrome_child,
and corresponding content_app and content_app_child that depend on only
the subtargets that should be included in the appropriate dll.
Pull bluetooth_utils from bluetooth_device into separate common target
as it's referenced from chrome/common/extensions.
Currently (probably) Windows-only and requires setting chrome_multiple_dll=1
for gyp.
Links, but Blink is still included in browser.
Single-process mode is currently disabled when chrome_multiple_dll is set.
Current graph is at: http://commondatastorage.googleapis.com/chromelinkgraph/deps.html
generated by "python tools\win\split_link\graph_dependencies.py deps.html"
Remove the previous hacky-er attempt at this that was named "split dll".
TBR=jam@chromium.org
BUG=237249,256965
Review URL: https://codereview.chromium.org/17619005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Requires https://codereview.chromium.org/15067010/ before landing)
TBR=jam@chromium.org
R=cpu@chromium.org
BUG=237249
Review URL: https://chromiumcodereview.appspot.com/14995016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R= chrisha@chromium.org, kerz@chromium.org, mmoss@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13686015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This uses Syzygy's new filtering feature to avoid instrumenting functions with known and deferred bugs.
BUG=
Review URL: https://chromiumcodereview.appspot.com/12655008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've also modified the chrome_syzygy.gyp file to automaticaly produce the SyzyAsan'd version of Chrome.dll if 'asan'=1 on Windows.
TBR=sky@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/12095105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new naming scheme simply appends .pdb to the target (e.g. foo.dll.pdb and
foo.exe.pdb). This is beneficial for a couple reasons:
* no more chrome_dll.pdb and chrome_exe.pdb silliness
* also avoids this issue if we end up with similarly named targets in the
future (target.dll and target.exe)
* ninja already does this, and, by extension, either ninja needs to be broken
to use the old scheme, or the we fix the broken in the existing system.
One less difference between msvs and ninja.
Fixes for chrome-internal stuff: https://chromereviews.googleplex.com/5681015
BUG=
Review URL: https://codereview.chromium.org/11384003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We create a fake PDB build step in order to use the PDBs in the
dependency graph. The wait script will attempt to open the PDB
for writting. On success we assume that mspdbsrv is done, and
it is now legal to access the file. At this point we generate
a stamp file on which PDB consumers can depend.
Renames chrome_dll.pdb to chrome.dll.pdb to match ninja
Pulls in /PROFILE fix for GYP
Add PDB target for syzygy to depend on.
BUG=126499
Review URL: https://codereview.chromium.org/11232072
TBR=noelallen@google.com
Review URL: https://codereview.chromium.org/11365048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We create a fake PDB build step in order to use the PDBs in the
dependency graph. The wait script will attempt to open the PDB
for writting. On success we assume that mspdbsrv is done, and
it is now legal to access the file. At this point we generate
a stamp file on which PDB consumers can depend.
Renames chrome_dll.pdb to chrome.dll.pdb to match ninja
Pulls in /PROFILE fix for GYP
Add PDB target for syzygy to depend on.
BUG=126499
Review URL: https://codereview.chromium.org/11232072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This CL adds an All_syzygy target to the build/all.gyp solution,
that builds a Syzygy-reordered chrome.dll and mini_installer.
If there there is a chrome.dll-order.json file present in the output
directory, chrome.dll will be ordered according to that, otherwise
it will be randomized.
Moved most of mini_installer.gyp to a common .gypi file for reuse.
Review URL: http://codereview.chromium.org/8698009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111710 0039d316-1c4b-4281-b951-d872f2087c98
|