| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This is the default, so these are no-ops.
TBR=thakis@chromium.org
BUG=123026
Review URL: https://codereview.chromium.org/141693007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builds.
This is my second attempt to do this, the first time https://codereview.chromium.org/23460023/ has been reverted (https://codereview.chromium.org/23858006) because the new target 'copy_syzyasan_binaries' was not build, so the SyzyASan binaries were missing from the syzygy dir...
Currently the syzygy_optimize script was taking care of copying asan_rtl.[dll|pdb] to the syzygy directory, this was causing 2 warnings when building a SyzyASan splitted build with ninja:
- ninja: warning: multiple rules generate syzygy\asan_rtl.dll. builds involving this target will not be correct; continuing anyway
- ninja: warning: multiple rules generate syzygy\asan_rtl.dll.pdb. builds involving this target will not be correct; continuing anyway
The multiple rules come from the fact that both syzygy\chrome.dll and syzygy\chrome_child.dll were trying to generate those artifacts.
I've also added agent_logger.exe to the syzygy directory, with this it'll be easier for the person grabing a SyzyASan build from the LKGR builder to use it.
I've also removed all the "--agent-dll" logic from syzygy_instrument.py as it was only copying the asan binaries to the syzygy directory, it's now done directly in the 'copy_syzyasan_binaries' gyp target.
R=chrisha@chromium.org
BUG=
Review URL: https://codereview.chromium.org/25890006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in at r1811).
As we've renamed asan_rtl.dll* to syzyasan_rtl.dll* in this version this CL also update the references to asan_rtl.dll*
R=chrisha@chromium.org, thakis@chromium.org
BUG=294373
Review URL: https://codereview.chromium.org/25067002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change breaks the official ASAN Canaries.
BUG=290090
NOTRY=true
> Copy asan_rtl.* and agent_logger.exe to the syzygy directory for the ASan builds.
>
> Currently the syzygy_optimize script was taking care of copying asan_rtl.[dll|pdb] to the syzygy directory, this was causing 2 warnings when building a SyzyASan splitted build with ninja:
>
> - ninja: warning: multiple rules generate syzygy\asan_rtl.dll. builds involving this target will not be correct; continuing anyway
> - ninja: warning: multiple rules generate syzygy\asan_rtl.dll.pdb. builds involving this target will not be correct; continuing anyway
>
> The multiple rules come from the fact that both syzygy\chrome.dll and syzygy\chrome_child.dll were trying to generate those artifacts.
>
> I've also added agent_logger.exe to the syzygy directory, with this it'll be easier for the person grabing a SyzyASan build from the LKGR builder to use it.
>
> I've also removed all the "--agent-dll" logic from syzygy_instrument.py as it was only copying the asan binaries to the syzygy directory, it's now done directly in the 'copy_syzyasan_binaries' gyp target.
>
> R=chrisha@chromium.org
> BUG=
>
> Review URL: https://chromiumcodereview.appspot.com/23460023
TBR=sebmarchand@chromium.org
Review URL: https://codereview.chromium.org/23858006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builds.
Currently the syzygy_optimize script was taking care of copying asan_rtl.[dll|pdb] to the syzygy directory, this was causing 2 warnings when building a SyzyASan splitted build with ninja:
- ninja: warning: multiple rules generate syzygy\asan_rtl.dll. builds involving this target will not be correct; continuing anyway
- ninja: warning: multiple rules generate syzygy\asan_rtl.dll.pdb. builds involving this target will not be correct; continuing anyway
The multiple rules come from the fact that both syzygy\chrome.dll and syzygy\chrome_child.dll were trying to generate those artifacts.
I've also added agent_logger.exe to the syzygy directory, with this it'll be easier for the person grabing a SyzyASan build from the LKGR builder to use it.
I've also removed all the "--agent-dll" logic from syzygy_instrument.py as it was only copying the asan binaries to the syzygy directory, it's now done directly in the 'copy_syzyasan_binaries' gyp target.
R=chrisha@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/23460023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was preventing the SyzyASan instrumentation of a split build.
R=chrisha@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/22831034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is that chrome_dll_pdb_workaround satisfies the chrome.dll.pdb dependency, and we use that stub of a PDB.Just having the meta-target chrome_dll dependency is sufficient.
R=chrisha@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/23325003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Adds optional build steps to do syzygy steps on chrome_child.dll. gyp
refactor to make the chrome_syzygy.gyp be reusable twice.
mini_installer_syzygy fiddled a little to use a list of binaries.
TBR=chrisha@chromium.org, robertshield@chromium.org
BUG=237249
Review URL: https://chromiumcodereview.appspot.com/21093004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214802 0039d316-1c4b-4281-b951-d872f2087c98
|