summaryrefslogtreecommitdiffstats
path: root/chrome/chrome_tests.gypi
Commit message (Collapse)AuthorAgeFilesLines
* Add unit tests for locaiton arbitrator and browser tests for the access ↵joth@chromium.org2010-02-171-0/+3
| | | | | | | | | | | | | token store (as it integrates with browser singletons) Fixes a few bugs discovered along the way, and make large-ish redesign of the access token API in order to allow sane use with threading restrictions. BUG=None TEST=unit_tests.exe --gtest_filter=Geol* --gtest_repeat=10000 --gtest_break_on_failure Review URL: http://codereview.chromium.org/600141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39232 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting change: broke unit tests on chrome OS.finnur@chromium.org2010-02-161-3/+0
| | | | | | | | | | | Revert 39143 - This change will include preferences as part of the usual startup sequence of the PSS that already includes bookmarks. This is a temporary solution until we have a proper component to manage the startup and shutdown of multiple data types. Review URL: http://codereview.chromium.org/601037 TBR=skrul@chromium.org Review URL: http://codereview.chromium.org/611006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39155 0039d316-1c4b-4281-b951-d872f2087c98
* This change will include preferences as part of the usual startup sequence ↵skrul@chromium.org2010-02-161-0/+3
| | | | | | | | of the PSS that already includes bookmarks. This is a temporary solution until we have a proper component to manage the startup and shutdown of multiple data types. Review URL: http://codereview.chromium.org/601037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39143 0039d316-1c4b-4281-b951-d872f2087c98
* For sync, make ProcessCommitResponseCommand handle commit entries one ↵tim@chromium.org2010-02-161-0/+2
| | | | | | | | | | | | | | | ModelSafeGroup at a time. Enforce ModelSafeGroup restrictions in the StatusController by DCHECKing if out-of-bounds. Move OrderedCommitSet to its own file. Removed some unused error counters and ResetTransientState calls that were useless. BUG=31911 TEST=ProcessCommitResponseTest, OrderedCommitSetTest Review URL: http://codereview.chromium.org/604045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39139 0039d316-1c4b-4281-b951-d872f2087c98
* Re-implement SpellcheckWordIterator with ICU.hbono@chromium.org2010-02-161-0/+1
| | | | | | | | | | | | | | | This change re-implements the SpellcheckWordIterator class to use ICU custom rules so we can use the ICU dictionary to handle Thai and Korean. Also, this class has added a couple of new features to improve the spell-checking quality: * Decompose Hangul syllables into Korean Jamos. This helps us support Korean spell-checking. * Filter out some characters not needed by our spell-checker (e.g. Hebrew niqquds and Arabic vowel signs). This prevents us from marking a word that includes these characters as misspelled. BUG=8487 TEST=unit_test.exe --gtest_filter=SpellcheckWordIteratorTest* Review URL: http://codereview.chromium.org/577020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39082 0039d316-1c4b-4281-b951-d872f2087c98
* Adding summary string generation for the AutoFill feature.dhollowa@chromium.org2010-02-131-0/+4
| | | | | | | | | | | | | | | | | | Includes a small modification to the generated resources, needed additional whitespace in credit card summary. Added summary generation to autofill_profile.* and modified summary generation in credit_card.* to match. credit_card.* modifications were largely to use string16 instead of std::wstring. Factored out common unit testing utilities into autofill_common_unittest.*, and added unit tests for summary string generation for credit_card.* and autofill_profile.*. BUG=35551 TEST=unit_tests --gtest_filter=AutoFillProfileTest.*:CreditCardTest.* Review URL: http://codereview.chromium.org/606031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39002 0039d316-1c4b-4281-b951-d872f2087c98
* Enable BookmarkContextMenuControllerTest ↵estade@chromium.org2010-02-131-0/+3
| | | | | | | | | | | | | | | (browser/views/bookmark_context_menu_controller_unittest), which I added recently but failed to enable. The rename is to match the file name and avoid name conflicts with BookmarkContextMenuTest (in browser/views). Also mac apparently doesn't like having a member var that has a type defined in an anonymous namespace. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/600106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39001 0039d316-1c4b-4281-b951-d872f2087c98
* Implements the auto-translate on click: if you have translatedjcampan@chromium.org2010-02-121-0/+1
| | | | | | | | | | | | | | | a page and are navigating to a new page in the same language by clicking a link, the new page is automatically translated. In order to do that I moved the language state from the navigation entry to some dedicated class that each TabContents owns. Also added some basic unit-testing for good measure. BUG=35477 TEST=See bug steps. Run unit-tests. Review URL: http://codereview.chromium.org/596092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38961 0039d316-1c4b-4281-b951-d872f2087c98
* Browser Action Container should not shrink when visible extension is disabled.finnur@chromium.org2010-02-121-0/+1
| | | | | | | | | | | | | | | We now calculate the visible actions before removing them from the vector so we can maintain the same number after deletion occurs. Also added unit tests and fixed a bug in GetTooltip where we were hard-coding the index to be 0. BUG=35349 TEST=Covered by new unit test. Review URL: http://codereview.chromium.org/606008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38959 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the state-machine & threading out of the windows wifi provider into ↵joth@chromium.org2010-02-121-0/+1
| | | | | | | | | | | | | | a cross platform base class This will make the linux & mac impementations much simpler BUG=11246 TEST=Aded wifi_data_provider_common_unittest.cc. Run: unit_tests.exe --gtest_filer=Geoloc* Review URL: http://codereview.chromium.org/604019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38890 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill dialog for the Mac. This is UI only at this point. The UI is not ↵dhollowa@chromium.org2010-02-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | hooked up to the back end yet. The UI demonstrates manipulation of one address and one credit card record. Eventually buttons will be added to add and remove additional records. The additions in this CL are: - Preferences dialog has a new "Change autofill settings" button that triggers an autofill settings dialog. - The autofill settings dialog now exists and allows the user to manipulate form autofill data. Specifically address information and credit card information. - Each address or credit card record is presented in a disclosure view to allow for summary or detailed views of each record. - The autofill dialog is layed out dynamically in a vertical list (ordered by y) using the VerticalLayoutView. - Sections are delimited visually with the SectionSeparatorView. There are currently two sections, one for addresses and one for credit cards. - Unit tests are present that exercise the invocation of the dialog and check basic functionality. Checks are performed to see that data is flowing from core profile and credit card data structures into Cocoa model data structures used for bindings internally by the UI. - There are three .xib files (AutoFillDialog.xib, AutoFillAddressFormView.xib, and AutoFillCreditCardFormView.xib) that partition the dialog UI into distinct views, controllers, and model objects. - Cocoa databinding is utilized to syncronize dependent parts of the UI. - All strings are stored in internationalized form in .grd files and .xib files (with one small TODO execption, see below). The things remaining to do are: - Hook the UI up to the backend model, specifically the PersonalDataManager data. - Add support for arbitrary number of address and credit card records. I.e. Add and Delete buttons. - Scroll-to-Point support for autoscrolling when tabbing between fields. - Billing and shipping address popups in the credit card section. - Any validation of input (need to circle back with UI folks on this). - Input validation unit tests. - String concatenation of the summary label needs to be internationalized. BUG=33029 TEST=none Review URL: http://codereview.chromium.org/558066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38873 0039d316-1c4b-4281-b951-d872f2087c98
* Create preferences DTC and wire it into the profile sync factory.skrul@chromium.org2010-02-111-0/+1
| | | | | | | | Also includes a small valgrind error fix. Review URL: http://codereview.chromium.org/598046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38815 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented new notification methods.akalin@chromium.org2010-02-111-0/+3
| | | | | | | | | | | | | | | | | Added a NotificationMethod enum, which defines NOTIFICATION_LEGACY, NOTIFICATION_TRANSITIONAL, NOTIFICATION_NEW (see bug for details). Made SendUpdateTask and SubscribeTask take a NotificationMethod and use it. Added command-line switch to override default notification method (currently NOTIFICATION_LEGACY). Added a bunch of unittests. BUG=33261 TEST=trybots, manual testing with notification client pythons scripts and browsers with different notification methods Review URL: http://codereview.chromium.org/573046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38740 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up client side of per-datatype GetUpdates.nick@chromium.org2010-02-111-0/+1
| | | | | | | | | | | Which datatypes are fetched is dictated by the ModelSafeRoutingInfo. We change the semantic of the ModelSafeRoutingInfo so that datatypes which should not be synced are not in the map. We will do GetUpdates for GROUP_PASSIVE datatypes. BUG=29905 TEST=included unit tests Review URL: http://codereview.chromium.org/594024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38726 0039d316-1c4b-4281-b951-d872f2087c98
* Replace __MSG_some_name__ template within extension css files with localized ↵cira@chromium.org2010-02-111-0/+1
| | | | | | | | | | | | | messages. We avoid replacing messages within html and js extension files for security reasons. Also, developers can already localize messages in html/js using chrome.i18n.getMessage calls. TEST=Localize extension, try body{direction: __MSG_@@bidi_reversed_dir__;} in popup.css, while using non-rtl locale. Text should be alligned to the right (as if we were using rtl locale). BUG=26144 Review URL: http://codereview.chromium.org/570007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38717 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor PostClientToServer message, include new unit tests for it. In prep ↵chron@google.com2010-02-101-1/+1
| | | | | | | | | | | for adding auth filter changes. TEST=unit tests included BUG=35321 Review URL: http://codereview.chromium.org/597025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38703 0039d316-1c4b-4281-b951-d872f2087c98
* Include test_shell.gypi in webkit.gyp instead of maintaining a distinctmark@chromium.org2010-02-101-3/+3
| | | | | | | | | | | | | | | | | | test_shell.gyp. This allows the removal of webkit.gyp:pull_in_test_shell, eliminating the circular relationship between webkit.gyp and test_shell.gyp. The expected semantics of building all of test_shell during a webkit.gyp:All build is performed are retained. This change depends on GYP r781 (in Chromium at r38526) for GYP suffix operator path section treatment. It also depends on Chromium r38519 and r38658 for common.gypi treatment of chromium_code. BUG=33186 TEST=Xcode no longer holds stale project files in memory Review URL: http://codereview.chromium.org/602006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38664 0039d316-1c4b-4281-b951-d872f2087c98
* First stab at a DataTypeController.skrul@chromium.org2010-02-101-0/+10
| | | | | | | | This is my first stab at a DataTypeController, plus a BookmarkDataTypeController implementation. It is not fully wired into the PSS yet :) Review URL: http://codereview.chromium.org/545074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38655 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that ResourceQueue is shut down before destruction.phajdan.jr@chromium.org2010-02-101-0/+1
| | | | | | | | | | | | | Rewrite UserScriptListener unit test to not use ResourceDispatcherHost. Share more code with ExtensionsServiceTest. TEST=Covered by unit_tests. BUG=none Review URL: http://codereview.chromium.org/601005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38648 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for HTML5 databases to the cookie tree model.jochen@chromium.org2010-02-101-1/+3
| | | | | | | | | BUG=34633 TEST=create local databases, open cookie tree view from prefs. Review URL: http://codereview.chromium.org/596009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38635 0039d316-1c4b-4281-b951-d872f2087c98
* Add basic tests for extension crash recovery.phajdan.jr@chromium.org2010-02-101-0/+1
| | | | | | | | | | | Also update the test infrastructure to support the required features. TEST=browser_tests BUG=30405 Review URL: http://codereview.chromium.org/572038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38604 0039d316-1c4b-4281-b951-d872f2087c98
* Desktop Notifications for the macjohnnyg@chromium.org2010-02-091-0/+1
| | | | | | | | | | BUG=23066 TEST=notify_demo.html Review URL: http://codereview.chromium.org/548208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38533 0039d316-1c4b-4281-b951-d872f2087c98
* Added UNIQUE_CLIENT_TAG to sync engine. Added some syncapi unit tests. Added ↵chron@google.com2010-02-091-0/+1
| | | | | | | | | | | | | | new index to syncable. Added new DB col to syncable. Renamed singleton tag to UNIQUE_CLIENT_TAG. Added syncapi layer support for unique client tags. Hooked up wire protocol to use this index. Downintegrate of sync.proto from trunk. TEST=unit tests included BUG=32636 Review URL: http://codereview.chromium.org/558015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38518 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38469 - Desktop Notifications for the mac!johnnyg@chromium.org2010-02-091-1/+0
| | | | | | | | | | | | BUG=23066 TEST=notify_demo.html Review URL: http://codereview.chromium.org/548208 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/600015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where positions inside of a newly-committed folder would benick@chromium.org2010-02-091-1/+3
| | | | | | | | | | | | | | | | | | | reversed if the children of the folder weren't committed in the same batch as the folder. Refactor ApplyUpdatesCommandTest, pulling out functionality that would be useful for any SyncerCommand test, into syncer_command_test.h. Add a test case for ProcessCommitResponseCommand using the new SyncerCommandTest framework. Add a test for the bug. BUG=33081 TEST=sync_unit_tests. Also, manual testing, using the reduced repro instructions described in comment #26 of the bug. Review URL: http://codereview.chromium.org/572021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38472 0039d316-1c4b-4281-b951-d872f2087c98
* Desktop Notifications for the mac!johnnyg@chromium.org2010-02-091-0/+1
| | | | | | | | | BUG=23066 TEST=notify_demo.html Review URL: http://codereview.chromium.org/548208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38469 0039d316-1c4b-4281-b951-d872f2087c98
* Preserve order of extensions when they auto-update.finnur@chromium.org2010-02-081-0/+1
| | | | | | | | | | | Also added tests for the ExtensionToolbarModel. BUG=33401 TEST=ExtensionToolbarModelTest (new test). Review URL: http://codereview.chromium.org/587002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38407 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully final attempt at landing ↵joth@chromium.org2010-02-081-0/+1
| | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=38207 Adds tests for network geolocation provider. In the end, it seems templated static methods cannot be called from gtest's SetUp method on a Mac Release build. Beats me. I'm doing my stuff in the c'tor for now, and made a note to come back to it. BUG=http://crbug.com/11246 TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure Review URL: http://codereview.chromium.org/578017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38354 0039d316-1c4b-4281-b951-d872f2087c98
* Show the filebrowse ui rather than the download shelf in chromeos.xiyuan@chromium.org2010-02-051-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This cl displays the filebrowse ui rather than download shelf for downloads in chrom(e|ium) os. It conditionally replaces (with preprocessor macros) the Browser::OnStartDownload method to do this. The cl adds a static FileBrowseUI::OpenPopup(profile, hashArgument), which opens the file browse ui and passes it the provided hash argument. This is invoked directly from Browser::OnStartDownload. The USBMountObserver code was changed to call this static method, rather than open the popup by hand as it had been doing. I'm not sure about ownership of the Browser* returned by OpenPopup, but based on other code in the tree I assume chrome will deal with freeing it when appropriate. Before this change, USBMountObserver would add the window to registrar_ *before* showing it. Now that FileBrowseUI::OpenPopup returns a which which is already visible, this is no longer the case. I assume this won't be a problem. Commit this for rginda. Original review: http://codereview.chromium.org/555167 BUG=none TEST=none Review URL: http://codereview.chromium.org/564022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38222 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38207 - bah. still can't work out why this passes fine on local ↵joth@chromium.org2010-02-051-1/+0
| | | | | | | | | | | | | | | | | | | | | machine & try bots. Reattempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 (asserts tidy up slit out into its own change http://codereview.chromium.org/578013/show) Add tests for the geolocation network provider. Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe gtest_filter=NetworkLocationProvider* gtest_break_on_failure Review URL: http://codereview.chromium.org/578006 TBR=joth@chromium.org Review URL: http://codereview.chromium.org/575021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38208 0039d316-1c4b-4281-b951-d872f2087c98
* Re-attempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 joth@chromium.org2010-02-051-0/+1
| | | | | | | | | | | | | | | (asserts tidy up slit out into its own change http://codereview.chromium.org/578013/show) Add tests for the geolocation network provider. Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure Review URL: http://codereview.chromium.org/578006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38207 0039d316-1c4b-4281-b951-d872f2087c98
* Implement FormManager, a class that manages forms in a RenderView.jhawkins@chromium.org2010-02-051-0/+1
| | | | | | | | BUG=18201 TEST=FormManagerTest Review URL: http://codereview.chromium.org/577009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38157 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up third_party/cld.jshin@chromium.org2010-02-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Remove files we don't use that come from toolbar 2. Simplify the directory structure by removing the redundant intermediary directories bar/toolbar/cld/i18n This will bring CLD a step closer to where it can be open-sourced separately (or along with CED for encoding detection.). It's not there yet. In addition to the clean-up, change |LanguageCode*| return 'nb', 'he', 'fil' instead of 'no', 'iw', and 'tl'. Also, use LanguageCodeWithDialects instead of LanguageCode to get 'zh-CN' instead of 'zh'. This is to simplify the 3-way mapping between Chrome's UI locale code, CLD's language code and what's accepted by Google Translate. It's also another preparation for open-sourcing because we'd better use the standard code rather than the obsolete code like 'iw' when open-sourcing. BUG=32759, 33613 TEST=third_party/cld builds on all platforms and pass the following tests: - unit_tests: Extension*.DetectTabLanguage and CompactLangDetTest.* - browser_tests: ExtensionBrowserTest.Toolstrip git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38146 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38108 - Basic group policy support, third try. Doesn't wire any ↵gwilson@chromium.org2010-02-041-2/+0
| | | | | | | | | | | | group policy to preferences yet. In this iteration, I modified the unit test to require full access (read+write) to the necessary registry keys before running. TBR=hclam Review URL: http://codereview.chromium.org/570025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38109 0039d316-1c4b-4281-b951-d872f2087c98
* Basic group policy support, third try. Doesn't wire any group policy to ↵gwilson@google.com2010-02-041-0/+2
| | | | | | | | | | | | | | | preferences yet. In this iteration, I modified the unit test to require full access (read+write) to the necessary registry keys before running. R=kuchhal,cpu BUG=19374 TEST=unit test included Review URL: http://codereview.chromium.org/555057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38108 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 37989 - unit test failed on Mac builder despite passing on try serverjoth@chromium.org2010-02-031-1/+0
| | | | | | | | | | | | | | | | Original change: Add tests for the geolocation network provider. Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe gtest_filter=NetworkLocationProvider* gtest_break_on_failure Review URL: http://codereview.chromium.org/556106 TBR=joth@chromium.org Review URL: http://codereview.chromium.org/570006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37992 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for the geolocation network provider.joth@chromium.org2010-02-031-0/+1
| | | | | | | | | | | Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure Review URL: http://codereview.chromium.org/556106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37989 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adds code for fullscreen mode, including a floating dropdown toolbar ↵rohitrao@chromium.org2010-02-031-0/+1
| | | | | | | | | | and tabstrip. This change does not enable the fullscreen menu item; a future CL will do that. BUG=31638 TEST=No visible changes. Unittests should pass. Review URL: http://codereview.chromium.org/542013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37932 0039d316-1c4b-4281-b951-d872f2087c98
* Support reordering of Browser Actions within the container. Currently does ↵finnur@chromium.org2010-02-031-0/+2
| | | | | | | | | | | | | | not support dragging to/from the chevron menu. Also fixed two bugs in the same code: - the container would be 0 width if a value for it hasn't been saved (part of bug 32101). - the default icon was not used when a tab specific icon was not found (bug 34317). BUG=http://crbug.com/26990, http://crbug.com/32101, http://crbug.com/34317 TEST=In both LTR and RTL locale, try reordering the browser actions and make sure to test dragging to the ends with and without a chevron visible. Install Send to Gmail extension and make sure it has an icon while in the overflow menu. Review URL: http://codereview.chromium.org/549224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37922 0039d316-1c4b-4281-b951-d872f2087c98
* Build pyauto for Linux.nirnimesh@chromium.org2010-02-021-4/+9
| | | | | | | | | | | | Since we build a shared library (for swig), we should attempt to build pyauto only when linux_fpic==1. Also, 'product_prefix' options with gyp (instead of platform-specifc ones) to get the right filename for the output shared lib. BUG=32285 TEST=linux builders should remain happy Review URL: http://codereview.chromium.org/568007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37867 0039d316-1c4b-4281-b951-d872f2087c98
* Adds bookmark context menu test to the set of tests on chromeos.sky@chromium.org2010-02-021-7/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/548227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37836 0039d316-1c4b-4281-b951-d872f2087c98
* Wire popup blocking UI to the new machinery and port over the user's old ↵pkasting@chromium.org2010-02-021-3/+1
| | | | | | | | | | | | | | | | whitelist. Notably, this removes the UI entirely for Mac and Linux. We need to rebuild it. This also guts the old system's testing, since most of it disappeared or changed radically. We should test the new stuff. I will file a followup bug for that. There are various tiny edge cases, like if you click the address bar icon really quickly, sometimes you'll get popups without any title yet, which makes them leave gaps in the bubble that appears. We can fix that sort of thing. The critical bit I tried to ensure was that we never try to open a dead popup or use a dead TabContents, no matter what. BUG=33314 TEST=Go visit some sites with popups and play with things Review URL: http://codereview.chromium.org/562013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37819 0039d316-1c4b-4281-b951-d872f2087c98
* The first step towards supporting the Hungarian spell-checking dictionary.hbono@chromium.org2010-02-021-0/+2
| | | | | | | | | | | | | | | This change fixes a couple of problems needed for using a Hungarian dictionary in Chrome. 1. Use TrimWhitespace() in TrimLine() Sorry, this is caused by my mistake that used TrimWhiteSpaceUTF8() without checking it deeply. 2. Replace morphing rules with compound rules. it seems existing Hungarian dictionaries use (language-specific) morphing rules to handle words that have both prefixes and suffixes, e.g. "legjobb" (best). It is better to replace such (language-dependent) morphing rules with (language-independent) compound rules to avoid language-specific issues. (As far as I tested, this change fixes many quality problems caused by Hungarian compounds.) This change also adds simple tests for our dictionary converter. BUG=15558 TEST=unit_test --gtest_filter=ConvertDictTest* Review URL: http://codereview.chromium.org/553087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37816 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Enable some left-behind unit tests.shess@chromium.org2010-02-011-3/+0
| | | | | | | | | | | NavicationControllerTest, TaskManagerTest and BackFwdMenuModelTest. BUG=none TEST=none Review URL: http://codereview.chromium.org/557063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37731 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of the DatabaseModelWorker, take 2.albertb@google.com2010-02-011-0/+1
| | | | | | | | | BUG=none TEST=unit tests Review URL: http://codereview.chromium.org/557043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37702 0039d316-1c4b-4281-b951-d872f2087c98
* OS X: Import settings dialog cleanup.jeremy@chromium.org2010-02-011-0/+1
| | | | | | | | | | | | | * Make Import settings dialog app modal. * No longer allow display of multiple dialogs at once. * For some reason, unit test was present but missing from .gyp file - re-added and freshened up. BUG=33011 TEST=selecting Chrome->Import Bookmarks and settings multiple times should only open bookmarks once. Review URL: http://codereview.chromium.org/556097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37689 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionInstalledBubble for Mac.mirandac@chromium.org2010-01-311-0/+1
| | | | | | | | | | Adds ExtensionInstalledBubble.xib, which contains the framework for the bubble itself (icon view, close button, and three message fields). BUG= 26974 TEST= Install an extension. Bubble should show same information as windows bubble. Review URL: http://codereview.chromium.org/527012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37671 0039d316-1c4b-4281-b951-d872f2087c98
* Make download items drag sources on OS X.thakis@chromium.org2010-01-301-0/+2
| | | | | | | | | | | | | Extract button dragging out of BookmarkButton into DraggableButton. Make BookmarkButton a subclass of DraggableButton. Create new class DownloadItemButton and make it a subclass of DraggableButton. xib change: Make download item a DownloadItemButton instead of an NSButton. BUG=15776 TEST=Download something, wait for it to complete, then drag it from the download shelf to somewhere. It should now work. Bookmarks should still be draggable in the bookmarks bar. Review URL: http://codereview.chromium.org/180036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37621 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r37535.darin@chromium.org2010-01-291-1/+0
| | | | | | | | | | | | | There was no LGTM, and there was still open discussion in the code review. See http://codereview.chromium.org/554119. This was not ready to land. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/553154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37556 0039d316-1c4b-4281-b951-d872f2087c98
* Implement extended cookie controls.jochen@chromium.org2010-01-291-0/+1
| | | | | | | | | BUG=32782 TEST=none Review URL: http://codereview.chromium.org/554119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37535 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 15:04:32 +0000